GNU bug report logs - #6459
24.0.50; completions-format should not have a `nil' choice

Previous Next

Full log

View this message in rfc822 format

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Juri Linkov <juri <at> jurta.org>
Cc: 6459 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: bug#6459: 24.0.50; completions-format should not have a `nil'  choice
Date: Sat, 19 Jun 2010 17:04:27 +0200

On Sat, Jun 19, 2010 at 4:37 PM, Juri Linkov <juri <at> jurta.org> wrote:
>> (defcustom completions-format nil
>>   "Define the appearance and sorting of completions.
>> If the value is `vertical', display completions sorted vertically
>> in columns in the *Completions* buffer.
>> If the value is `horizontal' or nil, display completions sorted
>> horizontally in alphabetical order, rather than down the screen."
>>   :type '(choice (const nil) (const horizontal) (const vertical))
>>   :group 'minibuffer
>>   :version "23.2")
>>
>> There is no reason for the `nil' choice.  Please remove it and make the
>> default value `horizontal'.  Occam's razor (KISS) and clarity for users
>> argue for this.
>
> We could remove nil from the docstring and from :type, and change
> the default value to `horizontal', but I'd still treat nil as
> `horizontal' internally for compatibility.


Since this is a new defcustom woulddn't it be better to not let nil be
a valid value? That may catch some problems and the backward
compatibilities are not likely to be big.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.