From unknown Sat Jul 26 23:57:05 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64580: 30.0.50; Comment describing Lisp_Overlay object in src/lisp.h:2590 is not current Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jul 2023 12:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64580 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 64580@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168916607524552 (code B ref -1); Wed, 12 Jul 2023 12:48:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Jul 2023 12:47:55 +0000 Received: from localhost ([127.0.0.1]:51890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZG6-0006Nu-Vh for submit@debbugs.gnu.org; Wed, 12 Jul 2023 08:47:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:40282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZG4-0006N3-97 for submit@debbugs.gnu.org; Wed, 12 Jul 2023 08:47:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJZFu-00051o-0D for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 08:47:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJZFp-0002q7-6n for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 08:47:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7A8E9240101 for ; Wed, 12 Jul 2023 14:47:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689166042; bh=37z19kLkEmA03jQoIVVp3jTw2ym3hIqefHG4z1JpqKc=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=myqene9AHKFg+YzSyk5SpBeg/d8JBdI8mRHNWlEqO2eLeuS6DdTTCHFS6iIzfCGiR 7gHjadAri2z9U5R4e4N+mawYOSNhsOTMhnLM/s4V91r4YHTjoAph5+4fwpZnbkG6hb ABKt/a1+cYUnTiky41oRFqI7bAk2J3ZlymyDX3YKw0+IeRy5i2raVY6JX/WjcfEhDQ Cwsf1qS50oKwzZ1CJq9SIa/agxX4/wrr5FC6IGWQZAmztin5lTSd9HNySFZvTMJCk1 Hg8gLShmyRtWVp09hnzJNXsaDnd9G+A4QXMt5e4PFN2E4y8vYYvlj8vE8S/4GXWLQl 0P0ls4JqPoXZg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1HZK5lTzz6twb for ; Wed, 12 Jul 2023 14:47:21 +0200 (CEST) From: Ihor Radchenko Date: Wed, 12 Jul 2023 12:47:30 +0000 Message-ID: <87fs5t5mal.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, I am not reading lisp.h, trying to understand the Lisp object layout. The comments are generally excellent, but I just stumbled upon Lisp_Overlay definition, where the comment appears to be outdated and only reflects the past times when overlays did not yet use itree: /* START and END are markers in the overlay's buffer, and PLIST is the overlay's property list. */ struct Lisp_Overlay /* An overlay's real data content is: - plist - buffer (really there are two buffer pointers, one per marker, and both points to the same buffer) - insertion type of both ends (per-marker fields) - start & start byte (of start marker) - end & end byte (of end marker) - next (singly linked list of overlays) - next fields of start and end markers (singly linked list of markers). I.e. 9words plus 2 bits, 3words of which are for external linked lists. */ { union vectorlike_header header; Lisp_Object plist; struct buffer *buffer; /* eassert (live buffer || NULL). */ struct itree_node *interval; } GCALIGNED_STRUCT; START and END are no longer in the struct. NEXT fields are also no longer applicable, even via itree_node struct. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-06 built on localhost Repository revision: d97b77e6c66db46b198c696f83458aa141794727 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Gentoo Linux -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From unknown Sat Jul 26 23:57:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ihor Radchenko Subject: bug#64580: closed (Re: bug#64580: 30.0.50; Comment describing Lisp_Overlay object in src/lisp.h:2590 is not current) Message-ID: References: <837cr45hw5.fsf@gnu.org> <87fs5t5mal.fsf@localhost> X-Gnu-PR-Message: they-closed 64580 X-Gnu-PR-Package: emacs Reply-To: 64580@debbugs.gnu.org Date: Thu, 13 Jul 2023 08:36:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1689237362-11880-1" This is a multi-part message in MIME format... ------------=_1689237362-11880-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64580: 30.0.50; Comment describing Lisp_Overlay object in src/lisp.h:2590 = is not current which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64580@debbugs.gnu.org. --=20 64580: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64580 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1689237362-11880-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64580-done) by debbugs.gnu.org; 13 Jul 2023 08:35:06 +0000 Received: from localhost ([127.0.0.1]:53341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJrn0-00034R-BK for submit@debbugs.gnu.org; Thu, 13 Jul 2023 04:35:06 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJrmx-00033p-8v for 64580-done@debbugs.gnu.org; Thu, 13 Jul 2023 04:35:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJrmr-0001GQ-0c; Thu, 13 Jul 2023 04:34:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rjdK8wQcY3U5XB0LH1n+Yf4JckiyfS+UGeKmADu1wHk=; b=AWu/JGR+mlbC g3nZ66XWoULsQubwOUt+DHVHrXDDX/qbsF655A9VPOuhlkDxWmLrxiUYKTEdh7No+vbzFhVJ0ugfF KUHLsrR5McvIzpZvM3xoYGSva4nzJACb0HR7rnjUaM1lHbafV6UkdHHwyDVT05J+G4VZQ3GI9Sk97 TgnLT8zFX87w5LmL+FVcesb44wujnwelsexqYPH1tkxUhtkGy9Mhguld/bHv90EQuYPMOUEd7ZRis p8mttpkfxE4QaJPHGBOmij1hufupxPf3BfZJ8DCoRQgkEiI3Q3ii5cmpWfSqmBTnMOcMpnfcbPX0H GiT+J/XdFY4y58nqK0gS8Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJrmV-0006sz-5X; Thu, 13 Jul 2023 04:34:56 -0400 Date: Thu, 13 Jul 2023 11:34:50 +0300 Message-Id: <837cr45hw5.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko In-Reply-To: <87fs5t5mal.fsf@localhost> (message from Ihor Radchenko on Wed, 12 Jul 2023 12:47:30 +0000) Subject: Re: bug#64580: 30.0.50; Comment describing Lisp_Overlay object in src/lisp.h:2590 is not current References: <87fs5t5mal.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64580-done Cc: 64580-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Ihor Radchenko > Date: Wed, 12 Jul 2023 12:47:30 +0000 > > /* START and END are markers in the overlay's buffer, and > PLIST is the overlay's property list. */ > struct Lisp_Overlay > /* An overlay's real data content is: > - plist > - buffer (really there are two buffer pointers, one per marker, > and both points to the same buffer) > - insertion type of both ends (per-marker fields) > - start & start byte (of start marker) > - end & end byte (of end marker) > - next (singly linked list of overlays) > - next fields of start and end markers (singly linked list of markers). > I.e. 9words plus 2 bits, 3words of which are for external linked lists. > */ > { > union vectorlike_header header; > Lisp_Object plist; > struct buffer *buffer; /* eassert (live buffer || NULL). */ > struct itree_node *interval; > } GCALIGNED_STRUCT; > > START and END are no longer in the struct. NEXT fields are also no > longer applicable, even via itree_node struct. Thanks, fixed on the emacs-29 branch. ------------=_1689237362-11880-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Jul 2023 12:47:55 +0000 Received: from localhost ([127.0.0.1]:51890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZG6-0006Nu-Vh for submit@debbugs.gnu.org; Wed, 12 Jul 2023 08:47:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:40282) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZG4-0006N3-97 for submit@debbugs.gnu.org; Wed, 12 Jul 2023 08:47:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJZFu-00051o-0D for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 08:47:44 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJZFp-0002q7-6n for bug-gnu-emacs@gnu.org; Wed, 12 Jul 2023 08:47:40 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 7A8E9240101 for ; Wed, 12 Jul 2023 14:47:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689166042; bh=37z19kLkEmA03jQoIVVp3jTw2ym3hIqefHG4z1JpqKc=; h=From:To:Subject:Date:Message-ID:MIME-Version:From; b=myqene9AHKFg+YzSyk5SpBeg/d8JBdI8mRHNWlEqO2eLeuS6DdTTCHFS6iIzfCGiR 7gHjadAri2z9U5R4e4N+mawYOSNhsOTMhnLM/s4V91r4YHTjoAph5+4fwpZnbkG6hb ABKt/a1+cYUnTiky41oRFqI7bAk2J3ZlymyDX3YKw0+IeRy5i2raVY6JX/WjcfEhDQ Cwsf1qS50oKwzZ1CJq9SIa/agxX4/wrr5FC6IGWQZAmztin5lTSd9HNySFZvTMJCk1 Hg8gLShmyRtWVp09hnzJNXsaDnd9G+A4QXMt5e4PFN2E4y8vYYvlj8vE8S/4GXWLQl 0P0ls4JqPoXZg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1HZK5lTzz6twb for ; Wed, 12 Jul 2023 14:47:21 +0200 (CEST) From: Ihor Radchenko To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Comment describing Lisp_Overlay object in src/lisp.h:2590 is not current Date: Wed, 12 Jul 2023 12:47:30 +0000 Message-ID: <87fs5t5mal.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, I am not reading lisp.h, trying to understand the Lisp object layout. The comments are generally excellent, but I just stumbled upon Lisp_Overlay definition, where the comment appears to be outdated and only reflects the past times when overlays did not yet use itree: /* START and END are markers in the overlay's buffer, and PLIST is the overlay's property list. */ struct Lisp_Overlay /* An overlay's real data content is: - plist - buffer (really there are two buffer pointers, one per marker, and both points to the same buffer) - insertion type of both ends (per-marker fields) - start & start byte (of start marker) - end & end byte (of end marker) - next (singly linked list of overlays) - next fields of start and end markers (singly linked list of markers). I.e. 9words plus 2 bits, 3words of which are for external linked lists. */ { union vectorlike_header header; Lisp_Object plist; struct buffer *buffer; /* eassert (live buffer || NULL). */ struct itree_node *interval; } GCALIGNED_STRUCT; START and END are no longer in the struct. NEXT fields are also no longer applicable, even via itree_node struct. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.17.8) of 2023-07-06 built on localhost Repository revision: d97b77e6c66db46b198c696f83458aa141794727 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: Gentoo Linux -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at ------------=_1689237362-11880-1--