GNU bug report logs - #64579
[PATCH] gnu: libleak: Update to 0.3.6.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64579 in the body.
You can then email your comments to 64579 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Ford <fanquake <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libleak: Update to 0.3.6.
Date: Wed, 12 Jul 2023 10:27:39 +0100

From 790f44dde3a2a68ac9525f45b72ba65f8486d0f0 Mon Sep 17 00:00:00 2001
From: fanquake <fanquake <at> gmail.com>
Date: Wed, 12 Jul 2023 10:08:56 +0100
Subject: [PATCH] gnu: libleak: Update to 0.3.6.

* gnu/packages/debug.scm (libleak): Update to 0.3.6.
---
 gnu/packages/debug.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/debug.scm b/gnu/packages/debug.scm
index 7283d04bd2..0c97f61ccb 100644
--- a/gnu/packages/debug.scm
+++ b/gnu/packages/debug.scm
@@ -716,7 +716,7 @@ (define-public libbacktrace
 (define-public libleak
   (package
     (name "libleak")
-    (version "0.3.5")
+    (version "0.3.6")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -725,7 +725,7 @@ (define-public libleak
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1p8mb0hcfp8hdv1klv6rrpkn2zlhjxgkxbbjsk8kszxv7ijln87d"))))
+                "1p6x20mm0dym2qn10d6cvwmh71m93xwcd319g94zkv88hj5q17n6"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f                      ;no test suite
-- 
2.41.0

Message #8 received at 64579 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 64579 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH 2/2] gnu: node-lts: Install files irrespective of number of
 hardlinks.
Date: Thu, 13 Jul 2023 10:43:48 +0200

* gnu/packages/node.scm (node-lts)[arguments]: Add build phase
'ignore-number-of-hardlinks.
---
 gnu/packages/node.scm | 31 ++++++++++++++++++++++++++++++-
 1 file changed, 30 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/node.scm b/gnu/packages/node.scm
index c0bb4f2342..8ba57dd4e0 100644
--- a/gnu/packages/node.scm
+++ b/gnu/packages/node.scm
@@ -874,7 +874,36 @@ (define-public node-lts
                  (copy-file (string-append llhttp "/src/http.c")
                             "deps/llhttp/src/http.c")
                  (copy-file (string-append llhttp "/include/llhttp.h")
-                            "deps/llhttp/include/llhttp.h"))))))))
+                            "deps/llhttp/include/llhttp.h"))))
+           ;; npm installs dependencies by copying their files over a tar
+           ;; stream.  A file with more than one hardlink is marked as a
+           ;; "Link".  pacote/lib/fetcher.js calls node-tar's extractor with a
+           ;; filter that ignores any "Link" entries.  This means that
+           ;; dependending on the number of hardlinks on files in a node-*
+           ;; package *some* of its files may not be installed when generating
+           ;; another package's "node_modules" directory.  The build output
+           ;; would differ depending on irrelevant file system state.
+           ;;
+           ;; To avoid this, we patch node-tar to treat files with hardlinks
+           ;; the same as any other file, so that node-tar has no choice but
+           ;; to extract all of them --- independent of pacote's filter.
+           ;;
+           ;; Why not patch pacote's filter instead?  This has led to subtle
+           ;; differences in where the files are installed, so it's easier to
+           ;; just ensure that files with hardlinks are always treated as
+           ;; regular files.
+           ;;
+           ;; Discussion:
+           ;;   https://lists.gnu.org/archive/html/guix-devel/2023-07/msg00040.html
+           ;; Upstream bug report:
+           ;;   https://github.com/npm/pacote/issues/285
+           (add-after 'install 'ignore-number-of-hardlinks
+             (lambda* (#:key outputs #:allow-other-keys)
+               (let ((file (string-append (assoc-ref outputs "out")
+                                          "/lib/node_modules/npm/node_modules"
+                                          "/tar/lib/write-entry.js")))
+                 (substitute* file
+                   (("this.stat.nlink > 1") "false")))))))))
     (native-inputs
      (list ;; Runtime dependencies for binaries used as a bootstrap.
            c-ares-for-node
-- 
2.40.1

Message #13 received at 64579-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 64579-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: libleak: Update to 0.3.6.
Date: Thu, 13 Jul 2023 10:48:07 +0200

Thank you for the patch (and sorry for the unrelated email I
accendentally sent to this issue).

I’ve applied it and pushed to the “master” branch with commit
dd4c1992103a65b8fbdc80fe07a9fe9be822769a.

-- 
Ricardo

Message #16 received at 64579 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: Ricardo Wurmus <rekado <at> elephly.net>, 64579 <at> debbugs.gnu.org
Subject: Re: [bug#64579] [PATCH 2/2] gnu: node-lts: Install files
 irrespective of number of hardlinks.
Date: Fri, 14 Jul 2023 14:42:06 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> * gnu/packages/node.scm (node-lts)[arguments]: Add build phase
> 'ignore-number-of-hardlinks.

LGTM, and I was able to do node-related things with these patches
applied locally.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.