GNU bug report logs - #64576
[PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64576: closed ([PATCH] gnu: libusb-compat: Compile with full
 path of libusb-1.0.so)
Date: Wed, 06 Sep 2023 04:02:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 06 Sep 2023 00:01:01 -0400
with message-id <87edjc9chu.fsf <at> gmail.com>
and subject line Re: bug#64576: [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
has caused the debbugs.gnu.org bug report #64576,
regarding [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64576: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64576
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: nathan <nathan_mail <at> nborghese.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
Date: Tue, 11 Jul 2023 15:34:00 -0400

[Message part 3 (text/plain, inline)]

fix bug#64409
In libusb-compat-0.1.8/libusb/libusb-dload.h, dlopen is used to load libusb.
We need to specify an absolute path.
With this fix, teensy_loader_cli doesn't immediately fail with a missing library error.
./pre-inst-env guix shell teensy-loader-cli -- teensy_loader_cli
If you merge the patch from bug#64563 first, you can't test this patch with teensy_loader_cli.

[0001-gnu-libusb-compat-Compile-with-full-path-of-libusb-1.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: nathan <nathan_mail <at> nborghese.com>
Cc: 64576-done <at> debbugs.gnu.org
Subject: Re: bug#64576: [PATCH] gnu: libusb-compat: Compile with full path
 of libusb-1.0.so
Date: Wed, 06 Sep 2023 00:01:01 -0400

Hi,

nathan <nathan_mail <at> nborghese.com> writes:

> fix bug#64409
> In libusb-compat-0.1.8/libusb/libusb-dload.h, dlopen is used to load libusb.
> We need to specify an absolute path.
> With this fix, teensy_loader_cli doesn't immediately fail with a missing library error.
> ./pre-inst-env guix shell teensy-loader-cli -- teensy_loader_cli
> If you merge the patch from bug#64563 first, you can't test this patch with teensy_loader_cli.
>
>>From c0a8ecea0ce6f3954061a3d061a3243fa65c6cfb Mon Sep 17 00:00:00 2001
> From: nathan <nathan_mail <at> nborghese.com>
> Date: Mon, 10 Jul 2023 23:22:48 -0400
> Subject: [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
>
> * gnu/packages/libusb.scm (libusb) [configure-flags]: Provide full path of
>   libusb-1.0.so so dlopen works.
> ---
>  gnu/packages/libusb.scm | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
> index d0837c8a91..39586147ba 100644
> --- a/gnu/packages/libusb.scm
> +++ b/gnu/packages/libusb.scm
> @@ -101,7 +101,10 @@ (define-public libusb-compat
>      (build-system gnu-build-system)
>      (arguments
>       (list #:configure-flags
> -           #~(list "--disable-static")))
> +           #~(list "--disable-static"
> +                   (string-append "LIBUSB_1_0_SONAME="
> +                                  #$(this-package-input "libusb")
> +                                  "/lib/libusb-1.0.so"))))
>      (native-inputs
>       (list autoconf automake libtool pkg-config))
>      (inputs

Interesting!  I fixed this independently with ddd8bb104, using a RUNPATH
approach.  Yours is a better solution, now applied :-).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.