Subject: bug#64559: closed (Re: [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 14 Feb 2024 19:21:02 +0000

Your bug report

#64559: [PATCH] gnu: freesasa: Fix memerr tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
64559: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64559
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#64559] [PATCH] gnu: freesasa: Fix memerr tests.
From: David Elsing <[email-masked]>
To: [email-masked]
Cc: Bruno Victal <[email-masked]>, [email-masked]
Date: Wed, 14 Feb 2024 19:20:19 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

David Elsing <[email-masked]> writes:

> that's true, I just filed an issue: https://github.com/mittinatten/freesasa/issues/94.

I included this patch in another patch series for rdkit, which was now
applied in commit cc772e7f3172a8014e32c7ea3f6626963d4e9e16. The issue
was also fixed upstream.

Subject: [PATCH] gnu: freesasa: Fix memerr tests.
From: David Elsing <[email-masked]>
To: [email-masked]
Cc: David Elsing <[email-masked]>
Date: Mon, 10 Jul 2023 18:06:11 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/chemistry.scm (freesasa)[arguments]: Add
"CFLAGS=-fno-builtin-malloc" to #:configure-flags.
---
 gnu/packages/chemistry.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/chemistry.scm b/gnu/packages/chemistry.scm
index cddccf8aea..431b845989 100644
--- a/gnu/packages/chemistry.scm
+++ b/gnu/packages/chemistry.scm
@@ -703,7 +703,11 @@ (define-public freesasa
       #~(list "--enable-check"
               "--enable-parser-generator"
               "CXXFLAGS=-std=c++17"
-              "--enable-doxygen")
+              "--enable-doxygen"
+              ;; Some tests rely on replacing malloc with a wrapper which
+              ;; fails in a controlled way, but this does not work if the call
+              ;; is replaced.
+              "CFLAGS=-fno-builtin-malloc")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'remove-libc++-linking
-- 
2.40.1