GNU bug report logs - #64543
[PATCH] package-report-bug: don't fail on custom groups defined by eval

Previous Next

Package: emacs;

Reported by: sbaugh <at> catern.com

Date: Sun, 9 Jul 2023 17:09:02 UTC

Severity: normal

Tags: patch

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


Message #41 received at 64543 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Spencer Baugh <sbaugh <at> catern.com>, 64543 <at> debbugs.gnu.org,
 sbaugh <at> janestreet.com
Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom
 groups defined by eval
Date: Sat, 15 Jul 2023 10:05:13 +0000
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC)
>> From: Spencer Baugh <sbaugh <at> catern.com>
>> Cc: Philip Kaludercic <philipk <at> posteo.net>, sbaugh <at> janestreet.com,
>> 	64543 <at> debbugs.gnu.org
>> 
>> On Jul 15, 2023 04:57, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> 
>>  >   >> Previously we just assumed that the car of an element of 
>>  >   >> custom-current-group-alist was a filename.  But actually it can be nil 
>>  >   >> if a custom group was defined by just evaling Lisp. 
>>  >   > 
>>  >   > Where is this behaviour documented?  I couldn't reproduce it with a 
>>  >   > simple experiment. 
>>  > 
>>  >   To reproduce: 
>>  >   M-: (defgroup mygroup nil "my group") RET 
>>  > 
>>  > The patch would ensure that if groups like these are defined (which 
>>  > might happen by mistake), then `package-report-bug' will remain robust 
>>  > and not fail due to a unrelated issue. 
>> 
>>  Is this case important enough to make this change so late in the 
>>  pretest?  Spencer, how did you bump into this situation in Real Life?
>> 
>> I evaled a buffer containing a defgroup with C-c C-e (or maybe just a region?)
>
> Why did you do that?

Evaluating an entire buffer with C-c C-e is not unreasonable, but it
will not bind `load-file-name', which `load-file' would have done, but
there is no binding for that.




This bug report was last modified 1 year and 310 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.