GNU bug report logs - #64543
[PATCH] package-report-bug: don't fail on custom groups defined by eval

Previous Next

Full log

Message #20 received at 64543 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: sbaugh <at> catern.com
Cc: philipk <at> posteo.net, 64543 <at> debbugs.gnu.org
Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups
 defined by eval
Date: Thu, 13 Jul 2023 07:54:25 +0300

> Cc: 64543 <at> debbugs.gnu.org
> From: sbaugh <at> catern.com
> Date: Wed, 12 Jul 2023 19:26:13 +0000 (UTC)
> 
> +(defun uniquify-dirname-transform-default (dirname)
> +  "Simply return DIRNAME unchanged."
> +  dirname)

If you don't explain the need for its existence in the doc string,
this function looks weirdly redundant.

> +(defcustom uniquify-dirname-transform #'uniquify-dirname-transform-default
> +  "A function to transform the dirname used to uniquify a buffer.

Come to think about it, why not use 'identity as the default value?
Then the above weird function could be deleted.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.