From unknown Fri Jun 20 07:20:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64543 <64543@debbugs.gnu.org> To: bug#64543 <64543@debbugs.gnu.org> Subject: Status: [PATCH] package-report-bug: don't fail on custom groups defined by eval Reply-To: bug#64543 <64543@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:20:39 +0000 retitle 64543 [PATCH] package-report-bug: don't fail on custom groups defin= ed by eval reassign 64543 emacs submitter 64543 sbaugh@catern.com severity 64543 normal tag 64543 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 13:08:29 2023 Received: (at submit) by debbugs.gnu.org; 9 Jul 2023 17:08:29 +0000 Received: from localhost ([127.0.0.1]:47092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIXtc-0005NN-I4 for submit@debbugs.gnu.org; Sun, 09 Jul 2023 13:08:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:33230) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIXtZ-0005NC-5Z for submit@debbugs.gnu.org; Sun, 09 Jul 2023 13:08:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIXtX-0003ZN-Ls for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 13:08:24 -0400 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIXtV-0007gf-0L for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2023 13:08:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:mime-version:to:content-type:cc:content-type:from: subject:to; s=s1; bh=+JWix5okv0KfMxuBuReA7DkLXbK/Yloi6dxoyOgIHVA=; b=nvzPMsqxFNk1UzG778/G+6GGesPt3wQldFgrgjHu4xMklfEAj3VJtL7y/qXufPRDPSRx DqOstOd1J8eVtiLkjuII3i1Kx8mqmES7JzvInFsAa55SGq5Qv0FkjWjG3Xo6ufNzqXEesn wtvNgGo60hjx3q1nLiB2GkUclg4ukeSbB4SSncEpeO9RlE6SWBCiR28hZlTK4slq3inwJM 0uqbNBkjLisnPn2473PvGhB+R7mxAmFewZQqYGKysPXX95NAmNQvJ8G0G6dvCh8aOcVCPd QxTT1YJkecxITg1BwVs+cCLiJpyULOK/ke4M73K39wrRCRr2bbbX31lCetwOywEQ== Received: by filterdrecv-canary-56575c7785-wd5jg with SMTP id filterdrecv-canary-56575c7785-wd5jg-1-64AAE982-16 2023-07-09 17:08:18.526578886 +0000 UTC m=+5160607.308082276 Received: from earth.catern.com (unknown) by geopod-ismtpd-12 (SG) with ESMTP id Et-zotqqTsaEx5WbwDdccg for ; Sun, 09 Jul 2023 17:08:18.418 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gnu.org Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 1444860077 for ; Sun, 9 Jul 2023 13:08:17 -0400 (EDT) From: sbaugh@catern.com Subject: [PATCH] package-report-bug: don't fail on custom groups defined by eval Date: Sun, 09 Jul 2023 17:08:18 +0000 (UTC) Message-ID: <87351xm2ri.fsf@catern.com> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbKF0iGxty0yv91GpjN=2FNx?= =?us-ascii?Q?pHt7LqMrf3mU=2F1zqeoHO+eJSgXOd1i6GCz=2FnbKz?= =?us-ascii?Q?1f+6IHa0hTYGLq8UJvKDvtLQljGYa5=2FtT96xtkv?= =?us-ascii?Q?qklja0XnLBBOgKZO60PWovlVgl5H8dCpEz3+HOS?= =?us-ascii?Q?rYoh8BRGVsV84OjYTFJ1wkC9w8CY=2F25Hqz4FkR6?= =?us-ascii?Q?XwqsR=2FCKBXe6Xq=2FG8=3D?= To: bug-gnu-emacs@gnu.org X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=149.72.123.24; envelope-from=bounces+21787432-3678-bug-gnu-emacs=gnu.org@em8926.catern.com; helo=s.wrqvtbkv.outbound-mail.sendgrid.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Tags: patch Previously we just assumed that the car of an element of custom-current-group-alist was a filename. But actually it can be nil if a custom group was defined by just evaling Lisp. * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a custom group was defined by eval. In GNU Emacs 29.0.92 (build 13, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-07-04 built on earth Repository revision: 5ef6e74202e2bdae5999913bff527a4a16d9176e Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101008 System Description: NixOS 23.05 (Stoat) Configured using: 'configure --cache-file=3Dconfig.cache --with-x-toolkit=3Dlucid --with-tree-sitter --with-xinput2 CC=3Dgcc PKG_CONFIG=3Dpkg-config PKG_CONFIG_PATH=3D/nix/store/s3r15m8wbl4wqk4khqlf41ikryhjm1bi-file-5.44-de= v/lib/pkgconfig:/nix/store/f9jbn419h46c78z1pi49yn9a8742b0ql-gnutls-3.8.0-de= v/lib/pkgconfig:/nix/store/knq0pv08wm4dins7m4jh0n7cv7pjvdjr-nettle-3.9.1-de= v/lib/pkgconfig:/nix/store/dy8p07vrrhdgpnl45xz9c0k0didbikdh-gmp-with-cxx-6.= 2.1-dev/lib/pkgconfig:/nix/store/6hkdabzyqhyq5ypq4c9b2cibr1d1zg1s-harfbuzz-= 7.3.0-dev/lib/pkgconfig:/nix/store/hyns944pqgblw4icskylvlpm5krmfvcr-graphit= e2-1.3.14-dev/lib/pkgconfig:/nix/store/08cdp9vgvy023ysfa2y01gzsm2jv6phx-jan= sson-2.14/lib/pkgconfig:/nix/store/nqlbk40lh7igs61l77dwgdkn8dc2akcm-libxml2= -2.10.4-dev/lib/pkgconfig:/nix/store/b3axl73v3yvqqx7g47njqb5wzxvm280p-zlib-= 1.2.13-dev/lib/pkgconfig:/nix/store/3f2rc4inlcxmq11718qmz94v2rpybw70-ncurse= s-6.4-dev/lib/pkgconfig:/nix/store/bxy745kyb1fwhpfkiaaz3wgvpkpvwcpq-dbus-1.= 14.8-dev/lib/pkgconfig:/nix/store/9714v7c4cgpm4yqcyqk6n9xw9iq3a1bs-expat-2.= 5.0-dev/lib/pkgconfig:/nix/store/zzi7pcadidqh798yddxv6pwdbwpkikma-libselinu= x-3.3-dev/lib/pkgconfig:/nix/store/w14j7y5nl14vy4ikcivss35jmrqq3fxj-libotf-= 0.9.16-dev/lib/pkgconfig:/nix/store/arhk7hsch4scyv6m24fw03yq6wq5wbbx-m17n-l= ib-1.8.2/lib/pkgconfig:/nix/store/1jbbrny8xcjb68lb5m30cvxycfkyhvsv-sqlite-3= .42.0-dev/lib/pkgconfig:/nix/store/5vx779yqkxaysv48gicwlgv0ippbrhc4-systemd= -253.5-dev/lib/pkgconfig:/nix/store/5vx779yqkxaysv48gicwlgv0ippbrhc4-system= d-253.5-dev/share/pkgconfig:/nix/store/djifahvk3qp06ssqxv6gy1ixdnnypr9s-tre= e-sitter-0.20.8/lib/pkgconfig:/nix/store/74aasy1d2r5y27zn68cs1rxwy1llzn05-l= ibwebp-1.3.0/lib/pkgconfig:/nix/store/8sk7bp89iwb4gw96fq6xakb6lcy2x52n-Xaw3= d-1.6.3/lib/pkgconfig:/nix/store/ppvb3ha8148am3ajnzxnm6i3ri38c01n-libXmu-1.= 1.3-dev/lib/pkgconfig:/nix/store/jyxf8cjbj3nzh00x48nfram79i63chdi-libX11-1.= 8.6-dev/lib/pkgconfig:/nix/store/zk9v0nr5zdfi1ybkhcfifmxsng7hfl23-xorgproto= -2021.5/share/pkgconfig:/nix/store/3q1k18v8aa6mxs538bha4ry0mp3m321l-libxcb-= 1.14-dev/lib/pkgconfig:/nix/store/hcscz68zvfk1skyb25wrnha959f6hhrc-libXt-1.= 2.1-dev/lib/pkgconfig:/nix/store/kl55wj6qc3v481jsgvzm5w2csnhm84zf-libSM-1.2= .3-dev/lib/pkgconfig:/nix/store/s3f67kvsn55rxp2rc98xv0hkq364yci1-libICE-1.0= .10-dev/lib/pkgconfig:/nix/store/rsw4ri8025jgln8vpsrmg82bzgbcw3zr-cairo-1.1= 6.0-dev/lib/pkgconfig:/nix/store/jir0rqbcy0d9qr9kf5cwf2yphql4ykyw-fontconfi= g-2.14.2-dev/lib/pkgconfig:/nix/store/n2g3xblaz1k4civv1z6hhm1nsmp3m17p-free= type-2.13.0-dev/lib/pkgconfig:/nix/store/isbmyzm2shmp0wsjr4cy45v2i58h2zvw-b= zip2-1.0.8-dev/lib/pkgconfig:/nix/store/bl2qwy78jr2sqm260imgxmd5dzhjqvag-br= otli-1.0.9-dev/lib/pkgconfig:/nix/store/z96jh9ag5b3565lwwb5chjb9bfp5i2qv-li= bpng-apng-1.6.39-dev/lib/pkgconfig:/nix/store/jjd4z18grhky6lh8n463v648nnf56= 28b-pixman-0.42.2/lib/pkgconfig:/nix/store/qd14wrazwcspjv3q65vgh35pl7b8nifq= -libXext-1.3.4-dev/lib/pkgconfig:/nix/store/gj8i21xx87ip9b971j2d1m0rmrzyhbi= r-libXau-1.0.9-dev/lib/pkgconfig:/nix/store/4gpinwwdqhi927xkrfpr1hvdd56baxg= k-libXrender-0.9.10-dev/lib/pkgconfig:/nix/store/d1jbygs6hcn6dysk706i9zf07y= d18wmr-xcb-util-0.4.1-dev/lib/pkgconfig:/nix/store/hdc4ika0mb1cv0cf6dchwxbr= 004rc50i-glib-2.76.3-dev/lib/pkgconfig:/nix/store/wxyh848a6xcqy2v8727vcwspr= i53pqwi-libffi-3.4.4-dev/lib/pkgconfig:/nix/store/42jx72681qzliic0xsjhvx24c= il2gapk-libGL-1.6.0-dev/lib/pkgconfig:/nix/store/b9lmdkxpvgkj6zc956fvhshzis= qpi767-libglvnd-1.6.0-dev/lib/pkgconfig:/nix/store/gff29sbhg1gcw969mpm5rb69= 3kj5v18w-libXaw-1.0.14-dev/lib/pkgconfig:/nix/store/776xijk8rsb1b4c0dsxwq0k= 82bvm7mm9-libXpm-3.5.15-dev/lib/pkgconfig:/nix/store/qizdmm43xi65mdngal8bpb= pqcdc8290d-libjpeg-turbo-2.1.5.1-dev/lib/pkgconfig:/nix/store/db7ix62fx4nvr= 9j1fjdvnznl2npff4pr-librsvg-2.55.1-dev/lib/pkgconfig:/nix/store/q0hg0951w1d= v9y40m9ggln8phwil6lxc-gdk-pixbuf-2.42.10-dev/lib/pkgconfig:/nix/store/34rr5= nvgljsc4bi3mxjxg8abmjr1f7hn-libtiff-4.5.0-dev/lib/pkgconfig:/nix/store/zwkr= 4kjcjs213pw9mhzi46bzlw6qwxzq-libdeflate-1.18/lib/pkgconfig:/nix/store/6na55= 2yzwml88j8g5vqf5h9ir3vw8myi-xz-5.4.3-dev/lib/pkgconfig' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-package-report-bug-don-t-fail-on-custom-groups-defin.patch >From 663f36f52c7c8e66e54d4e93ce037428bf1b3dd0 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 9 Jul 2023 12:59:50 -0400 Subject: [PATCH] package-report-bug: don't fail on custom groups defined by eval Previously we just assumed that the car of an element of custom-current-group-alist was a filename. But actually it can be nil if a custom group was defined by just evaling Lisp. * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a custom group was defined by eval. --- lisp/emacs-lisp/package.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 3e6acd9b388..f67e99e04b5 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4642,6 +4642,7 @@ package-report-bug (boundp (car ent)) (not (eq (custom--standard-value (car ent)) (default-toplevel-value (car ent)))) + (car group) (file-in-directory-p (car group) (package-desc-dir desc))) (push (car ent) vars)))) (dlet ((reporter-prompt-for-summary-p t)) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 10 10:13:32 2023 Received: (at 64543) by debbugs.gnu.org; 10 Jul 2023 14:13:32 +0000 Received: from localhost ([127.0.0.1]:48916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIrdr-0004HH-TW for submit@debbugs.gnu.org; Mon, 10 Jul 2023 10:13:32 -0400 Received: from mout01.posteo.de ([185.67.36.65]:37989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIrdq-0004H4-2N for 64543@debbugs.gnu.org; Mon, 10 Jul 2023 10:13:30 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3B88B240027 for <64543@debbugs.gnu.org>; Mon, 10 Jul 2023 16:13:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1688998404; bh=nvQHQqQ5j+2SpCBGro/3wX81P+qnk8A7e/PSQicuEfw=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=fyVMC0yej2Az8AUxeWK+p14PdyY43sxlAcevTRLMHSjswu+yTc/cCdtF0Asf4erNQ vS8WOCAIfWZenetAxqOc4NhlPXh6pGLWZ0LG3HYvVuMb13+iuZYj4OMo1JZzYK8xFB 3I3HpljtYvgWblVpmBa9Wuu8vKNnbYKQ9pRHo3YgHfFTUxHX+r1Gf+7bg7XIo93uSo X5eSGPG6ZK8WC3oNTq4EqNo6nWmgV4/M6KOy7o0G7UGDfsFBdqcz41nZ8C0c9VJvBd 8qHnAO6XU0Df5SSyZQZ8a2pZe1wQL3gXQpW8PBzXTEeFxS+8236UqWJb5kCENL+xi4 uDbvc/36R9sSA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R05ZW4DGKz9rxL; Mon, 10 Jul 2023 16:13:23 +0200 (CEST) From: Philip Kaludercic To: sbaugh@catern.com Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87351xm2ri.fsf@catern.com> (sbaugh@catern.com's message of "Sun, 09 Jul 2023 17:08:18 +0000 (UTC)") References: <87351xm2ri.fsf@catern.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Mon, 10 Jul 2023 14:13:23 +0000 Message-ID: <87edlfkg70.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) sbaugh@catern.com writes: Thanks, > From: Spencer Baugh > Date: Sun, 9 Jul 2023 12:59:50 -0400 > Subject: [PATCH] package-report-bug: don't fail on custom groups defined by > eval > > Previously we just assumed that the car of an element of > custom-current-group-alist was a filename. But actually it can be nil > if a custom group was defined by just evaling Lisp. Where is this behaviour documented? I couldn't reproduce it with a simple experiment. > * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a > custom group was defined by eval. > --- > lisp/emacs-lisp/package.el | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 3e6acd9b388..f67e99e04b5 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4642,6 +4642,7 @@ package-report-bug > (boundp (car ent)) > (not (eq (custom--standard-value (car ent)) > (default-toplevel-value (car ent)))) > + (car group) If you are checking for (car group), when do this in the loop instead of wrapping the entire `dolist'? > (file-in-directory-p (car group) (package-desc-dir desc))) > (push (car ent) vars)))) > (dlet ((reporter-prompt-for-summary-p t)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 15:26:23 2023 Received: (at 64543) by debbugs.gnu.org; 12 Jul 2023 19:26:23 +0000 Received: from localhost ([127.0.0.1]:52957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfTj-0003FG-4R for submit@debbugs.gnu.org; Wed, 12 Jul 2023 15:26:23 -0400 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:31216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfTf-0003Eu-Dq for 64543@debbugs.gnu.org; Wed, 12 Jul 2023 15:26:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: cc:content-type:from:subject:to; s=s1; bh=G8kywpdFVNLakVjW0mP56JD2aQx4B7iq8+EeocYuzWA=; b=LGGxjNfYVHbL/MV2D+kUX282ZTsny+EPJImn4p2k5G4W9nXyEPLJkHUp2NIadietfstu 8/3/Gj4/UTBPkUnnBgvXS8mAYWyybey6rmACcx5610mY+fNtjaa+8WwHOoiFHfx4FfLEoC n2JibnN1Kn+C2bAAZDdKNE4YOrkMwcAg+sXI/blHvWmYyZ+7DtOwgJCRI8jnjGQbIrYqx8 rMAriEUXtiBj+FI/kOQpnSWbXQ4jmB415P+x2US21SnSNON4Qpd4NU/nxI8bmf1Rbo5iDW 4peF+CtMqQVfEU7ZqbVUTupEkTRGg55CKiMakEzkMDVUy/KguKeh6Yp8d/5tIGdQ== Received: by filterdrecv-66949dbc98-rr4mv with SMTP id filterdrecv-66949dbc98-rr4mv-1-64AEFE55-34 2023-07-12 19:26:13.699570191 +0000 UTC m=+1529429.464332959 Received: from earth.catern.com (unknown) by geopod-ismtpd-1 (SG) with ESMTP id X5OKlLJxTmurcTOwsynBOg Wed, 12 Jul 2023 19:26:13.584 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=posteo.net Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 1C85D6009C; Wed, 12 Jul 2023 15:26:13 -0400 (EDT) From: sbaugh@catern.com Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87edlfkg70.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 10 Jul 2023 14:13:23 +0000") References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> Date: Wed, 12 Jul 2023 19:26:13 +0000 (UTC) Message-ID: <87ttu9j5ii.fsf@catern.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbIoHjcnq2sgG+sZZqVAwN?= =?us-ascii?Q?nWqgMyWSfMNgvxDtr4xv86dvE=2FNMagIxWftJXmt?= =?us-ascii?Q?1vKdouFNiuMlmJGOCQMlwgo4sCRRA8co03bLGr3?= =?us-ascii?Q?3M+3SkIubtPVDwNeuzsCfMSej6Jh1Tk=2FdEQxj3I?= =?us-ascii?Q?NbVXkNt6o=2F9X0HvUgE6SE4Mhg+DfEVBf2AA=3D=3D?= To: Philip Kaludercic X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 2.5 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Philip Kaludercic writes: > sbaugh@catern.com writes: > > Thanks, > >> From: Spencer Baugh >> Date: Sun, 9 Jul 2023 12:59:50 -0400 >> Subject: [PATCH] package-report-bug: don't fail on custom groups defined [...] Content analysis details: (2.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [149.72.154.232 listed in bl.score.senderscore.com] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [149.72.154.232 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: 64543 Cc: 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Philip Kaludercic writes: > sbaugh@catern.com writes: > > Thanks, > >> From: Spencer Baugh >> Date: Sun, 9 Jul 2023 12:59:50 -0400 >> Subject: [PATCH] package-report-bug: don't fail on custom groups defined [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [149.72.154.232 listed in wl.mailspike.net] 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [149.72.154.232 listed in bl.score.senderscore.com] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Philip Kaludercic writes: > sbaugh@catern.com writes: > > Thanks, > >> From: Spencer Baugh >> Date: Sun, 9 Jul 2023 12:59:50 -0400 >> Subject: [PATCH] package-report-bug: don't fail on custom groups defined by >> eval >> >> Previously we just assumed that the car of an element of >> custom-current-group-alist was a filename. But actually it can be nil >> if a custom group was defined by just evaling Lisp. > > Where is this behaviour documented? I couldn't reproduce it with a > simple experiment. To reproduce: M-: (defgroup mygroup nil "my group") RET I don't think it's documented anywhere? custom-current-group-alist is not documented so this wouldn't be either. >> * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a >> custom group was defined by eval. >> --- >> lisp/emacs-lisp/package.el | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >> index 3e6acd9b388..f67e99e04b5 100644 >> --- a/lisp/emacs-lisp/package.el >> +++ b/lisp/emacs-lisp/package.el >> @@ -4642,6 +4642,7 @@ package-report-bug >> (boundp (car ent)) >> (not (eq (custom--standard-value (car ent)) >> (default-toplevel-value (car ent)))) >> + (car group) > > If you are checking for (car group), when do this in the loop instead > of wrapping the entire `dolist'? Good point. I was just copying the last condition in the and. Lifted them both out of the loop: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Support-transforming-the-dirname-used-by-uniquify.patch >From 2873d4c482acfd1ced749d593fd512c408e0a578 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 9 Jul 2023 22:21:03 -0400 Subject: [PATCH] Support transforming the dirname used by uniquify By transforming the dirname, we can add additional information to use during uniquifying. A basic one: uniquifying buffer names based on the project name. * lisp/progmodes/project.el (project-uniquify-dirname-transform): Add. * lisp/uniquify.el (uniquify-dirname-transform-default) (uniquify-dirname-transform): Add. (bug#62621) (uniquify-rationalize-file-buffer-names, uniquify-buffer-file-name): Use uniquify-dirname-transform. * test/lisp/uniquify-tests.el (uniquify-home, uniquify-project-transform): Add tests. --- lisp/progmodes/project.el | 12 ++++++++++++ lisp/uniquify.el | 26 +++++++++++++++++++++----- test/lisp/uniquify-tests.el | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 66 insertions(+), 5 deletions(-) diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index d482cc24d70..78f9fb410c1 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1835,5 +1835,17 @@ project-switch-project (let ((project-current-directory-override dir)) (call-interactively command)))) +;;;###autoload +(defun project-uniquify-dirname-transform (dirname) + "Include `project-name' in DIRNAME if in a project." + (if-let (proj (project-current nil dirname)) + (let ((root (project-root proj))) + (expand-file-name + (file-name-concat + (file-name-directory root) + (project-name proj) + (file-relative-name dirname root)))) + dirname)) + (provide 'project) ;;; project.el ends here diff --git a/lisp/uniquify.el b/lisp/uniquify.el index d1ca455b673..b2f28a10d51 100644 --- a/lisp/uniquify.el +++ b/lisp/uniquify.el @@ -168,6 +168,20 @@ uniquify-list-buffers-directory-modes That means that when `buffer-file-name' is set to nil, `list-buffers-directory' contains the name of the directory which the buffer is visiting.") +(defun uniquify-dirname-transform-default (dirname) + "Simply return DIRNAME unchanged." + dirname) + +(defcustom uniquify-dirname-transform #'uniquify-dirname-transform-default + "A function to transform the dirname used to uniquify a buffer. + +It takes a single argument: the directory of the buffer. It +should return a string filename (which does not need to actually +exist in the filesystem) to use for uniquifying the buffer name." + :type '(choice (function-item uniquify-dirname-transform-default) + function) + :group 'uniquify) + ;;; Utilities ;; uniquify-fix-list data structure @@ -209,7 +223,8 @@ uniquify-rationalize-file-buffer-names ;; this buffer. (with-current-buffer newbuf (setq uniquify-managed nil)) (when dirname - (setq dirname (expand-file-name (directory-file-name dirname))) + (setq dirname (funcall uniquify-dirname-transform + (expand-file-name (directory-file-name dirname)))) (let ((fix-list (list (uniquify-make-item base dirname newbuf nil))) items) @@ -268,10 +283,11 @@ uniquify-buffer-file-name (if (memq major-mode uniquify-list-buffers-directory-modes) list-buffers-directory)))) (when filename - (directory-file-name - (file-name-directory - (expand-file-name - (directory-file-name filename)))))))) + (funcall uniquify-dirname-transform + (directory-file-name + (file-name-directory + (expand-file-name + (directory-file-name filename))))))))) (defun uniquify-rerationalize-w/o-cb (fix-list) "Re-rationalize the buffers in FIX-LIST, but ignoring `current-buffer'." diff --git a/test/lisp/uniquify-tests.el b/test/lisp/uniquify-tests.el index abd61fa3504..e533c4b644c 100644 --- a/test/lisp/uniquify-tests.el +++ b/test/lisp/uniquify-tests.el @@ -88,6 +88,21 @@ uniquify-dirs '("a/dir/" "b/dir/"))) (mapc #'kill-buffer bufs))))) +(ert-deftest uniquify-home () + "uniquify works, albeit confusingly, in the presence of directories named \"~\"" + (let (bufs) + (save-excursion + (push (find-file-noselect "~") bufs) + (push (find-file-noselect "./~") bufs) + (should (equal (mapcar #'buffer-name bufs) + '("~" "~<>"))) + (push (find-file-noselect "~/foo") bufs) + (push (find-file-noselect "./~/foo") bufs) + (should (equal (mapcar #'buffer-name bufs) + '("foo<~>" "foo" "~" "~<>"))) + (while bufs + (kill-buffer (pop bufs)))))) + (ert-deftest uniquify-rename-to-dir () "Giving a buffer a name which matches a directory doesn't rename the buffer" (let ((uniquify-buffer-name-style 'forward) @@ -125,5 +140,23 @@ uniquify-space-prefix (should (equal (buffer-name) "| foo")) (kill-buffer))) +(require 'project) +(ert-deftest uniquify-project-transform () + "`project-uniquify-dirname-transform' works" + (let ((uniquify-dirname-transform #'project-uniquify-dirname-transform) + (project-vc-name "foo1/bar") + bufs) + (save-excursion + (should (file-exists-p "../README")) + (push (find-file-noselect "../README") bufs) + (push (find-file-noselect "other/README") bufs) + (should (equal (mapcar #'buffer-name bufs) + '("README" "README"))) + (push (find-file-noselect "foo2/bar/README") bufs) + (should (equal (mapcar #'buffer-name bufs) + '("README" "README" "README"))) + (while bufs + (kill-buffer (pop bufs)))))) + (provide 'uniquify-tests) ;;; uniquify-tests.el ends here -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 15:48:56 2023 Received: (at 64543) by debbugs.gnu.org; 12 Jul 2023 19:48:56 +0000 Received: from localhost ([127.0.0.1]:52986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfpY-0004BI-ER for submit@debbugs.gnu.org; Wed, 12 Jul 2023 15:48:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfpU-0004Ap-8S for 64543@debbugs.gnu.org; Wed, 12 Jul 2023 15:48:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3BFAF240028 for <64543@debbugs.gnu.org>; Wed, 12 Jul 2023 21:48:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689191325; bh=Y1ufoInx5xPnIAlHrxlEsGxsLGHidLzP5ZUPvHYaowY=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=V3LIdzL4veK7kv5/4yDogn+Z4SbI4revnOqNMvfcY1RT6YYjPAFOhlRj8WvqDYs8x WhCWLQI7f+WBIhmoWR89jcSv1HyGVT8TYzs/bopGGalyfsWVO3G++ybba3eJnPKFre rL6SRWcusQSv5lprOqYfUl8W2B8BnsEiWPZKeBm4x01A+CGe18kKfK6EvXxGGHmnBX Ww2OM9BxZCMOTk7Zp4DdqDBIC9jaSEwm8R9FDiufhfPGuhJCWj6g13IXMUuqQF6rWG 2Pa2DZlmKjsxf8/STDSkzqL03CnW0U5Yrqc2oKLhqPQFcYJ8IF/gtNxBWmTdSXvT+8 5w2z6HXuPXoWA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R1SwX3G23z9rxL; Wed, 12 Jul 2023 21:48:44 +0200 (CEST) From: Philip Kaludercic To: sbaugh@catern.com Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87ttu9j5ii.fsf@catern.com> (sbaugh@catern.com's message of "Wed, 12 Jul 2023 19:26:13 +0000 (UTC)") References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Wed, 12 Jul 2023 19:48:43 +0000 Message-ID: <87edlcc3ms.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) sbaugh@catern.com writes: > Philip Kaludercic writes: > >> sbaugh@catern.com writes: >> >> Thanks, >> >>> From: Spencer Baugh >>> Date: Sun, 9 Jul 2023 12:59:50 -0400 >>> Subject: [PATCH] package-report-bug: don't fail on custom groups defined by >>> eval >>> >>> Previously we just assumed that the car of an element of >>> custom-current-group-alist was a filename. But actually it can be nil >>> if a custom group was defined by just evaling Lisp. >> >> Where is this behaviour documented? I couldn't reproduce it with a >> simple experiment. > > To reproduce: > M-: (defgroup mygroup nil "my group") RET OK, I misunderstood your point, I assumed we were talking about `defcustom' declarations that were evaluated outside the context of a file. > I don't think it's documented anywhere? custom-current-group-alist is > not documented so this wouldn't be either. > >>> * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a >>> custom group was defined by eval. >>> --- >>> lisp/emacs-lisp/package.el | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el >>> index 3e6acd9b388..f67e99e04b5 100644 >>> --- a/lisp/emacs-lisp/package.el >>> +++ b/lisp/emacs-lisp/package.el >>> @@ -4642,6 +4642,7 @@ package-report-bug >>> (boundp (car ent)) >>> (not (eq (custom--standard-value (car ent)) >>> (default-toplevel-value (car ent)))) >>> + (car group) >> >> If you are checking for (car group), when do this in the loop instead >> of wrapping the entire `dolist'? > > Good point. I was just copying the last condition in the and. Lifted > them both out of the loop: > > From 2873d4c482acfd1ced749d593fd512c408e0a578 Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Sun, 9 Jul 2023 22:21:03 -0400 > Subject: [PATCH] Support transforming the dirname used by uniquify Wrong patch? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 15:56:52 2023 Received: (at 64543) by debbugs.gnu.org; 12 Jul 2023 19:56:53 +0000 Received: from localhost ([127.0.0.1]:53004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfxE-0004Uz-Hj for submit@debbugs.gnu.org; Wed, 12 Jul 2023 15:56:52 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:37571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJfxC-0004Ug-HK for 64543@debbugs.gnu.org; Wed, 12 Jul 2023 15:56:51 -0400 From: Spencer Baugh To: Philip Kaludercic Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87edlcc3ms.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 12 Jul 2023 19:48:43 +0000") References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> Date: Wed, 12 Jul 2023 15:56:44 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@catern.com, 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > sbaugh@catern.com writes: >> Good point. I was just copying the last condition in the and. Lifted >> them both out of the loop: >> >> From 2873d4c482acfd1ced749d593fd512c408e0a578 Mon Sep 17 00:00:00 2001 >> From: Spencer Baugh >> Date: Sun, 9 Jul 2023 22:21:03 -0400 >> Subject: [PATCH] Support transforming the dirname used by uniquify > > Wrong patch? Oops! Here's the right one: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-package-report-bug-don-t-fail-on-custom-groups-defin.patch >From fb31777bcc1935de351eaa35c1ed679c66d24a92 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 9 Jul 2023 12:59:50 -0400 Subject: [PATCH] package-report-bug: don't fail on custom groups defined by eval Previously we just assumed that the car of an element of custom-current-group-alist was a filename. But actually it can be nil if a custom group was defined by just evaling Lisp. * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a custom group was defined by eval. --- lisp/emacs-lisp/package.el | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 3e6acd9b388..58ca19f7fe2 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -4637,13 +4637,14 @@ package-report-bug vars) (dolist-with-progress-reporter (group custom-current-group-alist) "Scanning for modified user options..." - (dolist (ent (get (cdr group) 'custom-group)) - (when (and (custom-variable-p (car ent)) - (boundp (car ent)) - (not (eq (custom--standard-value (car ent)) - (default-toplevel-value (car ent)))) - (file-in-directory-p (car group) (package-desc-dir desc))) - (push (car ent) vars)))) + (when (and (car group) + (file-in-directory-p (car group) (package-desc-dir desc))) + (dolist (ent (get (cdr group) 'custom-group)) + (when (and (custom-variable-p (car ent)) + (boundp (car ent)) + (not (eq (custom--standard-value (car ent)) + (default-toplevel-value (car ent))))) + (push (car ent) vars))))) (dlet ((reporter-prompt-for-summary-p t)) (reporter-submit-bug-report maint name vars)))) -- 2.39.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 13 00:54:18 2023 Received: (at 64543) by debbugs.gnu.org; 13 Jul 2023 04:54:18 +0000 Received: from localhost ([127.0.0.1]:53159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJoLK-0002mm-HM for submit@debbugs.gnu.org; Thu, 13 Jul 2023 00:54:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJoLI-0002mX-QU for 64543@debbugs.gnu.org; Thu, 13 Jul 2023 00:54:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJoLD-0006sN-IN; Thu, 13 Jul 2023 00:54:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yJvvE2hH3LcR8nwTBmpZLnqa2oPcGFyx5fTPajgj9qA=; b=qTnHiyBzxWFp OyfX8ph9lCJoxY/SYaFs65pJAJ4LNb2ibH3/wEUKP5SavFGNVaYPDd10o4V2il7Vpid5V/j92LiZW /gvrStxLvnxvnz6MtBmPSe8iqEDrtSifT3DKVp701tpC3HSAuPTGFxPIDVAdg/qLlBL7mDYTBYZrt U+B+uczACjSt71KRA3Dyf6pYdEAhJGFucy99+uLnmHjJSE4b68M8p0T1++53U4lamBXFXj1CDgTzr h8qtgdb4VRqvU1RcIL4O8NUb4G7XVFySVUSDEOpc4LBqDpMo7RyfsQIlVNCCYYQ31qXUn/GsmBRox KNC/YgEzocnrcZpIMsHqHA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJoLB-0003nT-Rn; Thu, 13 Jul 2023 00:54:11 -0400 Date: Thu, 13 Jul 2023 07:54:25 +0300 Message-Id: <83mt005s3i.fsf@gnu.org> From: Eli Zaretskii To: sbaugh@catern.com In-Reply-To: <87ttu9j5ii.fsf@catern.com> (sbaugh@catern.com) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: philipk@posteo.net, 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 64543@debbugs.gnu.org > From: sbaugh@catern.com > Date: Wed, 12 Jul 2023 19:26:13 +0000 (UTC) > > +(defun uniquify-dirname-transform-default (dirname) > + "Simply return DIRNAME unchanged." > + dirname) If you don't explain the need for its existence in the doc string, this function looks weirdly redundant. > +(defcustom uniquify-dirname-transform #'uniquify-dirname-transform-default > + "A function to transform the dirname used to uniquify a buffer. Come to think about it, why not use 'identity as the default value? Then the above weird function could be deleted. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 14 15:44:30 2023 Received: (at 64543) by debbugs.gnu.org; 14 Jul 2023 19:44:30 +0000 Received: from localhost ([127.0.0.1]:43552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKOiM-0003Fs-7x for submit@debbugs.gnu.org; Fri, 14 Jul 2023 15:44:30 -0400 Received: from mout01.posteo.de ([185.67.36.65]:56621) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKOiK-0003Ff-9N for 64543@debbugs.gnu.org; Fri, 14 Jul 2023 15:44:28 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B801A240027 for <64543@debbugs.gnu.org>; Fri, 14 Jul 2023 21:44:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689363862; bh=ax+OHev3xv6TE9vuTk2jHOFzGHMP2j0H5NE8unjBCr8=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=VhRqBUE8io0F0fhx1saLwNaZh5PJ+UtKz9erwGOuBQhSI5ABIgfApZFsUporZWSnu nWDWg5q16dyiGlPOI/9W1PvWYwrC96khC7RwzkOfwFlE+luhSR4R2/pC0zju6X2qUC hhERloyi9XJFAIwa5xS2j2o5JcYovS0FxENRCM2bGBs6H9lL7wXH3Wk1qDAyD8ll77 TlLYCOrCGF/uH598k0LJp2x+o+t21jH0rWdDpVQn6opPKdog/7IPQbVyKDx3aHKMoc iL6IyKIz9AnRI8+0bCRghv22wO9br0pqImmeIyyegTE4JIfdsGzPaD4yTg9f99yV2z y3DCECKn5FPxA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R2hkS1Swzz6twK; Fri, 14 Jul 2023 21:44:16 +0200 (CEST) From: Philip Kaludercic To: Spencer Baugh Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: (Spencer Baugh's message of "Wed, 12 Jul 2023 15:56:44 -0400") References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Fri, 14 Jul 2023 19:44:15 +0000 Message-ID: <87fs5qp9bk.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@catern.com, 'Eli Zaretskii' , 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Spencer Baugh writes: > Philip Kaludercic writes: > >> sbaugh@catern.com writes: >>> Good point. I was just copying the last condition in the and. Lifted >>> them both out of the loop: >>> >>> From 2873d4c482acfd1ced749d593fd512c408e0a578 Mon Sep 17 00:00:00 2001 >>> From: Spencer Baugh >>> Date: Sun, 9 Jul 2023 22:21:03 -0400 >>> Subject: [PATCH] Support transforming the dirname used by uniquify >> >> Wrong patch? > Oops! Here's the right one: > > From fb31777bcc1935de351eaa35c1ed679c66d24a92 Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Sun, 9 Jul 2023 12:59:50 -0400 > Subject: [PATCH] package-report-bug: don't fail on custom groups defined by > eval > > Previously we just assumed that the car of an element of > custom-current-group-alist was a filename. But actually it can be nil > if a custom group was defined by just evaling Lisp. > > * lisp/emacs-lisp/package.el (package-report-bug): Don't fail when a > custom group was defined by eval. > --- > lisp/emacs-lisp/package.el | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el > index 3e6acd9b388..58ca19f7fe2 100644 > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -4637,13 +4637,14 @@ package-report-bug > vars) > (dolist-with-progress-reporter (group custom-current-group-alist) > "Scanning for modified user options..." > - (dolist (ent (get (cdr group) 'custom-group)) > - (when (and (custom-variable-p (car ent)) > - (boundp (car ent)) > - (not (eq (custom--standard-value (car ent)) > - (default-toplevel-value (car ent)))) > - (file-in-directory-p (car group) (package-desc-dir desc))) > - (push (car ent) vars)))) > + (when (and (car group) > + (file-in-directory-p (car group) (package-desc-dir desc))) > + (dolist (ent (get (cdr group) 'custom-group)) > + (when (and (custom-variable-p (car ent)) > + (boundp (car ent)) > + (not (eq (custom--standard-value (car ent)) > + (default-toplevel-value (car ent))))) > + (push (car ent) vars))))) > (dlet ((reporter-prompt-for-summary-p t)) > (reporter-submit-bug-report maint name vars)))) LGTM. Eli, would it be OK to push this to emacs-29, as this is a bug in the existing code? Most of the changes are indentation/whitespace changes anyway. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 01:49:09 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 05:49:09 +0000 Received: from localhost ([127.0.0.1]:43823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKY9V-0003vb-DD for submit@debbugs.gnu.org; Sat, 15 Jul 2023 01:49:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKY9T-0003vH-P7 for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 01:49:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKY9N-0006vR-P4; Sat, 15 Jul 2023 01:49:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/Oy9tuY3ZNmYPjpxzecY3DMz8QjsexSvJMrffxMMVpM=; b=R/A+zJFQdQRU zImQYUud8xr8cYPJYNoSlp+ZQYJBJNydu3HlmswHsxMSpCyXt8N3LaKrd21z010/kPdEAz9eMlJP1 uWGx+sMT2m1XY4QdejTni4ETJWmPb1w88GZDWW6ezTX+P7VVDlhGOUiRfn9NNgBzA3++/fEvx6AUt s5WoWzwak2OcndbEfU8sgf8ZmPi5RHGABCWvJK50C/ORzVTcabpYg1Qmn9PeFNf6ISBgPIwAzqKSO /0Mp/8KTzBjYCDXzp3MInh2i7ssxK1Ss/+36JEYs7WhZViSIDXQMrvFJbUIn/u/NlDseTj0OOzmjz 4UTPJ4/MDWbpUfNEb6EHyw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKY9M-0008Kp-Eu; Sat, 15 Jul 2023 01:49:01 -0400 Date: Sat, 15 Jul 2023 08:49:21 +0300 Message-Id: <83mszxenby.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87fs5qp9bk.fsf@posteo.net> (message from Philip Kaludercic on Fri, 14 Jul 2023 19:44:15 +0000) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> <87fs5qp9bk.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, 64543@debbugs.gnu.org, sbaugh@catern.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: sbaugh@catern.com, 64543@debbugs.gnu.org, "'Eli Zaretskii'" > Date: Fri, 14 Jul 2023 19:44:15 +0000 > > Eli, would it be OK to push this to emacs-29, as this is a bug in the > existing code? Most of the changes are indentation/whitespace changes > anyway. I don't understand the cases in which this bug happens, and so cannot make the decision. The entire discussion of this bug never described such a case, AFAICT. (Also, the commit log message could use some loving care: what does it mean when it says "Previously"?) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 03:40:12 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 07:40:12 +0000 Received: from localhost ([127.0.0.1]:43969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKZsy-0001EW-GT for submit@debbugs.gnu.org; Sat, 15 Jul 2023 03:40:12 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKZsu-0001EC-VW for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 03:40:11 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E6211240103 for <64543@debbugs.gnu.org>; Sat, 15 Jul 2023 09:40:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689406802; bh=yQBcLFnPZs9rN4k3CXkfUQyljMPvl/4t3Qvb8uzHPwo=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=YwxOrRa4NszstS3nTAp44ZhxhIFez3oBsmxX97J5QnqPSe/MAYRmiDXNf0iIsPSPy J24btNVZqRQ4OriLNb5ji7igJNNBhW8W3W6vpJ+AXtcbbLJ5uFfsVAMX1sc91PyXYa vG706Xno7nMlqKzFn2MevjA4KU/G80MrioDCQZW3qKiHs5KyZbj9Vxv5CNA49RJq2X LYh4VC9SVj2FOw6jstXF8NVOtqbNcKHsdhGA7I9JB+mvMgAcNfHQQ+bSTbveohmtJ5 pBoz7MeOuw4fvbztMZ5um+d/Lg/VEmvLUMR9C4CyFywn91VdjgC5b0iaIu1U3umrW4 jeZxdq+tHgSow== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R30cL0Xx2z6twG; Sat, 15 Jul 2023 09:40:01 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <83mszxenby.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 08:49:21 +0300") References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> <87fs5qp9bk.fsf@posteo.net> <83mszxenby.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 15 Jul 2023 07:40:01 +0000 Message-ID: <87mszx62su.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, 64543@debbugs.gnu.org, sbaugh@catern.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: sbaugh@catern.com, 64543@debbugs.gnu.org, "'Eli Zaretskii'" >> Date: Fri, 14 Jul 2023 19:44:15 +0000 >> >> Eli, would it be OK to push this to emacs-29, as this is a bug in the >> existing code? Most of the changes are indentation/whitespace changes >> anyway. > > I don't understand the cases in which this bug happens, and so cannot > make the decision. Spencer gave this example: >> Previously we just assumed that the car of an element of >> custom-current-group-alist was a filename. But actually it can be nil >> if a custom group was defined by just evaling Lisp. > > Where is this behaviour documented? I couldn't reproduce it with a > simple experiment. To reproduce: M-: (defgroup mygroup nil "my group") RET The patch would ensure that if groups like these are defined (which might happen by mistake), then `package-report-bug' will remain robust and not fail due to a unrelated issue. > The entire discussion of this bug never described > such a case, AFAICT. (Also, the commit log message could use some > loving care: what does it mean when it says "Previously"?) How about --8<---------------cut here---------------start------------->8--- * lisp/emacs-lisp/package.el (package-report-bug): Do not assume that every entry in 'custom-current-group-alist' has a non-nil entry for a filename. It is possible for a group to not be associated with any file, e.g. when a 'defgroup' form is evaluated using 'eval-expression'. (bug#64543) --8<---------------cut here---------------end--------------->8--- A related discussion might be if `custom-declare-group' could be improved, by not just consulting `load-file-name', but using `macroexp-file-name'. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 04:56:55 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 08:56:56 +0000 Received: from localhost ([127.0.0.1]:44123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKb5D-0003PI-IQ for submit@debbugs.gnu.org; Sat, 15 Jul 2023 04:56:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKb5A-0003P4-83 for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 04:56:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKb54-0007uy-NH; Sat, 15 Jul 2023 04:56:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KJhkykdMPpWx5K8WWezFJ1EjxZXvgQzjueNpB2w1RRs=; b=WZ7An6Bmk1yS njvuHXh+cJJRdLvd6IXoMQqiz9Tnf4kPt1c/NSCdOEz0btoqeuRt2qAqz2nJcWjoSw7WG5P9WrJq2 rJmSVYJ1Ws7DBDBh21ejhcfL5towImpPRDkFdWICdrc4u16E7xVPNK7ayvsdExQmtg9yc5CfT6DJ7 AyBwbRppnYlvi3gdOwpQ3Rc3mSvkgB75zyXLorHLR1iSyYmzHUBnPUQqrdCHvwfdK0ZuGqRvNkLQF NXjXWLmCFztN1GXl83OkgWDY75d5+4GyaeLvhqLq16v4GsjkSQoOdUfssv6jKTSKhFnUB5JSc/y64 Ljl9ZrceMoCf5t8NLOD7rg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKb54-0001Pp-70; Sat, 15 Jul 2023 04:56:46 -0400 Date: Sat, 15 Jul 2023 11:57:06 +0300 Message-Id: <83h6q5d02l.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87mszx62su.fsf@posteo.net> (message from Philip Kaludercic on Sat, 15 Jul 2023 07:40:01 +0000) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval References: <87351xm2ri.fsf@catern.com> <87edlfkg70.fsf@posteo.net> <87ttu9j5ii.fsf@catern.com> <87edlcc3ms.fsf@posteo.net> <87fs5qp9bk.fsf@posteo.net> <83mszxenby.fsf@gnu.org> <87mszx62su.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, 64543@debbugs.gnu.org, sbaugh@catern.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: sbaugh@janestreet.com, sbaugh@catern.com, 64543@debbugs.gnu.org > Date: Sat, 15 Jul 2023 07:40:01 +0000 > > Eli Zaretskii writes: > > >> Eli, would it be OK to push this to emacs-29, as this is a bug in the > >> existing code? Most of the changes are indentation/whitespace changes > >> anyway. > > > > I don't understand the cases in which this bug happens, and so cannot > > make the decision. > > Spencer gave this example: > > >> Previously we just assumed that the car of an element of > >> custom-current-group-alist was a filename. But actually it can be nil > >> if a custom group was defined by just evaling Lisp. > > > > Where is this behaviour documented? I couldn't reproduce it with a > > simple experiment. > > To reproduce: > M-: (defgroup mygroup nil "my group") RET > > The patch would ensure that if groups like these are defined (which > might happen by mistake), then `package-report-bug' will remain robust > and not fail due to a unrelated issue. Is this case important enough to make this change so late in the pretest? Spencer, how did you bump into this situation in Real Life? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 05:12:57 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 09:12:57 +0000 Received: from localhost ([127.0.0.1]:44151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbKj-0003p9-5D for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:12:57 -0400 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:2528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbKf-0003op-BM for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 05:12:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=subject:in-reply-to:from:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=4VvIwWAOSZWCYR9ci2CsxuTSv4ClisQog2s3KV1H3s0=; b=RDQld6FGtthNdNM/2GjgeUXrvn3OixBIufyptEX+fuiUuvjo4uGC59M1yzGF/ZSqGA6g YOCm24CsPguTEu6l0wddnPwBNyq2oXfShWPUJ1hHzWmKzUv4DyFLhRh2cnx0j4TDeuwJzr c9ul7Ewab89SZi/YmgyUWqhkNQhz4SHl0BYJgEjWYwZr6uZAIfkwYbQ/WqllRJpXzyGYel 05XQlT+jwbCfQ0PSQ47kYJYcIXoxqV8l8zRGFA7TlMdExnBDZQBiLrtQrsXdqoczXgApGh E5Nk/ElYhyZenHcOLXwrOmHzV48r0X9kYH9R+U9rPqt/S9GJ1YzqdOY1/f8xbxNA== Received: by filterdrecv-d7bbbc8bf-hv8x8 with SMTP id filterdrecv-d7bbbc8bf-hv8x8-1-64B26310-2 2023-07-15 09:12:48.02704777 +0000 UTC m=+5650390.252183038 Received: from earth.catern.com (unknown) by geopod-ismtpd-16 (SG) with ESMTP id P-04K6I3S0uw8JWuCbs_Pg Sat, 15 Jul 2023 09:12:47.981 +0000 (UTC) Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval Message-ID: X-Android-Message-ID: In-Reply-To: <83h6q5d02l.fsf@gnu.org> From: Spencer Baugh Importance: Normal X-Priority: 3 X-MSMail-Priority: Normal MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?GW3oCMoYnalRiojMOuLzE6x2H5kORXvlCdz1UwQVRMVT4fbh9ODEfCogOe74cO?= =?us-ascii?Q?rI4e0V+MFZgakz9Re5a6=2FCgswKSIPcd3ym7=2FqGl?= =?us-ascii?Q?XoDGw18yjJx0iiPvH60lOrrYeZytgTxkPXU8MMm?= =?us-ascii?Q?osswrcstgDtO0975HWG8X0wX2q2hDV17XKON7vm?= =?us-ascii?Q?c3oCAgsJCbCvbuIpaMhoMKzdCOuPElR392Vz3Wo?= =?us-ascii?Q?DYnq4mZrQogpZ53Ndb0DDsF1Oug4TBuIygrekn?= To: Eli Zaretskii X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: base64 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Jul 15, 2023 04:57, Eli Zaretskii wrote: > From: Philip Kaludercic > Cc: sbaugh@janestreet.com, sbaugh@catern.com, 64543@debbugs.gnu.org > Date: Sat, 15 Jul 2023 07:40:01 +0000 > > Eli Zaretskii writes: > [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 MIME_HTML_ONLY BODY: Message only has text/html MIME parts 0.0 HTML_MESSAGE BODY: HTML included in message 0.0 MIME_BASE64_TEXT RAW: Message text disguised using base64 encoding 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [149.72.154.232 listed in wl.mailspike.net] 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.6 HTML_MIME_NO_HTML_TAG HTML-only message, but there is no HTML tag -0.0 T_SCC_BODY_TEXT_LINE No description available. 1.0 MALF_HTML_B64 Malformatted base64-encoded HTML content X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, Philip Kaludercic , 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) PGRpdiBkaXI9J2F1dG8nPjxkaXY+PGRpdiBjbGFzcz0iZ21haWxfZXh0cmEiPjxicj48ZGl2IGNs YXNzPSJnbWFpbF9xdW90ZSI+T24gSnVsIDE1LCAyMDIzIDA0OjU3LCBFbGkgWmFyZXRza2lpICZs dDtlbGl6QGdudS5vcmcmZ3Q7IHdyb3RlOjxiciB0eXBlPSJhdHRyaWJ1dGlvbiI+PGJsb2NrcXVv dGUgY2xhc3M9InF1b3RlIiBzdHlsZT0ibWFyZ2luOjAgMCAwIC44ZXg7Ym9yZGVyLWxlZnQ6MXB4 ICNjY2Mgc29saWQ7cGFkZGluZy1sZWZ0OjFleCI+PHAgZGlyPSJsdHIiPiZndDsgRnJvbTogUGhp bGlwIEthbHVkZXJjaWMgJmx0O3BoaWxpcGtAcG9zdGVvLm5ldCZndDsKPGJyPgomZ3Q7IENjOiBz YmF1Z2hAamFuZXN0cmVldC5jb20sJm5ic3A7IHNiYXVnaEBjYXRlcm4uY29tLCZuYnNwOyA2NDU0 M0BkZWJidWdzLmdudS5vcmcKPGJyPgomZ3Q7IERhdGU6IFNhdCwgMTUgSnVsIDIwMjMgMDc6NDA6 MDEgKzAwMDAKPGJyPgomZ3Q7IAo8YnI+CiZndDsgRWxpIFphcmV0c2tpaSAmbHQ7ZWxpekBnbnUu b3JnJmd0OyB3cml0ZXM6Cjxicj4KJmd0OyAKPGJyPgomZ3Q7ICZndDsmZ3Q7IEVsaSwgd291bGQg aXQgYmUgT0sgdG8gcHVzaCB0aGlzIHRvIGVtYWNzLTI5LCBhcyB0aGlzIGlzIGEgYnVnIGluIHRo ZQo8YnI+CiZndDsgJmd0OyZndDsgZXhpc3RpbmcgY29kZT8mbmJzcDsgTW9zdCBvZiB0aGUgY2hh bmdlcyBhcmUgaW5kZW50YXRpb24vd2hpdGVzcGFjZSBjaGFuZ2VzCjxicj4KJmd0OyAmZ3Q7Jmd0 OyBhbnl3YXkuCjxicj4KJmd0OyAmZ3Q7Cjxicj4KJmd0OyAmZ3Q7IEkgZG9uJ3QgdW5kZXJzdGFu ZCB0aGUgY2FzZXMgaW4gd2hpY2ggdGhpcyBidWcgaGFwcGVucywgYW5kIHNvIGNhbm5vdAo8YnI+ CiZndDsgJmd0OyBtYWtlIHRoZSBkZWNpc2lvbi4mbmJzcDsgCjxicj4KJmd0OyAKPGJyPgomZ3Q7 IFNwZW5jZXIgZ2F2ZSB0aGlzIGV4YW1wbGU6Cjxicj4KJmd0OyAKPGJyPgomZ3Q7Jm5ic3A7Jm5i c3A7ICZndDsmZ3Q7IFByZXZpb3VzbHkgd2UganVzdCBhc3N1bWVkIHRoYXQgdGhlIGNhciBvZiBh biBlbGVtZW50IG9mCjxicj4KJmd0OyZuYnNwOyZuYnNwOyAmZ3Q7Jmd0OyBjdXN0b20tY3VycmVu dC1ncm91cC1hbGlzdCB3YXMgYSBmaWxlbmFtZS4mbmJzcDsgQnV0IGFjdHVhbGx5IGl0IGNhbiBi ZSBuaWwKPGJyPgomZ3Q7Jm5ic3A7Jm5ic3A7ICZndDsmZ3Q7IGlmIGEgY3VzdG9tIGdyb3VwIHdh cyBkZWZpbmVkIGJ5IGp1c3QgZXZhbGluZyBMaXNwLgo8YnI+CiZndDsmbmJzcDsmbmJzcDsgJmd0 Owo8YnI+CiZndDsmbmJzcDsmbmJzcDsgJmd0OyBXaGVyZSBpcyB0aGlzIGJlaGF2aW91ciBkb2N1 bWVudGVkPyZuYnNwOyBJIGNvdWxkbid0IHJlcHJvZHVjZSBpdCB3aXRoIGEKPGJyPgomZ3Q7Jm5i c3A7Jm5ic3A7ICZndDsgc2ltcGxlIGV4cGVyaW1lbnQuCjxicj4KJmd0OyAKPGJyPgomZ3Q7Jm5i c3A7Jm5ic3A7IFRvIHJlcHJvZHVjZToKPGJyPgomZ3Q7Jm5ic3A7Jm5ic3A7IE0tOiAoZGVmZ3Jv dXAgbXlncm91cCBuaWwgIm15IGdyb3VwIikgUkVUCjxicj4KJmd0OyAKPGJyPgomZ3Q7IFRoZSBw YXRjaCB3b3VsZCBlbnN1cmUgdGhhdCBpZiBncm91cHMgbGlrZSB0aGVzZSBhcmUgZGVmaW5lZCAo d2hpY2gKPGJyPgomZ3Q7IG1pZ2h0IGhhcHBlbiBieSBtaXN0YWtlKSwgdGhlbiBgcGFja2FnZS1y ZXBvcnQtYnVnJyB3aWxsIHJlbWFpbiByb2J1c3QKPGJyPgomZ3Q7IGFuZCBub3QgZmFpbCBkdWUg dG8gYSB1bnJlbGF0ZWQgaXNzdWUuCjxicj4KCjxicj4KSXMgdGhpcyBjYXNlIGltcG9ydGFudCBl bm91Z2ggdG8gbWFrZSB0aGlzIGNoYW5nZSBzbyBsYXRlIGluIHRoZQo8YnI+CnByZXRlc3Q/Jm5i c3A7IFNwZW5jZXIsIGhvdyBkaWQgeW91IGJ1bXAgaW50byB0aGlzIHNpdHVhdGlvbiBpbiBSZWFs IExpZmU/PC9wPjwvYmxvY2txdW90ZT48L2Rpdj48L2Rpdj48L2Rpdj48ZGl2IGRpcj0iYXV0byI+ SSBldmFsZWQgYSBidWZmZXIgY29udGFpbmluZyBhIGRlZmdyb3VwIHdpdGggQy1jIEMtZSAob3Ig bWF5YmUganVzdCBhIHJlZ2lvbj8pPC9kaXY+PGRpdiBkaXI9ImF1dG8iPjxkaXYgY2xhc3M9Imdt YWlsX2V4dHJhIj48YnI+PC9kaXY+PC9kaXY+PC9kaXY+ From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 05:23:09 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 09:23:09 +0000 Received: from localhost ([127.0.0.1]:44162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbUb-00047u-HS for submit@debbugs.gnu.org; Sat, 15 Jul 2023 05:23:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKbUY-00047F-Fu for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 05:23:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbUS-0000GW-14; Sat, 15 Jul 2023 05:23:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ciJtstXfvtKUP+sPC1EMieoA5ncQ7pfNNmDIen1YT/g=; b=Xl7uf+W4cpTb CcdyUVSl9d7+1D/AOT8UC4dRlJcXd8a68pps8jNv0CqKJsQmOU0LWLRZ4/yknovQy8zfbNU8JC2MR bCtjX9fbt4smnDm+kEgX+U7KO5iEvuxG51ia4423sjWFKtG+nZAhc9aGt0RmATBjZYnSXfz3xG0+v jESPJO6eTxzj/aFiXqmX5PRkNff0afYQ7Rsj4eUDIJUC8MjRK8AxuoK84p/nQVc2h0drYxrIe+uH5 WMIhiDfpnU0ULT1eXvDJLiQXoHzPC0uYmwK895i1ExgYw1R7AZ6VoQ6qApG09QwaeT3SpU0+VLtOA xkykfnYXaMz6wlH/Rg0klA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKbUR-0006ne-HR; Sat, 15 Jul 2023 05:22:59 -0400 Date: Sat, 15 Jul 2023 12:23:21 +0300 Message-Id: <83bkgdcyuu.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Sat, 15 Jul 2023 09:12:48 +0000 (UTC)) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, philipk@posteo.net, 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) > From: Spencer Baugh > Cc: Philip Kaludercic , sbaugh@janestreet.com, > 64543@debbugs.gnu.org > > On Jul 15, 2023 04:57, Eli Zaretskii wrote: > > > >> Previously we just assumed that the car of an element of > > >> custom-current-group-alist was a filename. But actually it can be nil > > >> if a custom group was defined by just evaling Lisp. > > > > > > Where is this behaviour documented? I couldn't reproduce it with a > > > simple experiment. > > > > To reproduce: > > M-: (defgroup mygroup nil "my group") RET > > > > The patch would ensure that if groups like these are defined (which > > might happen by mistake), then `package-report-bug' will remain robust > > and not fail due to a unrelated issue. > > Is this case important enough to make this change so late in the > pretest? Spencer, how did you bump into this situation in Real Life? > > I evaled a buffer containing a defgroup with C-c C-e (or maybe just a region?) Why did you do that? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 06:05:23 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 10:05:24 +0000 Received: from localhost ([127.0.0.1]:44210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKc9T-0005JA-H1 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 06:05:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:59955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKc9Q-0005Ih-Dy for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 06:05:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5F52C240029 for <64543@debbugs.gnu.org>; Sat, 15 Jul 2023 12:05:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689415514; bh=h8j3C4KVis9POBKHlNT0t+k6mF+kLKrSf6+Dp06uTMA=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=NmVDm7OpescFJzLm9VsfF2uL4vkT/jsVD1RfVZ5Z5/QsGjbf/aQsLZr+aMSNzqlDL 9DoQ9QyFVPqB3wuTeinpA5rn2NGuLQZyq8BRD9p3vHSTvpIS7CluNOpKYTIFb9iuii KjQ3XBhvDsWdJEbRJpidZNMi1JGyW9bZFGMYIa6hDX1I064mBLXF0yFfPKVhgsdtAi aHZJ5MCJzKM3vlfRAUv0mfYgGjaPCBd3j989oAAZjgNrpQKvV2Zh3S/T7V+wpw0mCZ ELMboL4ua/Ih8R17yV99WMxvpzwfN3T8lsvj15WJYTN8tZLFwEFnORKAeQ1WhFXvPs 0gLPm15AT6tRA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R33qs48SXz9rxN; Sat, 15 Jul 2023 12:05:13 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <83bkgdcyuu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 12:23:21 +0300") References: <83bkgdcyuu.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 15 Jul 2023 10:05:13 +0000 Message-ID: <87wmz17ana.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: Spencer Baugh , 64543@debbugs.gnu.org, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) >> From: Spencer Baugh >> Cc: Philip Kaludercic , sbaugh@janestreet.com, >> 64543@debbugs.gnu.org >> >> On Jul 15, 2023 04:57, Eli Zaretskii wrote: >> >> > >> Previously we just assumed that the car of an element of >> > >> custom-current-group-alist was a filename. But actually it can be nil >> > >> if a custom group was defined by just evaling Lisp. >> > > >> > > Where is this behaviour documented? I couldn't reproduce it with a >> > > simple experiment. >> > >> > To reproduce: >> > M-: (defgroup mygroup nil "my group") RET >> > >> > The patch would ensure that if groups like these are defined (which >> > might happen by mistake), then `package-report-bug' will remain robust >> > and not fail due to a unrelated issue. >> >> Is this case important enough to make this change so late in the >> pretest? Spencer, how did you bump into this situation in Real Life? >> >> I evaled a buffer containing a defgroup with C-c C-e (or maybe just a region?) > > Why did you do that? Evaluating an entire buffer with C-c C-e is not unreasonable, but it will not bind `load-file-name', which `load-file' would have done, but there is no binding for that. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 06:23:06 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 10:23:06 +0000 Received: from localhost ([127.0.0.1]:44228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKcQc-0005kW-5x for submit@debbugs.gnu.org; Sat, 15 Jul 2023 06:23:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKcQZ-0005jj-9t for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 06:23:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKcQS-0007WK-U5; Sat, 15 Jul 2023 06:22:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5ol2EzCyU4M4h2WK0/7XStP8r/0HNvmm13m89gULkrI=; b=KEyOm9yxpkEC IqCGZsL9YGNC8eb/QYdqM9YTAAqMS7Z04MKc+DUBFveSOlZyHDm69sTxDG7gfjkRO+tZFgqn8IINT BXlB+gfvovvMOqEzXH5GTd4LI5YBDkdowa/MuWQzxuFIkLgG2PnfVNIPYveK1vGQV7/RMOqgbchdR ha3I8m4it4XjMm/GEJ3IMNM2cDNTwp0TRcE34aCPhIc77Eliaa1XNR9rhkTEyUzwKyyAjF7YXFDX/ on/fUKUpROv/hJpx9VT8nvWb5VPI+TzlV6v2ThfXrUJmdyHd2Gj8lTL0wJ9tXhGBFEhxf5J7ArY9r I+ex495OvRy7d78h+ejgpQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKcQQ-0003s8-Jy; Sat, 15 Jul 2023 06:22:56 -0400 Date: Sat, 15 Jul 2023 13:23:16 +0300 Message-Id: <834jm5cw2z.fsf@gnu.org> From: Eli Zaretskii To: Philip Kaludercic In-Reply-To: <87wmz17ana.fsf@posteo.net> (message from Philip Kaludercic on Sat, 15 Jul 2023 10:05:13 +0000) Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval References: <83bkgdcyuu.fsf@gnu.org> <87wmz17ana.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@catern.com, 64543@debbugs.gnu.org, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philip Kaludercic > Cc: Spencer Baugh , sbaugh@janestreet.com, > 64543@debbugs.gnu.org > Date: Sat, 15 Jul 2023 10:05:13 +0000 > > Eli Zaretskii writes: > > >> I evaled a buffer containing a defgroup with C-c C-e (or maybe just a region?) > > > > Why did you do that? > > Evaluating an entire buffer with C-c C-e is not unreasonable, but it > will not bind `load-file-name', which `load-file' would have done, but > there is no binding for that. it sounds strange to me. But okay, please install on emacs-29 with the improved log message, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 13:45:21 2023 Received: (at 64543) by debbugs.gnu.org; 15 Jul 2023 17:45:21 +0000 Received: from localhost ([127.0.0.1]:46036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKjKa-00077A-I8 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 13:45:21 -0400 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net ([149.72.154.232]:4912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKjKX-00076p-WB for 64543@debbugs.gnu.org; Sat, 15 Jul 2023 13:45:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=1vifentq7DyHadSyNFOzrK6k3t95YhcFfqdRdP4ulos=; b=Zyysd1U4MSOgEPZXZ29EM5k5bSRnzUv/Pmdsq11RXFrXTdJtQMh0KVzCt7so3N8Z9gvP 9EOJc0AKInGpfEst1/kUW/Bw5e/5u3Zi4Wrx90gmUC0oOQpcS7B8ouvvY/h3O6SAifBuGE O0V/2+qRzS+zdlSG4nlbPJlnWvGhkR6RYDiZFk6lAItUR6Kxtvyuv2SzGD+AqMeD9XqlpC oz9eNHTLlviFufeNE1qESVOMm75CgE9pM7w3xnA4acuRrqjksib8LgAsaccdUIjsxGyYpf tR23C0hi3Pq/2SE1WqLyM1CLXU1gMLu1CXI5OcXrpzwS00N66lGrq5KOPq8AdSNQ== Received: by filterdrecv-66949dbc98-xnttg with SMTP id filterdrecv-66949dbc98-xnttg-1-64B2DB28-47 2023-07-15 17:45:12.50123974 +0000 UTC m=+1782616.679718240 Received: from earth.catern.com (unknown) by geopod-ismtpd-7 (SG) with ESMTP id my6p7C4HSKSO-O5F0w46eg Sat, 15 Jul 2023 17:45:12.456 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=posteo.net Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 2AD2F6256B; Sat, 15 Jul 2023 13:45:12 -0400 (EDT) From: sbaugh@catern.com Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87wmz17ana.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 15 Jul 2023 10:05:13 +0000") References: <83bkgdcyuu.fsf@gnu.org> <87wmz17ana.fsf@posteo.net> Date: Sat, 15 Jul 2023 17:45:12 +0000 (UTC) Message-ID: <87r0p9hxw7.fsf@catern.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbKO4Cm=2Fdnh4mEooRIJ8+G?= =?us-ascii?Q?g+dlDevNLP4+qdv7tWpcf2U0A8i80nZDx1uYEqw?= =?us-ascii?Q?6E7oM5KYkTTkgyuOQAB3Lbr=2FBXAsIjrmFReISSf?= =?us-ascii?Q?QTvqh=2F4PIzuPh5qn=2FGpdjX4G=2FoPpyVVLfq8ypKD?= =?us-ascii?Q?wU5BtccXq9q35VUKKCa8Z8mAy=2FM35ZWSpEA=3D=3D?= To: Philip Kaludercic X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, Eli Zaretskii , 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Philip Kaludercic writes: > Eli Zaretskii writes: > >>> Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) >>> From: Spencer Baugh >>> Cc: Philip Kaludercic , sbaugh@janestreet.com, >>> 64543@debbugs.gnu.org >>> >>> On Jul 15, 2023 04:57, Eli Zaretskii wrote: >>> >>> > >> Previously we just assumed that the car of an element of >>> > >> custom-current-group-alist was a filename. But actually it >>> > >> can be nil >>> > >> if a custom group was defined by just evaling Lisp. >>> > > >>> > > Where is this behaviour documented? I couldn't reproduce it with a >>> > > simple experiment. >>> > >>> > To reproduce: >>> > M-: (defgroup mygroup nil "my group") RET >>> > >>> > The patch would ensure that if groups like these are defined (which >>> > might happen by mistake), then `package-report-bug' will remain robust >>> > and not fail due to a unrelated issue. >>> >>> Is this case important enough to make this change so late in the >>> pretest? Spencer, how did you bump into this situation in Real Life? >>> >>> I evaled a buffer containing a defgroup with C-c C-e (or maybe just >>> a region?) >> >> Why did you do that? > > Evaluating an entire buffer with C-c C-e is not unreasonable, but it > will not bind `load-file-name', which `load-file' would have done, but > there is no binding for that. Maybe we should add a binding for load-file? Or maybe C-c C-e should bind load-file-name if the region is not active? Btw, just curious: how do others test modifications they make to Lisp files? I usually make a couple changes to several functions or variables and then reloading the whole file is easier than going defun by defun. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 19:33:54 2023 Received: (at 64543-done) by debbugs.gnu.org; 15 Jul 2023 23:33:54 +0000 Received: from localhost ([127.0.0.1]:46252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKolt-0001zM-MO for submit@debbugs.gnu.org; Sat, 15 Jul 2023 19:33:53 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKolp-0001z5-6w for 64543-done@debbugs.gnu.org; Sat, 15 Jul 2023 19:33:52 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4B39A240027 for <64543-done@debbugs.gnu.org>; Sun, 16 Jul 2023 01:33:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689464023; bh=+dVC2TAs3lPykH8vP9suRhEbbyebpMdeJKY5z/uKPbA=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=DEEgfZQN/gSHzTHNfUk7FDSjFPjOmZmGIFivzV/JBe6LrAweeFNNer/J8tdaJGsbu /IZKfO+55W7CNOiz/Evd9FvKxVWtsljTREhL0aWVVjdkvJ5GE+6efOqeevN9orZ/Rm nxnC2nbM2j+I+vKhIdf2EaFEz/mJ+fA2phurzNUVQXb4jCcZcy5CT4VK+GjR57UgyX Vq34U+05wHYODndgJqrT2bahitRNvsODu2SfxChPFfFNutSgxbfT7182iiesSRdPNd vl6SshJTR/FRBJTch0AIfjM3MPLeNco0JBKC+9csrNcotfXM1o1YuBSygn9F5+2Yu5 oLRk87RXEsHZg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R3Pmk2Hf2z9rxG; Sun, 16 Jul 2023 01:33:42 +0200 (CEST) From: Philip Kaludercic To: Eli Zaretskii Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <834jm5cw2z.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2023 13:23:16 +0300") References: <83bkgdcyuu.fsf@gnu.org> <87wmz17ana.fsf@posteo.net> <834jm5cw2z.fsf@gnu.org> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sat, 15 Jul 2023 23:33:40 +0000 Message-ID: <87cz0s21ij.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543-done Cc: sbaugh@catern.com, 64543-done@debbugs.gnu.org, sbaugh@janestreet.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Spencer Baugh , sbaugh@janestreet.com, >> 64543@debbugs.gnu.org >> Date: Sat, 15 Jul 2023 10:05:13 +0000 >> >> Eli Zaretskii writes: >> >> >> I evaled a buffer containing a defgroup with C-c C-e (or maybe >> > just a region?) >> > >> > Why did you do that? >> >> Evaluating an entire buffer with C-c C-e is not unreasonable, but it >> will not bind `load-file-name', which `load-file' would have done, but >> there is no binding for that. > > it sounds strange to me. > > But okay, please install on emacs-29 with the improved log message, > and thanks. Done. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 08:34:11 2023 Received: (at 64543) by debbugs.gnu.org; 16 Jul 2023 12:34:11 +0000 Received: from localhost ([127.0.0.1]:47019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL0x1-0001Da-9y for submit@debbugs.gnu.org; Sun, 16 Jul 2023 08:34:11 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL0ww-0001Cz-8P for 64543@debbugs.gnu.org; Sun, 16 Jul 2023 08:34:10 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4D0A424002A for <64543@debbugs.gnu.org>; Sun, 16 Jul 2023 14:34:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1689510840; bh=kwdCCDKEFA2QN0qXYsgMMxQhMF6ZsSfbr8v+Qo6uH6w=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=pZ1xzzVwDXJWLeQAlie37F6yprTdv3E2W4RcQL+nGZArR1z87dBsL/4JVrpK/cH+w /OsRUcTS7X67YTESV1nMJ5Q67t5sfpEZTWUntN/bQhRsqLAVDmgvnu6JwbhK2FqKgJ uXdpAJPwV13WN7VxMTtvRf1/XUfB/hXyAeSwQByykewCwXPOXkJ1wAq/xWo2rLeA3k wwlJukX3l7Y3FKCwtFItYHKZNG8Wa5mwPXRlqqA0ywAgtk2XHb+W9psWTAwHk2xW/S QdRwCPdjeLMd33MNLnr3v1a2muK1S+rqAUc4nd1a62T1u2A1nnCnnxqsw5DiBcj6E9 4Jeulv0zJ/BeQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R3l532jKVz6ty0; Sun, 16 Jul 2023 14:33:59 +0200 (CEST) From: Philip Kaludercic To: sbaugh@catern.com Subject: Re: bug#64543: [PATCH] package-report-bug: don't fail on custom groups defined by eval In-Reply-To: <87r0p9hxw7.fsf@catern.com> (sbaugh@catern.com's message of "Sat, 15 Jul 2023 17:45:12 +0000 (UTC)") References: <83bkgdcyuu.fsf@gnu.org> <87wmz17ana.fsf@posteo.net> <87r0p9hxw7.fsf@catern.com> Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Date: Sun, 16 Jul 2023 12:33:59 +0000 Message-ID: <87mszwxcg8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64543 Cc: sbaugh@janestreet.com, Eli Zaretskii , 64543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) sbaugh@catern.com writes: > Philip Kaludercic writes: > >> Eli Zaretskii writes: >> >>>> Date: Sat, 15 Jul 2023 09:12:48 +0000 (UTC) >>>> From: Spencer Baugh >>>> Cc: Philip Kaludercic , sbaugh@janestreet.com, >>>> 64543@debbugs.gnu.org >>>> >>>> On Jul 15, 2023 04:57, Eli Zaretskii wrote: >>>> >>>> > >> Previously we just assumed that the car of an element of >>>> > >> custom-current-group-alist was a filename. But actually it >>>> > >> can be nil >>>> > >> if a custom group was defined by just evaling Lisp. >>>> > > >>>> > > Where is this behaviour documented? I couldn't reproduce it with a >>>> > > simple experiment. >>>> > >>>> > To reproduce: >>>> > M-: (defgroup mygroup nil "my group") RET >>>> > >>>> > The patch would ensure that if groups like these are defined (which >>>> > might happen by mistake), then `package-report-bug' will remain robust >>>> > and not fail due to a unrelated issue. >>>> >>>> Is this case important enough to make this change so late in the >>>> pretest? Spencer, how did you bump into this situation in Real Life? >>>> >>>> I evaled a buffer containing a defgroup with C-c C-e (or maybe just >>>> a region?) >>> >>> Why did you do that? >> >> Evaluating an entire buffer with C-c C-e is not unreasonable, but it >> will not bind `load-file-name', which `load-file' would have done, but >> there is no binding for that. > > Maybe we should add a binding for load-file? Or maybe C-c C-e should > bind load-file-name if the region is not active? I am not familiar enough with the intention between distinguishing evaluation and loading to comment on this, or where the distinction /should/ matter. > Btw, just curious: how do others test modifications they make to Lisp > files? I usually make a couple changes to several functions or > variables and then reloading the whole file is easier than going defun > by defun. I either eval the defuns right after editing them using C-M-x or I'd infrequently use M-x load-file. From unknown Fri Jun 20 07:20:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 14 Aug 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator