GNU bug report logs - #64536
30.0.50; Make cl-print put buttons on ellipses

Previous Next

Package: emacs;

Reported by: Stefan Monnier <monnier <at> iro.umontreal.ca>

Date: Sun, 9 Jul 2023 04:44:01 UTC

Severity: normal

Found in version 30.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 64536 <at> debbugs.gnu.org (full text, mbox):

From: Ihor Radchenko <yantar92 <at> posteo.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Gemini Lasswell <gazally <at> runbox.com>, 64536 <at> debbugs.gnu.org
Subject: Re: bug#64536: 30.0.50; Make cl-print put buttons on ellipses
Date: Mon, 14 Aug 2023 15:15:40 +0000
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> I am not sure if this can be done on byte compiler level.
>
> Not sure either.  A compiler-macro placed on `make-text-button` and
> `make-button` could look for a `:type` arg and check its obsolescence,
> but I don't know how effective it would be.

Maybe not that bad.
Of course, it will miss :type values not known at compile time, but it
is the same issue even with ordinary obsolete variables/functions that
are used not by their literal name.

>> For runtime, after skimming through button.el, it looks like
>> `button-category-symbol' might be used to throw a warning when obsolete
>> button type is being used.
>
> Runtime check are easier and more reliable, indeed, but also more
> annoying and directed at the wrong person :-(

Makes sense. Although, they can be useful for maintainers if such checks
can be enabled explicitly, by flipping a variable.
We used such approach for org-element--cache-self-verify.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>




This bug report was last modified 1 year and 335 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.