GNU bug report logs - #64529
30.0.50; [PATCH] Add special $GID variable for Eshell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64529 in the body.
You can then email your comments to 64529 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Fri, 7 Jul 2023 23:35:58 -0700

[Message part 1 (text/plain, inline)]

Currently, Eshell has a special $UID variable that's connection-aware 
(so it returns the remote UID if the current directory is remote). 
However, it doesn't do this for $GID. Here's a patch to fix that.

[0001-Add-special-GID-variable-in-Eshell.patch (text/plain, attachment)]

Message #8 received at 64529 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 64529 <at> debbugs.gnu.org
Subject: Re: bug#64529: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Sat, 08 Jul 2023 15:07:02 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

Hi Jim,

> Currently, Eshell has a special $UID variable that's connection-aware
> (so it returns the remote UID if the current directory is
> remote). However, it doesn't do this for $GID. Here's a patch to fix
> that.

LGTM.

Best regards, Michael.

Message #13 received at 64529-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 64529-done <at> debbugs.gnu.org
Subject: Re: bug#64529: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Sat, 8 Jul 2023 12:27:46 -0700

On 7/8/2023 6:07 AM, Michael Albinus wrote:
> LGTM.

Thanks for taking a look. Merged as e074081af3d, and closing this now.

Message #16 received at 64529 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 64529 <at> debbugs.gnu.org
Subject: Re: bug#64529: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Sun, 09 Jul 2023 10:43:17 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

> Thanks for taking a look. Merged as e074081af3d, and closing this now.

Thanks. Just a minor comment: you might document, that $UID and $GID
return -1 in case they cannot determine the value on a remote system.

But maybe this is too minor to be mentioned in the Eshell manual, so
it's just your decision.

Best regards, Michael.

Message #19 received at 64529 <at> debbugs.gnu.org (full text, mbox):

From: Jim Porter <jporterbugs <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 64529 <at> debbugs.gnu.org
Subject: Re: bug#64529: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Sun, 9 Jul 2023 12:31:55 -0700

On 7/9/2023 1:43 AM, Michael Albinus wrote:
> Thanks. Just a minor comment: you might document, that $UID and $GID
> return -1 in case they cannot determine the value on a remote system.
> 
> But maybe this is too minor to be mentioned in the Eshell manual, so
> it's just your decision.

I thought about that too, but decided it was a bit too minor. I could be 
convinced otherwise though; I don't have a strong feeling about it.

Message #22 received at 64529 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 64529 <at> debbugs.gnu.org
Subject: Re: bug#64529: 30.0.50; [PATCH] Add special $GID variable for Eshell
Date: Sun, 09 Jul 2023 22:04:25 +0200

Jim Porter <jporterbugs <at> gmail.com> writes:

Hi Jim,

>> Thanks. Just a minor comment: you might document, that $UID and $GID
>> return -1 in case they cannot determine the value on a remote system.
>> But maybe this is too minor to be mentioned in the Eshell manual, so
>> it's just your decision.
>
> I thought about that too, but decided it was a bit too minor. I could
> be convinced otherwise though; I don't have a strong feeling about it.

As said, your decision. I have also no strong position about.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.