GNU bug report logs - #64519
[PATCH] gnu: godot: Update to 4.1. Rename godot@3 to godot-lts.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: John Kehayias <john.kehayias <at> protonmail.com>
Subject: bug#64519: closed (Re: bug#64519: [PATCH] gnu: Add freetype-brotli.)
Date: Fri, 14 Jul 2023 15:13:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#64519: [PATCH] gnu: godot: Update to 4.1.  Rename godot <at> 3 to godot-lts.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64519 <at> debbugs.gnu.org.

-- 
64519: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64519
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64519-done <at> debbugs.gnu.org
Subject: Re: bug#64519: [PATCH] gnu: Add freetype-brotli.
Date: Fri, 14 Jul 2023 15:12:16 +0000

Hi,

On Fri, Jul 14, 2023 at 03:25 PM, Ludovic Courtès wrote:

> Hi,
>
> John Kehayias <john.kehayias <at> protonmail.com> skribis:
>
[snip]
>> Actually I think our freetype package should do that as well, but
>> since has nearly 18k dependents that should be grouped with other
>> large changes. I brought this up on guix-devel [0] but didn't get
>> any responses about this change. I think it is not controversial,
>> just how to manage the rebuilds. Perhaps on the next mesa/related
>> branch?
>
> Yes, you should check on IRC or guix-devel whether this change can be
> piggybacked on an existing mass-rebuild branch.
>

I'll see what is next. mesa-updates is built, but if that needs a
rebuild or other updates I can put it there. Otherwise the next large
branch job.

>> From f5622c12a84d208efefc53af88fe5f284485f2ff Mon Sep 17 00:00:00 2001
>> Message-Id:
>> <f5622c12a84d208efefc53af88fe5f284485f2ff.1689091993.git.john.kehayias <at> protonmail.com>
>> From: John Kehayias <john.kehayias <at> protonmail.com>
>> Date: Fri, 7 Jul 2023 12:05:16 -0400
>> Subject: [PATCH] gnu: Add freetype-brotli.
>>
>> * gnu/packages/fontutils.scm (freetype-brotli): New variable.
>
> [...]
>
>> +(define-public freetype-brotli
>> +  (package
>> +    (inherit freetype)
>> +    (name "freetype-brotli")
>
> Maybe ‘freetype-with-brotli’ as you suggested.   Also please add a TODO
> about the eventual merge of this into ‘freetype’.
>

Done.

Pushed as 49b0a5ee5f908d8efa8e792f8635f723fd1d26ed and 09e73683a2c303016fa57bf5d84a8e997d4c0a30

Thanks!
John

[Message part 3 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: godot: Update to 4.1.  Rename godot <at> 3 to godot-lts.
Date: Fri, 07 Jul 2023 16:27:08 +0000

[Message part 4 (text/plain, inline)]

Hi Guixers,

Here's a patch to add Godot 4! I've tested it builds and can load some sophisticated examples, working with the new Vulkan support. There is no longer a headless build so that has been removed as an output. The previous version, godot <at> 3 is an LTS release now (and in need of an update I see) so I kept that as godot-lts.

I wasn't sure how best to break this up in commits, let me know if these should be separate and how (1. rename godot to godot-lts and 2. add godot <at> 4?). I did my best to put in all the changes in the package definition from 3 to 4 in the changelog, but please do check. Due to the amount and scope of changes I didn't think godot-lts could easily inherit from godot.

Thanks!
John

[0001-gnu-godot-Update-to-4.1.-Rename-godot-3-to-godot-lts.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.