GNU bug report logs - #64519
[PATCH] gnu: godot: Update to 4.1. Rename godot@3 to godot-lts.

Previous Next

Full log

Message #11 received at 64519 <at> debbugs.gnu.org (full text, mbox):

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64519 <at> debbugs.gnu.org
Subject: Re: bug#64519: [PATCH] gnu: Add freetype-brotli.
Date: Tue, 11 Jul 2023 16:19:31 +0000

[Message part 1 (text/plain, inline)]

Hi Ludo,

On Tue, Jul 11, 2023 at 03:51 PM, Ludovic Courtès wrote:

> Hi John,
>

[snip]

> Looks like the arguments and snippet are too different to be factorized
> via inheritance.  However, one could still inherit from the other to
> factorize license/synopsis/description?
>

Yes, thought of that afterwards and made that change locally now.

> Apart from this minor issue, LGTM!
>

I completely forgot there is another patch needed here, one to add freetype-brotli. That is just our freetype package with brotli added as a propagated-input for WOFF font support (if I recall). Attaching the patch now.

Actually I think our freetype package should do that as well, but since has nearly 18k dependents that should be grouped with other large changes. I brought this up on guix-devel [0] but didn't get any responses about this change. I think it is not controversial, just how to manage the rebuilds. Perhaps on the next mesa/related branch?

[0] <https://lists.gnu.org/r/guix-devel/2023-06/msg00113.html>

Thanks!
John

[0001-gnu-Add-freetype-brotli.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.