Subject: Re: bug#64519: [PATCH] gnu: godot: Update to 4.1. Rename godot@3 to godot-lts.

From: Ludovic Courtès <[email-masked]>
Date: Tue, 11 Jul 2023 15:51:51 +0200

Hi John,

John Kehayias <[email-masked]> skribis:

> From 287373c727c5292e5778f60aacf3685a4feddeca Mon Sep 17 00:00:00 2001
> Message-Id: <28737[email-masked]>
> From: John Kehayias <[email-masked]>
> Date: Fri, 7 Jul 2023 12:05:39 -0400
> Subject: [PATCH] gnu: godot: Update to 4.1.  Rename godot@3 to godot-lts.
>
> * gnu/packages/game-development.scm (godot): Update to 4.1.
> [source]: Update snippet: remove embree and enet; add amd-fsr, astcenc,
> basis_universal, brotli, linuxbsd_headers, etcpak, meshoptimizer, msdfgen,
> noise, openxr, rvo2, spirv-reflect, thorvg, volk, vulkan.
> [arguments]: Remove #:scons.  Update #:scons-flags to unbundle more
> libraries.
> [phases]: Remove 'build-headless phase (headless is no longer has a separate
> build).  Add 'fix-dl-open-paths and 'unbundle-xkbcommon phases.  In 'install
> phase, remove headless output.  Update 'wrap phase to remove eudev.
> [outputs]: Remove headless.
> [inputs]: Add dbus, embree, enet, fontconfig, glslang, libpng, harfbuzz,
> icu4c, libxkbcommon, openxr, speech-dispatcher, vulkan-loader, zlib.  Remove
> bullet.  Rename freetype to freetype-brotli.
> (godot-lts): New variable.  godot@3 is the LTS release.
> * gnu/packages/games.scm (superstarfighter)[native-inputs]: Use it.
> [inputs]: Use it.

[...]

> +(define-public godot-lts
>    (package
>      (name "godot")
>      (version "3.4.2")
> @@ -1982,6 +1988,253 @@ (define-public godot
>  scripted in a Python-like language.")
>      (license license:expat)))
>  
> +(define-public godot
> +  (package
> +    (name "godot")
> +    (version "4.1")

Looks like the arguments and snippet are too different to be factorized
via inheritance.  However, one could still inherit from the other to
factorize license/synopsis/description?

Apart from this minor issue, LGTM!

Thanks,
Ludo’.