GNU bug report logs - #64516
[PATCH] docview: Only enable imenu when supported

Previous Next

Package: emacs;

Reported by: Morgan Smith <Morgan.J.Smith <at> outlook.com>

Date: Fri, 7 Jul 2023 15:30:01 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64516: closed ([PATCH] docview: Only enable imenu when supported)
Date: Thu, 20 Jul 2023 16:06:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 20 Jul 2023 19:05:38 +0300
with message-id <83bkg636wd.fsf <at> gnu.org>
and subject line Re: bug#64516: [PATCH] docview: Only enable imenu when supported
has caused the debbugs.gnu.org bug report #64516,
regarding [PATCH] docview: Only enable imenu when supported
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64516: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64516
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Morgan Smith <Morgan.J.Smith <at> outlook.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] docview: Only enable imenu when supported
Date: Fri, 07 Jul 2023 11:24:01 -0400
[Message part 3 (text/plain, inline)]
Hello,

More info is in the commit message.

To re-create the error open up an EPUB file (or possibly any non-PDF
file in doc-view) and press 'M-g i' to run 'imenu'.  Doing that I get
the following error:

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  string-match("\\`PK\\'" nil)
  imenu-find-default("PK" (("*Rescan*" . -99) nil))
  imenu--completion-buffer((("*Rescan*" . -99) nil) nil)
  imenu-choose-buffer-index()
  byte-code("\300 C\207" [imenu-choose-buffer-index] 1)
  command-execute(imenu)

[0001-docview-Only-enable-imenu-when-supported.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: Morgan.J.Smith <at> outlook.com, jao <at> gnu.org, 64516-done <at> debbugs.gnu.org
Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported
Date: Thu, 20 Jul 2023 19:05:38 +0300
> From: Tassilo Horn <tsdh <at> gnu.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 64516 <at> debbugs.gnu.org, jao <at> gnu.org
> Date: Tue, 18 Jul 2023 21:14:35 +0200
> 
> Alright, I've amended your patch with my slight modifications.  Eli,
> feel free to "git am" it where you see fit.  It should apply both on
> master and on emacs-29.

Thanks to both of you.  I've now installed this on the master branch,
and I'm closing the bug.


This bug report was last modified 1 year and 358 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.