From unknown Sun Aug 17 22:08:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64516 <64516@debbugs.gnu.org> To: bug#64516 <64516@debbugs.gnu.org> Subject: Status: [PATCH] docview: Only enable imenu when supported Reply-To: bug#64516 <64516@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:08:21 +0000 retitle 64516 [PATCH] docview: Only enable imenu when supported reassign 64516 emacs submitter 64516 Morgan Smith severity 64516 normal tag 64516 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 11:29:25 2023 Received: (at submit) by debbugs.gnu.org; 7 Jul 2023 15:29:25 +0000 Received: from localhost ([127.0.0.1]:43626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHnOe-0001tG-VD for submit@debbugs.gnu.org; Fri, 07 Jul 2023 11:29:25 -0400 Received: from lists.gnu.org ([209.51.188.17]:53184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHnOd-0001t4-1Q for submit@debbugs.gnu.org; Fri, 07 Jul 2023 11:29:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHnOU-0002yL-RK for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 11:29:16 -0400 Received: from mail-dm6nam04olkn20831.outbound.protection.outlook.com ([2a01:111:f400:7e8b::831] helo=NAM04-DM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHnOR-0008CA-Vu for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 11:29:13 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mU2DVY2A4gJlXJCD80XUooLvKhPbS1BVhA3G67r2pQrIiBXYSJcFfJVNB4CWmLHwuwSgnsY/8YbnQ0FpwgttVhv0K6fAKka8z6sDziGxd8SoZ2XReYPR2+57GiMWwAuqyBtwGbYzaIklHFxXHvbRcsxSYJ9ReQh1kQ6/LqdYxw4KNT7X/pElQtGbsT7cTmhQ8Qsumybn9QozgBLFlJt+7605QXaQnRp5MC/EDGUsk1PMcy1w3/uBoUUv6kfL+qtfNNja30bokUfN5bjSzSyWAZeQwlrTGNExcLEzAGNGSf00/K5Gu/KA3nKiXg3n8x64Mq/83h/eETHks3R7SJVP5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SdaBem1W+uegYTtKOb02oLVGdnpwZYXUhZ6q546bKhA=; b=cT/oqTsl2RffRlJ6DOCSR1owEFqGeHVfDdFjcMzfQr5l0dEAcqOhYG99Jqbe/Dy8kcMnMXNB3T/KEUrtDcRIuwKL9608UjNMh1IRe519ghfsqR1PU2cctYje8yuILvGcNh5qPUhv0b6qAcnXmEpPDPTtBr79UtpWjZAth+rNvDTjH1qua8SHUCz/SI6KvWDsdnS0zkbcRXFM8qu/Y2/oQFQ9shDFTldG0aGKxYPtkqRgQAPf/oU4Wa3r/CqhFTjrKS+B6n1S0lJ6m1M2i7Joj0mx64UNhP457ZQKkZ3sttSL85qanCWYLXo3qXwCf1kwmCrxATVyE8ycqA3fI99dkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SdaBem1W+uegYTtKOb02oLVGdnpwZYXUhZ6q546bKhA=; b=mtAiHLktBmtY636zMKcxYPGmkCFsTpaG3cpd6ix6FbendjVWmrKsHPSSZh99aaCPDx3wdh2jbdVX6ocuip/0zHfQyFNsIj3JfrL1D28m134fKix7xA37CInDE+ZC1uuIgNaO9A40V9cebkq+x+axQKzNogmZ6k1wh8Sc7XCq2sAFPVotyFhTo41TYU9syra3b2n8jKi2D62SghFOCfEwNX44sBm9R+VtO9n/O0Czck1I1dJLVx/8WfDGSUxa2uaidb4VPAmXHMzF1vHWx8/xIEjG/DdNt5fi/lVgyP0J6KW2mdnQQHJq0xTxbOFjZK2a4wuWQDAr7j0wiiY+P4x9fw== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SJ0PR03MB5615.namprd03.prod.outlook.com (2603:10b6:a03:27a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.17; Fri, 7 Jul 2023 15:24:04 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6565.025; Fri, 7 Jul 2023 15:24:04 +0000 From: Morgan Smith To: bug-gnu-emacs@gnu.org Subject: [PATCH] docview: Only enable imenu when supported X-Hashcash: 1:20:230707:bug-gnu-emacs@gnu.org::j5ITP967/guWxTx1:0BGk Date: Fri, 07 Jul 2023 11:24:01 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [0o507szMLXiXuDXTkw8g0pZEHfsgN0duBU71qvaic35cAHwmuYww/g==] X-ClientProxiedBy: YQZPR01CA0100.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:83::21) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87bkgneodq.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SJ0PR03MB5615:EE_ X-MS-Office365-Filtering-Correlation-Id: f6c7c8a1-31e0-4cca-1b10-08db7efe32a0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dsb+mAKNJ1ASQrwMe3ykIop4z8LItX2Z8Mr2nPQZdovvk6zCjkpwLHfSuwtgurlEhXfPWVAQAEsFc0aM6y+sA/5b4VH9Xa51kHQmOzKXnblVoFzwJTEObPhmDQ/OyeMAYgNAx6p4mhvbQ3lmTdmXReU3/6d53RJJLDKY4w/8FHVBvdhx7izOO9KzpOI8kNib+Yv+U2aVYivYt9TmTtW9bOPmZi7Y2vMCSyFkQEWz3L6Uow1LBFUtMoQSa0IyKwLz3446mdhiafEQkQsQNC+6aROI5kqw3lYlSrXiFB5xc45ZiJM5q7Tx9Gu7EvHrrglnh859+Vqovd6OZ9KUDVakZi/ZAyz75Q4/LsL1fO/AQEoKXnxqwYifJCv826U9qgEIg7JdXh0AXbOfuR3t7gUpxH9rF8B04rf/bf+nJt1wzFOyrhWb/WC1NAOBEKKTfQGUiCr2EEpNP552bG42KnUMGE+dwwEVI7sjayv0NZq/QvKWu/Y5Uf6cOSHUagRrSUZ/LAkXyiSxxcvKpGlbbNv7MrZCvSK8xWaKwzuLea8dCUQcssCgre7uKccAokF7ogBp X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZPQDKHBQjGL4xgf+lsCSv09IsDPQV4NqqRKlE1gwvEwmgtMLl/8dLLgHKya3?= =?us-ascii?Q?WuGzMsrED3E8gbmdDogLdocghCrNFDa5f/3sfrJcYNbkndZG/iins4sadQ+1?= =?us-ascii?Q?/9I/BbwGjI3ymTejcbA9mv/+bl5s3ix8PqwcaNk/GxeRsiE6rCmZ3tX14JC1?= =?us-ascii?Q?StGGRXhKEL4WVD/biY8zz3RrHNMGOXCdSee+3qtn+YAtYiA7IgXKlygjcfeU?= =?us-ascii?Q?s+rOgit0sCXzBbBVY1tJIOpHmt7eDAzAQCV4uVXGijBn59AGGDsdAkHna9vz?= =?us-ascii?Q?tro0XRb3acB9E3h3vZnNaZlv0SMnNAVxqXgfI3+QN8m84WItsAIwtobepcEQ?= =?us-ascii?Q?L3BrPDKufLUL/1ShglaRAorULMDHY2Q1QlDYyKM6V/0ucedrF4azkdz4wVuL?= =?us-ascii?Q?Ko7V62U/98OsdmocIEGYuE8pOZicef/9K6XytXYWTlWxMyvcOyb4HpBEIZL3?= =?us-ascii?Q?6lsaSta+e1dFziFsBXXv9dosKvFN/n3uzL4ImuHXxtOXMix9XPPxR2FdcaSA?= =?us-ascii?Q?ZMSRetyWq1jSTOWPBZjDG1to7T/QVIm+jxyojlxotAT8CO3gEbayag9sWEzM?= =?us-ascii?Q?aXYERK6lOdteMYult42RmIfNfB5ngWKt23B+jsAIxzcUKalHxtfleTWJvdWr?= =?us-ascii?Q?4VBHzuJfmNgGfmFE3icsL5a2L/6PfO6qySYy6gtEGKE/5cm+gqdvpOTpLwpv?= =?us-ascii?Q?B7v1aOUM0t0BMg5pgSUDR6bY6QFJ0l1Ld0q7HNIa9PBqUhKi1+yLLnEPxhs9?= =?us-ascii?Q?KCgpnX+EGcRM/vcsZPls+y9yrcAwQIUe/WbcEaXxI9l8fvJ2yMZElJMvtbS5?= =?us-ascii?Q?ANeKDrhM546NjwTHB/slUBAoacGXSyLO4dn0F2+9CXoXwZUBkIuciuU71wfL?= =?us-ascii?Q?A98whmzczlDN3uPISDrr01sciuq+9a6k60GmmSOlgiHQ9ZzHdfdrIptVxUL+?= =?us-ascii?Q?srchVXMvuviM3XaIJI5AiMHkzf39TWNutSKKpSDpZiiG3evlKbN9pYj/5Ckw?= =?us-ascii?Q?Hc4JRP+YaFRbKLzj8GcbSP59g+5Y6YZ+iK0daD2/Zp3TBlmp5YsBd8BXvzZg?= =?us-ascii?Q?sxixvUuWsP+vtYT1unp7+PKKzXwtpgRfuNEt2cTHnewnGeEYAKw/6OTv+cn7?= =?us-ascii?Q?L6mn9DVzScWGst2fJK1Sfv+EnHu42PZkZxRR9lkXe9/IuriaCm2FCnmINKbw?= =?us-ascii?Q?phPapRhEwmgWFz6kkV+e5IGg6ETgilxTNx9rB73Q2TQjJp5C+4F5V4Cj1Ac3?= =?us-ascii?Q?IoGrr4NhQdMrLp4TJEPDtdaewu+hdlD63tazkXVAog=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6c7c8a1-31e0-4cca-1b10-08db7efe32a0 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 15:24:04.5243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5615 Received-SPF: pass client-ip=2a01:111:f400:7e8b::831; envelope-from=Morgan.J.Smith@outlook.com; helo=NAM04-DM6-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Hello, More info is in the commit message. To re-create the error open up an EPUB file (or possibly any non-PDF file in doc-view) and press 'M-g i' to run 'imenu'. Doing that I get the following error: Debugger entered--Lisp error: (wrong-type-argument stringp nil) string-match("\\`PK\\'" nil) imenu-find-default("PK" (("*Rescan*" . -99) nil)) imenu--completion-buffer((("*Rescan*" . -99) nil) nil) imenu-choose-buffer-index() byte-code("\300 C\207" [imenu-choose-buffer-index] 1) command-execute(imenu) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-Only-enable-imenu-when-supported.patch >From cd73281f324a5b21c304789ca7b828295e8718d9 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Fri, 7 Jul 2023 11:17:15 -0400 Subject: [PATCH] docview: Only enable imenu when supported While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. (doc-view-imenu-setup): Don't check for 'mutool' as that is already done by 'doc-view-imenu-enabled'. Only enable imenu for PDF documents. --- lisp/doc-view.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..d9c12fc49c0 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1912,7 +1912,8 @@ doc-view--pdf-outline (let ((outline nil) (fn (shell-quote-argument (expand-file-name fn)))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -1961,7 +1962,7 @@ doc-view-imenu-index (defun doc-view-imenu-setup () "Set up local state in the current buffer for imenu, if needed." - (when (and doc-view-imenu-enabled (executable-find "mutool")) + (when (and doc-view-imenu-enabled (eq 'pdf doc-view-doc-type)) (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil imenu-sort-function nil -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 11:40:34 2023 Received: (at 64516) by debbugs.gnu.org; 7 Jul 2023 15:40:34 +0000 Received: from localhost ([127.0.0.1]:43632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHnZS-0002A1-9Q for submit@debbugs.gnu.org; Fri, 07 Jul 2023 11:40:34 -0400 Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com ([40.92.20.10]:27296 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHnZM-00029j-TG for 64516@debbugs.gnu.org; Fri, 07 Jul 2023 11:40:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lJMBd2ef1yvMqy6kl8VVmz6GhkzZH165ouEGTCUGdtPe2q8XvleyI1v3Sl2vl0XH3OAtd6krZCzQAd/yCDd3jjv24LjzvAClsJznsCo5347gADixZA2eZ2ljN3tpwstkTl1kRXUjuGZnTGf+OJdERZCMlvTXEVGZ7+tyxcw8g/W6g9KZqarDtsP5W6ZfAah+IxKlJoyBUp/mBoNuxJvj6/mD0cFl0TfVglT7Oe7IPLaa/TNKOmW1JDiRwtBh2m7Md4xedvvhGG50LSaTLTeAS80sM07Xx9pUCBwmETCt6NYFtVsFy2cmXU5YFLO2kSZm4ptnRleCK4FQGPT1qmLnpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2VL34/FYcComNN8Fl7I2dFVFS8kd6Dlot0p1erZkWEg=; b=DxoOzYmcRW/pP48sn1ekC+Ojhtpu8iT0f8UqMoBlrMZI9acJrZ2x+go3xa/qv/6dMePZ+ulb4isl6W+cK4ORVLHLE7mHy6lbY9VYld5YJSPwW9bW8T3X8BsKS7jl0iSkSNrtAaOjIGMqmpETA2Wjdh/0mvW8mdtrkY/lRvT9kVueQFANRS7WNEUjTuPfuDbsVYTwV8qkPMOIeCSMXa4e67eAqSTyLRyFTx8awgRdQL+ePniEH6rRRWI14TthpnVpO0WoOOQvgdKHYvQbKZnBD5DAeohfdAYtISskym2G7cjz8NEGk4UtEG4MEmEAxN+XRdK2od3GiF7Ksr2MgoKVTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2VL34/FYcComNN8Fl7I2dFVFS8kd6Dlot0p1erZkWEg=; b=OXrrb2e5n7aGw/enVdgnatG6kQ6Jekrm24Tkuv5TWBdfUe6YKHKIG0yKjTV5+SqrFq9qqeZDWQ2ckmwpPvuXhtI8aJebaL2lfCJ/ZzWnKOTI4N2YfRLS75wfPsm2Do6BxEJ/8OFyA+CzwMgyEAQEH+61CcHdJUbIAZlEv/29UBp4dKC3BoCCgBJLsiVezc4EgFcPPfFr5KFy16Tm+MibVajiKiGBNvzSUKRWvrKKR2J5o+Mcz1GCieEnII8EHpSm934puciuOu2U0yKiJUmI5hyhrJq85pr+Tz9VmvXjZnTHD1PkBuBniCx3mFkwuOEiauGjCDs2k5yjs5mLDHIuAw== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by DM6PR03MB5370.namprd03.prod.outlook.com (2603:10b6:5:249::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Fri, 7 Jul 2023 15:40:22 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6565.025; Fri, 7 Jul 2023 15:40:22 +0000 From: Morgan Smith To: 64516@debbugs.gnu.org Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: (Morgan Smith's message of "Fri, 07 Jul 2023 11:24:01 -0400") References: X-Hashcash: 1:20:230707:64516@debbugs.gnu.org::nliFvLpKQmBaoDcj:E32G Date: Fri, 07 Jul 2023 11:40:20 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [vGLDgYSvGHLWUwQjlzBouh843z2FQctmZccvlRoOV2Uug+tGf/Y3EA==] X-ClientProxiedBy: YQZPR01CA0181.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:8b::11) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87mt07d923.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|DM6PR03MB5370:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cb07b21-fdcc-4bd5-015b-08db7f0079b5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2oXmQZXiDnlGmyyBuEM2XZNUW6CBQ19mCSkwxTiKUtILxrM74X5v23mPqnw3MhgE2AzLQyo4APielHRm3omrWa0MqsCouGsDpQfXG0NkRUVMA8GBl34dP58FMoTQj00Z/BkiY94Gj3tb2tiJ3nvwYjeT6lxBv4aN9yqOvjxTlE43orJJrdxSBXqca1RBVMoYLgRJjFN8WKcta4Vw+mEgiWHz0OmRWG85/BSR6EniQfw6SjI7DISnGHSkx1eTDphhNLBE/PI/RZVt7vnrKivJ0DL0yf6Zwc1H+sUwCr61Lob1+D9sV47cuQtjAwwuakcLgBstgVwPrufA1pX7l4ih1Kwi1ez63+dabRPalXatJNUo5ybJYmYX9nST1zx5Ii1YJFfRCVHNWhxR3lB3MdEj57FbxZf1rCMHyAbERJd+CnUJEjhzyrm6XC3AYye+C3Der67Oh0PcHT8jL8iPtEzVIRhIdtEO/dTwMCb/N9VgfMjJ7px+NuxquEe/GvRFJUA4juw+pQ7hPJWpFd1w0rvHZvwdeR8THtMcPQNsCxrxYJ1ZJDSsU1XzWSFuUDS+Aw+k X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?smYUOSP8CjrGXdLju2GZELDVHOlOGYaox8pg1GJiVUMAMZdLoyUhvO0dAHq7?= =?us-ascii?Q?TNJjexLqGrthj+MKcjQX65yzuoEeX236+yCLpIoxz4D3BCZqY2LAmYFdqEEc?= =?us-ascii?Q?0w7eXbUofVwnY7tBfRPmhjBmwCkHyaYXFSFxTmmeYi36HGAJZn/UtBeGZohv?= =?us-ascii?Q?FL+eswSXVMPFQqouhsCFlRll/uqMKDBgXLLK8ZR6NAIjdAcDAXvFlp53SwY6?= =?us-ascii?Q?XROBGOQV+tSw4sxuX25gaayuQLx8ENgHEfPrhd1Tae87iwOmAF4+TlP7QQV1?= =?us-ascii?Q?DA3sXixdLhfHoXQYPyQtMqd/o8tezHDWO9aY6AkDuonRfgROmZd2uBpISYM3?= =?us-ascii?Q?d9LS8CZydHkTX4NMHvL+74ziSp7mKMdw7xHvIXb2yXWsdhwJkSlTO3WqY6C9?= =?us-ascii?Q?TiL3j+quZ+AxYoCpZNoaPbB4G/oFlAdRzKaNWpsBUR1banj6uwdjvYwR6Yqf?= =?us-ascii?Q?tYbleZFTLU9I0oyETOnwC+sBbX8iidY1tBKQB06Up56nYOCor6O58eIKr+JK?= =?us-ascii?Q?8ZIxrjDj/D+lZoVr9h42CdzJFOBAyRldUM9znr9TDmMQ6XCw/tRNagwS1z9f?= =?us-ascii?Q?q7Aa2gK0bsBkDc+3wSjrBI+HEThvXhCLVmiYVsPKCzOBsgLPUXALJqsIE7UV?= =?us-ascii?Q?5KCyvcA4v7O6UL3FpkXUTsjg3KnOprsEbqL2jPoSP6ef1/Q0xbRNjmKzrYYp?= =?us-ascii?Q?tiz1hyePcBOrppnQoe3EsuUW6MOBzgktvj4lJWVIJubmYKVi9lzdvJ4j+Ejd?= =?us-ascii?Q?xSMPwsWFrMTzn124XrcsVpmyPBnU54sZ+ojWc3sIV30XrhbM7t2OKQW19VqJ?= =?us-ascii?Q?p2zXa7GdbkTDjGkl63DZwow3Vs0ioJk5OOGNdmyt2mpLV3vRBb4JfkJT9a+v?= =?us-ascii?Q?l6zIolBI3n/ZDNAlAk/5x/7IOo7YogzRXLGhdQtDUP/UcvmWfW20Xv+NKn2B?= =?us-ascii?Q?rhOAP4GhIutz1cHJAaYTq+aiwWGXdvOMyaTEy6ABpZQV+6yMIQZj88IO7hPy?= =?us-ascii?Q?TM74PTdTHsYHNwB+fvLDtuE3C7C8wls8PujQ814iUetmIzG1qDXbGY8sVEN4?= =?us-ascii?Q?NTTzz2f1YnWzachFUujRnpPW/1VcYH5TQ0Y2KsrcD09vBiy+cfuPYVCjf0wZ?= =?us-ascii?Q?a11Z/4L5PiJsoy8EWbR9LC4BWTlB3JpLVEsRhV2rWn36x+1lRpRN9kQTDotF?= =?us-ascii?Q?I/Sj8uA8RKm8fst8AsKR9HCLk7AaTYe/2QTnKLSgt7HUgSwd5eon/PlWIEdu?= =?us-ascii?Q?oRyTMdpeCqSF0tbjY+Pdzu51fEy4yJ1eFfelrMncBA=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6cb07b21-fdcc-4bd5-015b-08db7f0079b5 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 15:40:22.4959 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5370 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Sorry, here is a V2. The previous patch would fail for files with funny filenames that need escaping. This I have removed the call to 'shell-quote-argument' as 'call-process' doesn't want escapes. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-Only-enable-imenu-when-supported.patch >From 1f4ef75d0ed4fedb3be1ef67bb32fd89a3577db5 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Fri, 7 Jul 2023 11:17:15 -0400 Subject: [PATCH] docview: Only enable imenu when supported While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. Simplify a little by removing a 'let' statement. (doc-view-imenu-setup): Don't check for 'mutool' as that is already done by 'doc-view-imenu-enabled'. Only enable imenu for PDF documents. (bug#64516) --- lisp/doc-view.el | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..693a5ae5509 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1907,20 +1907,20 @@ doc-view--pdf-outline Each element in the returned list contains information about a section's title, nesting level and page number. The list is flat: its tree structure is extracted by `doc-view--imenu-subtree'." - (let ((fn (or file-name (buffer-file-name)))) + (let ((fn (expand-file-name (or file-name (buffer-file-name)))) + outline) (when fn - (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) - (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) - (goto-char (point-min)) - (while (re-search-forward doc-view--outline-rx nil t) - (push `((level . ,(length (match-string 1))) - (title . ,(replace-regexp-in-string "\\\\[rt]" " " - (match-string 2))) - (page . ,(string-to-number (match-string 3)))) - outline))) - (nreverse outline))))) + (with-temp-buffer + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (error "Unable to create imenu index using `mutool'")) + (goto-char (point-min)) + (while (re-search-forward doc-view--outline-rx nil t) + (push `((level . ,(length (match-string 1))) + (title . ,(replace-regexp-in-string "\\\\[rt]" " " + (match-string 2))) + (page . ,(string-to-number (match-string 3)))) + outline))) + (nreverse outline)))) (defun doc-view--imenu-subtree (outline act) "Construct a tree of imenu items for the given outline list and action. @@ -1961,7 +1961,7 @@ doc-view-imenu-index (defun doc-view-imenu-setup () "Set up local state in the current buffer for imenu, if needed." - (when (and doc-view-imenu-enabled (executable-find "mutool")) + (when (and doc-view-imenu-enabled (eq 'pdf doc-view-doc-type)) (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil imenu-sort-function nil -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 12:06:11 2023 Received: (at 64516) by debbugs.gnu.org; 7 Jul 2023 16:06:12 +0000 Received: from localhost ([127.0.0.1]:43658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHnyF-0002qM-Go for submit@debbugs.gnu.org; Fri, 07 Jul 2023 12:06:11 -0400 Received: from mail-co1nam11olkn2067.outbound.protection.outlook.com ([40.92.18.67]:3425 helo=NAM11-CO1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHny9-0002ph-QZ for 64516@debbugs.gnu.org; Fri, 07 Jul 2023 12:06:10 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJ84m2Yw3r2t/mvEhYW7pf8puKzE2egQcIX2jm4g/QOvOKHldu4er5bH4xTGB3ilv0/R8B2ZZXEWPvjdFlTRQEC0NNm7Z3VQLUuuLMdCRv2pCzm3I0Y6aY8oV4XXI2YRBRjLwN9ZPQzaHHMWvy16CCr9SxT/13eoGN39KOirTwXSuV1Q9YQyPbjkPaliSy2UYELnjox788/npRjg1bY5WeqYNCp8wwDRQznU8qlwqO6pPCz6ttwvw7bt6DLZjq/+sWOo7wVK2L9a3Ngb8D6cp/cgJiAc2bQ5EPD5aMeO6ZNsLT4kfCSBJDnFKstI2+0bAfb2+m0mfuL6M7vhxKEiDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=07Ej3lR0DiaAl0MnUd9mD3VknrP36QUiHa+T2IAk1+g=; b=dXkxo+oeEjlaNyXsWQT5u7OKrEzlTKOUY8//ki9TBCPlu98glstMy8ofchQBht/2hpGiqMC+3hQjeuacMYZIAOOABaYLHRQvcRFwivC34upC4MigK6+sk8ULm/3aco/lHcCAH2F1H1BDWUGpkVaFD80InBs5+XkMkyJjVegISOSV6Zj+BQAq9ExZ7oM8cHEq45afGQ5hMpmfYb7RH0AfwSE5jnHpSDyzh10dlXLWkrs+AMD/u2NOcfyme+X8qR5Lnk3usiwy8oYhECRTT1L5EEP0xT3UdvfNbFeJeFtWBzc7cUKYdKs+t/UIXDhgBdsyzgeGEqmRLFXxrXtVKN/GeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=07Ej3lR0DiaAl0MnUd9mD3VknrP36QUiHa+T2IAk1+g=; b=jW3yPZM0EuVWwLahB3QnVUnFxqLK9bhN6/iped788AxyL/vCtkjIRBjJ/FutEYb4GXSBwub2JOUUw9i/+bdGyv03iH+KnX0RQT2tHVjpbn4emB5EkAnoqnSwoewG4IYX7gxEkjjj+Ww7AIF8XHH4hXpd7uAannuOQwAmBRiSbwirNdwaMJ+ijPz89bD2enupmX4qD36aijghf+O5xjQupLsl1ozf1vrxMcvfGljPEvxwJ3/uhi4MJ0PqBmKhUv5OLw8K3qmupyeldVciS543IyPcdDMqe+Ym0iWEIfsoSEnT5IQ29NGGjf33biyfWOKytu9enyoY0l+5PanFWHEccw== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SA1PR03MB6579.namprd03.prod.outlook.com (2603:10b6:806:1ca::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.25; Fri, 7 Jul 2023 16:05:59 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::d561:bdf5:3af9:b03e%4]) with mapi id 15.20.6565.025; Fri, 7 Jul 2023 16:05:59 +0000 From: Morgan Smith To: 64516@debbugs.gnu.org Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: (Morgan Smith's message of "Fri, 07 Jul 2023 11:40:20 -0400") References: X-Hashcash: 1:20:230707:64516@debbugs.gnu.org::HR7h4DlYJVkiibYa:0fYX Date: Fri, 07 Jul 2023 12:05:56 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [i0PBRxSTFwvtIq97l3X+FnlqbFrxhklTkTVRaT7+dCzc2CM+718bUQ==] X-ClientProxiedBy: YQXP288CA0018.CANP288.PROD.OUTLOOK.COM (2603:10b6:c00:41::48) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <871qhjd7vf.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SA1PR03MB6579:EE_ X-MS-Office365-Filtering-Correlation-Id: 741a951e-3d63-4615-ab0c-08db7f040d82 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QqI//0M/rF5u2IssHi2AhJ6sa3mp1PVk4WWtvPvpk9JaPiRV6WVwVhn8OzJQI+3iCD3zXCiygF/l8sDgOSBkRA2oqMNrJk9qTd9jTKLYkxScvfX5qnL2H7kx3h7Q+yxznPWqYSBrK3yyAW4+VUma/MT12L10vtqKLvV/kkPuX7x35R9F+jawfgWR1Mk5U+UOnHVG+N2y0witLOVSLZuZBT+EZ/d7kHJGxcr+K07U0o9YvKq+cVbth76rcOoDdR5Bp++VvoUXyjpDGebuhUQoggGVv8Bvgwp9X4j0rM/fYqbOB6wNeFNrc9qt8EVzAGcTZ93JUhF4uskBFzzUr2BDh3wr0++aiaKzUIjB1yWq2Z8Q4ygZnmw5tugZYlrAiO1Fbq+o4Z4eBTVxECqe6yGxNXHvbG7R7BOVlhM+ICeCehsCTtFRCYeKaOQJiKRCDWZUEPMYRaQUaVv0PlY7Fg9BODlLIOJvBSBwNTgh1dHNcPpY2aB8XevlsNR9EagjQNM2sgmVOA4tZVLy8mv+UtvPujiS1zStJSpik43fUlrLdrS7zbhVwtoObCCPLnSoDl3X X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3CknNmcB5fT34VzwG4PCHVRbWcON7c9Si+y9BVvbTm941W+2J75NEhkIwfYk?= =?us-ascii?Q?KYEiqgr7AiiKdqUUvabqq2HbIkTYwHiOSVjsM+/iNMVsE0iazPsZqL2qc3Nb?= =?us-ascii?Q?0o0bP8EfMXzgth1dJKVX/j/wjMwnP5Fp/Xl3Qq7WrQe2/EUxn2t/KpKBYqYn?= =?us-ascii?Q?wHJ3G0ke710wRw27a7ojwTia94CV0QueyWR7MlbdzYlg1iFUiO/H5a1CyOM9?= =?us-ascii?Q?4LroRWGvJDxMQdFjS0yKschMsNvbVPg4kgYS5tUZz8L+FyK5XEoPTt6Y3Fxd?= =?us-ascii?Q?d5dBl0eYNzkNTayHXtXTLArx0HWWgdEJiTb03rEzQrPj2WitXugL8EYh8PNc?= =?us-ascii?Q?wCEZ7LlQk/qfMbdWD5W3sVIv8tRbecHHdAy5zQo4FFjZNOv96KMIpodbLKpF?= =?us-ascii?Q?1bRHk1r9U76ISk4SsknSsT1lwIaGFZYvsmsH6PKB2kTLt2DvciR3ehNiTFW3?= =?us-ascii?Q?Gc4g0iX8Lfwp7VucLelMKukbc1OArpAlXJNdhFe7Wy2qzEjYyt2bGkxVhQue?= =?us-ascii?Q?/SpzGDJdWUFJHf6WSR+BukW9zLklsbyBSsmrQUb6ISiHyCW5rZYz6oqQxDNn?= =?us-ascii?Q?xnQJxWR2pEZIqHCwKIGW8WF1BX99gvVy1PNbe7789RpR8sHt0tC2C+re3gAe?= =?us-ascii?Q?2NiqKcrhQgyzMaiaJEDo/WyGiLwC0h3inXOGHCxL1Il6ZWbUBlGJB3puG5xg?= =?us-ascii?Q?+58xGonWyYWeV9D10ZpOuuNypwHfgOTC5ZTEZKfXE86wUNJobzIK3fDfWKI5?= =?us-ascii?Q?ySE/Cbm3cuELFbQnIPSv9Fc94NLdDSUDqshKdbMoho7T4KD+wfxRm4ZyTwZe?= =?us-ascii?Q?pH1kJ5pZsLu07DXHRMuUgUS8cYeGBImcaK/2q+v7RsaWUqMvrP3eCot/wGdg?= =?us-ascii?Q?Ks+h4lMRZGV4GDJe9VzbTFGAAEPBX3eGyMXNoZpXogFV36Vk++7SksXlPaHM?= =?us-ascii?Q?Qzzeqr283J5gh3O+fli5ZpnMjHCdknB/D6hIHGYLeTcU4hS41pV8XwOnSR/x?= =?us-ascii?Q?/N78FtGMcmwNa7FXmRKmHwOgCHqVj5rFNY/gETUU5agzNgNqtzjj2CUFzEMq?= =?us-ascii?Q?+CifmnwGQICaTAJf4+1Z819UiI249tuN9H0EOftyyoibBjmnP9RSoDtQ8v9R?= =?us-ascii?Q?QVAjegOUcnz19vnLVBiDjw98jotgoqXJsYcFXZF+U0XectcD6tOBnNjCzhkm?= =?us-ascii?Q?vwhfDe7sNHjPs8wUDVpJfDZrFWpDo2QP1ysuPa3daJGPRW3W0y8IYOetdYm3?= =?us-ascii?Q?Kl7N4oEWYnmlUDQrY9btw5PR1W0VxIKe8PE1rE627Q=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 741a951e-3d63-4615-ab0c-08db7f040d82 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2023 16:05:59.0764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6579 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Sorry, I wasn't thinking very hard about the simplifications I made in the V2 patch. Now it would error out if '(or file-name (buffer-file-name))' was nil which I assume can happen. Here is a V3 patch which should be good now. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-Only-enable-imenu-when-supported.patch >From 011beaccb3b2e004240ed80a4948d791fc4efbb9 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Fri, 7 Jul 2023 11:17:15 -0400 Subject: [PATCH] docview: Only enable imenu when supported While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. (doc-view-imenu-setup): Don't check for 'mutool' as that is already done by 'doc-view-imenu-enabled'. Only enable imenu for PDF documents. (bug#64516) --- lisp/doc-view.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..101de04297f 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1910,9 +1910,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -1961,7 +1962,7 @@ doc-view-imenu-index (defun doc-view-imenu-setup () "Set up local state in the current buffer for imenu, if needed." - (when (and doc-view-imenu-enabled (executable-find "mutool")) + (when (and doc-view-imenu-enabled (eq 'pdf doc-view-doc-type)) (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil imenu-sort-function nil -- 2.40.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 05:14:43 2023 Received: (at 64516) by debbugs.gnu.org; 8 Jul 2023 09:14:43 +0000 Received: from localhost ([127.0.0.1]:44284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qI41b-0000Lh-B7 for submit@debbugs.gnu.org; Sat, 08 Jul 2023 05:14:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qI41Z-0000LV-1A for 64516@debbugs.gnu.org; Sat, 08 Jul 2023 05:14:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qI41T-0008Qt-Ji; Sat, 08 Jul 2023 05:14:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8nRxro5XveNzHU+lBjxVByMz/9kc/G0DJjfTtEPoxcs=; b=doGLNnip31kO PhoQhKbH/RA8dDOgaaVXCV1hMMwnnurrPpJ3TzfD1x36r+cgztu89cEwrojVBvngm4bl0m0Wb5ecZ YR93U4tfd7P6hekFzjrjBA0wlj2lJf+/UzTdVQXxab2HYL4ruxSY7RUulAKumAQgdKEsRLJgskeWk Z2V17129gBVMP7+XQA+hWwSLpRdfYOW/n4c+QrzQKjrWZfS0Q9bH0cNQSJ73yxKVnc2n+woIghlEH iOvrvEaVo9FNcU3Q/WJnjS16s2WDnV46HxxVBO60IO3YTHoVDneE9NAU8XB/1kaxIo1azeJbDiXW+ BTQe7u+QcC3s8CBFHscy2w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qI41S-0003a8-WC; Sat, 08 Jul 2023 05:14:35 -0400 Date: Sat, 08 Jul 2023 12:14:40 +0300 Message-Id: <83lefqdatb.fsf@gnu.org> From: Eli Zaretskii To: Morgan Smith , Tassilo Horn In-Reply-To: (message from Morgan Smith on Fri, 07 Jul 2023 11:24:01 -0400) Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: 64516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Smith > Date: Fri, 07 Jul 2023 11:24:01 -0400 > > More info is in the commit message. > > To re-create the error open up an EPUB file (or possibly any non-PDF > file in doc-view) and press 'M-g i' to run 'imenu'. Doing that I get > the following error: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > string-match("\\`PK\\'" nil) > imenu-find-default("PK" (("*Rescan*" . -99) nil)) > imenu--completion-buffer((("*Rescan*" . -99) nil) nil) > imenu-choose-buffer-index() > byte-code("\300 C\207" [imenu-choose-buffer-index] 1) > command-execute(imenu) Thanks. Tassilo, any comments to the problem and the proposed patch? From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 04:51:25 2023 Received: (at 64516) by debbugs.gnu.org; 9 Jul 2023 08:51:25 +0000 Received: from localhost ([127.0.0.1]:45822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIQ8b-0002hU-FO for submit@debbugs.gnu.org; Sun, 09 Jul 2023 04:51:25 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIQ8Z-0002hI-Mx for 64516@debbugs.gnu.org; Sun, 09 Jul 2023 04:51:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIQ8T-0003X7-Sr; Sun, 09 Jul 2023 04:51:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=HRu7kWExdvEMy1xDVu87ZT8E56ndvubIh7VSKk7Cq2U=; b=fD6F1NUmGUy98n 7z62dXb4k4kYfnK11N33mnhdlruhyPxPJMW0z6Ocd9YtcJxgT5NOe+K+PZNP5IP0okhmxW6z0Y9A2 rCouXacEErZ+vsSu8K7aeydIJBIQTwMDW6hGybaPWg0gliCMCB9fpwjTH9z8DnALuT+WqIc4elg5O fRE2Hjopcc6h3kWHdppFF5Y4i0yR1SR1A0N3sQd7fMfNPR0THyVk+pyf13H//8KGTXyRar2b9ptX3 pz26+EZ0ZLZZeY6dGmp1tEJ6/L/OVlHDPIS9Irs2LtDkSPJKH20xH1R1m4CG0j2rlhD9TwgbQ7plq 7FA1th7Twm+rvnfNmIYw==; Received: from auth2-smtp.messagingengine.com ([66.111.4.228]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qIQ8T-0006ON-K8; Sun, 09 Jul 2023 04:51:17 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id E9C8627C0054; Sun, 9 Jul 2023 04:51:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 09 Jul 2023 04:51:16 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrvdehgddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe fgtedtudeivdfhfffhfefhvefhuedvheejjeefleffheekffeutdfhgfejiefhgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 Jul 2023 04:51:15 -0400 (EDT) References: <83lefqdatb.fsf@gnu.org> User-agent: mu4e 1.11.9; emacs 30.0.50 From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Sun, 09 Jul 2023 10:13:41 +0200 In-reply-to: <83lefqdatb.fsf@gnu.org> Message-ID: <878rbpxybj.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Morgan Smith , 64516@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: Hi Morgan & Eli, >> To re-create the error open up an EPUB file (or possibly any non-PDF >> file in doc-view) and press 'M-g i' to run 'imenu'. Doing that I get >> the following error: >>=20 >> Debugger entered--Lisp error: (wrong-type-argument stringp nil) >> string-match("\\`PK\\'" nil) >> imenu-find-default("PK" (("*Rescan*" . -99) nil)) >> imenu--completion-buffer((("*Rescan*" . -99) nil) nil) >> imenu-choose-buffer-index() >> byte-code("\300 C\207" [imenu-choose-buffer-index] 1) >> command-execute(imenu) > > Thanks. > > Tassilo, any comments to the problem and the proposed patch? I couldn't test it because all epub files I found result in imenu unavailable: "No items suitable for an index found in this buffer" and not the described error. Anyhow, I've looked at the patch (V3) which basically looks good to me. However, I'm not sure if setting doc-view-imenu-enabled to nil if mutool is there but the doc is not a PDF is the right thing. I think the only difference is the error you get when invoking imenu, i.e., if we'd skip that hunk of the patch and cater for the possibility that "mutool show" might eventually support epub files, you'd get "Unable to create imenu index using `mutool'" right now. With that hunk, you get "This buffer cannot use =E2=80=98imenu-default-create-index-function=E2= =80=99" which is not really better. So I'd suggest leave the doc-view-imenu-enabled initialization as-is and in the "mutool show exits non-zero case", we signal a imenu-unavailable-error (rather than a plain error) with the message that's already there in the patch. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 11 13:49:42 2023 Received: (at 64516) by debbugs.gnu.org; 11 Jul 2023 17:49:42 +0000 Received: from localhost ([127.0.0.1]:50986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJHUb-0006Kt-Ov for submit@debbugs.gnu.org; Tue, 11 Jul 2023 13:49:42 -0400 Received: from mail-bn1nam02olkn2066.outbound.protection.outlook.com ([40.92.15.66]:63815 helo=NAM02-BN1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJHUX-0006Jw-LS for 64516@debbugs.gnu.org; Tue, 11 Jul 2023 13:49:39 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dddIXWW5XQQUog4OurgaySlehaVrIkEiyADJcqI52jh7nBiPEzyXC9GR6bz0LV2neVaYDPhxDUDW6deJ5RByjvD+SM6EMcGQTaRacK0eYMK9/WXTj4jtwTWlLo6pQwlC29xtgzg0+Qp/7d994PzOAvRdt/XgLuDfLJVwW5invbaGAJuBwrz/ZqxMWWBM0D/98mJQGaEslwDBL9hX01krpy0WJmaXjSyGE3aXRrkIvq1D5gMIor4AdqfulBPgidKJAwnc3tTF9PLPjVdbYjzB8JG9OSGd3Ze3og/BSCNZDPdxd+Gr0RCVgHdLPL4bc3NyqlVSwP1WEF0j+0DOc1mjag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wBj92OJzgk+evmV3irdxL2t7OSHBDq0zvf4srYepjrU=; b=bs3Cv8KTgeAoP2znz8tch6TsIP+3XK1K6bPu35ofp0KZMFAtR1hViQV/Fr75oML7+q45RqlIQnCLkbvnDhfZFIkdPfksbG/Tg4q+vYUdGR5hS37gBKi0q7lRTWa5C6xWZIuIaPAa/Vc7kmGxbdzenKCX6bUwiUSRKAfMkDThjX2CDaMUsEWhtlK0uD0uVcF1kVduehdtWyIYAqRwxdNdDleotzzX5D3CbDw94QmJ++kvrWngyQNvWJySG675eZW/gvI/qw650BPpwrMM5vHfRGniO4KjoTo91+WIle2IuPKGxoGQS/3CQXxD2RYxAVNxK3UOuYh4jVxiWwGB4zPv6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wBj92OJzgk+evmV3irdxL2t7OSHBDq0zvf4srYepjrU=; b=WcEPUASfKSL0olFezUV4RhXAKg9Dd75wR2rdb02CpgTLKYRufmjTd7hfz+d18Bh5C3je0ZbN0e2pTdnKGjtrzLCeG0vofqUVzRX3N+n2k8O44DZwbfqbTjfLELP2yic/xek6/ZmZui+5SMn92E0WyZ3DqJJQbOPiRwkd2nMf0cG/mi5mVan3WfrzszraB8rwYHDhBXr2IVvHhHsXgNs4sTihEh/Z1kCisXXjbIuuGzW3zgUlRiMt0e+Wxdj7CbfHtXKY//Da/gDuaPwb7fs/7zGcpKHntLNp3DAW+ut1AhcbOucM34vgar1y97pkxiPSzrzq5Dqwg2UPYv9v1M3fFA== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by BY5PR03MB4982.namprd03.prod.outlook.com (2603:10b6:a03:1f1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.31; Tue, 11 Jul 2023 17:49:30 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8%6]) with mapi id 15.20.6565.028; Tue, 11 Jul 2023 17:49:30 +0000 From: Morgan Smith To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: <878rbpxybj.fsf@gnu.org> (Tassilo Horn's message of "Sun, 09 Jul 2023 10:13:41 +0200") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> X-Hashcash: 1:20:230711:64516@debbugs.gnu.org::60ltqKRl8TU7Gzx6:1g6U X-Hashcash: 1:20:230711:eliz@gnu.org::NddTz84yw4y/493B:1UAn X-Hashcash: 1:20:230711:tsdh@gnu.org::xGBnqs0DjIaBJFDc:0cml X-Hashcash: 1:20:230711:jao@gnu.org::VsOrtPwuLX4CJLum:Nt4 Date: Tue, 11 Jul 2023 13:49:25 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [Et4SjWO24h8gXWtjVAbzQ0gtzZNhYjM/] X-ClientProxiedBy: YT1P288CA0023.CANP288.PROD.OUTLOOK.COM (2603:10b6:b01::36) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <874jma9w4a.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|BY5PR03MB4982:EE_ X-MS-Office365-Filtering-Correlation-Id: b726382d-0d8b-4929-b3b0-08db82372d30 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DWSKAAAc3BJE55Kupf0K+rpsipTZUoKfJJWwcZxDsxlo6Hi5FKmCIam6EvSu+MXRu36FknVmAyuOL//3qcIKwfqxRPBl612c5+9DQFCQP1siHEBp47xkrQXJYjP3SehUi+qqXO5SzRvj6tpxVa2aEM4COiBPze6+dgbWtDZMJhZ8PLEYKRR1eVgIa0Tm8JhM6mCpsZ8xpOjE7xkKBmPxicUXzjeRGhViVOSoDQ/PO4NzyU4w2MURc5AxeE93N7XEywnULiI+pLCNSC7BhWg8aW2aOA3B87q7ns5YxvvaJAfit7cfbjxuAlsTPfTRn1uYeNPsRj1AhOftYSa7VB5hsvw5IYfIgrJ36AQ0WNbQYB5McI2xnlCOp7hni9lsWK5amLPMIMjY3hj4RiIDKf8gAzyiWXUWeb2lGRpDDYQyyIKTUewZXu0tXB3NzwNo1+9NbD3Pbg3oJBQ19EbRc79FozufTprZgGWX2Mxma4BM0pqEo427pjJFABuDh6qsOccdvjyL73pUh7OxTVe1Stsz8FWdRYdWRM7eF3JWymvxNIKMzR4QYz9MpeP4VWbUqhaP X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+N8PTVaR7AEaK2+HGtGzP1VhXQ1PiR72AGBU4rUM53gT3SIfq1ZoG+q5MbC6?= =?us-ascii?Q?WYOs9YOZsQsObM8kzwxrkJbgihO8f1bIAsgwfCDsyXtu1xabRTAbeR7bUOP5?= =?us-ascii?Q?AHSPhG+HdRZp/9AlfTGk9g33q0yBfxplukGGuj7FTCgMN6pL+V/h/UP6OdQW?= =?us-ascii?Q?OUuf8qgp8ybmjRRPkBl0YZD3KjbCqNfW+mXuUcsKiZcQ9uWHxHFpiAtxzF1c?= =?us-ascii?Q?a/9zO2dksogZgAIbPMv6Z5jmCbO1X+KHKWggOFdFarrK5oaEta3T+g6XPIkk?= =?us-ascii?Q?yO9WD80knKqKqQbz7MJb3w/OPcZK4WGjiz5r2S+y88N0Ubyzun/qB+xIFfw7?= =?us-ascii?Q?0R99W4n+U3yx4oNJ9arq8i5+8mgI/3MiVF59epZxRJb5LmxI7DGsb6MQsC1R?= =?us-ascii?Q?sAc2800wkWTjQMszVg58BV429R4cVByu6m/bu2jSUdYqkUyP0aRtOhGSq+dC?= =?us-ascii?Q?UI7xc+EtdFRpkWlA+fo6dJZBm+6yrcyg5TfEm05Lkb7ggTLxfHJGXUjH9Woa?= =?us-ascii?Q?DW9uPCEJERkrFuO5oGcMJf5jK4S8aQVIXQFZOvHTnq5gN1jD1FcBClOCZz46?= =?us-ascii?Q?dX5/eKYJMhbDUCKBMqShnvBtGieUyQtO0KmS7Dr8T8rhbxBIvLwVe95v8DmY?= =?us-ascii?Q?evYK8C+IXRovW3zY6j55bXw01Ak06Tkw27T8FGpK3P2f65SGYclfKor8nmdn?= =?us-ascii?Q?xuhtGtUk7Wukfc+iSCqOP7Rb2/V6iDWhfp86BTfCy+rmvnaJ8spJ2PhZ0SzR?= =?us-ascii?Q?WfECodaLxUNHOqbX2oHiErksxIgSMDihKDoC/5p2Zt3tZZhzojRXZs4ZQgWo?= =?us-ascii?Q?tgPt80zcXU2FNdrkBrnQQzcgMW8rtv7tYWoSJguCfH46GMh7ciApEHTfXuib?= =?us-ascii?Q?PyKBFz5z5Rf9pct+OOPWvbV6Xio93HAZMIrjagL3M9xxDMLJLSy9vSlZ+4SR?= =?us-ascii?Q?b/Twddn9+lqjp1+zXSkY5jd3HK8yXS7dFMOXo/PekUyrvpDWSLFKj73bsFTP?= =?us-ascii?Q?Ue51aqJ+UBjvQ3f5xrO6pzkMNSbvzG13rFd268o2ZhEq0aEe163Rgwewf3Nm?= =?us-ascii?Q?cDrcof0AJ8eMNiG82PonCMQbC+9T64QcKiWzsrjG0IiqV37ICzukMI5Vlgv6?= =?us-ascii?Q?2BQ6JwVpoBOgbA36mYrpwlsk1NleYjDkObZFbNwFwfTx9aHwGVae5caweXLB?= =?us-ascii?Q?v0zwKYS5SxgxzMKkO23dgpMJoNIubIt6cOBtMFQ+oCWY27DUoGRTNoVqm/Q?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b726382d-0d8b-4929-b3b0-08db82372d30 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 17:49:30.2179 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB4982 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello, Tassilo Horn writes: > > I couldn't test it because all epub files I found result in > > imenu unavailable: "No items suitable for an index found in this buffer" > > and not the described error. I feel like my reviewers often can't reproduce my errors. I'm running Emacs from a very recent commit and I have mutool installed. I really feel like the error should be reproducible for anyone that meets those two requirements. Do I need to include more information in my bug reports? If so, what information? Anyways I modified my patch with Tassilo's feedback. However, I realized that it partially reverts commit b23e062d7463b76d25dfd9ba4a80c1848a448e42 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-imenu-check-return-value-of-mutool.patch >From 5b24d23e3317491c31ae1392c29ac7cdf303f9d4 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 11 Jul 2023 13:31:40 -0400 Subject: [PATCH] docview: imenu: check return value of 'mutool' While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. (doc-view-imenu-setup): Do not preemptively run 'doc-view--pdf-outline' as an error here would inhibit display of the document. --- lisp/doc-view.el | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..d5ccfc19853 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -147,6 +147,8 @@ (require 'filenotify) (eval-when-compile (require 'subr-x)) +(autoload 'imenu-unavailable-error "imenu") + ;;;; Customization Options (defgroup doc-view nil @@ -1910,9 +1912,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -1964,8 +1967,7 @@ doc-view-imenu-setup (when (and doc-view-imenu-enabled (executable-find "mutool")) (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil - imenu-sort-function nil - doc-view--outline (doc-view--pdf-outline)) + imenu-sort-function nil) (when doc-view--outline (imenu-add-to-menubar "Outline")))) ;;;; User interface commands and the mode -- 2.40.1 --=-=-= Content-Type: text/plain I can't really seem to figure out why we call 'doc-view--pdf-outline' in doc-view-imenu-setup even after reading the two bug reports that are linked in the commit message. For this reason I CC'd jao --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 11 14:23:02 2023 Received: (at 64516) by debbugs.gnu.org; 11 Jul 2023 18:23:02 +0000 Received: from localhost ([127.0.0.1]:51031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJI0r-0007DL-QZ for submit@debbugs.gnu.org; Tue, 11 Jul 2023 14:23:02 -0400 Received: from mail-dm3nam02olkn2107.outbound.protection.outlook.com ([40.92.43.107]:10465 helo=NAM02-DM3-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJI0o-0007Cy-GK for 64516@debbugs.gnu.org; Tue, 11 Jul 2023 14:23:00 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gFH+KZDjejl5knIR20OxYlxNbo47772ayoQGFcPR/l8mszwMQ4IE7f7utRT0hsvv5KGslA210co0vSVVhl6DxkYZNatxkdHHQF4UV8k+9ieMBZskTcIli9kBbnhUiphrq4GP7I0Vd9AoxW2smyNCgpT5EPBoua0aiSownKaZbTOZEuIpSphmDywtvI3SVcwRSnW/xU9VdqExuZv1jhjWSUQBdRTHft3YxIiOI1I4eQyURoK7ToW/B3lBM9c7tks27RfZHbBQUiTmaEoRS+cIb2AiXrItsw9gYLX1sImprp6zHxpIt7++egkd8RDqIM4AKAltIpU4cpbKMFSYEZDFIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DQ2XnNtdlQ8FzB7B/RaULAH9AivBxOTZskw2VjRTKLc=; b=SDpZpofP/ylxVc6pjQms+1N9WOSqjSeKSkXaLysLV0hD+ls/QY7cCTCkz1yhoddUP8ebTbIBv+kGnmaPCEtpyjY7NivaeWDpBznZKUfdg+h8rWfEJmAcwfYybwmdKylSH4uu9WJRdUrLAKoPX9zDsqycVzAP2Sygsxdqexo+Wu6lxFoJluxZjoA8CKNdoh4Y0snGdzBFaUXcCn2l5idNvhVh+4Dk2t6ef0iVUH5cHVsdaf5SEHOEUTnM9r+/0dzMUCpvsXC1ILO4Ab11KofkZZp9UHbMX3hApaaDgThyIZ226T2okucw1963ruxJOYvrwqz7yAQLoKECZJ7wkclEEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DQ2XnNtdlQ8FzB7B/RaULAH9AivBxOTZskw2VjRTKLc=; b=Wh7ud3feXjNdPd3FNkdaVB87Kj3uCxIrDu81xCxout2Hfyjojo/2W4gZGQkw6pF0t8YgoiGIVf8HtMpp3IjC+g8hJh5xmeYaVPJD/JuzU2SNw8e//Lruvvt/dTwrN3mq2D/cTu29Isja2QtHknmSQ4Av5a5W/j7Njf3k1G1Zmxf104hP7f+opapcyPkDPo22IXmIQlyXRIAGpsreYoFs46Bn4Op4P92u+0+0SR1R25Sy/M7Zk/wRoldfLgn0j1zV/8zNc89GUeaNiShLTFYdP5M2Pd4dPp5p6gX/HIOlFpQLLmsoVmDT6efhG+jIOAc0RKMlqfdMmnP+pNizpuP8Rw== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by SA0PR03MB5484.namprd03.prod.outlook.com (2603:10b6:806:c2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.32; Tue, 11 Jul 2023 18:22:51 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8%6]) with mapi id 15.20.6565.028; Tue, 11 Jul 2023 18:22:51 +0000 From: Morgan Smith To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: (Morgan Smith's message of "Tue, 11 Jul 2023 13:49:25 -0400") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> X-Hashcash: 1:20:230711:jao@gnu.org::fisBgY5pzyUgKoM8:ZB8 X-Hashcash: 1:20:230711:eliz@gnu.org::bIfeUm0Tw76YVxOP:30T0 X-Hashcash: 1:20:230711:tsdh@gnu.org::tJQ33sQ848HgH5gO:02xk X-Hashcash: 1:20:230711:64516@debbugs.gnu.org::5dBsYcJwzQjxIfPv:ETHi Date: Tue, 11 Jul 2023 14:22:49 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [n40VxfdcmyxhMIw4PTorL/xzSS/YSeS2] X-ClientProxiedBy: YT4PR01CA0032.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:fe::24) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87fs5u8g06.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|SA0PR03MB5484:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b7b4e66-5415-4fd7-4619-08db823bd65d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6ll7O3SoePo1q1p+xr9Z4pc3Knjxb3D1pnKbcn+WIEl1DUKxGaAxIB7+khpowzclkoSgvFr7rBUoTorjxvplHLbsmiC1Zqo+gvv84HA7BwS8hc8y2F76HMMMpahlCpWcBlcR5V37bFJz1R5+umWLB3VXZR2luhFkNdWA8571mKHcabKEgJlkZNIC4jNjTxksDXxJaGzbqzenzsl12m+HxnC3KvWm0qK2DVYYa+AVgMMzEPwha9UiUfzNmOnpnEXKbkfjqGr3Df80o9SRYmMCzvK9JN5gdjjjmx4hVk90YboMUloyBbSByTyOiDIIweYYmNmjMWeGWalg6/HzYoQMp3Oa5Ooo6KMICb3rhdnkKqcmo4/+UyMXv3UPOAjdhob7FMhMmyoAn7BH3rc56bUpi20qAQWaOEOPDJO3W+ki9cK96QQ/Ta8vsfY/17oWwVoNhmtrmKTloFpPQFJ8fB7617b2v9YaQ0JYfZpi7Z0QivVfYeOfoCOYDQVSpy68mouuLDTEIVeC88oC/lxhSHgS0XPxiSkgvgO3LV1N7rS/Ru3GbtfcOdB2FaI7rOqRw9e5 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?b9QIoN/2fKX096P7mfdyfqyTxhXKvGxWbjhc7SZPdr9QXmidI0CzsAAzWRzu?= =?us-ascii?Q?1HxwlUhrEMZcY4HRLJ9pnwNlGtZFYEbzfDdsb3s4JbNsNcmhttJNybt+OoiY?= =?us-ascii?Q?nXGbnvpyF60eb8yhqBn/mEuUNL2uebB75GSGmGyja0BQ6M7GYrANvBOIRZtq?= =?us-ascii?Q?jXwH98lTyYleDgVuVVC8ea3t2jdhZDq2g77tUnFQuZTVDKEw3fEMrvRRPYWo?= =?us-ascii?Q?MaR1jXYBBiJW3dd9ijLKKsnTPpCS72sW1cwt9T9x11I0ZOlEg3IsYdptzIAS?= =?us-ascii?Q?07CO5tHnnM9t83AjDz8Ev7BXbh4SUaESLDn5/ZFzcBNrjqBblRPCqiKXmfqT?= =?us-ascii?Q?P31HXyypuwujrn1bK81EknZHUrpgVyBSVOfNtHRFtnu/3+PBESXeEI82AQku?= =?us-ascii?Q?p5AS4xhSiWl20VWyR13FRlvaMyYVEhwSVUBSH+Lk6xxTYYGMOngVOmFL+9II?= =?us-ascii?Q?4/TUy+ZQym+mO6fjotJLAUatKkmX8pKKDvonilThaU0Kp+n9qr78UARsi8X8?= =?us-ascii?Q?TPQv1/NQ4Lw56QzQqXyTNbmz25S/9IEnD+s+eH8MJdXNwVxBUe5EBMgv6yr6?= =?us-ascii?Q?ULaNEYGAq4K+3a9I0tAPIhBJsg2YhBmh0uVFGrr6smKzr/L40xFq+E+eVMHH?= =?us-ascii?Q?Dt0qkkg7fJZdH9ixABvianF59I4vyL95qh/Z1Qu7501aWCAr5VzQECiu6ze7?= =?us-ascii?Q?0rhkHoF0Qae+7rO6n9qAJwyFJinCtXfiHYd48UjHHVu7q1SnEJ7BpNwxhHft?= =?us-ascii?Q?KHXp3zuS/mjIgyOamHMnBifIYWRVeF04eMRlr7/gRcESSqrKUToLiz/h45G1?= =?us-ascii?Q?y6DRem1Vdco37t8PORT4luDOlMJ7+sJoelN1z5plRnb4svHudEIuaE/6JmVF?= =?us-ascii?Q?bagYdqLmYAawhNzWaie0M7ThMtEl0Xgm8dxmxv6vKyOuquPjQNbrA8ntO4se?= =?us-ascii?Q?d98yZSU903vJVWoMZKtz02lDPpmYJ3K1qq75qkXwkCzDovMjZRfL/wH+zmfK?= =?us-ascii?Q?6NK71nRlPHLsp+gBBJq7cDMKzXS/x3RX9/lPIqZZfcioSVB/wb5HNJrkejpI?= =?us-ascii?Q?2Olz9inbG9ORTUeHRHYqklUOxjNCZvlfsTzJiXyftEyfotCFMsGP2sAxBbFS?= =?us-ascii?Q?uBJdQC1nvla2ZRiph1Z1PhIfXwp1mP/nkx+WSCxhJ9ykz0M7UwkeVe+Ysy50?= =?us-ascii?Q?FNhc6eIPdy/8DAPud6vZQYVg8f2J5HVvuT1MDN/gumVr9bQbBc3/h1wL8sU?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b7b4e66-5415-4fd7-4619-08db823bd65d X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2023 18:22:51.8241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5484 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-imenu-check-return-value-of-mutool.patch >From d2315c945d6fd87a2371eefb82ec0241287e66a1 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 11 Jul 2023 14:08:24 -0400 Subject: [PATCH] docview: imenu: check return value of 'mutool' While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. (doc-view-mode): Run 'doc-view-imenu-setup' in the 'doc-view-mode-hook' so that errors don't prevent displaying the document. --- lisp/doc-view.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..f64c3a9719b 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -147,6 +147,8 @@ (require 'filenotify) (eval-when-compile (require 'subr-x)) +(autoload 'imenu-unavailable-error "imenu") + ;;;; Customization Options (defgroup doc-view nil @@ -1910,9 +1912,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -2236,7 +2239,7 @@ doc-view-mode (setq mode-name "DocView" buffer-read-only t major-mode 'doc-view-mode) - (doc-view-imenu-setup) + (add-hook 'doc-view-mode-hook #'doc-view-imenu-setup nil t) (doc-view-initiate-display) ;; Switch off view-mode explicitly, because doc-view-mode is the ;; canonical view mode for PDF/PS/DVI files. This could be -- 2.40.1 --=-=-= Content-Type: text/plain Hello, I apologize for my "oops I figured it out immediately after I sent the email" syndrome. I was trying to find the answer in the bug reports when the answer was in the code and quite obvious. Anyways here is a patch that unconditionally enables imenu but checks the return value of mutool and will raise an imenu-unavailable-error when it is not successful. However, that error stops docview from displaying the document so I decided to put the setup function in a hook so the error occurs after the document is displayed. I looked briefly for documentation on how errors work in hooks but could not find any. I don't want this error to prevent the other hooks from being run (which would be user defined hooks. we don't currently use this hook). Thanks, Morgan --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 11 14:28:01 2023 Received: (at 64516) by debbugs.gnu.org; 11 Jul 2023 18:28:01 +0000 Received: from localhost ([127.0.0.1]:51045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJI5g-0007La-TJ for submit@debbugs.gnu.org; Tue, 11 Jul 2023 14:28:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJI5e-0007LM-RU for 64516@debbugs.gnu.org; Tue, 11 Jul 2023 14:27:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJI5Z-00031N-3P; Tue, 11 Jul 2023 14:27:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+gYmnDDBtNfRqm+CxPkgx1Et2lk6Y/sB0f155G4t2Ls=; b=QrZGjTaJAkLF O0Rworr19tCcvRN9ebtRmjXBGtwMLmEizLjsX23cV+29o58kEquYO61PoGaPcw3M2rLdugCMi/pew Vza+G5C7ZXsJkiROnTW3pq5moIdd7frju0ah5ekh53626Xfo27bJy18VAAQ5NpJ5eM/Y3RSkz7m0v fYzxLs+xrcMqXLQUD//i1kfcBxmUuZAvuQnsUiZe7Y1c+doFNsiBmQVLuzkEPvqMMfJO5pFhWycLD yrhMeSuvA95TDBBTzHl7rCV8pIgOAnFqd9xLDWq+iY+FAj4gmqz+x+eu4obf3rlZJm2wTL1Gh1R3K S4pYrAXJ7BRM2pQsmLC7WQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qJI5Y-0003bl-FR; Tue, 11 Jul 2023 14:27:52 -0400 Date: Tue, 11 Jul 2023 21:28:04 +0300 Message-Id: <83h6qa716z.fsf@gnu.org> From: Eli Zaretskii To: Morgan Smith In-Reply-To: (message from Morgan Smith on Tue, 11 Jul 2023 13:49:25 -0400) Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: jao@gnu.org, 64516@debbugs.gnu.org, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Smith > Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org > Date: Tue, 11 Jul 2023 13:49:25 -0400 > > Anyways I modified my patch with Tassilo's feedback. However, I > realized that it partially reverts commit > b23e062d7463b76d25dfd9ba4a80c1848a448e42 And reintroduces the problem which that commit fixed? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 04:05:01 2023 Received: (at 64516) by debbugs.gnu.org; 15 Jul 2023 08:05:01 +0000 Received: from localhost ([127.0.0.1]:44041 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKaGz-0001zL-Dl for submit@debbugs.gnu.org; Sat, 15 Jul 2023 04:05:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKaGy-0001z7-AY for 64516@debbugs.gnu.org; Sat, 15 Jul 2023 04:05:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKaGq-0003NJ-KI; Sat, 15 Jul 2023 04:04:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RBSaXquabnaZ6s3Vy+LV8XyUVhBujDIC1npwwXO2Xgw=; b=DsrJRxfQQ7Qk qzYiziqfL9nFdJ7qka8lHj0iJ+41lMZQpphZ0iOgx+lMrQhu5Zs5ruFQcJBpo1e44NZdv1gZTvaUM 1fsO+m3tFfOaDasxN9miDbXb8d+vJHQCr0k717v3WXKdXoJdMq7rVpul25Ms3iahUg7ZgJGEULyG5 zXGB+eEFgTWxh+7V495DpEIDW5mL5WJf7PVYlynEEl7DFigAfjFMRcNGt2bSar0XfFWuE8UjZ954v iicJwuyycE0sYaXCbAdH+Uk5mo8le8TKeWdFql29ortb3gDEkhPWljfmiOYntxI+XYNxFRskzQgBk CXbn5RvOo7otcwu9oh4UkQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKaGo-0008FT-Oi; Sat, 15 Jul 2023 04:04:51 -0400 Date: Sat, 15 Jul 2023 11:05:11 +0300 Message-Id: <83ttu5d2h4.fsf@gnu.org> From: Eli Zaretskii To: Morgan Smith In-Reply-To: (message from Morgan Smith on Tue, 11 Jul 2023 14:22:49 -0400) Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: jao@gnu.org, 64516@debbugs.gnu.org, tsdh@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Morgan Smith > Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org > Date: Tue, 11 Jul 2023 14:22:49 -0400 > > I apologize for my "oops I figured it out immediately after I sent the > email" syndrome. I was trying to find the answer in the bug reports > when the answer was in the code and quite obvious. > > Anyways here is a patch that unconditionally enables imenu but checks > the return value of mutool and will raise an imenu-unavailable-error > when it is not successful. However, that error stops docview from > displaying the document so I decided to put the setup function in a hook > so the error occurs after the document is displayed. > > I looked briefly for documentation on how errors work in hooks but could > not find any. I don't want this error to prevent the other hooks from > being run (which would be user defined hooks. we don't currently use > this hook). Tassilo, is this okay, in your opinion? From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 14:44:58 2023 Received: (at 64516) by debbugs.gnu.org; 15 Jul 2023 18:44:58 +0000 Received: from localhost ([127.0.0.1]:46077 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKkGI-0000GK-2w for submit@debbugs.gnu.org; Sat, 15 Jul 2023 14:44:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKkGF-0000G7-AS for 64516@debbugs.gnu.org; Sat, 15 Jul 2023 14:44:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKkG9-0005kV-76; Sat, 15 Jul 2023 14:44:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=62hvRvzCjM5q6NY2KpF49453LFuOzLJk2xu2VKuM8eA=; b=Jud21NaFCHYbbg ek9zSkkmqh2d8pkF+USGHgaKtyesSnIkC0r2bz6Pm6hCmt3GKbAkIkX/xjbuO3KkXulQp5eh9cE+R uDb1qLPDMhZORsHBUYUHBhBsJljjjMWcJ5LzChpIlEwxcbVeyz/qVOHSRB+riYSyIRkPgJpEiXwfO QpjYlK6nOYostlO+5uJe172Z4uGZqq6+ye5eUvzh3kFZPgKCcBkmokcQR+ZbAR1MuRB20+naaKS9T BHgLGc+eC0vus94EH51xWbuhEzKPEziHaQYU+BPK+9bQ9f+aPKoiV3qwY+ybwaMnWRDcIKhgKdGgC 8DtVMI80DfaAqgIjYGsg==; Received: from auth2-smtp.messagingengine.com ([66.111.4.228]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKkG1-0002qU-3P; Sat, 15 Jul 2023 14:44:47 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id EBAB527C0054; Sat, 15 Jul 2023 14:44:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 15 Jul 2023 14:44:39 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeekgddufedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe dujedtheduvdelffejkeetgedvheelhedvueefhfeukeekkeehvdfggeegffevgfenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 15 Jul 2023 14:44:38 -0400 (EDT) References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> User-agent: mu4e 1.11.9; emacs 30.0.50 From: Tassilo Horn To: Eli Zaretskii Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Sat, 15 Jul 2023 20:39:20 +0200 In-reply-to: <83ttu5d2h4.fsf@gnu.org> Message-ID: <87jzv1c8vg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Morgan Smith , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: Hi Morgan & Eli, >> Anyways here is a patch that unconditionally enables imenu but checks >> the return value of mutool and will raise an imenu-unavailable-error >> when it is not successful. However, that error stops docview from >> displaying the document so I decided to put the setup function in a >> hook so the error occurs after the document is displayed. > > Tassilo, is this okay, in your opinion? Yes, almost. I'd rather handle the error rather putting the setup function in a hook and let the error hit top-level and flash the screen. --8<---------------cut here---------------start------------->8--- 1 file changed, 11 insertions(+), 5 deletions(-) lisp/doc-view.el | 16 +++++++++++----- modified lisp/doc-view.el @@ -147,6 +147,8 @@ (require 'filenotify) (eval-when-compile (require 'subr-x)) +(autoload 'imenu-unavailable-error "imenu") + ;;;; Customization Options (defgroup doc-view nil @@ -214,7 +216,7 @@ doc-view-mupdf-use-svg :type 'boolean :version "30.1") -(defcustom doc-view-imenu-enabled (and (executable-find "mutool") t) +(defcustom doc-view-imenu-enabled (executable-find "mutool") "Whether to generate an imenu outline when \"mutool\" is available." :type 'boolean :version "29.1") @@ -1910,9 +1912,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -1961,7 +1964,7 @@ doc-view-imenu-index (defun doc-view-imenu-setup () "Set up local state in the current buffer for imenu, if needed." - (when (and doc-view-imenu-enabled (executable-find "mutool")) + (when doc-view-imenu-enabled (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil imenu-sort-function nil @@ -2236,7 +2239,10 @@ doc-view-mode (setq mode-name "DocView" buffer-read-only t major-mode 'doc-view-mode) - (doc-view-imenu-setup) + (condition-case imenu-error + (doc-view-imenu-setup) + (imenu-unavailable (message "imenu support unavailable: %s" + (cadr imenu-error)))) (doc-view-initiate-display) ;; Switch off view-mode explicitly, because doc-view-mode is the ;; canonical view mode for PDF/PS/DVI files. This could be --8<---------------cut here---------------end--------------->8--- Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 19:51:08 2023 Received: (at 64516) by debbugs.gnu.org; 15 Jul 2023 23:51:08 +0000 Received: from localhost ([127.0.0.1]:46267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKp2Z-0002T8-W4 for submit@debbugs.gnu.org; Sat, 15 Jul 2023 19:51:08 -0400 Received: from mail-mw2nam12olkn2105.outbound.protection.outlook.com ([40.92.23.105]:42959 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKp2T-0002SX-Vm for 64516@debbugs.gnu.org; Sat, 15 Jul 2023 19:51:06 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c50VIBT9uZHQOmA0fi+zTDKRM/mrRpSwdS17hkz7BtosT4fwWtf/5rDPKtIIMTbkLjZQqVfQCjIicqLYHYe0Gw7kMYuVvQ2YMW80XiNlS26XzexeK1TpWasDAcN+CuT9kIc/WvaE8a0OEEeipB4udlbvzlrEIC2ZvrCiwU8Xkgc++YxXPGx+HRHgImYQwrLUuCAd1hV0epfzENX7gfmunbNEdIiCr2NnD6lqs5T5N/gHqK+QZbGwoTaW2dnwJRjNZEDtXt83i/KOe5x8a0YhAIpumde5afrcJ38EVHn0cJRGnkYwafw2l1S5CKdpmWr1nBj8YRpNRfReb7aBZkS0BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WsjF7HlONlG9uSVdTIohZvpAj4q1Lmq9zKrs4yN+E2w=; b=LS44+gasQlwGOH4HXj9yScq+fDme95Pi3zJGu6ggjZ0QB1Sx1izWxnZ0n70+pIRiVRYwlMlRSm3IiXWIfU82r5M2mOHdtfFwkew5UBn/44DH+AvLFGmYE/ZJquALE+X25QMWVpxd94o8Sqzk4T6hZ6sQkH2ITgm7P35805kYbeNfOnmeZeUn1u/ppGlr6vnu1au6zLdxnBClY0rE2JiFqP4Q8t3cuJYV7kOcRXtqzpk+ZwBl5F0FIW71ueWBiUMjeSPeNux8irBPyjTyJQVGPpew6OFo4QZpd2r8Xg3MtMOVgGsgUwUqBY2djxb9YKUeT5cy7r5Ep8KuwEmKGC8ISQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WsjF7HlONlG9uSVdTIohZvpAj4q1Lmq9zKrs4yN+E2w=; b=RTL3deeXUbg3zwSGsDMQ73/qLpaROskWP6l8fCgGvvQtWmDDyn3fvdvCF8kIYO7Bx9AuwqXGmRT50Coq/IZAPSCsYesQP46dkk2ioW8ay6GAf4J1B1OXfNg4Vm/1bSBOo26QT+QG5n9DFnJs4500lUS++Vhjc4Rku8uufwiNK2kZuSENw6huG+8lnwrGXwPFtikk01+3Drb8W1emopvWENDG6k8hn4k5zAtop0Aks3dFgPPjvOhgAa+ObUK/kexBSsJaNWuPQFJJiKdI6/Pskmf/2OXb01B1uRakpXL19k5y67nfsgEWa+yeOmPpO0eu+Dm/P0rw2lsVG27qz4VP+g== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by BY5PR03MB5079.namprd03.prod.outlook.com (2603:10b6:a03:1f2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Sat, 15 Jul 2023 23:50:55 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::6d7:a135:f84c:a7b8%6]) with mapi id 15.20.6588.028; Sat, 15 Jul 2023 23:50:54 +0000 From: Morgan Smith To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: <87jzv1c8vg.fsf@gnu.org> (Tassilo Horn's message of "Sat, 15 Jul 2023 14:44:49 -0400") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> X-Hashcash: 1:20:230715:jao@gnu.org::bcUV0MDbJpBQ5z3E:H5ht X-Hashcash: 1:20:230715:64516@debbugs.gnu.org::zqW5rCPevzJvFLH3:0COw X-Hashcash: 1:20:230715:eliz@gnu.org::2FRWKptV1muFi5RC:1J5k X-Hashcash: 1:20:230715:tsdh@gnu.org::XDQsqD8jAeutYlRX:noO Date: Sat, 15 Jul 2023 19:50:52 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [gV5SxJ4Co2HNbQR0Pn3gOCvgyUFlGjPs] X-ClientProxiedBy: YT4PR01CA0139.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d5::6) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87wmz020pv.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|BY5PR03MB5079:EE_ X-MS-Office365-Filtering-Correlation-Id: d51abd38-bd66-4483-a539-08db858e5402 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uUIvP1M3bbthIo+D0OI84xPkhkVECnbMGbLKGsM1V2BPxgZ5Oj4MhGWiKs/ozTHFlaH4V1xQb9PMObygTOf9BkimagW6TCKOshh2Uhgv6jWpExJqGN92KsoO5VmFZc13vpoGJdhzHbAErmlgDCUUGDuUBFZFXjow+/XAJq60wyF6HsxJ36XC2qvDWU8GSyKKO14EPFCSx/xtGKJPnPxjv432lqS5o4ltMjUuyjUoobZxjpd2mG/P51UEGV1ERqtgaR9YQC3VkQRTCNnTy0/saO6CtU5+pGdpnC3tautq1K/x+PexVpcC1ltmyJVHxII/Bqy2aMR0+baehMKx4UeGOQQFNeN6K5mUcfKE7B+rLnnvRZs3PiepyToKP02E983HQIou2PthtzuI2sm2zKVGCurcBq73KilGqwPMgoao1W4FVAdB6AdGyw80ay0eXLrOVGQR9Yk1uS2vAVdFJsZFv5GmyAbQI98cgTNkVIBmKMChfwGBZieT1gHWHNYXQ0jgT9dm7biu8zeSI/FYquRgH0bB2Z66UdJTRT2XQVcIll4VfYywsYNZ3wzqmtxtVlB6 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P4oiREc0LssNG+Mr8iudq7OYhEW1BZvCN460VmsrOlPIXwUT/JlorZOlFTJz?= =?us-ascii?Q?pcoKrJRZsiInt3PrRbh6KFzrqR/wzXiar3oscL7bnvK778jdGsj5ke+wiilg?= =?us-ascii?Q?Qspi+MMdRAr2XnSwj913unaRzk7lNJpsG1dEorHMuAHF0CP1DZeMeeWzfH35?= =?us-ascii?Q?61jNoNJQl0YSemAuaNWRODhU66cejSd59qLuF/yoMKm6nvDF0rMmvhcNzlfB?= =?us-ascii?Q?80zY3VEUo2IayaMIB5P5HBTDSYtAZ6UGW0MhmpmpGJxAYS5LyXaRmppsUv9c?= =?us-ascii?Q?vhGLGeMVnTM9tRtBWZeIsca81Hnls9hR50ZpR6Eh5wwcd0yVuFiEjgpG1GFn?= =?us-ascii?Q?JE4Hl9+UZ76hRZQg/1jYIInD8WjvftUrfmqD31Idm8e1YLlD6pPkV60Ay2Vu?= =?us-ascii?Q?ZwApYZ738vf0sCr3CuG+R/xxJFBzsI95Frlh5soeBd1hXvJNEOSab5D0wz7+?= =?us-ascii?Q?9y4QMpg1PU73kvZZfsdGU4TpXSgneJCoyj+TeftRI2c6zW2vk0447isnc0su?= =?us-ascii?Q?VPuMuT152OEISWGNix+6Apj+RVO2XT4NeMUoOxJhDTk2Ns7O6fu+nJspO45Q?= =?us-ascii?Q?HGWGN34wBh3JUMMSV5nWw+R+bt20ZkhurtqfuTj3E4bx+OFexWspR5SPHnhJ?= =?us-ascii?Q?2i78nmN2fB16Obw+bKTSPEwJU/jE8ODiFaZsbAbPxZ0j1J4fhl+ZfBTuQOPV?= =?us-ascii?Q?UaiG3OZX38nMYYhn6c0UxNkFEUNS+kexZ2SOTEgJ9Q8leThO3P4N4NOnnCKh?= =?us-ascii?Q?w8vHXYeJZ5v79nu70DwQbg/rZpZPnGGtaVHs0IebPDO4t/BfA0nAzg/wi1hx?= =?us-ascii?Q?tsB0BIzJ5ldUmCuRBB7QgDPC3CH7fy0yG4cKvYl2KJYQL82bhOj7HKA4DTXo?= =?us-ascii?Q?D61wW5zyMTSLvNyd/AJfReHYzNMZTi0eRZALerVuJBB7J2FrvcluxMW48JBv?= =?us-ascii?Q?y6RibjEv4ZqF40oOGmi+DAbAvqbxSVIfVrZfSNPzmksEZdsBeC1rf/H2VhaY?= =?us-ascii?Q?Lq6JjKy2JgpjxmoIynepI4RcPxoL0APzPYuCFoo4XeL1tQS4JxTOFWbCD//6?= =?us-ascii?Q?Ht8F15saL5a8L5rpsC7Uq5FYBj7JM96//uiE3U7v4x3VgFbi8vsD/EvjHaYZ?= =?us-ascii?Q?LDaDKN2iKI8yphXVJDjLH7gh0iePU7S8d2hxhvxVET+Fd47U760EawKvFwIq?= =?us-ascii?Q?IxuI37atwJ8KVBgPgXPXcTUBNB/rww7tukU3s8x/ruH8PxOfjzsP96EMBLM?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d51abd38-bd66-4483-a539-08db858e5402 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2023 23:50:54.8450 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5079 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Tassilo Horn writes: > > Yes, almost. I'd rather handle the error rather putting the setup > function in a hook and let the error hit top-level and flash the screen. > I've made the requested change. Please see attached. Thank you, Morgan --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-imenu-check-return-value-of-mutool.patch >From 7de1362395597d2d7210dc78dcdb104071d758ab Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 11 Jul 2023 14:08:24 -0400 Subject: [PATCH] docview: imenu: check return value of 'mutool' While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. (doc-view-mode): Ignore imenu-unavailable errors when calling 'doc-view-imenu-setup'. --- lisp/doc-view.el | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..7d604a7bc86 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -147,6 +147,8 @@ (require 'filenotify) (eval-when-compile (require 'subr-x)) +(autoload 'imenu-unavailable-error "imenu") + ;;;; Customization Options (defgroup doc-view nil @@ -1910,9 +1912,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -2236,7 +2239,7 @@ doc-view-mode (setq mode-name "DocView" buffer-read-only t major-mode 'doc-view-mode) - (doc-view-imenu-setup) + (ignore-error imenu-unavailable (doc-view-imenu-setup)) (doc-view-initiate-display) ;; Switch off view-mode explicitly, because doc-view-mode is the ;; canonical view mode for PDF/PS/DVI files. This could be -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 00:40:13 2023 Received: (at 64516) by debbugs.gnu.org; 16 Jul 2023 04:40:13 +0000 Received: from localhost ([127.0.0.1]:46352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtYK-0001h4-SA for submit@debbugs.gnu.org; Sun, 16 Jul 2023 00:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKtYH-0001gn-3a for 64516@debbugs.gnu.org; Sun, 16 Jul 2023 00:40:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKtYB-0005lP-7m; Sun, 16 Jul 2023 00:40:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Subject:References:In-Reply-To:To:From: Date; bh=Wscty2/2qGZJ0ithas3udBxYVKbqAe1K0aZEB9VyKqc=; b=MrwDWon1rDIY06LdIuRp Nd60belEy+sE/EKfq9FQAK3NVww1WyuFPJjMD2i6BJKdKozdTdJY/QmDW8irvaw91cY94cwguPY7J ZkghymmiIX/19QCT5lqv8QkExi8efucCEsz606ikmatIOpMiOQIgW0K5xex/fYQARV8t7QzwNBDdy zE0b82qC7hjIZhRz5WCkS7KNLNwcHSLQmInwfn22UhsAbFtbRFdtouQylCYi91oho4M2JX/ZH/1Ng /WxtK2dusE9x8C3uIoqAWxE1guZf2oz4jzNf5/HdRJtO++q7FfxEWSl1AGz8UkvsBkAI9QKof6i0Q XXc4p5dSA1APEg==; Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKtYA-0005VS-0u; Sun, 16 Jul 2023 00:40:02 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id 02D7927C005A; Sun, 16 Jul 2023 00:40:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 16 Jul 2023 00:40:00 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfeelgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefkjghfufggtgfgsehtqhertddttdejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhephf duhfejjedvtdfhteejtdejgeeiudeiueduteeuhfffgfehhedtvddvheeugeeunecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jul 2023 00:39:58 -0400 (EDT) Date: Sun, 16 Jul 2023 06:39:57 +0200 (GMT+02:00) From: Tassilo Horn To: Morgan Smith Message-ID: In-Reply-To: References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Morgan, Why do you ignore the error altogether? FWIW, just use the patch from my la= st message and we're good to commit. Thanks, Tassilo 16.07.2023 01:56:09 Morgan Smith : > Tassilo Horn writes: >=20 >>=20 >> Yes, almost.=C2=A0 I'd rather handle the error rather putting the setup >> function in a hook and let the error hit top-level and flash the screen. >>=20 >=20 > I've made the requested change.=C2=A0 Please see attached. >=20 > Thank you, >=20 > Morgan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 11:03:07 2023 Received: (at 64516) by debbugs.gnu.org; 16 Jul 2023 15:03:07 +0000 Received: from localhost ([127.0.0.1]:48405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL3H8-0006tb-V0 for submit@debbugs.gnu.org; Sun, 16 Jul 2023 11:03:07 -0400 Received: from mail-mw2nam10olkn2109.outbound.protection.outlook.com ([40.92.42.109]:7816 helo=NAM10-MW2-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL3H4-0006sy-Vw for 64516@debbugs.gnu.org; Sun, 16 Jul 2023 11:03:05 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YhQZPsRR8k2/FSd1ospnX1ZbiZHAqsA9kHm5EtdM2rHpb5W89WB0iDR6rRL59J6AVXqo8i+yFQN4L/wt9lhWnUW0clfRD9FiG0n644ZcjgcFGQT2//SijSDWiITBcBFgTI0t6VRyHOZtfoECSDOFl/jiR1nKUHE4RHcR7K9iIvkaHSnDyVNmtLYEaoGnpYXRTVgLb6gxG1OvI5uSgQLKjer17BhjZINppQciEbj5Er6ZmYehY8Q+fULBBJrmKfN2F3vhCjgs+GvhEKqWY1P29J8dCQIs3s1rGPosZM8usz6yXQoRHguQP68cxAp8PWtIf0YEWnlKnoSBp0Q09oh+bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dRknaSyyiNtjF8cDrXCYOrI5uPhUOs9unl8PhQWHDYU=; b=JK9XEU/GRr1Ct9XU+QqbJxFbmeoy1SLncUxRzOFUfaB/1NsJ8/kkoqta0PimMnJ6cRLH512a/K/huk6oT9yA6urGBD7y4KGI9Q9IZSjXDxQ5UYsbSTN07Z0itDggqJ2oXUHaWifBNPYsuBxg4wDloqadNOQqS3WIaj3cZaV/sxhJXW20Z/aBSbWNQ5DuAbI/+KB19zMaoWzW+1fD1lI7Ec5Uw1biCMsj+zakpXh3C/TW5IaM9TZ/xorq8fLjhbSWhBH6Viz7Z2efgO2zIt9iEFj6KIW1oTJXmyfaL1dxA0JZi3pPwnJgWg52lUtWZGu1l4T/QiEL2sIVUFk17H0tRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dRknaSyyiNtjF8cDrXCYOrI5uPhUOs9unl8PhQWHDYU=; b=BbRaC4nFi82T/LZKgxaB/8PFFiWpS/+R+hp63NlsczP4uaHLIY27Fq8g2fU1sRApGwsZUByqyem4cm4AQ/TtUe6iC6rqVPiUegtfKfV4xlvscg9FcKS97GFEOyw5VfBM6OiXnY4Wy7QXLPw06SvUgUyUvMM41wOMC+YcHeZIqfu3yC+Zyjn4DW4rxKERd10yoRI+JdcceZEBmzQlSQuWGi9cLGfOBNunZPyrhUzgb0LgMFFJoFaqyjyDaKZnR3YC274B4flUOUhyNrl/nOYEZkoOVcw0pkfqokt32teMmof9m3Pz0WehcI0J8+M6kFZG7vtQpvsbg5OBQFWH6bF7BQ== Received: from CY4PR03MB3159.namprd03.prod.outlook.com (2603:10b6:910:56::21) by PH0PR03MB6801.namprd03.prod.outlook.com (2603:10b6:510:118::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.31; Sun, 16 Jul 2023 15:02:56 +0000 Received: from CY4PR03MB3159.namprd03.prod.outlook.com ([fe80::f2af:a0f:d0d6:a02e]) by CY4PR03MB3159.namprd03.prod.outlook.com ([fe80::f2af:a0f:d0d6:a02e%7]) with mapi id 15.20.6588.031; Sun, 16 Jul 2023 15:02:55 +0000 From: Morgan Smith To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: (Tassilo Horn's message of "Sun, 16 Jul 2023 00:40:03 -0400") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> X-Hashcash: 1:20:230716:jao@gnu.org::kS327XDCuUO0sXI6:Vvt X-Hashcash: 1:20:230716:64516@debbugs.gnu.org::VcIswWhik9rsXsQQ:0JF4 X-Hashcash: 1:20:230716:tsdh@gnu.org::0PD1EwS4TNeiWIR/:12A6 X-Hashcash: 1:20:230716:eliz@gnu.org::TqDMYu3aTw+ydpJb:DVAG Date: Sun, 16 Jul 2023 11:03:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-TMN: [g8SKsSx8sh0gGR0x+NcwbqWuKYsS7iO/z64PqTi4gxBdApvwizmlhQ==] X-ClientProxiedBy: YQBP288CA0013.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::9) To CY4PR03MB3159.namprd03.prod.outlook.com (2603:10b6:910:56::21) X-Microsoft-Original-Message-ID: <871qh7zyof.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR03MB3159:EE_|PH0PR03MB6801:EE_ X-MS-Office365-Filtering-Correlation-Id: 662579ac-b102-40ae-c8d7-08db860dbc45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q6N8tjvh8q/lejorbUPicvI6udaTSpqIb3rorfYafj0uE/u19neeR7WgKU9ePDLzxelbp+73AiT9r64fW3i41qf2/tWZTG/ETT8mcOMRPZ1Lsx2P46+ywkmDo28Fj/pAOHRDcpoA+2ofTwercaYHUzgtOMgA5MMxXdoKJ5j1J2ToxXKffzDMKHNwVadAuZxfCaPs8fD8fTaJCDjEbrf2FKBBS6MZxgJvJVRs/748h8dHJsmlASXNN8bF83tXUyQ84wZteOswmIsDepK6AencSZl8wKeB4TvaDthhMAtgcpZmuTdqvfY+LATxDxWEF0HQ1He+5+S+ZwxVxwQg55EtaaKsmi9BrXHdPDZsuzmj7VqSCUXVVhyA0aeLAegwuyGJa3u8gdojBQskolTeOEdetYnVGLCLUdURgaVEQNlNZfzuY2gPRhlQhtYZ2m5/f844ewL1bRbixsPFwsGt0dOgzUaX154GIhIaIUQnCgX/wfBQz368YQXI6vA/5yMcfda3mH4DtstPEaKfLqfo9wbDUEAZOYA7ZXE9dUJ+glhFpwKyo2UUFhYBV0/Ho+h6udvs X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0b82/JVQc8yizEbM/NQQB7swuJMcmwOr+euns8VvsL9odeKEau0Xo1+DL06m?= =?us-ascii?Q?+bhIFW53w0twr6837JhXEyikSP0xd9S2fgmJ8jk94GZPyH6Sy4SyvE3O4+TI?= =?us-ascii?Q?gJDNoAb3Dwd7E8gP1S4lp9y2/TCEeaZfkBJeD7KbV3kS1lBhqToxLBKPIOeX?= =?us-ascii?Q?8stfcrMzX7VLp7vb6D4IeOyYqWUO6C6LqTFQQ+868wV6rhz84aL5ocAhNXf2?= =?us-ascii?Q?2bcFc1O1di42UNaPms4u/SFcTOMGmmP4ukcSvf5AqqaeAotUJeNtlHD8K0UI?= =?us-ascii?Q?jSAQv5sNAdGyHNNO0frnIyi4RBK5SCwAFRJRz421ce3UlmLoqTcJuTO/+u37?= =?us-ascii?Q?k1JNybfGHcNDHIAwFWbczj+0rxNYBhaLy2vdrewhUElpDtMlNjWGfkGdVsOY?= =?us-ascii?Q?+GN/0Rf6oZ/+qrnlcfTtGiH5csYpXuBB9xVOnyu3Ww6zEyIfwLNLcznBBOfg?= =?us-ascii?Q?G19idN/DtpzzlYom6uV15v1pjnZ1KBaGpumGvFBkZvKkOjX/fE7SnPhlWTJw?= =?us-ascii?Q?tUq0220Z5XOrvCQ6RtCPYPfx2IeduXYWcPh7Bb/K6EkDmmeps8B1Hil8li2B?= =?us-ascii?Q?5mqUubtFIlJM0KBKiX83/OYlSCtNha52rPRZ8DCkVhiAZU7AYZ4ut5h9JHCE?= =?us-ascii?Q?cEYGb2/vXix2s8irl12A4VuxiwFeip9qyd1e56YI/ILvyNMGS+PPYQYGckMp?= =?us-ascii?Q?Ncu0SpO/kVjnNBEqF5S7WwUhT5Sg+zuCD6Jf3Kr5bLfUnUFuHVqNXbP8ZtZv?= =?us-ascii?Q?BjEhRqUsG3Qyv9qOI1/iLwejdMRgazd2hsIoQIIf80KpJC3qaRK5A9sfCNgz?= =?us-ascii?Q?tfD4XbsWdP5A9z2A0bmdTy+3rsYqceWNaSBoLJn4O4MfZ5hSaW3mPeLc5EII?= =?us-ascii?Q?PBGJGWsnfQWySL5q1m+ZFmNYU2KdDdp3Yl/6Q3WaXz7WpcNwdzFm8vnGGlA7?= =?us-ascii?Q?LvGWgUpDpnHF2kwtWPefb4jFWayz/ditEzC/jAqgEZOxuMH8FSClbtB1KkJS?= =?us-ascii?Q?8ulJ/7MAIsgSLyYvOSToKB1Fn+uDgDLtM6Jx/QwTIFpRwKKM+TrpQBAFkXKt?= =?us-ascii?Q?HvzusJpdYoFNnUOrdSdxCug3+xl/b2zqCwTSYQfg2XRHoanRRbTu91prJKkP?= =?us-ascii?Q?yQrGZcBijge41Bo/gsrrJHMp2n9kJOF4UcHg0u1g5S7sPPKMOuf4p1a2/YZt?= =?us-ascii?Q?nkUeACRg3x2J737cxIoRcAcm4zDT832HzZxQeRvY3NL6UN+qxWRh5HRWEIkc?= =?us-ascii?Q?f7GeN1xCt2hSCClRyk42mcZTb1SgpDIVpDoaMddD8A=3D=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 662579ac-b102-40ae-c8d7-08db860dbc45 X-MS-Exchange-CrossTenant-AuthSource: CY4PR03MB3159.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2023 15:02:55.9471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6801 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, First of all I'd like to apologize for dragging this out and missing some details. If I paid a little more attention this would likely be done by now :P Tassilo Horn writes: > Why do you ignore the error altogether? So we have 3 scenarios: mutool not installed, mutool failed, and mutool is successful. Your patch would send a message on setup when mutool fails, but would not say anything in the other two scenarios. My patch would be silent on setup. Both patches would give the user an error if they actually try to use imenu. In my opinion, we should either be completely silent (on setup) or send a message when imenu is set up correctly. If you wanted to send a message when it fails I would accept that, but maybe we should consider also sending the message when mutool is not installed. Also, we have a macro 'with-demoted-errors' but we are missing a 'with-demoted-error' macro that lets you specify what error to demote. It would be cool if you converted this part of your patch into a definition of a 'with-demoted-error' macro. --8<---------------cut here---------------start------------->8--- + (condition-case imenu-error + (doc-view-imenu-setup) + (imenu-unavailable (message "imenu support unavailable: %s" + (cadr imenu-error)))) --8<---------------cut here---------------end--------------->8--- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 11:24:51 2023 Received: (at 64516) by debbugs.gnu.org; 16 Jul 2023 15:24:51 +0000 Received: from localhost ([127.0.0.1]:48410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL3cA-0007Tq-3N for submit@debbugs.gnu.org; Sun, 16 Jul 2023 11:24:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qL3c4-0007TY-Tq for 64516@debbugs.gnu.org; Sun, 16 Jul 2023 11:24:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qL3by-0007vO-4j; Sun, 16 Jul 2023 11:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Subject:References:In-Reply-To:To:From: Date; bh=nEYwl0uApIojL9hDD3veXgYUTz/ZV2iTZRVCDY+2x6Y=; b=oDMUpnfr+F3oDWqNbn8Z 8UU1aThjAbdxn/EdY4S1UDo7KY0HlZD3jKpWMZu77ry8syKb/aDimerZPHeTXWHyASae8Bt5COOLw bL4Emy5O5u85585MIGxK5TBlEJeF7beEST6GIn778r115oWaIDG8HFHLc4Cnkl7A8/sFZoLd00I/H LkfGFQxYmw/Zo3VrWTy0SBqKXVldPTqeyxaxSh59YaLbiZlhVDba6NdkUii3z4gvjHT8xsbIIwpb/ aDMZMM6nt1rGtRDDm7gU5pQXgWrvKR/wibT1apKc1S34x0CGoDzvccUrixMIAsMgWpGyW2/ZO7/Z2 5kUeZtI8SrpK9w==; Received: from auth2-smtp.messagingengine.com ([66.111.4.228]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qL3bx-0004hF-R4; Sun, 16 Jul 2023 11:24:37 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailauth.nyi.internal (Postfix) with ESMTP id 9C9FC27C0054; Sun, 16 Jul 2023 11:24:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 16 Jul 2023 11:24:35 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgedtgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvvefkjghfufggtgfgsehtqhertddttdejnecuhfhrohhmpefvrghsshhi lhhoucfjohhrnhcuoehtshguhhesghhnuhdrohhrgheqnecuggftrfgrthhtvghrnhephf duhfejjedvtdfhteejtdejgeeiudeiueduteeuhfffgfehhedtvddvheeugeeunecuvehl uhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhrnhdomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeeijeefkeejkeegqdeifeehvdel kedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrihhlrdhfmh X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 16 Jul 2023 11:24:34 -0400 (EDT) Date: Sun, 16 Jul 2023 17:24:31 +0200 (GMT+02:00) From: Tassilo Horn To: Morgan Smith Message-ID: <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> In-Reply-To: References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Morgan, my reasoning was to have an explanation in the *Messages* buffer for people= who ask themselves "where the heck is the Outline menu item"? If it's done= by condition-case or with-demoted-errors doesn't really matter. Feel free = to adapt it to your preference. Thanks, Tassilo 16.07.2023 17:03:05 Morgan Smith : > Hello, >=20 > First of all I'd like to apologize for dragging this out and missing > some details.=C2=A0 If I paid a little more attention this would likely b= e > done by now :P >=20 > Tassilo Horn writes: >=20 >> Why do you ignore the error altogether? >=20 > So we have 3 scenarios: mutool not installed, mutool failed, and mutool > is successful. >=20 > Your patch would send a message on setup when mutool fails, but would > not say anything in the other two scenarios. >=20 > My patch would be silent on setup. >=20 > Both patches would give the user an error if they actually try to use > imenu. >=20 > In my opinion, we should either be completely silent (on setup) or send a= message > when imenu is set up correctly.=C2=A0 If you wanted to send a message whe= n it > fails I would accept that, but maybe we should consider also sending the > message when mutool is not installed. >=20 >=20 > Also, we have a macro 'with-demoted-errors' but we are missing a > 'with-demoted-error' macro that lets you specify what error to demote. > It would be cool if you converted this part of your patch into a > definition of a 'with-demoted-error' macro. >=20 >=20 > --8<---------------cut here---------------start------------->8--- > +=C2=A0=C2=A0=C2=A0 (condition-case imenu-error > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (doc-view-imenu-setup) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (imenu-unavailable (message "imenu suppor= t unavailable: %s" > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (cadr imenu-error)))) > --8<---------------cut here---------------end--------------->8--- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 14:40:28 2023 Received: (at 64516) by debbugs.gnu.org; 18 Jul 2023 18:40:28 +0000 Received: from localhost ([127.0.0.1]:54300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLpcZ-0007RY-KK for submit@debbugs.gnu.org; Tue, 18 Jul 2023 14:40:27 -0400 Received: from mail-dm6nam10olkn2098.outbound.protection.outlook.com ([40.92.41.98]:38817 helo=NAM10-DM6-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLpcV-0007RF-Vv for 64516@debbugs.gnu.org; Tue, 18 Jul 2023 14:40:25 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=daCoTkFWIK6O+Ty3reDiQhwW0bWF26cKUvjI0SAFhCzqBYLuQM8jbo4bPHEMTFf0FuDPqqdLSSPnXDE0NRau8fLbhS0jxFnCizE5sBvLFCTzHv4GjiKjHGzMUInS92cc2DizVsBormTIEbJjLcDD7B9HYiWcCoYqWgY/3wM/llYNY50L/BqthofsM71jwYUg6CbftJP6q8cnR3TtaPw/AC88Ayf5p0tjUTy+FtOyj8Cbw7TbKi8av4nCxIOjM1TypsrMmdOo+wNvm8DTF6yRIWkRFEIxG56XAppvmmtgKcbJSnf6PZNf/Tci7OHfoacADVvcpBxE8lCl/E+TtCO7Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KQumKrVUFhzQuPR2rmBu8P/oSOVgAY2PCAJ1/ub8O4s=; b=iRo5LHKteJUIK64P41JXsjFoDvxdzl188f3tR4Hil9ZNJD7XiH+Y+WBBtMQww7eseH5pClgbch2kFrpPilu1GoZvxdnTqjvg21b0dLbKHWeFeeeJnhUKhaYD5QiafZxORQfDlXuBrjYjUjBamKEb4U7ICsjkA6tzdBS6H5iiuut6tX9seB+dOHk1QwPtxHV2nZuVZsY5O8fiJTttmP0EFwSBPPHOTZONgIiZS7IkHBEHFfrZ9K2LNErhFAmSbEpHu64KWoo8i53DvUFKt4vp9iIM6qkPrVXFqIRHqDzqOI/izFQd9yh3MA+utFxxCTolmlI5+Rr6bBTC3mQ6nLwwHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQumKrVUFhzQuPR2rmBu8P/oSOVgAY2PCAJ1/ub8O4s=; b=tF04aYoHYUNT+Wlc1uFbjX12Eat8LaMaAOz5AHE5IBwusmgd7GVlcUv1LdZvV9uT5jfofm8L8sHQ9X2Hvh5W2I8X65MAcDXqQr6PclLReQ0ox77sEXJX1oF32fyNs0bBN9TEts/VC9aNAOdHBx96u6/uK33ouaqEzagkEM30WJ5kgucNnxW06+AUqpctkeYhwa+wpONQIhOotuJczIQONwKEFjkYxAmOGpUrEBSHjmtuNQ23bLaugL0uYlD3T7p3eFoOq8n5diPOsXOh8yysZUjut7FC3pS0WFlIdlimlO65FBElQEhZWpH9218mgs7k4L1vRWgzQgJ52+Fk5gH2RA== Received: from DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) by BN9PR03MB5996.namprd03.prod.outlook.com (2603:10b6:408:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.32; Tue, 18 Jul 2023 18:40:16 +0000 Received: from DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::b2fc:59fe:bb07:4d95]) by DM5PR03MB3163.namprd03.prod.outlook.com ([fe80::b2fc:59fe:bb07:4d95%4]) with mapi id 15.20.6588.031; Tue, 18 Jul 2023 18:40:14 +0000 From: Morgan Smith To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> (Tassilo Horn's message of "Sun, 16 Jul 2023 11:24:39 -0400") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> X-Hashcash: 1:20:230718:jao@gnu.org::mcIFGV9F+04Gjmn+:0O1N X-Hashcash: 1:20:230718:tsdh@gnu.org::bta/ZeXYTvwaeLa4:1D2U X-Hashcash: 1:20:230718:eliz@gnu.org::6GisvJo3N1+W9Zyl:4BlR X-Hashcash: 1:20:230718:64516@debbugs.gnu.org::vB71GtYOIAeCGp9s:2DVT Date: Tue, 18 Jul 2023 14:40:12 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-TMN: [Jjh3wHj/uTmFbCyfiOduG4q7YoDF3w60] X-ClientProxiedBy: YQZPR01CA0089.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:84::9) To DM5PR03MB3163.namprd03.prod.outlook.com (2603:10b6:4:40::24) X-Microsoft-Original-Message-ID: <87o7k9rrlf.fsf@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR03MB3163:EE_|BN9PR03MB5996:EE_ X-MS-Office365-Filtering-Correlation-Id: eff98e55-6c90-4f32-0001-08db87be6cf3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tx1FxJhbjHpGIsB5T4i+VIQnvLalbvGOsrMnV+9ZrDkV0CtPzd6/SDnyglY9gkKr+EoozEUC0LzedqQZhtG0qoaAOaRnsioaYsN8Ssy7TLAK0fYg54rb1iU+87iYKfhcNKFQjStqs0pIwZsoPnhoZoX2a2ltSXrPClkngItn2Q+1pZ/uqADjrXSCWcCDxcGZhn9aM4l2jp5UXQN6pHRcpvJodb3zm7f0V0Z4kGwtN5/kGMRHGWUTeghPufOnYXqGCoRreBdOr7qxQGOHvHgJ8p6f4locPc5CaxNNPx7GQZa78hAioAM6rMzhTRpGyqbqLzO6K7Qn5kJmRDmbW5oBUuAMD4hbLiy3Bz7C0+eOyqZ3aYPz98WUTv1w/w7m5DGQlIWGHPGNsdFH2tRBYzuaeNV8uNF3niFHck9tNARlrChT4Umm3DegzuJfMd0f0p9HGbtWJQydZs3QT6ARqBhaLmjs1x//Tx0o5loON+CfbiZdBawdgIb7wC5YPUpwsKnEgyD2Cp4+c28jV+W0EmtrDsdlBDDXt3lSmzEGgiLyOcaenDxaon2bCq6SJqaecwQ/ X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GNjrLy2etbXIoqjddQ9dHX/XpwzYrTx8ehq7Sb9toFGIWOcL6hsrR+u+3Bkn?= =?us-ascii?Q?f4k7MYtCkeVn2pS4YYqmp2Q1iqYwVh1E84+2ehsJDdVM28GMnGobgzSgJDZF?= =?us-ascii?Q?rt1uBcMdGPvx3p3HPWdFbrJH/UWUSCR0J5M4jUWs3f1ecK0GeoCD7pTCjC6C?= =?us-ascii?Q?FoxzAa7T660FuTo9mONsMZ6MVvsndkWQxr7tLZHRIi+qRFsVLc+tXHSabtuu?= =?us-ascii?Q?EGKZ5Z66CGDKgevdsDSmS78L+MylD2er/pHZdeiGeuROr64dr9HwfqZladNu?= =?us-ascii?Q?Apnb9Cf+Y50Z/hk8Vil4e6dV5diZqUcNtoSbS/4/rCx2ZH6b/FlILWXH+6FI?= =?us-ascii?Q?n/rshIGaLTIbzlDO5qmEw5tq+DnpXw1MMTxbRAOHKw6G1Ts48699ctQcxpd5?= =?us-ascii?Q?hqjq+PCIOxaBeBBjE7lYrjleyRW3oLGMaKn7ghVEH72rbfPfHQLOGMMuI0dj?= =?us-ascii?Q?9GX6vErccvO8IFT1YEcNJLRKoxXDVs8f1SjR1H949zz0VgNYPdt3clA3iOtp?= =?us-ascii?Q?EJfho/uRfqlUdIDQfZk6F5Uldmx5Y4fhe79/eoO7JJTPXxMTSGoN0QqGbAIJ?= =?us-ascii?Q?uRQrzNRWFJ2Nj7EoRgP5cS6XPlySAFx9nphT3u7rZp2aXcFmO5iBuR67zDD6?= =?us-ascii?Q?FDFrltWTpdUN1DYX8k+7Ly0jY5u9/IZasmfSmcOWty3bnJIVdRvGyI/jCKKr?= =?us-ascii?Q?o4FfNn8RPNnbp18z/KOba7cfSCNnF8MZYWybEE9M0S5FFgsSgacMQ7RGrIMS?= =?us-ascii?Q?WCxRcVFAwie3l9ATneeScbmFMtSOmm9c6U8FIqTc1oPm0v4aJQbh0kWzQ5AL?= =?us-ascii?Q?a8wI1fRPJTSCV1P37w5HnHVk714T9FG0gkWFCQ8aggAE0Y4W6qzmpX+u0/JS?= =?us-ascii?Q?cC6qgcvO1SjBFZPdq1EOAMkcAYRbarM8Sfq/Ri+T7bN4Wvn6WXy3FTr6iKvU?= =?us-ascii?Q?vGfql3Tmxh8I0CBu3olQU+nE86Gw7c61WCzYGtAnh6y61LXWi0dmV1cFgA8u?= =?us-ascii?Q?CE/HsE1dSl4LR4jpwGxQV1m43Zl/3IXc2ZQW/b8AkRenAkObrcMxPtirIG9e?= =?us-ascii?Q?PuiQhv03fmO6wkJv7gWMoIdnOfc/ovjoSo1Cs+mCsx2oFYM8VKZY+oR7cmNe?= =?us-ascii?Q?6eXom6toMBF+YXKGdkYRqZM9N5ClnPjSWHzqmuzRgPy0jc6Bc6PiuIQBdw80?= =?us-ascii?Q?86tmGZnCSr46FzULTM9Lfa83ISejra1kDoQpZ8COTgdL29I2DuGkA+Am/Tw?= =?us-ascii?Q?=3D?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eff98e55-6c90-4f32-0001-08db87be6cf3 X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3163.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 18:40:14.9055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5996 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tassilo Horn writes: > my reasoning was to have an explanation in the *Messages* buffer for people who > ask themselves "where the heck is the Outline menu item"? I didn't think of users using the toolbar. I think you can go ahead and use the patch you sent a couple emails back. I'm happy with that one. Thank you for all your help! Morgan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 15:21:14 2023 Received: (at 64516) by debbugs.gnu.org; 18 Jul 2023 19:21:14 +0000 Received: from localhost ([127.0.0.1]:54322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqG2-0008W7-Cr for submit@debbugs.gnu.org; Tue, 18 Jul 2023 15:21:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLqG0-0008Vu-6p for 64516@debbugs.gnu.org; Tue, 18 Jul 2023 15:21:13 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qLqFt-0003tr-CQ; Tue, 18 Jul 2023 15:21:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=r7Dj9Ih0UUTq54S28p4OPCy9JDD/b44YqOgPLsMUTxY=; b=O8H0s10ZVySzbN RB1w1+vSoFxDzd1D/ya7r5ewX1guQF5ddCsF62fwPK3RIx34zIC5ZHWqV8QrOhWQyD3AEMNfKBcUz 3zOKBDavmVt/pDKnuPj0Es0LBf5Wdop1XlfsLmhg/I0yFuaxC+XEoDHsq6VL9fzzga0yGZSbvniff /pm58JozS9slIfwN9Gk/JcKL5tEj6+0rXtu2i3MsSi3SvsW42z91gUis0Aryz1we67gFVacpL/Rle f5lZUK6X6TMamQ7E5zM1Y7j2HSEAWx04ZKT7fA5i7G2ttZ3svHdgHhkk+kg31MZrpkPD+FD/cKx4S GKPswXxSw+6g8kbL2T1A==; Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qLqFt-0007ZV-4R; Tue, 18 Jul 2023 15:21:05 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailauth.nyi.internal (Postfix) with ESMTP id B205927C0054; Tue, 18 Jul 2023 15:21:04 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 18 Jul 2023 15:21:04 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeeggddufeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesmhdtreertdertdenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe eihfetffeiledufeffffekveegffehgefhieettdejgefgveeiueduveehffffteenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Jul 2023 15:21:03 -0400 (EDT) References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> User-agent: mu4e 1.11.9; emacs 30.0.50 From: Tassilo Horn To: Morgan Smith Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Tue, 18 Jul 2023 21:14:35 +0200 In-reply-to: Message-ID: <87jzuxrppg.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Morgan Smith writes: Hi Morgan, >> my reasoning was to have an explanation in the *Messages* buffer for >> people who ask themselves "where the heck is the Outline menu item"? > > I didn't think of users using the toolbar. I've heared there are three of them. But we are talking about the menu bar of which there are a good dozen users. :-) > I think you can go ahead and use the patch you sent a couple emails > back. I'm happy with that one. Alright, I've amended your patch with my slight modifications. Eli, feel free to "git am" it where you see fit. It should apply both on master and on emacs-29. Thanks, Tassilo --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-docview-imenu-check-return-value-of-mutool.patch >From 2a297bc4c1de575f45fa7fdb9e2b9ea2f23294a2 Mon Sep 17 00:00:00 2001 From: Morgan Smith Date: Tue, 11 Jul 2023 14:08:24 -0400 Subject: [PATCH] docview: imenu: check return value of 'mutool' While 'mutool' supports many filetypes, 'mutool show' only supports PDF files. This would lead to cryptic imenu errors when opening other file types (like EPUB) since we would parse the error output. During my testing this caused 'imenu--index-alist' to have a value of '(nil). * lisp/doc-view.el (doc-view--pdf-outline): Error when 'mutool' returns an error. Use 'call-process' to get the return value and remove the call to 'shell-quote-argument' as 'call-process' doesn't want any escapes. (doc-view-mode): Handle possible error from 'doc-view-imenu-setup'. (doc-view-imenu-enabled): Remove superfluous (and ... t). (doc-view-imenu-setup): Remove check for mutool already ensured by 'doc-view-imenu-enabled' being non-nil. --- lisp/doc-view.el | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index b14655fb274..847601872f5 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -147,6 +147,8 @@ (require 'filenotify) (eval-when-compile (require 'subr-x)) +(autoload 'imenu-unavailable-error "imenu") + ;;;; Customization Options (defgroup doc-view nil @@ -214,7 +216,7 @@ doc-view-mupdf-use-svg :type 'boolean :version "30.1") -(defcustom doc-view-imenu-enabled (and (executable-find "mutool") t) +(defcustom doc-view-imenu-enabled (executable-find "mutool") "Whether to generate an imenu outline when \"mutool\" is available." :type 'boolean :version "29.1") @@ -1910,9 +1912,10 @@ doc-view--pdf-outline (let ((fn (or file-name (buffer-file-name)))) (when fn (let ((outline nil) - (fn (shell-quote-argument (expand-file-name fn)))) + (fn (expand-file-name fn))) (with-temp-buffer - (insert (shell-command-to-string (format "mutool show %s outline" fn))) + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) (goto-char (point-min)) (while (re-search-forward doc-view--outline-rx nil t) (push `((level . ,(length (match-string 1))) @@ -1961,7 +1964,7 @@ doc-view-imenu-index (defun doc-view-imenu-setup () "Set up local state in the current buffer for imenu, if needed." - (when (and doc-view-imenu-enabled (executable-find "mutool")) + (when doc-view-imenu-enabled (setq-local imenu-create-index-function #'doc-view-imenu-index imenu-submenus-on-top nil imenu-sort-function nil @@ -2236,7 +2239,10 @@ doc-view-mode (setq mode-name "DocView" buffer-read-only t major-mode 'doc-view-mode) - (doc-view-imenu-setup) + (condition-case imenu-error + (doc-view-imenu-setup) + (imenu-unavailable (message "imenu support unavailable: %s" + (cadr imenu-error)))) (doc-view-initiate-display) ;; Switch off view-mode explicitly, because doc-view-mode is the ;; canonical view mode for PDF/PS/DVI files. This could be -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 12:05:43 2023 Received: (at 64516-done) by debbugs.gnu.org; 20 Jul 2023 16:05:43 +0000 Received: from localhost ([127.0.0.1]:59560 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMW9u-0006QP-SQ for submit@debbugs.gnu.org; Thu, 20 Jul 2023 12:05:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qMW9r-0006Pr-2D for 64516-done@debbugs.gnu.org; Thu, 20 Jul 2023 12:05:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMW9k-0006lw-Ik; Thu, 20 Jul 2023 12:05:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7NeCZuDKPS4YIsheXa+WCBdIpgRsMq3JIVLdyxIU8sA=; b=bWlHLyCzH8yz VNT76Aw2F2rOthU0SlbbmI9NpPJTyfHFCcVoZykqOtuOWNA4vf0Od7IDTaT9CN1hy9gyjLQ+mvGLX 7i2QJBYzhHI0WwqEmX8ZBrKxeW8HjXj/dh38E0QrBT47AO7sCTi4Fp36MpFs04z/ctNurheIZA+6F 0AK8Y59TRGVUFDn2+zM7rLJZE95t+TZrvIUpwRvZPbm3hI7bnpYLXW92R2ztKsY2ebeDP6+yrCFyW kNZGohtC4fIF8JkCCRobvnI73ppvS+VI5xONrO4sV5ISvBbxMgDp01xh7DAhagA0knBjml7HAoDQe oV11hdTGl+2akiNYkzG+Zw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qMW9J-00040Z-DU; Thu, 20 Jul 2023 12:05:30 -0400 Date: Thu, 20 Jul 2023 19:05:38 +0300 Message-Id: <83bkg636wd.fsf@gnu.org> From: Eli Zaretskii To: Tassilo Horn In-Reply-To: <87jzuxrppg.fsf@gnu.org> (message from Tassilo Horn on Tue, 18 Jul 2023 21:14:35 +0200) Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> <87jzuxrppg.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516-done Cc: Morgan.J.Smith@outlook.com, jao@gnu.org, 64516-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Tassilo Horn > Cc: Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org > Date: Tue, 18 Jul 2023 21:14:35 +0200 > > Alright, I've amended your patch with my slight modifications. Eli, > feel free to "git am" it where you see fit. It should apply both on > master and on emacs-29. Thanks to both of you. I've now installed this on the master branch, and I'm closing the bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 06:14:25 2023 Received: (at 64516) by debbugs.gnu.org; 28 Jul 2023 10:14:25 +0000 Received: from localhost ([127.0.0.1]:43741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKUL-0006sk-Bn for submit@debbugs.gnu.org; Fri, 28 Jul 2023 06:14:25 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]:44484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKUI-0006sV-0j for 64516@debbugs.gnu.org; Fri, 28 Jul 2023 06:14:23 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-99b9161b94aso279045666b.1 for <64516@debbugs.gnu.org>; Fri, 28 Jul 2023 03:14:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1690539256; x=1691144056; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZW/iFjbKqOm3sPwpNiCqwIeX52XtUQsk0EGwarRpW3o=; b=buQYCD0YqECPxXw/aidEv6GPgbFt10X36f4Y8k/kZhShAs/d3er8UdRXJtYo7j+QHI CXKPNKjWZAT3L92cWDZuP3ZWP9CiXEoB2eJJlFMm3HNJX832STEGPAU+zfNYWS7MCG1i URmGd8hkXuhsbyEyNTPcj3WF07maf7Samtxar9Rms+IsvRknBcJndqEhpwmcGD3A0GFz LK/XcOYCfZ/me5tCrAqYrqqbiQm6Oeyhyy4DfLL+WjT4PGOC2Rx3ciYzQqgvQ055vyXp qZrqa/Ce8OnWBP7guHUWsOfm3lEp7FaeED0fwYapQHOEBpVNMVinYU2dh5Ussn18n+lX Mi0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690539256; x=1691144056; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZW/iFjbKqOm3sPwpNiCqwIeX52XtUQsk0EGwarRpW3o=; b=bP22So9v32GI4hVG3XubPoBiAdCtxumw4tfChLqKOTaiNfzQkDF7RjdUcSfbpPW3rf eD9+VkjGTf4oIqZk/fBTt76atA1ye2XywglWBLikg3ipAj0k84cJ/YS85TSPykcUBWs2 qq2A7W6QdNUdvAmWEEFQjhNHm4MyuzCaZBDZ7cyEEzLl8Zcn6ppaUFEtg4Ln7BHrc02p yf5iyWIYmWKVHM9/pw6X0PGESarXFnu3RYj4aSzKUzo0ZquQDN1KP+FgunxQ5kKnXqtO Gi2kLnt0ssOlkENWakrcWxSZOwQ2jXIyC3S6jYC+NuVOzuw96mQ0X5u3bmsiLwk8kFBA hWSw== X-Gm-Message-State: ABy/qLYIon+FgZTZ5/+GIk/zgh3lHu+P8IKJgdjD5UUFIzZJDgKVzTZg 1VHiJe/CcD6MtjWbvz0Rg9vpHw== X-Google-Smtp-Source: APBJJlGXB0RJOnuy/Y/7Y98sRXXbRNxxJBXOpsO1C/8WnHYFMemZheWVTeWrLCg6R8zXX3dtXugKYg== X-Received: by 2002:a17:907:a087:b0:99b:e09b:17ef with SMTP id hu7-20020a170907a08700b0099be09b17efmr1984705ejc.71.1690539256075; Fri, 28 Jul 2023 03:14:16 -0700 (PDT) Received: from localhost ([2001:620:618:590:2:80b3:0:e5c]) by smtp.gmail.com with ESMTPSA id mb5-20020a170906eb0500b00997cce73cc7sm1883777ejb.29.2023.07.28.03.14.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 03:14:15 -0700 (PDT) From: "Basil L. Contovounesios" To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: <87jzuxrppg.fsf@gnu.org> (Tassilo Horn's message of "Tue, 18 Jul 2023 21:14:35 +0200") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> <87jzuxrppg.fsf@gnu.org> Date: Fri, 28 Jul 2023 12:14:14 +0200 Message-ID: <87edksfimh.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Morgan Smith , Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > diff --git a/lisp/doc-view.el b/lisp/doc-view.el > index b14655fb274..847601872f5 100644 > --- a/lisp/doc-view.el > +++ b/lisp/doc-view.el > @@ -147,6 +147,8 @@ [...] > + (unless (= 0 (call-process "mutool" nil (current-buffer) nil "show" fn "outline")) > + (imenu-unavailable-error "Unable to create imenu index using `mutool'")) Is call-process guaranteed to return a number? Would eq/l be more suitable than =? [ The same also appears in doc-view--revert-buffer. ] Thanks, -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 06:24:45 2023 Received: (at 64516) by debbugs.gnu.org; 28 Jul 2023 10:24:46 +0000 Received: from localhost ([127.0.0.1]:43757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKeL-00078Y-Jy for submit@debbugs.gnu.org; Fri, 28 Jul 2023 06:24:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPKeG-00078F-Ld for 64516@debbugs.gnu.org; Fri, 28 Jul 2023 06:24:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qPKeA-0004Mv-P5; Fri, 28 Jul 2023 06:24:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-reply-to:Date:Subject:To:From: References; bh=KYtoUmJDr+pdXGWnz0yDwAjsiAEXi+GyzZm9la0acnU=; b=EjFHdrvjxwcajU q5mw+JfKxwiPT4VjVyL9uNbeOJcKW5FkKpY2x+b6MwFGynLhiY6zXH0CUwE79r7MMJLdWAaXtWvYy 0syOE0gdUbiEWYCP4LLaTQFABpf6OvifF8QY2hDJQaxU3m+0glgBYZ/cPTiubAxpqihLZg1VkdEnr N3dziEcYrrjxkv5mAYkA6XPFTYX5BcxoYEZk6CJUWOLoBZQTFaEwOgL/U+4ChJj38GV1D7pv0HZ07 Pf0bRJsKmgQLo21qhOzqX7EYQXZ6O0j9dY5YDXdxBWmTm7uJZr7DLrZuf6VW4y0iMn+k6SD5fQ7kX 50gLV8rgCNepy9cUt5cA==; Received: from auth1-smtp.messagingengine.com ([66.111.4.227]) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qPKe8-0001S5-J6; Fri, 28 Jul 2023 06:24:34 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 1363827C0054; Fri, 28 Jul 2023 06:24:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 28 Jul 2023 06:24:32 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrieeigddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpehffgfhvfevufffjgfkgggtgfesthhqredttderjeenucfhrhhomhepvfgrshhs ihhlohcujfhorhhnuceothhsughhsehgnhhurdhorhhgqeenucggtffrrghtthgvrhhnpe fgtedtudeivdfhfffhfefhvefhuedvheejjeefleffheekffeutdfhgfejiefhgeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhorhhnod hmvghsmhhtphgruhhthhhpvghrshhonhgrlhhithihqdekieejfeekjeekgedqieefhedv leekqdhtshguhheppehgnhhurdhorhhgsehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: ib2b94485:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 28 Jul 2023 06:24:30 -0400 (EDT) References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> <87jzuxrppg.fsf@gnu.org> <87edksfimh.fsf@epfl.ch> User-agent: mu4e 1.11.12; emacs 30.0.50 From: Tassilo Horn To: "Basil L. Contovounesios" Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported Date: Fri, 28 Jul 2023 12:19:20 +0200 In-reply-to: <87edksfimh.fsf@epfl.ch> Message-ID: <87bkfwtjtu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64516 Cc: Morgan Smith , Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: >> diff --git a/lisp/doc-view.el b/lisp/doc-view.el >> index b14655fb274..847601872f5 100644 >> --- a/lisp/doc-view.el >> +++ b/lisp/doc-view.el >> @@ -147,6 +147,8 @@ > [...] >> + (unless (=3D 0 (call-process "mutool" nil (current-buffer) ni= l "show" fn "outline")) >> + (imenu-unavailable-error "Unable to create imenu index usin= g `mutool'")) > > Is call-process guaranteed to return a number? > Would eq/l be more suitable than =3D? Good question, the docs say: If DESTINATION is 0, =E2=80=98call-process=E2=80=99 returns immediately w= ith value nil. Otherwise it waits for PROGRAM to terminate and returns a numeric exit status or a signal description string. I guess if mutool is killed externally while emacs runs it, it could be such a "signal description string" in which case eql would be better even though that situation seems unlikely. I'll change that later. Thanks for the heads-up, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 07:22:35 2023 Received: (at 64516) by debbugs.gnu.org; 28 Jul 2023 11:22:35 +0000 Received: from localhost ([127.0.0.1]:43908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPLYI-0000Vp-Tm for submit@debbugs.gnu.org; Fri, 28 Jul 2023 07:22:35 -0400 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]:52514) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPLYG-0000VN-E8 for 64516@debbugs.gnu.org; Fri, 28 Jul 2023 07:22:33 -0400 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fb73ba3b5dso3334923e87.1 for <64516@debbugs.gnu.org>; Fri, 28 Jul 2023 04:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1690543346; x=1691148146; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=22a/PTXA+O5J3j4GsTL86MHQiiktkNIxqiDv1/OywzQ=; b=Zb2/toVXTbwuFj11Hqt/z+kDU1SN57wz1yNpFDPIdb12MSUxrGhJFzl2FDNY345Cag 3A9e8bKHuacSqQYWgfTxP+tEQcnOn7Mh/VSM0tndGw8pzeXyU1CFs5y27ZT979OqgZ7n /seqOV4oWjzycFU8SV3m1wi+fIq17LXrWvkqLsiOMtq8zZkx068Vkd4MXKInbwtU5kaw 8yf53Fj27/dr6FxHW65MDVMpGHhENEMKIWkupCvgm3DsZpK9DK09uOLq9aYhcZaqbo1o kLw3Qd8KQfw23Ipn3AQUVN8i63JL2CiZs6MLTbnvMhn/8z+cYKfvIre5J5iayLuROjUe raxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690543346; x=1691148146; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=22a/PTXA+O5J3j4GsTL86MHQiiktkNIxqiDv1/OywzQ=; b=I3SjlNKSOcC06aEYkGWDyrRTaInRudpyK0v2YSI0YhSUe9woEcbFaNOmAyuLIhQgi8 gQcRZ3mH7aDPvFD+OZLQ2lVvvED/Ty/7ZBv/lbD6BsyDeG4MVNCgzWJdbIOseH3Aohx3 22SZrn3/ZE6IQQInTWrb9yq/upKzVQfc/lUiY+w8ur6RidJo8wjTzAMl3XoYjuuhu+IV 01KETnogQGd8d79u4mk7n8BdSLt2tsSkklQgUcQX167WD7Ls1/EhzvHCAaAdjWllTaKg PXLa9HxoLzm+EQFW4af2J8ZGFsEejmuVZ2gCIgAl2Qt02AcY05eIx2QBMIHVU1lph5NE 63Mw== X-Gm-Message-State: ABy/qLbCGzLc3N72Y3EHuBKv7zYNk0loJuGt0nNmOJ/tQkGx2Xj+gUme mthO/sbtLKkEnrTD8SFLLReBKw== X-Google-Smtp-Source: APBJJlFqtiee++1cgD/57Z2kMkXX9uSBsTEF+FSOOvbMZsqtUBC4pyzAYTE1585UcXCD+SB2fP/cYA== X-Received: by 2002:a05:6512:360a:b0:4fe:de3:9fd1 with SMTP id f10-20020a056512360a00b004fe0de39fd1mr1291355lfs.36.1690543346366; Fri, 28 Jul 2023 04:22:26 -0700 (PDT) Received: from localhost ([2001:620:618:590:2:80b3:0:e5c]) by smtp.gmail.com with ESMTPSA id m26-20020aa7c2da000000b005221f8fe4b7sm1692985edp.11.2023.07.28.04.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 04:22:25 -0700 (PDT) From: "Basil L. Contovounesios" To: Tassilo Horn Subject: Re: bug#64516: [PATCH] docview: Only enable imenu when supported In-Reply-To: <87bkfwtjtu.fsf@gnu.org> (Tassilo Horn's message of "Fri, 28 Jul 2023 12:19:20 +0200") References: <83lefqdatb.fsf@gnu.org> <878rbpxybj.fsf@gnu.org> <83ttu5d2h4.fsf@gnu.org> <87jzv1c8vg.fsf@gnu.org> <04eb26ce-b33f-4ebf-9d9d-f1846fead2ed@gnu.org> <87jzuxrppg.fsf@gnu.org> <87edksfimh.fsf@epfl.ch> <87bkfwtjtu.fsf@gnu.org> Date: Fri, 28 Jul 2023 13:22:23 +0200 Message-ID: <87cz0ce0wg.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64516 Cc: Morgan Smith , Eli Zaretskii , 64516@debbugs.gnu.org, jao@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Tassilo Horn [2023-07-28 12:19 +0200] wrote: > "Basil L. Contovounesios" writes: > >> Is call-process guaranteed to return a number? >> Would eq/l be more suitable than =3D? > > Good question, the docs say: > > If DESTINATION is 0, =E2=80=98call-process=E2=80=99 returns immediately= with value nil. > Otherwise it waits for PROGRAM to terminate > and returns a numeric exit status or a signal description string. > > I guess if mutool is killed externally while emacs runs it, it could be > such a "signal description string" in which case eql would be better > even though that situation seems unlikely. Right, and it's often hard to decide whether/how the user should be made aware of such exceptional circumstances. > I'll change that later. Thanks, --=20 Basil From unknown Sun Aug 17 22:08:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 25 Aug 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator