From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 06 18:13:17 2023 Received: (at submit) by debbugs.gnu.org; 6 Jul 2023 22:13:17 +0000 Received: from localhost ([127.0.0.1]:42186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHXDx-0002wZ-5L for submit@debbugs.gnu.org; Thu, 06 Jul 2023 18:13:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:45962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHXDs-0002wP-V3 for submit@debbugs.gnu.org; Thu, 06 Jul 2023 18:13:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHXDs-0001ah-M3 for guix-patches@gnu.org; Thu, 06 Jul 2023 18:13:12 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHXDq-0002q1-Q5 for guix-patches@gnu.org; Thu, 06 Jul 2023 18:13:12 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-314417861b9so1212817f8f.0 for ; Thu, 06 Jul 2023 15:13:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688681589; x=1691273589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hd4LG4Hw709usvU767KvPzt5Cnixdz9TLTThzA3PT14=; b=LsO/mB8LE1MI89f+9auGIy9tDFnAKrkonZMzTOK0Nc+5aZMNFE4M4pfYVhUvgwoVDq AfifgK6uO8wh8p2sdevCHsN+PyMYucNh4goa7mLawpalCMIBw/tjfIYI4JVjEsx1cS1d yhsWbrV0RLsBRhYdMWlyN8ZSXX6KUy/C7YzEnvSmB3yDvLj606QSI/TD7Y3WDNhMphmh 98OCy9ieU2Q2fCynygAtGmyIUWWUtba/+5gjY/pRWDZBRb11m3yMc2k4UKAf+uFKVrVf Y00FOEwKu7gfznjXHEWIAWpPEAhBRJIPQp5GwApQ1ZVPbk6F9ei7Ee827Er4Kj4cM1o1 qo7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688681589; x=1691273589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hd4LG4Hw709usvU767KvPzt5Cnixdz9TLTThzA3PT14=; b=TtnCYg4rj5tS4q51Bdjt/CPJSIY9JB5+RkqO8aey8pOfGZfoGVo5NSgaPLs+6Eq48N yOgJBkprKBL/4WcWN792Rwzhnw/xBXmyBcQVa7O5keIKJXpy9R1585nFF2fJnY60iVcH MmXIUZkmfvN1pgigDnskImKG7mVCHzGGRSA3HFVgQHq+vlz7WkKIUWOPCV/tOcH/eRnR mDdcGafOf+vyrGyN5OFCfu0GrwKuA4keW4OtwMAlYWSFpNbm01oL+BPrZgr9kiJomNo6 6zT1fiRShBAcHKNXbGphAWS/RtmoLf8E1eVn+Nbkshbf1PR4yioco5d2Qi7QgB/Usi3C dYcg== X-Gm-Message-State: ABy/qLa8KprXN321mQsGD6U3eG21kVlMYiMOwkcBe6M5ZMiF12ApcT3L Zo1NFUjvl4kuCbk5+2OI9sl0dp3nKK4= X-Google-Smtp-Source: APBJJlG2+p8MsD0rwcaYNzTyNhMF5BrfTAYCPr82+njUwp4zCfjjJGy7XNugy4OTN95iI3bIaKT1tQ== X-Received: by 2002:adf:e289:0:b0:314:91d:58b5 with SMTP id v9-20020adfe289000000b00314091d58b5mr2516380wri.65.1688681588487; Thu, 06 Jul 2023 15:13:08 -0700 (PDT) Received: from guxtil.incerto.xyz (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id a12-20020a05600c224c00b003fba94c9e18sm727125wmm.4.2023.07.06.15.13.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 15:13:07 -0700 (PDT) From: Sharlatan Hellseher To: guix-patches@gnu.org Subject: [PATCH] gnu: Add unsio. Date: Thu, 6 Jul 2023 23:13:05 +0100 Message-Id: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Andreas Enge , Efraim Flashner , Eric Bavier Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=sharlatanus@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Sharlatan Hellseher , Iliya Tikhonenko X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/astronomy.scm (unsio): New variable. Co-Authored-By: Iliya Tikhonenko --- gnu/packages/astronomy.scm | 38 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index 3a1b584808..15590cb84b 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2021, 2022 Vinicius Monego ;;; Copyright © 2021 Greg Hogan ;;; Copyright © 2021 Foo Chuan Wei +;;; Copyright © 2023 Iliya Tikhonenko ;;; ;;; This file is part of GNU Guix. ;;; @@ -74,6 +75,7 @@ (define-module (gnu packages astronomy) #:use-module (gnu packages python-xyz) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages sqlite) #:use-module (gnu packages sphinx) #:use-module (gnu packages textutils) #:use-module (gnu packages time) @@ -3767,3 +3769,39 @@ (define-public python-wiimatch for optimal @code{matching} of weighted N-dimensional image intensity data using (multivariate) polynomials.") (license license:bsd-3))) + +(define-public unsio + ;; There is no versioned tag, use the latest commit. + (let ((commit "25e52468298e1194c9726ef5dba9d5fbb46870f5") + (revision "0")) + (package + (name "unsio") + (version (git-version "1.3.3" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.lam.fr/infrastructure/unsio") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "110i2p5608zhh5w3pf3b5r2651hykw2ayspgq6vpqsffhya1p170")))) + (build-system cmake-build-system) + (arguments + (list #:tests? #f ;No tests + #:build-type "Release" + #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=14"))) + (inputs (list gfortran hdf5 perl sqlite zlib)) + (home-page "https://projets.lam.fr/projects/unsio/wiki") + (synopsis "Universal Nbody snapshot I/O") + (description + "@acronym{UNSIO, Universal Nbody Snapshot Input Output} is an API which +perform input/output operations in a generic way, and on different kind of nbody +files format (nemo, Gadget binaries 1 and 2, Gadget hdf5, Ramses). By using this +API, a user could write only one analysis program which will work on all known +files format supported by UNSIO. It's not necessary anymore to know how is +implemented a file format, UNSIO will do transparently and automatically all the +hard work for you! With UNSIO, you will spend less time to develop your +analysis program. UNSIO comes with an integrated sqlite3 database which can be +used to retrieve automatically all your data among terabytes of hard disks.") + (license license:cecill)))) base-commit: de3b8684e9a8e90e243cc2061100b06576c04077 -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 05:29:47 2023 Received: (at 64504) by debbugs.gnu.org; 8 Aug 2023 09:29:47 +0000 Received: from localhost ([127.0.0.1]:35208 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTJ2A-00052b-Hd for submit@debbugs.gnu.org; Tue, 08 Aug 2023 05:29:46 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:41430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTJ27-00052N-Gu for 64504@debbugs.gnu.org; Tue, 08 Aug 2023 05:29:44 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1B21D831; Tue, 8 Aug 2023 11:29:37 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zNTLRxYColSN; Tue, 8 Aug 2023 11:29:36 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1D972390; Tue, 8 Aug 2023 11:29:36 +0200 (CEST) Date: Tue, 8 Aug 2023 11:29:34 +0200 From: Andreas Enge To: Sharlatan Hellseher Subject: Re: [bug#64504] [PATCH] gnu: Add unsio. Message-ID: References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="zAGY0plcZ/NEgaH7" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64504 Cc: 64504@debbugs.gnu.org, Efraim Flashner , Iliya Tikhonenko , Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --zAGY0plcZ/NEgaH7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hello, thanks for the patch! I tried to remove the marketing speech out of the description. For the #:build-type, the default value (release with debug information) also works and results in a package of the same size. Is there a reason to change it? Modified patch attached. I can also compile the package without the configure flags, are they useful? In the end dynamic and static libraries end up in a directory lib64/. Should this not be lib/? And there are lots of warnings about 34 bit shifts in a 32 bit type. But I suppose you tested that the library works. Andreas --zAGY0plcZ/NEgaH7 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: attachment; filename="0001-gnu-Add-unsio.patch" Content-Transfer-Encoding: 8bit >From f5401b0abbe58aa473738dc58d541e2bece9db65 Mon Sep 17 00:00:00 2001 Message-ID: From: Sharlatan Hellseher Date: Thu, 6 Jul 2023 23:13:05 +0100 Subject: [PATCH] gnu: Add unsio. * gnu/packages/astronomy.scm (unsio): New variable. Co-Authored-By: Iliya Tikhonenko Signed-off-by: Andreas Enge --- gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index e5c318c8bf..7e047d4ad7 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2021, 2022 Vinicius Monego ;;; Copyright © 2021 Greg Hogan ;;; Copyright © 2021 Foo Chuan Wei +;;; Copyright © 2023 Iliya Tikhonenko ;;; ;;; This file is part of GNU Guix. ;;; @@ -75,6 +76,7 @@ (define-module (gnu packages astronomy) #:use-module (gnu packages python-xyz) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages sqlite) #:use-module (gnu packages sphinx) #:use-module (gnu packages textutils) #:use-module (gnu packages time) @@ -3951,3 +3953,32 @@ (define-public python-wiimatch for optimal @code{matching} of weighted N-dimensional image intensity data using (multivariate) polynomials.") (license license:bsd-3))) + +(define-public unsio + ;; There is no versioned tag, use the latest commit. + (let ((commit "25e52468298e1194c9726ef5dba9d5fbb46870f5") + (revision "0")) + (package + (name "unsio") + (version (git-version "1.3.3" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.lam.fr/infrastructure/unsio") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "110i2p5608zhh5w3pf3b5r2651hykw2ayspgq6vpqsffhya1p170")))) + (build-system cmake-build-system) + (arguments + (list #:tests? #f ;No tests + #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=14"))) + (inputs (list gfortran hdf5 perl sqlite zlib)) + (home-page "https://projets.lam.fr/projects/unsio/wiki") + (synopsis "Input and output routines for n-body file formats") + (description + "@acronym{UNSIO, Universal Nbody Snapshot Input Output} provides +an API for performing input and output operations on different kinds of +n-body file formats (nemo, Gadget binaries 1 and 2, Gadget hdf5, Ramses).") + (license license:cecill)))) base-commit: f19736e62f9ab5fba0ac5fe184a221c2a5d374c6 -- 2.41.0 --zAGY0plcZ/NEgaH7-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 08:28:10 2023 Received: (at 64504) by debbugs.gnu.org; 8 Aug 2023 12:28:11 +0000 Received: from localhost ([127.0.0.1]:35435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTLon-0004Mi-QD for submit@debbugs.gnu.org; Tue, 08 Aug 2023 08:28:10 -0400 Received: from mpemail.mpe.mpg.de ([130.183.137.111]:46952 helo=mail.mpe.mpg.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTL1E-0002mV-BN for 64504@debbugs.gnu.org; Tue, 08 Aug 2023 07:36:57 -0400 Received: from [89.246.96.67] (helo=[192.168.68.186]) by mail.mpe.mpg.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qTL15-0003Nh-7h; Tue, 08 Aug 2023 13:36:47 +0200 Message-ID: <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> Date: Tue, 8 Aug 2023 13:37:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [bug#64504] [PATCH] gnu: Add unsio. Content-Language: en-US, ru To: Andreas Enge References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> From: Iliya Tikhonenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Id: tikhonenko X-Spam-Score: -2.4 (--) X-Debbugs-Envelope-To: 64504 X-Mailman-Approved-At: Tue, 08 Aug 2023 08:28:08 -0400 Cc: 64504@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.4 (---) Hello! I am the author of the initial version of this patch (kudos to Sharlatan for cleaning it up and bringing to guix proper!) On 8/8/23 11:29, Andreas Enge wrote: > For the #:build-type, the default value (release with debug information) also works and results in a package of the same size. Is there a reason to change it? Modified patch attached. The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for an example) to the point that it impacts performance sometimes, which is important considering the usecase of the library. > I can also compile the package without the configure flags, are they useful? Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14 > And there are lots of warnings about 34 bit shifts in a 32 bit type. > But I suppose you tested that the library works. I have not noticed any issues using it during the past two years, but this cannot be considered a proper test because I am actually using a small subset of the library. Perhaps, this warning should be reported upstream, thanks! All the best, Iliya From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 08 11:50:04 2023 Received: (at 64504) by debbugs.gnu.org; 8 Aug 2023 15:50:04 +0000 Received: from localhost ([127.0.0.1]:37580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOyB-0004O0-I9 for submit@debbugs.gnu.org; Tue, 08 Aug 2023 11:50:04 -0400 Received: from hera.aquilenet.fr ([2a0c:e300::1]:34218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qTOy9-0004NI-4s for 64504@debbugs.gnu.org; Tue, 08 Aug 2023 11:50:02 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 55E6BC30; Tue, 8 Aug 2023 17:49:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3MWzxwXdA5l7; Tue, 8 Aug 2023 17:49:52 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 08813390; Tue, 8 Aug 2023 17:49:51 +0200 (CEST) Date: Tue, 8 Aug 2023 17:49:50 +0200 From: Andreas Enge To: Iliya Tikhonenko Subject: Re: [bug#64504] [PATCH] gnu: Add unsio. Message-ID: References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="+v1xSokPgEAKmxu7" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64504 Cc: 64504@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --+v1xSokPgEAKmxu7 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Am Tue, Aug 08, 2023 at 01:37:14PM +0200 schrieb Iliya Tikhonenko: > On 8/8/23 11:29, Andreas Enge wrote: > > For the #:build-type, the default value (release with debug information) also works and results in a package of the same size. Is there a reason to change it? Modified patch attached. > The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for > an example) to the point that it impacts performance sometimes, which is > important considering the usecase of the library. Okay, I have reinstated your line and added a comment. > > I can also compile the package without the configure flags, are they useful? > Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14 I can... Patch attached. > > And there are lots of warnings about 34 bit shifts in a 32 bit type. > > But I suppose you tested that the library works. > I have not noticed any issues using it during the past two years, but this > cannot be considered a proper test because I am actually using a small > subset of the library. Perhaps, this warning should be reported upstream, > thanks! /tmp/guix-build-unsio-1.3.3-0.25e5246.drv-0/source/src/snapshotinterface.cc:125:45: warning: result of ‘(-2147483648 << 2)’ requires 34 bits to represent, but ‘int’ only has 32 bits [-Wshift-overflow=] 125 | req_bits = (unsigned int) (( 1 << 31 )<<2)-1; | ~~~~~~~~~~~~^~~~ Here is the offending line. This is indeed a bit surprising, as "int" usually has 32 bits. The 1 to be shifted is a signed int; 1*2^31 is not representable in the type, so if I understand the C standard correctly, the result is undefined. Then I have seen a Stackoverflow comment that it is okay in C++20. And indeed: #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=20") passes without these warnings. Should we add this? Although such constructs look a bit brittle to me, and it is not suggested by the author. There is still the question about the lib64/ installation directory, I think this should be changed. Andreas --+v1xSokPgEAKmxu7 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: attachment; filename="0001-gnu-Add-unsio.patch" Content-Transfer-Encoding: 8bit >From ebfdbb4941d1151d15ecc0efb5aacdd3532b30cb Mon Sep 17 00:00:00 2001 Message-ID: From: Sharlatan Hellseher Date: Thu, 6 Jul 2023 23:13:05 +0100 Subject: [PATCH] gnu: Add unsio. * gnu/packages/astronomy.scm (unsio): New variable. Co-Authored-By: Iliya Tikhonenko Signed-off-by: Andreas Enge --- gnu/packages/astronomy.scm | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/gnu/packages/astronomy.scm b/gnu/packages/astronomy.scm index e5c318c8bf..e18e8bb21e 100644 --- a/gnu/packages/astronomy.scm +++ b/gnu/packages/astronomy.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2021, 2022 Vinicius Monego ;;; Copyright © 2021 Greg Hogan ;;; Copyright © 2021 Foo Chuan Wei +;;; Copyright © 2023 Iliya Tikhonenko ;;; ;;; This file is part of GNU Guix. ;;; @@ -75,6 +76,7 @@ (define-module (gnu packages astronomy) #:use-module (gnu packages python-xyz) #:use-module (gnu packages qt) #:use-module (gnu packages readline) + #:use-module (gnu packages sqlite) #:use-module (gnu packages sphinx) #:use-module (gnu packages textutils) #:use-module (gnu packages time) @@ -3951,3 +3953,32 @@ (define-public python-wiimatch for optimal @code{matching} of weighted N-dimensional image intensity data using (multivariate) polynomials.") (license license:bsd-3))) + +(define-public unsio + ;; There is no versioned tag, use the latest commit. + (let ((commit "25e52468298e1194c9726ef5dba9d5fbb46870f5") + (revision "0")) + (package + (name "unsio") + (version (git-version "1.3.3" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.lam.fr/infrastructure/unsio") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "110i2p5608zhh5w3pf3b5r2651hykw2ayspgq6vpqsffhya1p170")))) + (build-system cmake-build-system) + (arguments + (list #:tests? #f ;No tests + #:build-type "Release")) ; to improve performace + (inputs (list gfortran hdf5 perl sqlite zlib)) + (home-page "https://projets.lam.fr/projects/unsio/wiki") + (synopsis "Input and output routines for n-body file formats") + (description + "@acronym{UNSIO, Universal Nbody Snapshot Input Output} provides +an API for performing input and output operations on different kinds of +n-body file formats (nemo, Gadget binaries 1 and 2, Gadget hdf5, Ramses).") + (license license:cecill)))) base-commit: 782ef67a59f4b564f16101cf23c30a3777b3f734 -- 2.41.0 --+v1xSokPgEAKmxu7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 14 12:10:40 2023 Received: (at 64504) by debbugs.gnu.org; 14 Aug 2023 16:10:41 +0000 Received: from localhost ([127.0.0.1]:34231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVa9P-0003ux-Mk for submit@debbugs.gnu.org; Mon, 14 Aug 2023 12:10:40 -0400 Received: from mpemail.mpe.mpg.de ([130.183.137.111]:51348 helo=mail.mpe.mpg.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVWt2-00022y-9U for 64504@debbugs.gnu.org; Mon, 14 Aug 2023 08:41:33 -0400 Received: from [89.246.96.65] (helo=[192.168.178.187]) by mail.mpe.mpg.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVWst-0006mS-3s; Mon, 14 Aug 2023 14:41:23 +0200 Message-ID: <07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de> Date: Mon, 14 Aug 2023 14:41:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 From: Iliya Tikhonenko Subject: Re: [bug#64504] [PATCH] gnu: Add unsio. To: Andreas Enge References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> Content-Language: en-US, ru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Id: tikhonenko X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 64504 X-Mailman-Approved-At: Mon, 14 Aug 2023 12:10:38 -0400 Cc: 64504@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On 8/8/23 17:49, Andreas Enge wrote: > Am Tue, Aug 08, 2023 at 01:37:14PM +0200 schrieb Iliya Tikhonenko: >> On 8/8/23 11:29, Andreas Enge wrote: >> The debug build type is unnecessary verbose (see src/uns.cc line 71-73 for >> an example) to the point that it impacts performance sometimes, which is >> important considering the usecase of the library. > Okay, I have reinstated your line and added a comment.Fine, maybe "to disable debug printing" would sound slightly more clear, but I am not sure. >> Checked again, I still cannot compile it without -DCMAKE_CXX_STANDARD=14 > I can... Patch attached. Yeah, it builds now. > #:configure-flags #~(list "-DCMAKE_CXX_STANDARD=20") > passes without these warnings. Should we add this? > Although such constructs look a bit brittle to me, and it is not suggested by the author. > > There is still the question about the lib64/ installation directory, > I think this should be changed. I think I am fine with both changes. I did a few quick tests and have not noticed any issues. All the best, Iliya From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 14:10:17 2023 Received: (at 64504-done) by debbugs.gnu.org; 17 Aug 2023 18:10:17 +0000 Received: from localhost ([127.0.0.1]:45543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhRp-0000HD-7c for submit@debbugs.gnu.org; Thu, 17 Aug 2023 14:10:17 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:46384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWhRk-0000Gt-I9 for 64504-done@debbugs.gnu.org; Thu, 17 Aug 2023 14:10:15 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id DF3CA429; Thu, 17 Aug 2023 20:10:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Gt7jkGbZtfzO; Thu, 17 Aug 2023 20:10:05 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 432D6170; Thu, 17 Aug 2023 20:10:05 +0200 (CEST) Date: Thu, 17 Aug 2023 20:10:03 +0200 From: Andreas Enge To: Iliya Tikhonenko Subject: Re: [bug#64504] [PATCH] gnu: Add unsio. Message-ID: References: <521af611d0794672c19a4899e42eb5e448ab1c1f.1688681498.git.sharlatanus@gmail.com> <138b0fbd-ca5b-17ac-9c18-4d657737d4c0@mpe.mpg.de> <07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <07cba047-bd5a-f7fe-2bdf-a0b8c9781456@mpe.mpg.de> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 64504-done Cc: 64504-done@debbugs.gnu.org, Sharlatan Hellseher , Efraim Flashner , Eric Bavier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, On 8/8/23 17:49, Andreas Enge wrote: > There is still the question about the lib64/ installation directory, > I think this should be changed. I just did with a little snippet; this has been programmed manually by the author, so could not be changed using cmake variables. Pushed, thanks for the new package! Andreas From unknown Fri Sep 05 15:36:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Sep 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator