GNU bug report logs - #64502
[PATCH] gnu: Add emacs-weyland-yutani-theme.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Ahmad Draidi via Guix-patches via <guix-patches <at> gnu.org>
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>, 64502 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#64502] [PATCH] gnu: Add emacs-weyland-yutani-theme.
Date: Fri, 07 Jul 2023 00:14:24 +0200

Hello,

Ahmad Draidi via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-weyland-yutani-theme): New
> variable.

Thank you. Some comments follow.

> +(define-public emacs-weyland-yutani-theme
> +  (let ((commit "e89a63a62e071180c9cdd9067679fadc3f7bf796")
> +        (revision "0"))
> +    (package
> +      (name "emacs-weyland-yutani-theme")
> +      (version (git-version "20210802.2251" revision commit))

Base version is actually "0.1", not "20210802.2251", per "Version"
keyword in main file.

> +      (description
> +       "Weyland Yutani is a dark Emacs theme based on the Alien movie franchise")

The final full stop is missing.

> +      (license license:gpl3))))

License is actually gpl3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.