GNU bug report logs - #645
23.0.60; rng-after-change-function error when validation not started

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 645 in the body.
You can then email your comments to 645 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; rng-after-change-function error when validation not started
Date: Sun, 03 Aug 2008 20:30:21 +0200

The function rng-after-change-function might be called before validation 
has started. This results in an error. The patch below corrects this 
problem.

Index: rng-valid.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/nxml/rng-valid.el,v
retrieving revision 1.8
diff -u -b -r1.8 rng-valid.el
--- rng-valid.el	3 Jul 2008 12:25:22 -0000	1.8
+++ rng-valid.el	3 Aug 2008 18:27:21 -0000
@@ -304,6 +304,7 @@
   (or rng-validate-mode (rng-validate-mode)))

 (defun rng-after-change-function (start end pre-change-len)
+  (when rng-validate-up-to-date-end
   ;; Work around bug in insert-file-contents.
   (when (> end (1+ (buffer-size)))
     (setq start 1)
@@ -343,7 +344,7 @@
   ;; Arrange to revalidate
   (rng-activate-timers)
   ;; Need to do this after activating the timer
-  (force-mode-line-update))
+    (force-mode-line-update)))

 (defun rng-compute-mode-line-string ()
   (cond (rng-validate-timer



In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
 of 2008-08-01

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>
To: "Lennart Borgman (gmail)" <lennart.borgman <at> gmail.com>,
        645 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#645: 23.0.60;	rng-after-change-function error when validation
 not started
Date: Sun, 03 Aug 2008 21:24:26 +0200

Hm. Please do not apply this now. I can't see why it can happen that 
rng-validate-up-to-date-end is nil. I will investigate it.


Lennart Borgman (gmail) wrote:
> The function rng-after-change-function might be called before validation 
> has started. This results in an error. The patch below corrects this 
> problem.
> 
> Index: rng-valid.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/nxml/rng-valid.el,v
> retrieving revision 1.8
> diff -u -b -r1.8 rng-valid.el
> --- rng-valid.el    3 Jul 2008 12:25:22 -0000    1.8
> +++ rng-valid.el    3 Aug 2008 18:27:21 -0000
> @@ -304,6 +304,7 @@
>    (or rng-validate-mode (rng-validate-mode)))
> 
>  (defun rng-after-change-function (start end pre-change-len)
> +  (when rng-validate-up-to-date-end
>    ;; Work around bug in insert-file-contents.
>    (when (> end (1+ (buffer-size)))
>      (setq start 1)
> @@ -343,7 +344,7 @@
>    ;; Arrange to revalidate
>    (rng-activate-timers)
>    ;; Need to do this after activating the timer
> -  (force-mode-line-update))
> +    (force-mode-line-update)))
> 
>  (defun rng-compute-mode-line-string ()
>    (cond (rng-validate-timer
> 
> 
> 
> In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
>  of 2008-08-01
> 
> 
> 
> 
> 

Message #22 received at 645-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 645-done <at> debbugs.gnu.org
Subject: Re: bug#645: 23.0.60;
	rng-after-change-function error when validation not started
Date: Sat, 09 Jul 2011 20:21:23 -0400

Never followed up; closing.

"Lennart Borgman (gmail)" wrote:

> Hm. Please do not apply this now. I can't see why it can happen that
> rng-validate-up-to-date-end is nil. I will investigate it.

Message #25 received at 645 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: 645 <at> debbugs.gnu.org, rgm <at> gnu.org
Cc: 645-done <at> debbugs.gnu.org
Subject: Re: bug#645: 23.0.60; rng-after-change-function error when validation
	not started
Date: Sun, 10 Jul 2011 02:45:09 +0200

That is ok. I do not have time to dive into this. And I think a rework
of some parts of Emacs must be done to fix it.

On Sun, Jul 10, 2011 at 02:21, Glenn Morris <rgm <at> gnu.org> wrote:
>
> Never followed up; closing.
>
> "Lennart Borgman (gmail)" wrote:
>
>> Hm. Please do not apply this now. I can't see why it can happen that
>> rng-validate-up-to-date-end is nil. I will investigate it.
>
>
>
>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.