From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 17 13:14:45 2010 Received: (at submit) by debbugs.gnu.org; 17 Jun 2010 17:14:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPIft-0002dv-Bu for submit@debbugs.gnu.org; Thu, 17 Jun 2010 13:14:45 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPIfq-0002dq-2e for submit@debbugs.gnu.org; Thu, 17 Jun 2010 13:14:43 -0400 Received: from lists.gnu.org ([199.232.76.165]:53439) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OPIfl-00041h-40 for submit@debbugs.gnu.org; Thu, 17 Jun 2010 13:14:37 -0400 Received: from [140.186.70.92] (port=47511 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPIfj-0006OW-8y for bug-gnu-emacs@gnu.org; Thu, 17 Jun 2010 13:14:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPIfh-0000X4-Vz for bug-gnu-emacs@gnu.org; Thu, 17 Jun 2010 13:14:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22632) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPIfh-0000Wp-PL for bug-gnu-emacs@gnu.org; Thu, 17 Jun 2010 13:14:33 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o5HHEVOr021069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 17 Jun 2010 13:14:31 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o5HHEUSW020151; Thu, 17 Jun 2010 13:14:30 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o5HHETQK028408; Thu, 17 Jun 2010 13:14:30 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 35A6E3784BE; Thu, 17 Jun 2010 11:14:29 -0600 (MDT) From: Tom Tromey To: bug-gnu-emacs@gnu.org Subject: 23.1; revert-buffer in *vc-diff* X-Attribution: Tom Date: Thu, 17 Jun 2010 11:14:28 -0600 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Scanned-By: MIMEDefang 2.67 on 10.5.11.17 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Tom Tromey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I typed '=' in a *vc-dir* buffer to get a diff. It would be nice if revert-buffer in the *vc-diff* buffer re-ran the same diff command. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /usr/share/emacs/23.1/etc/DEBUG for instructions. In GNU Emacs 23.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.16.6) of 2010-04-01 on x86-01.phx2.fedoraproject.org Windowing system distributor `The X.Org Foundation', version 11.0.10603901 configured using `configure '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i586-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-dbus' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xft' '--with-xpm' '--with-x-toolkit=gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i586-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Group Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-track-minor-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-spelling-mode: t erc-truncate-mode: t gnus-undo-mode: t erc-status-mode: t erc-services-mode: t erc-networks-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: u s t SPC b e c a u s e SPC m y SPC i m p r e s s i o n SPC i s SPC t h a t SPC m o s t SPC o f SPC t h e SPC g t a r g e t SPC s t u f f SPC i s SPC r e a l l y SPC q u i t e SPC h o s t - i n d e p e n d e n t b u t SPC I SPC h a v e SPC n o t SPC a c t u a l l y SPC t r i e s d SPC s a SPC b u i l d SPC o n SPC s o l a r i s , SPC s o SPC w h o SPC k n o w s C-z n C-s SPC . SPC C-p C-p E E E C-u C-n E E S-SPC C-z o C-z o C-z o y e a h a n y t h i n g SPC l i k e SPC t h a t SPC i s SPC p r a SPC b u g , SPC b u t SPC o I SPC r e a l i z e SPC t i m e SPC i s SPC l i m i t e d . . . C-z n = E E S-SPC SPC = E E E S-SPC E E E q s C-u C-n C-n C-n SPC E q s M-x r e p o r t - e m b Recent messages: Deleting article 21076 in mail.gnome Deleting article 21077 in mail.gnome Deleting article 21078 in mail.gnome Deleting article 21079 in mail.gnome Expiring articles...done (No changes need to be saved) Saving /home/tromey/.newsrc.eld... Saving file /home/tromey/.newsrc.eld... Wrote /home/tromey/.newsrc.eld Saving /home/tromey/.newsrc.eld...done Tom From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 10:55:18 2010 Received: (at 6447) by debbugs.gnu.org; 19 Jun 2010 14:55:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPzS0-0006Ne-Jd for submit@debbugs.gnu.org; Sat, 19 Jun 2010 10:55:16 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPzRy-0006NE-4f for 6447@debbugs.gnu.org; Sat, 19 Jun 2010 10:55:14 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.99.175.cable.starman.ee [82.131.99.175]) by mx1.starman.ee (Postfix) with ESMTP id 0C8403F4188; Sat, 19 Jun 2010 17:55:06 +0300 (EEST) From: Juri Linkov To: Tom Tromey Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* Organization: JURTA References: Date: Sat, 19 Jun 2010 17:52:47 +0300 In-Reply-To: (Tom Tromey's message of "Thu, 17 Jun 2010 11:14:28 -0600") Message-ID: <871vc3hyl8.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.6 (---) X-Debbugs-Envelope-To: 6447 Cc: 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.6 (---) > I typed '=' in a *vc-dir* buffer to get a diff. > It would be nice if revert-buffer in the *vc-diff* buffer re-ran the > same diff command. Like the command `diff' after calling `diff-mode' sets `revert-buffer-function' to lambda with its function arguments, `vc-diff-internal' could do the same: === modified file 'lisp/vc/vc.el' --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese (message "%s" (cdr messages)) nil) (diff-mode) + (set (make-local-variable 'revert-buffer-function) + `(lambda (ignore-auto noconfirm) + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) ;; Make the *vc-diff* buffer read only, the diff-mode key ;; bindings are nicer for read only buffers. pcl-cvs does the ;; same thing. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 19 13:36:53 2010 Received: (at 6447) by debbugs.gnu.org; 19 Jun 2010 17:36:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ1yP-0007bn-7G for submit@debbugs.gnu.org; Sat, 19 Jun 2010 13:36:53 -0400 Received: from pantheon-po23.its.yale.edu ([130.132.50.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQ1yM-0007bi-V7 for 6447@debbugs.gnu.org; Sat, 19 Jun 2010 13:36:51 -0400 Received: from furry (173-14-147-246-NewEngland.hfc.comcastbusiness.net [173.14.147.246]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o5JHajZF019729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Jun 2010 13:36:46 -0400 Received: by furry (Postfix, from userid 1000) id 1CC70C013; Sat, 19 Jun 2010 19:36:44 +0200 (CEST) From: Chong Yidong To: Juri Linkov Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> Date: Sat, 19 Jun 2010 13:36:43 -0400 In-Reply-To: <871vc3hyl8.fsf@mail.jurta.org> (Juri Linkov's message of "Sat, 19 Jun 2010 17:52:47 +0300") Message-ID: <87631ekjpw.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 6447 Cc: Tom Tromey , 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) Juri Linkov writes: > Like the command `diff' after calling `diff-mode' sets > `revert-buffer-function' to lambda with its function arguments, > `vc-diff-internal' could do the same: > > === modified file 'lisp/vc/vc.el' > --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 > +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 > @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese > (message "%s" (cdr messages)) > nil) > (diff-mode) > + (set (make-local-variable 'revert-buffer-function) > + `(lambda (ignore-auto noconfirm) > + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) > ;; Make the *vc-diff* buffer read only, the diff-mode key > ;; bindings are nicer for read only buffers. pcl-cvs does the > ;; same thing. Looks like a fine idea, please go ahead. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 18:01:55 2010 Received: (at 6447-done) by debbugs.gnu.org; 24 Jun 2010 22:01:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORuUc-0008WH-GH for submit@debbugs.gnu.org; Thu, 24 Jun 2010 18:01:54 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORuUa-0008W9-JC for 6447-done@debbugs.gnu.org; Thu, 24 Jun 2010 18:01:53 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (62.65.209.24.cable.starman.ee [62.65.209.24]) by mx2.starman.ee (Postfix) with ESMTP id E4F8B3F407E; Fri, 25 Jun 2010 01:01:45 +0300 (EEST) From: Juri Linkov To: Chong Yidong Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* Organization: JURTA References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> Date: Fri, 25 Jun 2010 00:47:08 +0300 In-Reply-To: <87631ekjpw.fsf@stupidchicken.com> (Chong Yidong's message of "Sat, 19 Jun 2010 13:36:43 -0400") Message-ID: <87y6e46r37.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 6447-done Cc: Tom Tromey , 6447-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.8 (---) >> Like the command `diff' after calling `diff-mode' sets >> `revert-buffer-function' to lambda with its function arguments, >> `vc-diff-internal' could do the same: >> >> === modified file 'lisp/vc/vc.el' >> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >> (message "%s" (cdr messages)) >> nil) >> (diff-mode) >> + (set (make-local-variable 'revert-buffer-function) >> + `(lambda (ignore-auto noconfirm) >> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >> ;; Make the *vc-diff* buffer read only, the diff-mode key >> ;; bindings are nicer for read only buffers. pcl-cvs does the >> ;; same thing. > > Looks like a fine idea, please go ahead. Done. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 24 19:16:14 2010 Received: (at 6447) by debbugs.gnu.org; 24 Jun 2010 23:16:14 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORveX-0001GM-UN for submit@debbugs.gnu.org; Thu, 24 Jun 2010 19:16:14 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ORveV-0001GE-Lu for 6447@debbugs.gnu.org; Thu, 24 Jun 2010 19:16:12 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1ORveR-00088b-QN; Thu, 24 Jun 2010 19:16:07 -0400 To: 6447@debbugs.gnu.org Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Thu, 24 Jun 2010 19:16:07 -0400 In-Reply-To: <87y6e46r37.fsf@mail.jurta.org> (Juri Linkov's message of "Fri\, 25 Jun 2010 00\:47\:08 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6447 Cc: juri@jurta.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Juri Linkov writes: >>> Like the command `diff' after calling `diff-mode' sets >>> `revert-buffer-function' to lambda with its function arguments, >>> `vc-diff-internal' could do the same: >>> >>> === modified file 'lisp/vc/vc.el' >>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>> (message "%s" (cdr messages)) >>> nil) >>> (diff-mode) >>> + (set (make-local-variable 'revert-buffer-function) >>> + `(lambda (ignore-auto noconfirm) >>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>> ;; same thing. >> >> Looks like a fine idea, please go ahead. > > Done. BTW, the log and log-incoming and log-outgoing buffers could use the same treatment... From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 25 16:56:14 2010 Received: (at 6447) by debbugs.gnu.org; 25 Jun 2010 20:56:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSFwc-0003IS-NX for submit@debbugs.gnu.org; Fri, 25 Jun 2010 16:56:14 -0400 Received: from smtp-out2.starman.ee ([85.253.0.4] helo=mx2.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSFwa-0003IB-6b for 6447@debbugs.gnu.org; Fri, 25 Jun 2010 16:56:12 -0400 X-Virus-Scanned: by Amavisd-New at mx2.starman.ee Received: from mail.starman.ee (62.65.210.19.cable.starman.ee [62.65.210.19]) by mx2.starman.ee (Postfix) with ESMTP id 821A73F40A8; Fri, 25 Jun 2010 23:56:05 +0300 (EEST) From: Juri Linkov To: Dan Nicolaescu Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* Organization: JURTA References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> Date: Fri, 25 Jun 2010 23:32:29 +0300 In-Reply-To: (Dan Nicolaescu's message of "Thu, 24 Jun 2010 19:16:07 -0400") Message-ID: <87wrtmlu8a.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.7 (---) X-Debbugs-Envelope-To: 6447 Cc: 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) > BTW, the log and log-incoming and log-outgoing buffers could use the same treatment... Do you think it should be implemented in `vc-log-internal-common'? -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 25 17:12:21 2010 Received: (at 6447) by debbugs.gnu.org; 25 Jun 2010 21:12:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGCC-0003Pi-Ub for submit@debbugs.gnu.org; Fri, 25 Jun 2010 17:12:21 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSGCB-0003Pc-Kl for 6447@debbugs.gnu.org; Fri, 25 Jun 2010 17:12:20 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OSGC7-0001UO-F1; Fri, 25 Jun 2010 17:12:15 -0400 To: Juri Linkov Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> <87wrtmlu8a.fsf@mail.jurta.org> From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Fri, 25 Jun 2010 17:12:15 -0400 In-Reply-To: <87wrtmlu8a.fsf@mail.jurta.org> (Juri Linkov's message of "Fri\, 25 Jun 2010 23\:32\:29 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6447 Cc: 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Juri Linkov writes: >> BTW, the log and log-incoming and log-outgoing buffers could use the same treatment... > > Do you think it should be implemented in `vc-log-internal-common'? Probably, that's where the log buffer gets created. But, IMHO, if you find a better place, that should be fine too. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 09 16:52:03 2010 Received: (at 6447) by debbugs.gnu.org; 9 Jul 2010 20:52:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXKYE-0007Io-5T for submit@debbugs.gnu.org; Fri, 09 Jul 2010 16:52:03 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OXKYB-0007Ii-13 for 6447@debbugs.gnu.org; Fri, 09 Jul 2010 16:51:59 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OXKY6-0003OV-4F; Fri, 09 Jul 2010 16:51:54 -0400 To: 6447@debbugs.gnu.org Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Fri, 09 Jul 2010 16:51:54 -0400 In-Reply-To: <87y6e46r37.fsf@mail.jurta.org> (Juri Linkov's message of "Fri\, 25 Jun 2010 00\:47\:08 +0300") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6447 Cc: juri@jurta.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Juri Linkov writes: >>> Like the command `diff' after calling `diff-mode' sets >>> `revert-buffer-function' to lambda with its function arguments, >>> `vc-diff-internal' could do the same: >>> >>> === modified file 'lisp/vc/vc.el' >>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>> (message "%s" (cdr messages)) >>> nil) >>> (diff-mode) >>> + (set (make-local-variable 'revert-buffer-function) >>> + `(lambda (ignore-auto noconfirm) >>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>> ;; same thing. >> >> Looks like a fine idea, please go ahead. > > Done. It would be nice to also have revert-buffer bound to "g" in this case, that would make this feature easier to use (and consistent with what we do for other modes). From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 02 05:26:06 2010 Received: (at 6447) by debbugs.gnu.org; 2 Aug 2010 09:26:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfrHa-0002VL-JP for submit@debbugs.gnu.org; Mon, 02 Aug 2010 05:26:06 -0400 Received: from impaqm4.telefonica.net ([213.4.138.4]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfrHY-0002Uy-W9 for 6447@debbugs.gnu.org; Mon, 02 Aug 2010 05:26:05 -0400 Received: from IMPmailhost6.adm.correo ([10.20.102.127]) by IMPaqm4.telefonica.net with bizsmtp id pJxf1e00b2kvMAa3QMS5kL; Mon, 02 Aug 2010 11:26:05 +0200 Received: from ceviche.home ([83.61.38.247]) by IMPmailhost6.adm.correo with BIZ IMP id pMS31e0055KwfZf1mMS3HH; Mon, 02 Aug 2010 11:26:05 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Received: by ceviche.home (Postfix, from userid 20848) id CDAD666125; Mon, 2 Aug 2010 11:26:02 +0200 (CEST) From: Stefan Monnier To: Dan Nicolaescu Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* Message-ID: References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> Date: Mon, 02 Aug 2010 11:26:02 +0200 In-Reply-To: (Dan Nicolaescu's message of "Fri, 09 Jul 2010 16:51:54 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 6447 Cc: 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >>>> Like the command `diff' after calling `diff-mode' sets >>>> `revert-buffer-function' to lambda with its function arguments, >>>> `vc-diff-internal' could do the same: >>>> >>>> === modified file 'lisp/vc/vc.el' >>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>>> (message "%s" (cdr messages)) >>>> nil) >>>> (diff-mode) >>>> + (set (make-local-variable 'revert-buffer-function) >>>> + `(lambda (ignore-auto noconfirm) >>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>>> ;; same thing. >>> >>> Looks like a fine idea, please go ahead. >> >> Done. > It would be nice to also have revert-buffer bound to "g" in this case, > that would make this feature easier to use (and consistent with what > we do for other modes). Fine by me (tho only when the diff-mode buffer is read-only, of course, it would be rather awkward for editing otherwise). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 06 00:02:43 2010 Received: (at 6447) by debbugs.gnu.org; 6 Aug 2010 04:02:43 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE8p-00004y-Bg for submit@debbugs.gnu.org; Fri, 06 Aug 2010 00:02:43 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE8n-00004t-RO for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:02:42 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhE9K-0002lc-Ag; Fri, 06 Aug 2010 00:03:14 -0400 To: Stefan Monnier Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Fri, 06 Aug 2010 00:03:14 -0400 In-Reply-To: (Stefan Monnier's message of "Mon\, 02 Aug 2010 11\:26\:02 +0200") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6447 Cc: 6447@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Stefan Monnier writes: >>>>> Like the command `diff' after calling `diff-mode' sets >>>>> `revert-buffer-function' to lambda with its function arguments, >>>>> `vc-diff-internal' could do the same: >>>>> >>>>> === modified file 'lisp/vc/vc.el' >>>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>>>> (message "%s" (cdr messages)) >>>>> nil) >>>>> (diff-mode) >>>>> + (set (make-local-variable 'revert-buffer-function) >>>>> + `(lambda (ignore-auto noconfirm) >>>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>>>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>>>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>>>> ;; same thing. >>>> >>>> Looks like a fine idea, please go ahead. >>> >>> Done. > >> It would be nice to also have revert-buffer bound to "g" in this case, >> that would make this feature easier to use (and consistent with what >> we do for other modes). > > Fine by me (tho only when the diff-mode buffer is read-only, of course, > it would be rather awkward for editing otherwise). Done. Should this also go in the menu? q is also missing from the menu. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 06 00:03:44 2010 Received: (at 6447) by debbugs.gnu.org; 6 Aug 2010 04:03:44 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE9n-00005f-Qi for submit@debbugs.gnu.org; Fri, 06 Aug 2010 00:03:44 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhE9m-00005a-D0 for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:03:42 -0400 Received: from dann by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OhEAJ-0002mO-Cb for 6447@debbugs.gnu.org; Fri, 06 Aug 2010 00:04:15 -0400 To: 6447@debbugs.gnu.org Subject: Re: bug#6447: 23.1; revert-buffer in *vc-diff* References: <871vc3hyl8.fsf@mail.jurta.org> <87631ekjpw.fsf@stupidchicken.com> <87y6e46r37.fsf@mail.jurta.org> From: Dan Nicolaescu X-Debbugs-No-Ack: yes Date: Fri, 06 Aug 2010 00:04:15 -0400 In-Reply-To: (Dan Nicolaescu's message of "Thu\, 24 Jun 2010 19\:16\:07 -0400") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 6447 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) Dan Nicolaescu writes: > Juri Linkov writes: > >>>> Like the command `diff' after calling `diff-mode' sets >>>> `revert-buffer-function' to lambda with its function arguments, >>>> `vc-diff-internal' could do the same: >>>> >>>> === modified file 'lisp/vc/vc.el' >>>> --- lisp/vc/vc.el 2010-06-11 19:09:57 +0000 >>>> +++ lisp/vc/vc.el 2010-06-19 14:51:14 +0000 >>>> @@ -1547,6 +1547,9 @@ (defun vc-diff-internal (async vc-filese >>>> (message "%s" (cdr messages)) >>>> nil) >>>> (diff-mode) >>>> + (set (make-local-variable 'revert-buffer-function) >>>> + `(lambda (ignore-auto noconfirm) >>>> + (vc-diff-internal ,async ',vc-fileset ,rev1 ,rev2 ,verbose))) >>>> ;; Make the *vc-diff* buffer read only, the diff-mode key >>>> ;; bindings are nicer for read only buffers. pcl-cvs does the >>>> ;; same thing. >>> >>> Looks like a fine idea, please go ahead. >> >> Done. > > BTW, the log and log-incoming and log-outgoing buffers could use the same treatment... I've done this implemented this in my local tree. From unknown Mon Aug 18 18:02:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Sep 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator