GNU bug report logs - #64459
30.0.50; Edebug can't instrument certain syntax-propertize-rules forms

Previous Next

Full log

Message #20 received at 64459 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 64459 <at> debbugs.gnu.org
Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain
 syntax-propertize-rules forms
Date: Tue, 04 Jul 2023 19:45:59 -0400

> diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el
> index d610fa005cc..002a24af18b 100644
> --- a/lisp/emacs-lisp/syntax.el
> +++ b/lisp/emacs-lisp/syntax.el
> @@ -249,11 +249,12 @@ syntax-propertize-rules
>  Note: There may be at most nine back-references in the REGEXPs of
>  all RULES in total."
>    (declare (debug (&rest &or symbolp    ;FIXME: edebug this eval step.
> -                         (form &rest
> -                               (numberp
> -                                [&or stringp ;FIXME: Use &wrap
> -                                     ("prog1" [&or stringp def-form] def-body)
> -                                     def-form])))))
> +                         (def-form
> +                          &rest
> +                          (numberp
> +                           [&or stringp ;FIXME: Use &wrap
> +                                ("prog1" [&or stringp form] def-body)
> +                                form])))))
>    (let ((newrules nil))
>      (while rules
>        (if (symbolp (car rules))

No, this one introduces a regression.  Try that one:


        Stefan


diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el
index d610fa005cc..41db2981d8c 100644
--- a/lisp/emacs-lisp/syntax.el
+++ b/lisp/emacs-lisp/syntax.el
@@ -249,11 +249,12 @@ syntax-propertize-rules
 Note: There may be at most nine back-references in the REGEXPs of
 all RULES in total."
   (declare (debug (&rest &or symbolp    ;FIXME: edebug this eval step.
-                         (form &rest
-                               (numberp
-                                [&or stringp ;FIXME: Use &wrap
-                                     ("prog1" [&or stringp def-form] def-body)
-                                     def-form])))))
+                         (def-form
+                          &rest
+                          (numberp
+                           [&or stringp ;FIXME: Use &wrap
+                                ("prog1" [&or stringp def-form] def-body)
+                                def-form])))))
   (let ((newrules nil))
     (while rules
       (if (symbolp (car rules))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.