From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 09:35:15 2023 Received: (at submit) by debbugs.gnu.org; 4 Jul 2023 13:35:15 +0000 Received: from localhost ([127.0.0.1]:35200 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgBW-0003wH-GP for submit@debbugs.gnu.org; Tue, 04 Jul 2023 09:35:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:56968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgBT-0003w4-2x for submit@debbugs.gnu.org; Tue, 04 Jul 2023 09:35:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGgBS-0002Xo-OS for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 09:35:10 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGgBP-0002zM-SZ for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2023 09:35:10 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-313e742a787so4825937f8f.1 for ; Tue, 04 Jul 2023 06:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688477705; x=1691069705; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=wMU1QahbRQ9mzyJXpBGBgbEveNvJPAPDCNWs3fCCzdE=; b=KaP7dO1fSLeIRSSWmUpSnMdmaAwTr3Liz3ZHdI0Ne4TMjUnhctDjVoJxR8g26n/QR/ C66C/6I9o7iYpggqiQXC8FyzBuo+qQ3h2UNJEclefwZWUBuDx63kXwBtDNwY1P6hfFyg gf3n1HX1rDW9DcvGBc+1B06q6qb9ymgfylHUeStz1uJjRN68lWYSprIPBl5FQUbFy0IL upRiFnaWzLy2vx6MebzEbjQ9KMegTvm54BoXFKKlYxqc7Fjy1fOwIBZO/s+JIcLkGKO2 aOj8Ok+FYJY0sKHM9BTWCuL3pyPyNRMt5dW1/zvvyoeQMx1+Bd5C5Ei4/FKQuXQ4lMnB hApQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688477705; x=1691069705; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wMU1QahbRQ9mzyJXpBGBgbEveNvJPAPDCNWs3fCCzdE=; b=VqYpQBo4nDcQi1YE/jjcFIFx3B8lE0gfQBLN/Mf7e/LR1PApfHqSSzI39ZcSodYFr4 MZKNlIe0pbkhEJumiBpFz8WHqOc4iqaMoL5c8ZaTCFKSx2uHoE7NawDbS/beMIaRqWpP WfuK2AdRYZQmo3GinlUF5P7kCMl65p5OlvfBSiUg2sAhTXJnz8SqoT/S4MbfGot/zUe1 Dd3qSsPP9Y574jV3XWbnKt4SgUXtgxjGf8ncBSmyaLWzZjiCi7Xwe9Fs5zufx/7rUL4F rdMy44a0Zn5dmabT3zeV+sh7khNV+nMOl3c8+rRXSIbHtmZHuHEA+ySDEpb10qT4NVjI p6UQ== X-Gm-Message-State: ABy/qLbVYdc768Lu8/4p7JsGU6Wo/bK0NAT9+Sx71xg3qpSA7fTfNgYg 5mztPXGxFUizynPUiJmSrJGPaGPjHCY= X-Google-Smtp-Source: APBJJlEPcGDYFCubNYsG5AvXMG08sY7anEkqxe3oxa7rwT2bn8wU+3zyTrwO/05M1pbs68jvlKhKTQ== X-Received: by 2002:adf:f84a:0:b0:314:140a:e629 with SMTP id d10-20020adff84a000000b00314140ae629mr14521859wrq.7.1688477704218; Tue, 04 Jul 2023 06:35:04 -0700 (PDT) Received: from phst-desktop.muc.corp.google.com ([2a00:79e0:15:10:d65e:42c5:c3f6:d404]) by smtp.gmail.com with ESMTPSA id c2-20020a5d4cc2000000b003143c9beeaesm2867961wrt.44.2023.07.04.06.35.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 06:35:03 -0700 (PDT) From: Philipp Stephani To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms Date: Tue, 04 Jul 2023 15:35:01 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=p.stephani2@gmail.com; helo=mail-wr1-x435.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Insert into *scratch*: (defun foo () (syntax-propertize-rules ((concat "")))) Now try to instrument this using C-u C-M-x. This will lead to an error "Eager macro-expansion failure": Debugger entered--Lisp error: (error "Eager macro-expansion failure: (void-= function edeb...") signal(error ("Eager macro-expansion failure: (void-function edeb...")) error("Eager macro-expansion failure: %S" (void-function edebug-after)) internal-macroexpand-for-load((setq elisp--eval-defun-result (let ((print= -level nil) (print-length nil)) (progn (defalias 'foo #'(lambda nil (edebug= -enter ... ... ...)))))) t) eval-region(146 200 nil #f(compiled-function (ignore) #)) ; Reading at buffer position 186 elisp--eval-defun() #f(compiled-function (edebug-it) "Evaluate top-level form around point an= d instrument it if EDEBUG-IT is non-nil.\nInteractively, EDEBUG-IT is the p= refix argument.\nIf `edebug-all-defs' is non-nil, that inverts the meaning = of EDEBUG-IT\nand the prefix argument: this function will instrument the fo= rm\nunless EDEBUG-IT is non-nil. The command `edebug-all-defs' toggles\nth= e value of the variable `edebug-all-defs'.\n\nIf point isn't in a top-level= form, evaluate the first top-level\nform after point. If there is no top-= level form after point,\nevaluate the first preceding top-level form.\n\nIf= the current defun is actually a call to `defvar' or `defcustom',\nevaluati= ng it this way resets the variable using its initial value\nexpression (usi= ng the defcustom's :set function if there is one), even\nif the variable al= ready has some other value. (Normally `defvar' and\n`defcustom' do not alt= er the value if there already is one.) In an\nanalogous way, evaluating a = `defface' overrides any customizations of\nthe face, so that it becomes def= ined exactly as the `defface' expression\nsays.\n\nIf `eval-expression-debu= g-on-error' is non-nil, which is the default,\nthis command arranges for al= l errors to enter the debugger.\n\nIf acting on a `defun' for FUNCTION, and= the function was\ninstrumented, `Edebug: FUNCTION' is printed in the echo = area. If not\ninstrumented, just FUNCTION is printed.\n\nIf not acting on = a `defun', the result of evaluation is displayed in\nthe echo area. This d= isplay is controlled by the variables\n`eval-expression-print-length' and `= eval-expression-print-level',\nwhich see." (interactive "P") #)(nil) edebug--eval-defun(#f(compiled-function (edebug-it) "Evaluate top-level f= orm around point and instrument it if EDEBUG-IT is non-nil.\nInteractively,= EDEBUG-IT is the prefix argument.\nIf `edebug-all-defs' is non-nil, that i= nverts the meaning of EDEBUG-IT\nand the prefix argument: this function wil= l instrument the form\nunless EDEBUG-IT is non-nil. The command `edebug-al= l-defs' toggles\nthe value of the variable `edebug-all-defs'.\n\nIf point i= sn't in a top-level form, evaluate the first top-level\nform after point. = If there is no top-level form after point,\nevaluate the first preceding to= p-level form.\n\nIf the current defun is actually a call to `defvar' or `de= fcustom',\nevaluating it this way resets the variable using its initial val= ue\nexpression (using the defcustom's :set function if there is one), even\= nif the variable already has some other value. (Normally `defvar' and\n`de= fcustom' do not alter the value if there already is one.) In an\nanalogous= way, evaluating a `defface' overrides any customizations of\nthe face, so = that it becomes defined exactly as the `defface' expression\nsays.\n\nIf `e= val-expression-debug-on-error' is non-nil, which is the default,\nthis comm= and arranges for all errors to enter the debugger.\n\nIf acting on a `defun= ' for FUNCTION, and the function was\ninstrumented, `Edebug: FUNCTION' is p= rinted in the echo area. If not\ninstrumented, just FUNCTION is printed.\n= \nIf not acting on a `defun', the result of evaluation is displayed in\nthe= echo area. This display is controlled by the variables\n`eval-expression-= print-length' and `eval-expression-print-level',\nwhich see." (interactive = "P") #) (4)) apply(edebug--eval-defun #f(compiled-function (edebug-it) "Evaluate top-l= evel form around point and instrument it if EDEBUG-IT is non-nil.\nInteract= ively, EDEBUG-IT is the prefix argument.\nIf `edebug-all-defs' is non-nil, = that inverts the meaning of EDEBUG-IT\nand the prefix argument: this functi= on will instrument the form\nunless EDEBUG-IT is non-nil. The command `ede= bug-all-defs' toggles\nthe value of the variable `edebug-all-defs'.\n\nIf p= oint isn't in a top-level form, evaluate the first top-level\nform after po= int. If there is no top-level form after point,\nevaluate the first preced= ing top-level form.\n\nIf the current defun is actually a call to `defvar' = or `defcustom',\nevaluating it this way resets the variable using its initi= al value\nexpression (using the defcustom's :set function if there is one),= even\nif the variable already has some other value. (Normally `defvar' an= d\n`defcustom' do not alter the value if there already is one.) In an\nana= logous way, evaluating a `defface' overrides any customizations of\nthe fac= e, so that it becomes defined exactly as the `defface' expression\nsays.\n\= nIf `eval-expression-debug-on-error' is non-nil, which is the default,\nthi= s command arranges for all errors to enter the debugger.\n\nIf acting on a = `defun' for FUNCTION, and the function was\ninstrumented, `Edebug: FUNCTION= ' is printed in the echo area. If not\ninstrumented, just FUNCTION is prin= ted.\n\nIf not acting on a `defun', the result of evaluation is displayed i= n\nthe echo area. This display is controlled by the variables\n`eval-expre= ssion-print-length' and `eval-expression-print-level',\nwhich see." (intera= ctive "P") #) (4)) eval-defun((4)) funcall-interactively(eval-defun (4)) call-interactively(eval-defun nil nil) command-execute(eval-defun) This fails on master and emacs-29, but not on emacs-28, so it's a regression that I think should be fixed before releasing Emacs 29. In GNU Emacs 30.0.50 (build 27, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-07-04 Repository revision: b8811f854ff2ea97c929d9f3f1674258ffc14cc1 Repository branch: syntax-propertize-rules-edebug Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=3Dwarn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=3Dall --enable-check-lisp-object-type --with-modules 'CFLAGS=3D-O0 -ggdb3'' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LC_MONETARY: en_DK.UTF-8 value of $LC_NUMERIC: en_DK.UTF-8 value of $LC_TIME: en_DK.UTF-8 value of $LANG: en_DK.UTF-8 value of $XMODIFIERS: @im=3Dibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug phst skeleton pcase ffap thingatpt url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core cl-macs json map byte-opt gv bytecomp byte-compile url-vars rx message sendmail mailcap yank-media dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader gnutls puny elp dbus xml subr-x compile text-property-search comint ansi-osc ansi-color ring cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 70027 11803) (symbols 48 8340 0) (strings 32 23360 2773) (string-bytes 1 713597) (vectors 16 16358) (vector-slots 8 219441 18429) (floats 8 45 47) (intervals 56 257 0) (buffers 976 11)) --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 09:43:07 2023 Received: (at 64459) by debbugs.gnu.org; 4 Jul 2023 13:43:07 +0000 Received: from localhost ([127.0.0.1]:35210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgJ9-0004Al-3p for submit@debbugs.gnu.org; Tue, 04 Jul 2023 09:43:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40628) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgJ5-0004A6-A5 for 64459@debbugs.gnu.org; Tue, 04 Jul 2023 09:43:05 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGgIz-0004t2-Q2; Tue, 04 Jul 2023 09:42:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rSr+qvC26SXU/yHpN0TRYIwFpPb7KYLhnJhi3c9oF68=; b=IggkwlYVvVYO lYK6hvsmOId1JX3QZ6CsnMtayQQgJ/Gepr8AX9djR0Qqx9cvek93+dhsm3PjvAlCvK0/cHI2SBr+3 eq0TiqhdBL7Jud7bQc1NhXohuSY/j1+oiltQRo2QdtE6AhKjmONKGak5EOKBW6HrUKveS9d8UgybX o9iBIqcGgHsVCGhpYm7roPM0AtiUW0527goBnZ/gmV0sL+eDSV01g2g2HV9W9GH0234+YYSvIbROQ WM1kBovBeEK+sfXmvORzEpQvyOt45/PG+ssEp/9DLMD8LsrdNElKupf7xCvdBP91rveFaPIls499t RWdWa1zKZaB/8NNSZAemhA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGgIy-00060p-WA; Tue, 04 Jul 2023 09:42:57 -0400 Date: Tue, 04 Jul 2023 16:42:52 +0300 Message-Id: <83a5wblrmr.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-Reply-To: (message from Philipp Stephani on Tue, 04 Jul 2023 15:35:01 +0200) Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Tue, 04 Jul 2023 15:35:01 +0200 > > This fails on master and emacs-29, but not on emacs-28, so it's a > regression that I think should be fixed before releasing Emacs 29. The part about this not being a problem in Emacs 28 is not true: if I try this in Emacs 28.2, I see in *Messages*: Edebug: foo Eager macro-expansion failure: (void-function edebug-after) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 10:06:23 2023 Received: (at 64459) by debbugs.gnu.org; 4 Jul 2023 14:06:23 +0000 Received: from localhost ([127.0.0.1]:36391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgff-0005Cj-Iq for submit@debbugs.gnu.org; Tue, 04 Jul 2023 10:06:23 -0400 Received: from mail-qv1-f54.google.com ([209.85.219.54]:61858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGgfa-0005CS-IN for 64459@debbugs.gnu.org; Tue, 04 Jul 2023 10:06:22 -0400 Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-635eb5b0320so41483156d6.3 for <64459@debbugs.gnu.org>; Tue, 04 Jul 2023 07:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688479573; x=1691071573; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=rxFcC/0gqWEYPf2lqx0idAdrR3R7ae/bLsIFBS5t2n4=; b=VSDzb2fVaZuJoxCOYV3WHxW+qCB16obWciOYKg+51BEeP62GL+dBdu+nZkPqp5x1JF NHzUovX1IK/UA7aaNgKN0nqCh7qSlDzheqn18+37dESlSVKxpujFI8ilJ4Tz4gA3bnOD 9PGhNIWJJGFegynAp9ogYldQFCGAzQFlv4T8jj+Slx84PEL+ap0KeAgjuhNjC4cLI8GE D59V+NuAumnafJgPNhDqL0t9Y19m5q/qqk4l+Ra80X2DW/IuqXcUSsq/1CigSu6s7fev LnNjoHHUDL54VP8wasE4Kr1cy37wK8sIdmPCagXGGv8u+/MFepP4LHN8TR00vwUMW0Jv f5pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688479573; x=1691071573; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rxFcC/0gqWEYPf2lqx0idAdrR3R7ae/bLsIFBS5t2n4=; b=iLJoHHE0J0lERvpi044dybKM3Z6NhVLxFvWM8pqpgYehNp84PZ1Jzu6jCeT0obSREG i/V3uIHHRrhWaPvJo2+j0q9M0NVRyF+7Vy2jRdHVhMCF0rdzjaeB6yQnjF0xyB1xxk6y Wg9yg6EgGvn4XoPE45r7ofzM4pAjwigIvuYF7BcFxkVFQX0CYHLWuK2l2RID2g7sZBdk vDngs0XAJ+YcUH0dpD4OClyhzVm/HF3GVHyz+UfJIi5l2wT3mBxIHwa5VFe7/4OtOeMH FaZY6eQgfzm+QhAtGQBv3ndVf2jIaJT53aYBz2MDm1s7uloW7EuW1soHALM4NvZ3Cn/s VqDQ== X-Gm-Message-State: ABy/qLbXBOpJHfKMl0ucyL8r8pkl+DSUdNMUYvFEB32/2zz+qdp5VRik zcGYEsbmLEUKj9nTmpz4puG7qZo4l/YRBnbUFkI= X-Google-Smtp-Source: APBJJlHVjEJfkKrsE/F9D3gM4hoiafXcwpjPgFuq74RrpfULRg5W+ZN3KHKukRnN6QrR4BUb8G/Qjcbjspsv/XrQD4U= X-Received: by 2002:a05:6214:124c:b0:5f7:a9e1:bbbf with SMTP id r12-20020a056214124c00b005f7a9e1bbbfmr18362494qvv.44.1688479572834; Tue, 04 Jul 2023 07:06:12 -0700 (PDT) MIME-Version: 1.0 References: <83a5wblrmr.fsf@gnu.org> In-Reply-To: <83a5wblrmr.fsf@gnu.org> From: Philipp Stephani Date: Tue, 4 Jul 2023 16:06:01 +0200 Message-ID: Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Di., 4. Juli 2023 um 15:42 Uhr schrieb Eli Zaretskii : > > > From: Philipp Stephani > > Date: Tue, 04 Jul 2023 15:35:01 +0200 > > > > This fails on master and emacs-29, but not on emacs-28, so it's a > > regression that I think should be fixed before releasing Emacs 29. > > The part about this not being a problem in Emacs 28 is not true: if I > try this in Emacs 28.2, I see in *Messages*: > > Edebug: foo > Eager macro-expansion failure: (void-function edebug-after) Ah, indeed. So it looks like the actual change between 28 and 29 is that macroexpansion failures are now hard errors. The easiest way to fix this is to replace the first `form' in the edebug spec with `sexp'. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 12:02:18 2023 Received: (at 64459) by debbugs.gnu.org; 4 Jul 2023 16:02:18 +0000 Received: from localhost ([127.0.0.1]:36462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGiTp-0007cM-Uk for submit@debbugs.gnu.org; Tue, 04 Jul 2023 12:02:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGiTl-0007c2-Pk for 64459@debbugs.gnu.org; Tue, 04 Jul 2023 12:02:17 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGiTf-00025M-Ti; Tue, 04 Jul 2023 12:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bCIQIzSmUfnLJlQdgCMakgg+EXxPRieA922gTYKfBCs=; b=aNC49IgIc9du r/LdS9QrwHkV7kjrKWi4WSf5wxk4qTQ08t4fTlNX6GdI2l8ciebvwZCssUbg0CKXtHVBeW6giqcRy acOrTpCEsmQwRYWMij7XdULGnG1ywl0Qj4qOFia622pjA5jnl8lgKnQAcV9COiFY6kR+GUp+I0pKR p0fnpF8uLDiU9Yb7GSwd10EH8ZWEK4NQxhNpxtsWsxAJz7/Pz06RhE9mo+NwAoEOoi6msEffXLp3B viP693izQjDm0AaLEJnfztG8TYWu5z5NRl4mWT8RDBWzkEhFN9ZdnLuQlfPlr8FbaREjDLzTX/wK5 xVLx5ITvLAC5t5VRfIvVAQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGiTf-0005pj-6E; Tue, 04 Jul 2023 12:02:07 -0400 Date: Tue, 04 Jul 2023 19:02:02 +0300 Message-Id: <838rbvll6t.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani , Stefan Monnier In-Reply-To: (message from Philipp Stephani on Tue, 4 Jul 2023 16:06:01 +0200) Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms References: <83a5wblrmr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Philipp Stephani > Date: Tue, 4 Jul 2023 16:06:01 +0200 > Cc: 64459@debbugs.gnu.org > > Am Di., 4. Juli 2023 um 15:42 Uhr schrieb Eli Zaretskii : > > > > > From: Philipp Stephani > > > Date: Tue, 04 Jul 2023 15:35:01 +0200 > > > > > > This fails on master and emacs-29, but not on emacs-28, so it's a > > > regression that I think should be fixed before releasing Emacs 29. > > > > The part about this not being a problem in Emacs 28 is not true: if I > > try this in Emacs 28.2, I see in *Messages*: > > > > Edebug: foo > > Eager macro-expansion failure: (void-function edebug-after) > > Ah, indeed. So it looks like the actual change between 28 and 29 is > that macroexpansion failures are now hard errors. > The easiest way to fix this is to replace the first `form' in the > edebug spec with `sexp'. Adding Stefan. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 16:56:50 2023 Received: (at 64459) by debbugs.gnu.org; 4 Jul 2023 20:56:50 +0000 Received: from localhost ([127.0.0.1]:36694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGn4s-00028q-1a for submit@debbugs.gnu.org; Tue, 04 Jul 2023 16:56:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGn4m-00028X-8e for 64459@debbugs.gnu.org; Tue, 04 Jul 2023 16:56:48 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A041E8073F; Tue, 4 Jul 2023 16:56:38 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 775AA805DB; Tue, 4 Jul 2023 16:56:37 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688504197; bh=RWKcPFjydIUS0MejSTmJgOeqAX+xayXXvE3NTEn5Dw0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BTAag6Fh+fS9n2VWIHxKrq5kuOeWWF+5wLfwlc5f1KxpsmBMmElcWpvQyEAOwEwdS 48SZq77ApDzyjdWm3E5CS4eV+j4Mhg0y5eFN6Evd3ulq2lGkzpVmbB/G8QcSND/clr Wm/9B2XG702+1jX5J4/F8XmU7pS28+K9Vlw865q2nSjnTjnFwFGCgz4mVPLECOQJp7 V/3qQo/Uh1/kxcWeg4KxduayfNSdVvG4scx6Mf/mQqcS/T3vi5azErNAjeRYvpm0qz wVXlhQ7FBJI0S+5mAlbiAxmHARvt7NYgiMj9VKE/u3FgHDnxAhJjj83tX67s+Bx2TP rwLnPba2fO3TQ== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5406B120228; Tue, 4 Jul 2023 16:56:37 -0400 (EDT) From: Stefan Monnier To: Philipp Stephani Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms In-Reply-To: (Philipp Stephani's message of "Tue, 04 Jul 2023 15:35:01 +0200") Message-ID: References: Date: Tue, 04 Jul 2023 16:56:36 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.075 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > (defun foo () (syntax-propertize-rules ((concat "")))) > > Now try to instrument this using C-u C-M-x. This will lead to an error > "Eager macro-expansion failure": > > Debugger entered--Lisp error: (error "Eager macro-expansion failure: (void-function edeb...") > signal(error ("Eager macro-expansion failure: (void-function edeb...")) I think the patch below should fix this problem. Can you confirm that it fixes it for you in a more realistic setting? Stefan diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el index d610fa005cc..002a24af18b 100644 --- a/lisp/emacs-lisp/syntax.el +++ b/lisp/emacs-lisp/syntax.el @@ -249,11 +249,12 @@ syntax-propertize-rules Note: There may be at most nine back-references in the REGEXPs of all RULES in total." (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. - (form &rest - (numberp - [&or stringp ;FIXME: Use &wrap - ("prog1" [&or stringp def-form] def-body) - def-form]))))) + (def-form + &rest + (numberp + [&or stringp ;FIXME: Use &wrap + ("prog1" [&or stringp form] def-body) + form]))))) (let ((newrules nil)) (while rules (if (symbolp (car rules)) From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 19:46:09 2023 Received: (at 64459) by debbugs.gnu.org; 4 Jul 2023 23:46:09 +0000 Received: from localhost ([127.0.0.1]:36808 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGpii-0006cS-Oa for submit@debbugs.gnu.org; Tue, 04 Jul 2023 19:46:09 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:23986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGpig-0006bp-VM for 64459@debbugs.gnu.org; Tue, 04 Jul 2023 19:46:07 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A9292809D7; Tue, 4 Jul 2023 19:46:01 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 509C6801BE; Tue, 4 Jul 2023 19:46:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688514360; bh=ZZsC6FuIJ0q5tsIy/oGJrXNJi8H1pk7hD9mbySKwvqg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YbGDpqewoRmP3KD2kxEFxZ9dujqQ9EXJ37QPiGZ5KdZIev7W1aKEEpws/FdMQShJM R2rA8acYqkzTaXCevm6z12PhtBPEK7KeyjYuwJ/YsIvK8pqn0Ycj434pBpv20rTl5g SxNlU5IQ4Sy6aSbZPS+4+8py0VigR8QHsVIY1Fjv0KhhewPcZllB57kVAClU1c7X7d NMg66NSKFMsgfklSZttAZ5kviMdPIdWNGEZ3VebzAqYrxSIB2ZMldGfGELzaDD1Q9p j1vqv045pHrcr9vRBjBNwNGjms6VUqQyrPYCsIdAy305Hut+K6n2Y1xiFKAwEUmqaC JizT0NWqUPrdQ== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 30BE91201E7; Tue, 4 Jul 2023 19:46:00 -0400 (EDT) From: Stefan Monnier To: Philipp Stephani Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms In-Reply-To: (Stefan Monnier's message of "Tue, 04 Jul 2023 16:56:36 -0400") Message-ID: References: Date: Tue, 04 Jul 2023 19:45:59 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el > index d610fa005cc..002a24af18b 100644 > --- a/lisp/emacs-lisp/syntax.el > +++ b/lisp/emacs-lisp/syntax.el > @@ -249,11 +249,12 @@ syntax-propertize-rules > Note: There may be at most nine back-references in the REGEXPs of > all RULES in total." > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. > - (form &rest > - (numberp > - [&or stringp ;FIXME: Use &wrap > - ("prog1" [&or stringp def-form] def-body) > - def-form]))))) > + (def-form > + &rest > + (numberp > + [&or stringp ;FIXME: Use &wrap > + ("prog1" [&or stringp form] def-body) > + form]))))) > (let ((newrules nil)) > (while rules > (if (symbolp (car rules)) No, this one introduces a regression. Try that one: Stefan diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el index d610fa005cc..41db2981d8c 100644 --- a/lisp/emacs-lisp/syntax.el +++ b/lisp/emacs-lisp/syntax.el @@ -249,11 +249,12 @@ syntax-propertize-rules Note: There may be at most nine back-references in the REGEXPs of all RULES in total." (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. - (form &rest - (numberp - [&or stringp ;FIXME: Use &wrap - ("prog1" [&or stringp def-form] def-body) - def-form]))))) + (def-form + &rest + (numberp + [&or stringp ;FIXME: Use &wrap + ("prog1" [&or stringp def-form] def-body) + def-form]))))) (let ((newrules nil)) (while rules (if (symbolp (car rules)) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 05:34:26 2023 Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 09:34:26 +0000 Received: from localhost ([127.0.0.1]:37117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGyu2-0005VN-BK for submit@debbugs.gnu.org; Wed, 05 Jul 2023 05:34:26 -0400 Received: from mail-qv1-f50.google.com ([209.85.219.50]:47386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGyty-0005V7-PY for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 05:34:24 -0400 Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-635dccdf17dso46466256d6.3 for <64459@debbugs.gnu.org>; Wed, 05 Jul 2023 02:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688549657; x=1691141657; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=t56btCJ7DTWC0I1wibCKKftcByuYUOuGrJB7o/DTjlc=; b=dUu3fx4BO/pMaaen98LH6Re9fiqV5GERdZejJAvt80RZMYAxeZxMlgZimW0HCzgvJw 2QM4d1iSgVmdr6qcRWNjm6igL42GEkfoGYDVYzRQR41Qrq67wAbOjWQSVVs3e5yOPd45 x3E82arQO5qWXyd+EQvy/7e8sIaoK01yD+1UhSPG7oPaVwL+6Ykx1Vb7fhtHQYNItklo AtdIiFCIH2PozAxjkw6t8pHwkB80QXUMgjY1w5Cih28gc+VB5cl1g+zdJ4U3P+hvRVLK NOwZs3NNca83hSdp4k2ekrmG1zbR0bq5lV1H1scWh+OZA6repmTJlLpvObjWcJBQnJ2c m+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688549657; x=1691141657; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=t56btCJ7DTWC0I1wibCKKftcByuYUOuGrJB7o/DTjlc=; b=WMOdBJX+S9BUjz/9YqbEbuRhTlbwLLCCQiHYBWuljLUuc+LLD3HuaADdZiNPCIpExA Z1DuUMvVyb8tabKkQ7o9pWMbk/t14Zz0qtLny+CimuQ8TVyj+4HLVTVyXGn+ujEq+EaQ hvJs+JUHe634m9EJ2Mn3AyOsGLyplGa2H8Kj49TL+iCtYZFzLFVQ59Jo9WRGmbsWOT0m ZqdwXQ+Ezf102lWFV83z/AR1StcKIxX+cXs/NlfnKPb/b/UZ+rLwQqfxJKGo56iShyew bDgSPUOvMhRwvTfPd7ga/yP5cqsHGujGd7u9DInDXx7ASGB73rzpClQ+0xnAbgLU245L aZwA== X-Gm-Message-State: ABy/qLbnjMptRGdKr1lKPT5nBqLDxpV/S5CAt08DN7zzPDWiWAdaXuby Lwllqa2vuYpniTvh6H7/rJy5cucCbZGOwltfRHc= X-Google-Smtp-Source: APBJJlHL/Z+NfrTIRR+oLvi56LL31OEb4mgJJLwZbwPDdWBdACl4caVpd8L0y+2sYTrjydOFDym4gefyosq5NoHVSIs= X-Received: by 2002:a05:6214:1c4d:b0:626:1be5:177b with SMTP id if13-20020a0562141c4d00b006261be5177bmr17232804qvb.65.1688549656934; Wed, 05 Jul 2023 02:34:16 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Philipp Stephani Date: Wed, 5 Jul 2023 11:34:06 +0200 Message-ID: Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Am Mi., 5. Juli 2023 um 01:46 Uhr schrieb Stefan Monnier : > > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el > > index d610fa005cc..002a24af18b 100644 > > --- a/lisp/emacs-lisp/syntax.el > > +++ b/lisp/emacs-lisp/syntax.el > > @@ -249,11 +249,12 @@ syntax-propertize-rules > > Note: There may be at most nine back-references in the REGEXPs of > > all RULES in total." > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. > > - (form &rest > > - (numberp > > - [&or stringp ;FIXME: Use &wrap > > - ("prog1" [&or stringp def-form] def-body) > > - def-form]))))) > > + (def-form > > + &rest > > + (numberp > > + [&or stringp ;FIXME: Use &wrap > > + ("prog1" [&or stringp form] def-body) > > + form]))))) > > (let ((newrules nil)) > > (while rules > > (if (symbolp (car rules)) > > No, this one introduces a regression. Try that one: > Yeah, that works at least in the cases I've tested. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 07:33:21 2023 Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 11:33:21 +0000 Received: from localhost ([127.0.0.1]:37702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0l7-0003GQ-EV for submit@debbugs.gnu.org; Wed, 05 Jul 2023 07:33:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43080) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0l4-0003G8-Ps for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 07:33:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0ky-0000xH-62; Wed, 05 Jul 2023 07:33:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l+G3/eGvAyXyZbnUjiUfrioOjBfrm27nyVGBuLgUty0=; b=ak/rH40uJL7I GGR4pucuU4uYfD8fBMEysumMSM//35DOdmXBC2E5AdNZdLlxLttEYh3NSQyT3Z50D1ScmxhM5ymsP A0aZlbbW6J4IwvT6mn5XfXRmiq8gNLfogFHO94PhjN+OpI1k+nAVKR5qB+DRT7e/UXjRHXFUhqwJz ovq+Ul3Agb61P3jkyi+pmJCGJDhuK7scxbB0nBl1C2amaLTpAs4n0rwF5WVPbDTNQu3/wiWggr0b0 OXj1MSUCNepi3bMAplSTMAYA2ss/VkVifZVIMKMRQjkEwXfo6DGF5ytEZ3hQ03FQaqWqvpRdxeJ7+ uonEd4nsndviiC0iLH+YBg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0kx-00038F-6c; Wed, 05 Jul 2023 07:33:11 -0400 Date: Wed, 05 Jul 2023 14:33:08 +0300 Message-Id: <83ilayk2yz.fsf@gnu.org> From: Eli Zaretskii To: Philipp Stephani In-Reply-To: (message from Philipp Stephani on Wed, 5 Jul 2023 11:34:06 +0200) Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: 64459@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 64459@debbugs.gnu.org > From: Philipp Stephani > Date: Wed, 5 Jul 2023 11:34:06 +0200 > > Am Mi., 5. Juli 2023 um 01:46 Uhr schrieb Stefan Monnier > : > > > > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el > > > index d610fa005cc..002a24af18b 100644 > > > --- a/lisp/emacs-lisp/syntax.el > > > +++ b/lisp/emacs-lisp/syntax.el > > > @@ -249,11 +249,12 @@ syntax-propertize-rules > > > Note: There may be at most nine back-references in the REGEXPs of > > > all RULES in total." > > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. > > > - (form &rest > > > - (numberp > > > - [&or stringp ;FIXME: Use &wrap > > > - ("prog1" [&or stringp def-form] def-body) > > > - def-form]))))) > > > + (def-form > > > + &rest > > > + (numberp > > > + [&or stringp ;FIXME: Use &wrap > > > + ("prog1" [&or stringp form] def-body) > > > + form]))))) > > > (let ((newrules nil)) > > > (while rules > > > (if (symbolp (car rules)) > > > > No, this one introduces a regression. Try that one: > > > > Yeah, that works at least in the cases I've tested. Thanks! Stefan, this is for master, right? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 08:43:31 2023 Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 12:43:31 +0000 Received: from localhost ([127.0.0.1]:37887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH1r1-0005Ia-I8 for submit@debbugs.gnu.org; Wed, 05 Jul 2023 08:43:31 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:30700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH1qy-0005IN-Ag for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 08:43:29 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 164781000DC; Wed, 5 Jul 2023 08:43:23 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id A777510002F; Wed, 5 Jul 2023 08:43:17 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688560997; bh=fLGEL6beT29nwhy1Elch1moE2uaJcze6X8EakcRxYyM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X3sdaj2n4J1GfMdtijvZk7hEyzMm98LkqAzcTaRQEW434US00lRqofrKWSMzvwbHj fD52+iMwxbqFsrCLQlcgv6jeT0m+F4vcVslk7CSOF8v0l7jPGt43rcZ8lg4ZWryt/r t4IAt2O/yBK0zKK5EzXIlQ87UZYZ/v7robF9lkEP5jmTsE+glQoCH4IShE3x2aVkNC qZGcr0jyS3hZ9LTT9ncr6sWaAiP12MWTID626T3tpcu6QO7FCGUKM9+n7fwaPO2dgG Jan0sjl1u7YhR+uA0ywInd7pqPmZ5UJ3eMDl1QXbqOgVfIKV1t6lf+3V1N+rL84oMd GHyUR6t2155gg== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7EA9D1204C0; Wed, 5 Jul 2023 08:43:17 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms In-Reply-To: <83ilayk2yz.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jul 2023 14:33:08 +0300") Message-ID: References: <83ilayk2yz.fsf@gnu.org> Date: Wed, 05 Jul 2023 08:43:15 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.179 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: Philipp Stephani , 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el >> > > index d610fa005cc..002a24af18b 100644 >> > > --- a/lisp/emacs-lisp/syntax.el >> > > +++ b/lisp/emacs-lisp/syntax.el >> > > @@ -249,11 +249,12 @@ syntax-propertize-rules >> > > Note: There may be at most nine back-references in the REGEXPs of >> > > all RULES in total." >> > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. >> > > - (form &rest >> > > - (numberp >> > > - [&or stringp ;FIXME: Use &wrap >> > > - ("prog1" [&or stringp def-form] def-body) >> > > - def-form]))))) >> > > + (def-form >> > > + &rest >> > > + (numberp >> > > + [&or stringp ;FIXME: Use &wrap >> > > + ("prog1" [&or stringp form] def-body) >> > > + form]))))) >> > > (let ((newrules nil)) >> > > (while rules >> > > (if (symbolp (car rules)) >> > >> > No, this one introduces a regression. Try that one: >> > >> >> Yeah, that works at least in the cases I've tested. Thanks! > > Stefan, this is for master, right? Yes: if you want it for `emacs-29`, I do think it's perfectly safe (it just replaces the one `form` with `def-form`), but I don't see any urgency here. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 09:35:13 2023 Received: (at 64459) by debbugs.gnu.org; 5 Jul 2023 13:35:13 +0000 Received: from localhost ([127.0.0.1]:37960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH2f3-0006cb-5K for submit@debbugs.gnu.org; Wed, 05 Jul 2023 09:35:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41578) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH2f0-0006cN-H4 for 64459@debbugs.gnu.org; Wed, 05 Jul 2023 09:35:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH2eu-0002ft-DK; Wed, 05 Jul 2023 09:35:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QsMwx33G3F8w6lRhuBaoMPBSgl9VkNYbrXArAM0WDqE=; b=P8mqaWU0kUKs Kw6EhyTihvIHhaN/Q9P/2l6kWDxvo8tQcCaKXNNzVqSIo50xk/Xzn3+I+Fa8onqvRamg6KJchNo2m wzGhH4f+2MAq1w1EcgPd+hrcEm89GYXS4S19CYKPTe6F4RRw9KkeC1QaClg5lTPDhmzw3eZke2Ate vnq7kBP7TFmByXIih4sswx+PTfBdMWLv/NmfARfq7x1auiy/9dKRu6GxoF9ax9ejdVNGKLp0glRRv CWW2jCOk2qTZ4mFSB0zQIF+8SqdL5T3fQC8BaWVW5M5bLxmEu7bsYE4tBQ378k9D308Y8B/0OblLt s/z8xT1B1vVQlVAowyF+8A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH2es-0006oJ-AM; Wed, 05 Jul 2023 09:35:03 -0400 Date: Wed, 05 Jul 2023 16:35:01 +0300 Message-Id: <835y6yjxbu.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Wed, 05 Jul 2023 08:43:15 -0400) Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms References: <83ilayk2yz.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459 Cc: p.stephani2@gmail.com, 64459@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Philipp Stephani , 64459@debbugs.gnu.org > Date: Wed, 05 Jul 2023 08:43:15 -0400 > > >> > > diff --git a/lisp/emacs-lisp/syntax.el b/lisp/emacs-lisp/syntax.el > >> > > index d610fa005cc..002a24af18b 100644 > >> > > --- a/lisp/emacs-lisp/syntax.el > >> > > +++ b/lisp/emacs-lisp/syntax.el > >> > > @@ -249,11 +249,12 @@ syntax-propertize-rules > >> > > Note: There may be at most nine back-references in the REGEXPs of > >> > > all RULES in total." > >> > > (declare (debug (&rest &or symbolp ;FIXME: edebug this eval step. > >> > > - (form &rest > >> > > - (numberp > >> > > - [&or stringp ;FIXME: Use &wrap > >> > > - ("prog1" [&or stringp def-form] def-body) > >> > > - def-form]))))) > >> > > + (def-form > >> > > + &rest > >> > > + (numberp > >> > > + [&or stringp ;FIXME: Use &wrap > >> > > + ("prog1" [&or stringp form] def-body) > >> > > + form]))))) > >> > > (let ((newrules nil)) > >> > > (while rules > >> > > (if (symbolp (car rules)) > >> > > >> > No, this one introduces a regression. Try that one: > >> > > >> > >> Yeah, that works at least in the cases I've tested. Thanks! > > > > Stefan, this is for master, right? > > Yes: if you want it for `emacs-29`, I do think it's perfectly safe (it > just replaces the one `form` with `def-form`), but I don't see any > urgency here. I don't see any urgency, either, since this problem existed at least since Emacs 28. So please install on master, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 11:38:07 2023 Received: (at 64459-done) by debbugs.gnu.org; 5 Jul 2023 15:38:07 +0000 Received: from localhost ([127.0.0.1]:38814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH4Zy-0001fs-R5 for submit@debbugs.gnu.org; Wed, 05 Jul 2023 11:38:07 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:47997) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH4Zx-0001fO-GU for 64459-done@debbugs.gnu.org; Wed, 05 Jul 2023 11:38:05 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3F6218080D; Wed, 5 Jul 2023 11:38:00 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3405B80443; Wed, 5 Jul 2023 11:37:59 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688571479; bh=MjfP8/2zfI4TFc6d/ms7t6QFs5R/md8MrsNBQB/QjTM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=A6anW9jwjB23Fyc/JMh7ru9vQdCopl0fFAQv0CeoMZ/UYQdWXiJNmlcAL1OD5Z5sG Hlo0uo5DZS5tC5Hsw24l565iWIY1IbB3pb0i9i9eluBYMc58bqK3aDAMXUJI/20Pl9 dTuWgP5p3xM8TT6oe+0oBENQ2U8durH4gYbIcGV1incbbeMV8nG+Y85Pr5+aF/dV6o MqezgRNRyAcw+CHhiPLbeH7wnQ/jscKtKASxwhWwGbJRpdO8oLep5MNo7XQ+e/kKTt zW9t6ekJIkWQU1Cft/w7OMiL+4/6mdCK4oWGz7ddBls/fdtRYmW3RNga8l90mqhLcW 7BrqG5oAbPF0Q== Received: from pastel (69-165-155-162.dsl.teksavvy.com [69.165.155.162]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0AAA61202A8; Wed, 5 Jul 2023 11:37:59 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#64459: 30.0.50; Edebug can't instrument certain syntax-propertize-rules forms In-Reply-To: <835y6yjxbu.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jul 2023 16:35:01 +0300") Message-ID: References: <83ilayk2yz.fsf@gnu.org> <835y6yjxbu.fsf@gnu.org> Date: Wed, 05 Jul 2023 11:37:58 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64459-done Cc: p.stephani2@gmail.com, 64459-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > So please install on master, and thanks. Installed, thanks, Setfan From unknown Tue Sep 09 11:47:03 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Aug 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator