Subject: Re: bug#64454: 30.0.50; In-Reply-To header obsolete content

From: Robert Pluim <[email-masked]>
Date: Tue, 04 Feb 2025 10:00:35 +0100

>>>>> On Tue, 04 Feb 2025 09:50:55 +0800, Andrew Cohen <[email-masked]> said:

    Andrew> I fixed this in my tree but never got around to pushing the result. I'll
    Andrew> push the following unless there are changes that are needed.

Only minor comments below.

    Andrew> Best,
    Andrew> Andy

    Andrew> da900f025e9ed5e8d0e5aa9fb6bf9f5d54436c6c
    Andrew> Author:     Andrew G Cohen <[email-masked]>
    Andrew> AuthorDate: Wed Jul 5 15:21:16 2023 +0800
    Andrew> Commit:     Andrew G Cohen <[email-masked]>
    Andrew> CommitDate: Tue Feb 4 09:45:29 2025 +0800

    Andrew> Parent:     2dc8c54341e Fix crashes on XI devices being disabled (bug#75870)
    Andrew> Merged:     master
    Andrew> Contained:  feature/igc
    Andrew> Follows:    emacs-29.1.90 (176367)

    Andrew> Don't use obsolete In-Reply-To header format in messages

    Andrew> When creating a new message, message-send-mail uses an obsolete format
    Andrew> for the In-Reply-To header that includes additional information about
    Andrew> the originating message.  This patch changes the default to use the
    Andrew> rfc5322 approved format, but allow the obsolete format through a
    Andrew> defcustom.

    Andrew> * lisp/gnus/message.el (message-make-in-reply-to): Return only the
    Andrew> message-id of the originating message (the default) unless the new
    Andrew> custom variable message-header-use-obsolete-in-reply-to is non-nil.
    Andrew> * doc/misc/message.texi: Document the new custom variable
    Andrew> message-header-use-obsolete-in-reply-to.

This new user option, its default value, and the behaviour change
should be documented in NEWS

Also please put (Bug#64454) somewhere in the commit message

    Andrew> 2 files changed, 44 insertions(+), 28 deletions(-)
    Andrew> doc/misc/message.texi |  6 +++++
    Andrew> lisp/gnus/message.el  | 66 +++++++++++++++++++++++++++++----------------------

    Andrew> modified   doc/misc/message.texi
    Andrew> @@ -1791,6 +1791,12 @@ Message Headers
    Andrew>  @code{message-carefully-insert-headers} will not insert a @code{To}
    Andrew>  header when the message is already @code{CC}ed to the recipient.
 
    Andrew> +@item message-header-use-obsolete-in-reply-to
    Andrew> +@vindex message-header-use-obsolete-in-reply-to
    Andrew> +Use an obsolete form of the @code{In-Reply-To} header that includes a
    Andrew> +parenthetical phrase with details of the originating email following
    Andrew> +the message id.  The default is @code{nil}.
    Andrew> +

"When non-@code{nil}, " or similar

    Andrew>  @item message-syntax-checks
    Andrew>  @vindex message-syntax-checks
    Andrew>  Controls what syntax checks should not be performed on outgoing posts.
    Andrew> modified   lisp/gnus/message.el
    Andrew> @@ -113,6 +113,13 @@ message-faces
    Andrew>    :group 'message
    Andrew>    :group 'faces)
 
    Andrew> +(defcustom message-header-use-obsolete-in-reply-to nil
    Andrew> +  "Include extra information in the In-Reply-To header (this form
    Andrew> +has been obsolete since RFC 2822.)"
    Andrew> +  :group 'message-headers
    Andrew> +  :version "31.1"
    Andrew> +  :type 'boolean)
    Andrew> +

The first sentence of the docstring should fit on a single line. The
reference to RFC 2822 can go in the body

    Andrew>  (defcustom message-directory "~/Mail/"
    Andrew>    "Directory from which all other mail file variables are derived."
    Andrew>    :group 'message-various
    Andrew> @@ -5993,35 +6000,38 @@ message-make-in-reply-to
    Andrew>    "Return the In-Reply-To header for this message."
    Andrew>    (when message-reply-headers
    Andrew>      (let ((from (mail-header-from message-reply-headers))
    Andrew> -	  (date (mail-header-date message-reply-headers))
    Andrew> -	  (msg-id (mail-header-id message-reply-headers)))
    Andrew> +          (date (mail-header-date message-reply-headers))
    Andrew> +          (msg-id (mail-header-id
    Andrew>    message-reply-headers)))

Ah, the side-effects of `indent-tabs-mode' being nil for
`emacs-lisp-mode' now 🙂 (no change needed)

Robert
--