From unknown Fri Aug 15 12:48:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64452 <64452@debbugs.gnu.org> To: bug#64452 <64452@debbugs.gnu.org> Subject: Status: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Reply-To: bug#64452 <64452@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:48:52 +0000 retitle 64452 [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *= Async-native-compile-log* reassign 64452 emacs submitter 64452 No Wayman severity 64452 wishlist tag 64452 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 03 20:30:39 2023 Received: (at submit) by debbugs.gnu.org; 4 Jul 2023 00:30:39 +0000 Received: from localhost ([127.0.0.1]:34705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTwE-0002kL-W4 for submit@debbugs.gnu.org; Mon, 03 Jul 2023 20:30:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:49552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGTw8-0002k9-IQ for submit@debbugs.gnu.org; Mon, 03 Jul 2023 20:30:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGTw8-0000jA-A3 for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:30:32 -0400 Received: from mail-qk1-x734.google.com ([2607:f8b0:4864:20::734]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qGTw6-00084W-It for bug-gnu-emacs@gnu.org; Mon, 03 Jul 2023 20:30:32 -0400 Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-7656652da3cso432391885a.1 for ; Mon, 03 Jul 2023 17:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688430628; x=1691022628; h=mime-version:message-id:date:subject:to:from:user-agent:from:to:cc :subject:date:message-id:reply-to; bh=4aDdlVz9Fj5FwRCzIcTda+n+vEI8ew1iK1yc3RJzEM0=; b=l22sMMbO7pmvTJ0U5KF+1Cs7Jwz59Pa07amEQn/9iwYFm0IO5j+jWK05wPoO5Uhyyv ihjdb9LNh424vq/bKYWSJZul8o83o8E4D11om/XTbAMszOOqjQci+CXX7K517cj1gY0b MCTciTIxghgXn+s5t+JqbyXuAfL7TEIP9s37RYANgeBmBfEduq5HGthl/gqaYcCR4tot pexqQFzSQagZEpK4D4lMGBMZpBoqKt7p+k22rdaly957+akFKiiV05BV2brJdNcmOaIj 2Nj2aeLZrfU3z45ItmqzWVKUo+/HDDEwHzolQFMTSSucTqnMj61tYYZgYBzGi+6AxpNA bOXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688430628; x=1691022628; h=mime-version:message-id:date:subject:to:from:user-agent :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4aDdlVz9Fj5FwRCzIcTda+n+vEI8ew1iK1yc3RJzEM0=; b=ZTNoa2ZxoXk7JfSzkItblKskfvg3R1nieXNo8BESap0j1SXPsHZ+26hOfT0xzIHhug VOEUECcnhxYWtHaglzactiHpMKVVBETPPq8aEqKENFqnf81OdV3ReEBp3501CtY9KHo4 zjp2rxAAtPm0qGXHIPNQ7MQagXLie0d6ZrFJ96kKheYqazSuPy51IfxrPSaSGA5m1FFm Iy6QCNGZDvUPKlYfYtQNRYC62inp8ICHRfj9D1qFXgPfR8/AIZOI4VgMmlT8JaF8ytHS HR6qBU0MWnugmUZYmStoBpquyRTZ2AhibTFImfEpaO/TrUJKWNsljnU3oEQgFp7bnGRY KtIw== X-Gm-Message-State: ABy/qLZi0bZiEq+qBCizImtghsGMcZrtfMs8iXdPIAZRCKbkWh6ic279 u74/Vjw3kzG1t0WAbYFjCYW5vLNC9FjMKA== X-Google-Smtp-Source: APBJJlGPZx7lEJyjlAd/pMRd1edUlhXjSer3B2Y2rPi/EixOxhImS/ojvofNt9ACYJySIf33JArksw== X-Received: by 2002:a05:620a:1928:b0:767:2ccf:1e2f with SMTP id bj40-20020a05620a192800b007672ccf1e2fmr14538433qkb.57.1688430627656; Mon, 03 Jul 2023 17:30:27 -0700 (PDT) Received: from laptop ([2601:84:847f:c697:2d4:9eff:feb6:970c]) by smtp.gmail.com with ESMTPSA id i21-20020a05620a075500b007677f66b160sm195555qki.124.2023.07.03.17.30.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jul 2023 17:30:27 -0700 (PDT) User-agent: mu4e 1.11.7; emacs 30.0.50 From: No Wayman To: bug-gnu-emacs@gnu.org Subject: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Mon, 03 Jul 2023 20:13:23 -0400 Message-ID: <87sfa44ixh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::734; envelope-from=iarchivedmywholelife@gmail.com; helo=mail-qk1-x734.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; format=flowed Unless there is good reason not to use special-mode, it'd be nice to have the typical special-mode bindings (quit-window especially) in these buffers. Rough draft patch attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comp.el-use-special-mode-for-log-buffers.patch >From d2aad9faf904bfd197e0dd30a178f1bf05821c0c Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Mon, 3 Jul 2023 20:23:00 -0400 Subject: [PATCH] * comp.el: use special-mode for log buffers (comp-log-to-buffer): ensure comp-log-buffer in special-mode (comp-run-async-workers): ensure comp-async-buffer in special-mode --- lisp/emacs-lisp/comp.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 22fb08e4688..20aee2006fa 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1133,7 +1133,7 @@ comp-log-to-buffer (log-buffer (or (get-buffer comp-log-buffer-name) (with-current-buffer (get-buffer-create comp-log-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'special-mode) (special-mode)) (current-buffer)))) (log-window (get-buffer-window log-buffer)) (inhibit-read-only t) @@ -4085,7 +4085,8 @@ comp-run-async-workers :buffer (with-current-buffer (get-buffer-create comp-async-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'special-mode) + (special-mode)) (current-buffer)) :command (list (expand-file-name invocation-name @@ -4119,6 +4120,7 @@ comp-run-async-workers (run-hooks 'native-comp-async-all-done-hook) (with-current-buffer (get-buffer-create comp-async-buffer-name) (save-excursion + (unless (derived-mode-p 'special-mode) (special-mode)) (let ((inhibit-read-only t)) (goto-char (point-max)) (insert "Compilation finished.\n")))) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 07:01:47 2023 Received: (at 64452) by debbugs.gnu.org; 4 Jul 2023 11:01:47 +0000 Received: from localhost ([127.0.0.1]:35076 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGdn0-0005nC-Ro for submit@debbugs.gnu.org; Tue, 04 Jul 2023 07:01:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGdmz-0005my-28 for 64452@debbugs.gnu.org; Tue, 04 Jul 2023 07:01:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGdmt-0003d6-A9; Tue, 04 Jul 2023 07:01:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Bf1N7LUQix31d5XsJ6guOFGAb541EjEp4ANaI457p2I=; b=P6m7LXtDZ4Lh B2k3aDIOQA/Wghzx7Ueh02VukNZPzGsA01HJZYaHkxm5YHuVoMGltcZ6TSKOc8nXMpvfUa4UTn6cf IRe5OwH50BHoD7Z1VP3B/AGT3Gf8UkhaKSpugIdZsOFCUs+FGwUmEMiXKKQzhUVuZz6Ye+IM5KFcV ShCCstZLNqQjPG7mJH3+ACI0qN0n6ZBez5HubbBtPo9uL9KoXxsLrctUvxwNL4cUue4hbZa52C3rX Ff7JjzwgRpIjWo8HabYmdaTFTHpvzfUeb1d+6+JQfyNTl20hHb3Y6eJpwUh/6qtx08RuPbfakVGWE vH3xhXGq7R1F7de2CDWdXg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGdms-0008C0-Kb; Tue, 04 Jul 2023 07:01:38 -0400 Date: Tue, 04 Jul 2023 14:02:15 +0300 Message-Id: <83zg4ckki0.fsf@gnu.org> From: Eli Zaretskii To: No Wayman , Andrea Corallo , Stefan Monnier In-Reply-To: <87sfa44ixh.fsf@gmail.com> (message from No Wayman on Mon, 03 Jul 2023 20:13:23 -0400) Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* References: <87sfa44ixh.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64452 Cc: 64452@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: No Wayman > Date: Mon, 03 Jul 2023 20:13:23 -0400 > > Unless there is good reason not to use special-mode, it'd be nice > to have the typical special-mode bindings (quit-window especially) > in these buffers. > > Rough draft patch attached. Thanks, but why not elisp-compile-mode, like we do in *Compile-log* buffers for byte compilation? From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 04 18:22:49 2023 Received: (at 64452) by debbugs.gnu.org; 4 Jul 2023 22:22:49 +0000 Received: from localhost ([127.0.0.1]:36747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGoQ5-0004WY-EK for submit@debbugs.gnu.org; Tue, 04 Jul 2023 18:22:49 -0400 Received: from mail-qk1-f171.google.com ([209.85.222.171]:44245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGoQ2-0004WI-Ef for 64452@debbugs.gnu.org; Tue, 04 Jul 2023 18:22:47 -0400 Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-765a6bbddd6so512036985a.0 for <64452@debbugs.gnu.org>; Tue, 04 Jul 2023 15:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688509360; x=1691101360; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=txALNBnlafB4RXbni8ws/KMpwGfcjlSJXjSQnBuz7jM=; b=RYg5/6RWrT7lvrY6BpG6lmBD4yr+lrKB98+9+DvUVUbxeyAyDP4dWys1sFT1OjhZsO YV7M6ldJaYr66bc29YrgRDfFeU8cp1iqpZwYVp+PpmT3DueFMpLP13RM3wCezh4MJsWj cSvrQc3uTaX18Vcwrn+cYXak3VAe0FNbw67QtKX+IGN7xlwc9ZnQvLt9WuWP4x5Z+3p+ J+lUBulrj6EG5E3quBMYxZopjt9/5Muq38TVE4WZ/gYp/ezbZ8AOsQHC1GhHHewi2bL5 0jYRGWOxX9ArK+Z0lBv4vxmxDXS0n7c+1hhd0hCxN3SfVnjDljb/jpTjtGQQDlq/oVJL /EHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688509360; x=1691101360; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=txALNBnlafB4RXbni8ws/KMpwGfcjlSJXjSQnBuz7jM=; b=lvQIDmDVl6XxVOnaR5g7ByN13gXjI/eiDMpYUocDOXwmSv+kIVEu5Snor3JYfo3Pfg vQ2EFrMIacy5J4eVXPSICf0o7E97R/mmLPLazK9fFLAABXU5uCNHSu7vJvk0UvVgJ6Tu QABpZyzKFancrmADK1Lp3cyUXFI5Fiunuh9pvKmGI7LzY5QbJ+EXmv2Uo0JPSTyXqtiT uVck2upGg7L1mQgIMXi3zNsZegFmpodBT1rhi3+oBQq3Z2BDGhmfLkN58TVooTAvumZI J+5A2iQ4ZkT5ZnBopv1t3ogFDbaiGncWbGHXserM4xihDDtI/sDOxU1Q3ylWDPZ1JCJE PrcA== X-Gm-Message-State: AC+VfDx0jZqPeghL1xWoxgt7kGdVhtukznAMXpBmmRusALwoIISjxV1u fgW9rwX9FhRxPdURW/toOmY6bfoyYrkfmhYY X-Google-Smtp-Source: ACHHUZ7rwulBjmgJ6LkFkNPN14fotySrHBvGCG+80NQgLHnQLIR0BzwrcWqC16n8WhJhYzGgbAdL6w== X-Received: by 2002:a05:620a:404e:b0:767:3cfa:dc0f with SMTP id i14-20020a05620a404e00b007673cfadc0fmr15972631qko.25.1688509360284; Tue, 04 Jul 2023 15:22:40 -0700 (PDT) Received: from laptop ([2601:84:847f:c697:2d4:9eff:feb6:970c]) by smtp.gmail.com with ESMTPSA id x10-20020ae9f80a000000b007676658e369sm3152696qkh.26.2023.07.04.15.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 15:22:39 -0700 (PDT) References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> User-agent: mu4e 1.11.7; emacs 30.0.50 From: No Wayman To: Eli Zaretskii Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* Date: Tue, 04 Jul 2023 18:21:00 -0400 In-reply-to: <83zg4ckki0.fsf@gnu.org> Message-ID: <87bkgr48qy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64452 Cc: 64452@debbugs.gnu.org, Andrea Corallo , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; format=flowed Eli Zaretskii writes: > Thanks, but why not elisp-compile-mode, like we do in > *Compile-log* > buffers for byte compilation? Works for me. Revision attached. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-comp.el-use-emacs-lisp-compilation-mode-for-log-buff.patch >From 9912e598354f877cb4ccf20ac68d7267d8c599c8 Mon Sep 17 00:00:00 2001 From: Nicholas Vollmer Date: Mon, 3 Jul 2023 20:23:00 -0400 Subject: [PATCH] * comp.el: use emacs-lisp-compilation-mode for log buffers (comp-log-to-buffer): ensure comp-log-buffer in emacs-lisp-compilation-mode (comp-run-async-workers): ensure comp-async-buffer in emacs-lisp-compilation-mode --- lisp/emacs-lisp/comp.el | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el index 22fb08e4688..5f42d10407f 100644 --- a/lisp/emacs-lisp/comp.el +++ b/lisp/emacs-lisp/comp.el @@ -1133,7 +1133,8 @@ comp-log-to-buffer (log-buffer (or (get-buffer comp-log-buffer-name) (with-current-buffer (get-buffer-create comp-log-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (current-buffer)))) (log-window (get-buffer-window log-buffer)) (inhibit-read-only t) @@ -4085,7 +4086,8 @@ comp-run-async-workers :buffer (with-current-buffer (get-buffer-create comp-async-buffer-name) - (setf buffer-read-only t) + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (current-buffer)) :command (list (expand-file-name invocation-name @@ -4119,6 +4121,8 @@ comp-run-async-workers (run-hooks 'native-comp-async-all-done-hook) (with-current-buffer (get-buffer-create comp-async-buffer-name) (save-excursion + (unless (derived-mode-p 'emacs-lisp-compilation-mode) + (emacs-lisp-compilation-mode)) (let ((inhibit-read-only t)) (goto-char (point-max)) (insert "Compilation finished.\n")))) -- 2.41.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 07:25:59 2023 Received: (at 64452) by debbugs.gnu.org; 5 Jul 2023 11:25:59 +0000 Received: from localhost ([127.0.0.1]:37214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0dz-0000PB-3b for submit@debbugs.gnu.org; Wed, 05 Jul 2023 07:25:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH0dw-0000Ow-IR for 64452@debbugs.gnu.org; Wed, 05 Jul 2023 07:25:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0dq-00077S-Sj; Wed, 05 Jul 2023 07:25:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7VuHEy0XO0XRX/Wu1TUeyc03lALUmpD0CnClnXIcPnI=; b=LB7s8CQSBqjd i6pbH+pHBev4UxLwbCcqxnBeKtDPKwuW8RsvayPXuOlyZ8elZU2H9xpugZG7VRTJP5aKXnusv4j9s Tyzom4CVeGQrOWJbObSu0ot/ZrwyxGMzSjZ2rgcsVzj8drHUYKMtRB3vBc7RzJsgl+c/pCYoMUGKw YE42Vt0WWv+yld6SYLOTdCzG3/9yx4DtyEcr+Tx8xVl+7sllKjA6RG/cywM8jEdVGSgJHZbqs7uPw 4jwSN3TBdR025N7kTcN3iIPMw7RrLJX4BUScEvzy+wKqkGheldX8mATgMdoVnByz9haetWYtrr3Je 9jeinLIrkorkKG6D4XqIvQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH0dq-0006Ar-86; Wed, 05 Jul 2023 07:25:50 -0400 Date: Wed, 05 Jul 2023 14:25:48 +0300 Message-Id: <83lefuk3b7.fsf@gnu.org> From: Eli Zaretskii To: No Wayman In-Reply-To: <87bkgr48qy.fsf@gmail.com> (message from No Wayman on Tue, 04 Jul 2023 18:21:00 -0400) Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64452 Cc: 64452@debbugs.gnu.org, acorallo@gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: No Wayman > Cc: Andrea Corallo , Stefan Monnier > , 64452@debbugs.gnu.org > Date: Tue, 04 Jul 2023 18:21:00 -0400 > > Eli Zaretskii writes: > > > Thanks, but why not elisp-compile-mode, like we do in > > *Compile-log* > > buffers for byte compilation? > > Works for me. Revision attached. > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 22fb08e4688..5f42d10407f 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -1133,7 +1133,8 @@ comp-log-to-buffer > (log-buffer > (or (get-buffer comp-log-buffer-name) > (with-current-buffer (get-buffer-create comp-log-buffer-name) > - (setf buffer-read-only t) > + (unless (derived-mode-p 'emacs-lisp-compilation-mode) > + (emacs-lisp-compilation-mode)) bytecomp.el uses (unless (derived-mode-p 'compilation-mode) (emacs-lisp-compilation-mode)) Isn't that better? Also, do we really need to do this twice in comp-run-async-workers? Andrea, any comments? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 08:52:56 2023 Received: (at 64452) by debbugs.gnu.org; 5 Jul 2023 12:52:56 +0000 Received: from localhost ([127.0.0.1]:37896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH207-0005bg-VJ for submit@debbugs.gnu.org; Wed, 05 Jul 2023 08:52:56 -0400 Received: from mail-qk1-f169.google.com ([209.85.222.169]:48179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH205-0005bS-Qh for 64452@debbugs.gnu.org; Wed, 05 Jul 2023 08:52:54 -0400 Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7673180224bso493488385a.0 for <64452@debbugs.gnu.org>; Wed, 05 Jul 2023 05:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688561567; x=1691153567; h=mime-version:cc:to:from:importance:in-reply-to:subject:date :savedfromemail:message-id:from:to:cc:subject:date:message-id :reply-to; bh=b3iNS6SANkGjJmcapP2cmy1CZ9xg+R5eRgbLTqm5weE=; b=JR1VX7U4LdkaFJmpJKT6hplPEUpnN2fctON1iY1BK8h9C/5l2YWGeVpw4ra+6u/9ZS c+SyCecZIaAyv7riiq/uTW29xfRmLFnSKNMNXkiobIIt8T3EPpnY0D6zVWZD9h2imujw as2ALuQxKgHv1Hri2ZeR2cK+UthjGxIdWZ7SGi0H0aGilaYsbeSTIHUsjVPMP6pDX5BF OpTUcYGbSd7G59xphfkNe3DhBaCrhR5r0Bn19EiVply5RjtMmAgaMO8HEtGy6h2+cbQj LiK34eija87kA6W7DsOeye8mGpVP51W1VshQ/+pDghYEsrfaUNdOsoM8pKNHD4CEKKf3 65Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688561567; x=1691153567; h=mime-version:cc:to:from:importance:in-reply-to:subject:date :savedfromemail:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=b3iNS6SANkGjJmcapP2cmy1CZ9xg+R5eRgbLTqm5weE=; b=Vimn7zadU/D4mG4unLIvD/d8j6j6RUXigTA3Xj2IFtOJFOb6TTT/rJyioTQ0prtJM+ vDKsAaCaEoc0T0YJO0MQHUCYxHbBfo/lLJUVUNT14pqcCQo+Mzspi3mtcv58eG8EKZ4w vU7/jeXmxgPPELjXAPVkPB2DzF2aaJK3UKzmsz668msmBbsujNoskgqrtEF+YvZfiLwG HaxgUPioZPsXUFXv814GC7S+ZzbRHLv4hCZ939CT7lNMmx1kvjEETMWDsOTKde1mW3dS ppzpVJpEIPBzTKxoljy7i6vw4jXYYIoGdwxAB2jMc13dChQkDdVBGkE1Rjkzw+Uzsqi9 pkMQ== X-Gm-Message-State: AC+VfDyZUiG1CGls9UeaJKcp1t8G6BOcipUZuF+PIbFgY+Zt1EyYz/ro M0V+3h5MKqhWCZwhXFga/aQ= X-Google-Smtp-Source: ACHHUZ5gZYSqebR+gtPh/8TFQ05XCyH3KIATwQxGGwrIWJvIgSKCReLKuAeQJYSELI3t12h4hs610Q== X-Received: by 2002:a05:620a:4444:b0:763:a20c:fe8b with SMTP id w4-20020a05620a444400b00763a20cfe8bmr18589666qkp.13.1688561566984; Wed, 05 Jul 2023 05:52:46 -0700 (PDT) Received: from ?IPv6:2601:84:847f:c697:d9bd:d675:fc25:4b68? ([2601:84:847f:c697:d9bd:d675:fc25:4b68]) by smtp.gmail.com with ESMTPSA id e1-20020a05620a12c100b007621b1bcbbfsm8207868qkl.102.2023.07.05.05.52.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 05:52:46 -0700 (PDT) Message-ID: <64a5679e.050a0220.42b7d.2a4a@mx.google.com> SavedFromEmail: iarchivedmywholelife@gmail.com Date: Wed, 05 Jul 2023 08:52:44 -0400 Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* In-Reply-To: <83lefuk3b7.fsf@gnu.org> Importance: normal From: iarchivedmywholelife To: Eli Zaretskii MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="--_com.samsung.android.email_376168053577850" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64452 Cc: 64452@debbugs.gnu.org, acorallo@gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ----_com.samsung.android.email_376168053577850 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 RmVlbCBmcmVlIHRvIGFsdGVyIHRoZSBwYXRjaCBhcyB5b3Ugc2VlIGZpdC5JIGhhdmUgbm8gbW9y ZSB0aW1lIHRvIGludmVzdCBpbiBpdC4KLS0tLS0tLS0gT3JpZ2luYWwgbWVzc2FnZSAtLS0tLS0t LUZyb206IEVsaSBaYXJldHNraWkgPGVsaXpAZ251Lm9yZz4gRGF0ZTogNy81LzIzICA3OjI1IEFN ICAoR01ULTA1OjAwKSBUbzogTm8gV2F5bWFuIDxpYXJjaGl2ZWRteXdob2xlbGlmZUBnbWFpbC5j b20+IENjOiBhY29yYWxsb0BnbnUub3JnLCBtb25uaWVyQGlyby51bW9udHJlYWwuY2EsIDY0NDUy QGRlYmJ1Z3MuZ251Lm9yZyBTdWJqZWN0OiBSZTogYnVnIzY0NDUyOiBbV2lzaGxpc3QvUEFUQ0hd IFVzZSBzcGVjaWFsLW1vZGUgZm9yICpOYXRpdmUtY29tcGlsZS1sb2cqLCAqQXN5bmMtbmF0aXZl LWNvbXBpbGUtbG9nKiA+IEZyb206IE5vIFdheW1hbiA8aWFyY2hpdmVkbXl3aG9sZWxpZmVAZ21h aWwuY29tPj4gQ2M6IEFuZHJlYSBDb3JhbGxvIDxhY29yYWxsb0BnbnUub3JnPiwgU3RlZmFuIE1v bm5pZXI+wqAgPG1vbm5pZXJAaXJvLnVtb250cmVhbC5jYT4sIDY0NDUyQGRlYmJ1Z3MuZ251Lm9y Zz4gRGF0ZTogVHVlLCAwNCBKdWwgMjAyMyAxODoyMTowMCAtMDQwMD4gPiBFbGkgWmFyZXRza2lp IDxlbGl6QGdudS5vcmc+IHdyaXRlczo+ID4gPiBUaGFua3MsIGJ1dCB3aHkgbm90IGVsaXNwLWNv bXBpbGUtbW9kZSwgbGlrZSB3ZSBkbyBpbiA+ID4gKkNvbXBpbGUtbG9nKj4gPiBidWZmZXJzIGZv ciBieXRlIGNvbXBpbGF0aW9uPz4gPiBXb3JrcyBmb3IgbWUuIFJldmlzaW9uIGF0dGFjaGVkLj4g PiBkaWZmIC0tZ2l0IGEvbGlzcC9lbWFjcy1saXNwL2NvbXAuZWwgYi9saXNwL2VtYWNzLWxpc3Av Y29tcC5lbD4gaW5kZXggMjJmYjA4ZTQ2ODguLjVmNDJkMTA0MDdmIDEwMDY0ND4gLS0tIGEvbGlz cC9lbWFjcy1saXNwL2NvbXAuZWw+ICsrKyBiL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVsPiBAQCAt MTEzMyw3ICsxMTMzLDggQEAgY29tcC1sb2ctdG8tYnVmZmVyPsKgwqDCoMKgwqDCoMKgwqDCoMKg IChsb2ctYnVmZmVyPsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKG9yIChnZXQtYnVmZmVy IGNvbXAtbG9nLWJ1ZmZlci1uYW1lKT7CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgKHdpdGgtY3VycmVudC1idWZmZXIgKGdldC1idWZmZXItY3JlYXRlIGNvbXAtbG9nLWJ1ZmZl ci1uYW1lKT4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc2V0ZiBidWZm ZXItcmVhZC1vbmx5IHQpPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh1 bmxlc3MgKGRlcml2ZWQtbW9kZS1wICdlbWFjcy1saXNwLWNvbXBpbGF0aW9uLW1vZGUpPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZW1hY3MtbGlzcC1jb21waWxh dGlvbi1tb2RlKSlieXRlY29tcC5lbCB1c2VzwqDCoMKgICh1bmxlc3MgKGRlcml2ZWQtbW9kZS1w ICdjb21waWxhdGlvbi1tb2RlKcKgwqDCoMKgwqAgKGVtYWNzLWxpc3AtY29tcGlsYXRpb24tbW9k ZSkpSXNuJ3QgdGhhdCBiZXR0ZXI/QWxzbywgZG8gd2UgcmVhbGx5IG5lZWQgdG8gZG8gdGhpcyB0 d2ljZSBpbiBjb21wLXJ1bi1hc3luYy13b3JrZXJzP0FuZHJlYSwgYW55IGNvbW1lbnRzPw== ----_com.samsung.android.email_376168053577850 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keSBkaXI9ImF1dG8iPkZlZWwgZnJlZSB0 byBhbHRlciB0aGUgcGF0Y2ggYXMgeW91IHNlZSBmaXQuPGRpdiBkaXI9ImF1dG8iPkkgaGF2ZSBu byBtb3JlIHRpbWUgdG8gaW52ZXN0IGluIGl0LjwvZGl2PjxkaXY+PGJyPjwvZGl2PjxkaXYgYWxp Z249ImxlZnQiIGRpcj0iYXV0byIgc3R5bGU9ImZvbnQtc2l6ZToxMDAlO2NvbG9yOiMwMDAwMDAi PjxkaXY+LS0tLS0tLS0gT3JpZ2luYWwgbWVzc2FnZSAtLS0tLS0tLTwvZGl2PjxkaXY+RnJvbTog RWxpIFphcmV0c2tpaSAmbHQ7ZWxpekBnbnUub3JnJmd0OyA8L2Rpdj48ZGl2PkRhdGU6IDcvNS8y MyAgNzoyNSBBTSAgKEdNVC0wNTowMCkgPC9kaXY+PGRpdj5UbzogTm8gV2F5bWFuICZsdDtpYXJj aGl2ZWRteXdob2xlbGlmZUBnbWFpbC5jb20mZ3Q7IDwvZGl2PjxkaXY+Q2M6IGFjb3JhbGxvQGdu dS5vcmcsIG1vbm5pZXJAaXJvLnVtb250cmVhbC5jYSwgNjQ0NTJAZGViYnVncy5nbnUub3JnIDwv ZGl2PjxkaXY+U3ViamVjdDogUmU6IGJ1ZyM2NDQ1MjogW1dpc2hsaXN0L1BBVENIXSBVc2Ugc3Bl Y2lhbC1tb2RlIGZvciAqTmF0aXZlLWNvbXBpbGUtbG9nKiwgKkFzeW5jLW5hdGl2ZS1jb21waWxl LWxvZyogPC9kaXY+PGRpdj48YnI+PC9kaXY+PC9kaXY+Jmd0OyBGcm9tOiBObyBXYXltYW4gJmx0 O2lhcmNoaXZlZG15d2hvbGVsaWZlQGdtYWlsLmNvbSZndDs8YnI+Jmd0OyBDYzogQW5kcmVhIENv cmFsbG8gJmx0O2Fjb3JhbGxvQGdudS5vcmcmZ3Q7LCBTdGVmYW4gTW9ubmllcjxicj4mZ3Q7Jm5i c3A7ICZsdDttb25uaWVyQGlyby51bW9udHJlYWwuY2EmZ3Q7LCA2NDQ1MkBkZWJidWdzLmdudS5v cmc8YnI+Jmd0OyBEYXRlOiBUdWUsIDA0IEp1bCAyMDIzIDE4OjIxOjAwIC0wNDAwPGJyPiZndDsg PGJyPiZndDsgRWxpIFphcmV0c2tpaSAmbHQ7ZWxpekBnbnUub3JnJmd0OyB3cml0ZXM6PGJyPiZn dDsgPGJyPiZndDsgJmd0OyBUaGFua3MsIGJ1dCB3aHkgbm90IGVsaXNwLWNvbXBpbGUtbW9kZSwg bGlrZSB3ZSBkbyBpbiA8YnI+Jmd0OyAmZ3Q7ICpDb21waWxlLWxvZyo8YnI+Jmd0OyAmZ3Q7IGJ1 ZmZlcnMgZm9yIGJ5dGUgY29tcGlsYXRpb24/PGJyPiZndDsgPGJyPiZndDsgV29ya3MgZm9yIG1l LiBSZXZpc2lvbiBhdHRhY2hlZC48YnI+Jmd0OyA8YnI+Jmd0OyBkaWZmIC0tZ2l0IGEvbGlzcC9l bWFjcy1saXNwL2NvbXAuZWwgYi9saXNwL2VtYWNzLWxpc3AvY29tcC5lbDxicj4mZ3Q7IGluZGV4 IDIyZmIwOGU0Njg4Li41ZjQyZDEwNDA3ZiAxMDA2NDQ8YnI+Jmd0OyAtLS0gYS9saXNwL2VtYWNz LWxpc3AvY29tcC5lbDxicj4mZ3Q7ICsrKyBiL2xpc3AvZW1hY3MtbGlzcC9jb21wLmVsPGJyPiZn dDsgQEAgLTExMzMsNyArMTEzMyw4IEBAIGNvbXAtbG9nLXRvLWJ1ZmZlcjxicj4mZ3Q7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IChs b2ctYnVmZmVyPGJyPiZndDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgKG9yIChnZXQtYnVm ZmVyIGNvbXAtbG9nLWJ1ZmZlci1uYW1lKTxicj4mZ3Q7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7ICh3aXRoLWN1cnJlbnQtYnVmZmVyIChnZXQtYnVm ZmVyLWNyZWF0ZSBjb21wLWxvZy1idWZmZXItbmFtZSk8YnI+Jmd0OyAtJm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7IChzZXRmIGJ1ZmZlci1yZWFkLW9u bHkgdCk8YnI+Jmd0OyArJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7ICh1bmxlc3MgKGRlcml2ZWQtbW9kZS1wICdlbWFjcy1saXNwLWNvbXBpbGF0aW9u LW1vZGUpPGJyPiZndDsgKyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAoZW1hY3MtbGlzcC1jb21waWxhdGlvbi1tb2RlKSk8YnI+ PGJyPmJ5dGVjb21wLmVsIHVzZXM8YnI+PGJyPiZuYnNwOyZuYnNwOyZuYnNwOyAodW5sZXNzIChk ZXJpdmVkLW1vZGUtcCAnY29tcGlsYXRpb24tbW9kZSk8YnI+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7IChlbWFjcy1saXNwLWNvbXBpbGF0aW9uLW1vZGUpKTxicj48YnI+SXNuJ3QgdGhh dCBiZXR0ZXI/PGJyPjxicj5BbHNvLCBkbyB3ZSByZWFsbHkgbmVlZCB0byBkbyB0aGlzIHR3aWNl IGluIGNvbXAtcnVuLWFzeW5jLXdvcmtlcnM/PGJyPjxicj5BbmRyZWEsIGFueSBjb21tZW50cz88 YnI+PC9ib2R5PjwvaHRtbD4= ----_com.samsung.android.email_376168053577850-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 10:47:57 2023 Received: (at 64452) by debbugs.gnu.org; 5 Jul 2023 14:47:57 +0000 Received: from localhost ([127.0.0.1]:38769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH3nR-0000Fw-IR for submit@debbugs.gnu.org; Wed, 05 Jul 2023 10:47:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qH3nP-0000F7-M5 for 64452@debbugs.gnu.org; Wed, 05 Jul 2023 10:47:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qH3nJ-0003ha-BD; Wed, 05 Jul 2023 10:47:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=r5Oqcx5d1D1NlFZqTu2wH07ZwNHZVq1Zup/iE+Pf9SQ=; b=jvNfElyz7pI+OcCbMK8X mWELhfumcxQc5VvnjRTZuH4aeUut5Rz9Va8Epvqyec/J/4dTmaIx6WZtDWAiBWEfXjKzzsG5EaIgD uRl05TYXJYRJKSCa1J0kHe4wi/ygC2dV1itbpWy3HOjYgh0SCs91RPBvea7zqotkszFP4lRMzp4gR 8H4TJei9+vcZs6Y+p+giywycv78s/8vVICGUPoUahlnFtZy3U/LbktfWdQgoJhh+c2YdfCpYXMsrf Sih/+Rjm/JJ4tKLxJAvb0TlX3Hl881gGmZ+KbNaYzael1Wa+whnOWlLiZ7gPLVQfYYLQqLKOnhzk7 N5VriHoKnpx0CQ==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1qH3nH-0002cw-Ks; Wed, 05 Jul 2023 10:47:48 -0400 From: Andrea Corallo To: Eli Zaretskii Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* In-Reply-To: <83lefuk3b7.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jul 2023 14:25:48 +0300") References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> <83lefuk3b7.fsf@gnu.org> Date: Wed, 05 Jul 2023 10:47:47 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64452 Cc: 64452@debbugs.gnu.org, No Wayman , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: No Wayman >> Cc: Andrea Corallo , Stefan Monnier >> , 64452@debbugs.gnu.org >> Date: Tue, 04 Jul 2023 18:21:00 -0400 >> >> Eli Zaretskii writes: >> >> > Thanks, but why not elisp-compile-mode, like we do in >> > *Compile-log* >> > buffers for byte compilation? >> >> Works for me. Revision attached. >> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> index 22fb08e4688..5f42d10407f 100644 >> --- a/lisp/emacs-lisp/comp.el >> +++ b/lisp/emacs-lisp/comp.el >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer >> (log-buffer >> (or (get-buffer comp-log-buffer-name) >> (with-current-buffer (get-buffer-create comp-log-buffer-name) >> - (setf buffer-read-only t) >> + (unless (derived-mode-p 'emacs-lisp-compilation-mode) >> + (emacs-lisp-compilation-mode)) > > bytecomp.el uses > > (unless (derived-mode-p 'compilation-mode) > (emacs-lisp-compilation-mode)) > > Isn't that better? > > Also, do we really need to do this twice in comp-run-async-workers? > > Andrea, any comments? No, haven't tried it but it LGTM form here. Bests Andrea From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 06 04:52:12 2023 Received: (at 64452-done) by debbugs.gnu.org; 6 Jul 2023 08:52:12 +0000 Received: from localhost ([127.0.0.1]:39549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHKih-0006cO-Jo for submit@debbugs.gnu.org; Thu, 06 Jul 2023 04:52:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHKif-0006cB-JQ for 64452-done@debbugs.gnu.org; Thu, 06 Jul 2023 04:52:10 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHKiZ-00087f-RO; Thu, 06 Jul 2023 04:52:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pDx5c6oX6TcwH5RO/HdTi0uSeTve7EYoOv/Dn8ie0rw=; b=D3miC9UemqFW Yk9gTx8eSllhSIllmumyjRW1XwXKK1OR7wwMiWMn9J9VcgecMbNNC4Vz3l7QoF9kTiTYhwAjczefh lljfljt6Du2nHV+dhmh55SFdWLAslaxMhkv22qnWK7nJJWIv7qL90S+s537VbzTNOmGjspoMZ2YFP Rj8ZYtnMBPGErRzl0PoBx7ttYqMNvtkflE2svWmX8UHyOy5BaXkRQgIpsCyYzwohMGo3fOIynRnZH 0WhNylEi/l5blbHbk1Q87dMi1sf9VEWXEiWOZSCWvlDZWP1xJnc8xMn9B150+gozXMBqfst/zqjBJ Y96EiDz7NhZApINQgeJ1XA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHKiZ-0005se-At; Thu, 06 Jul 2023 04:52:03 -0400 Date: Thu, 06 Jul 2023 11:52:02 +0300 Message-Id: <83bkgpifrh.fsf@gnu.org> From: Eli Zaretskii To: Andrea Corallo In-Reply-To: (message from Andrea Corallo on Wed, 05 Jul 2023 10:47:47 -0400) Subject: Re: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log* References: <87sfa44ixh.fsf@gmail.com> <83zg4ckki0.fsf@gnu.org> <87bkgr48qy.fsf@gmail.com> <83lefuk3b7.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64452-done Cc: 64452-done@debbugs.gnu.org, iarchivedmywholelife@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Andrea Corallo > Cc: No Wayman , monnier@iro.umontreal.ca, > 64452@debbugs.gnu.org > Date: Wed, 05 Jul 2023 10:47:47 -0400 > > Eli Zaretskii writes: > > >> From: No Wayman > >> Cc: Andrea Corallo , Stefan Monnier > >> , 64452@debbugs.gnu.org > >> Date: Tue, 04 Jul 2023 18:21:00 -0400 > >> > >> Eli Zaretskii writes: > >> > >> > Thanks, but why not elisp-compile-mode, like we do in > >> > *Compile-log* > >> > buffers for byte compilation? > >> > >> Works for me. Revision attached. > >> > >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > >> index 22fb08e4688..5f42d10407f 100644 > >> --- a/lisp/emacs-lisp/comp.el > >> +++ b/lisp/emacs-lisp/comp.el > >> @@ -1133,7 +1133,8 @@ comp-log-to-buffer > >> (log-buffer > >> (or (get-buffer comp-log-buffer-name) > >> (with-current-buffer (get-buffer-create comp-log-buffer-name) > >> - (setf buffer-read-only t) > >> + (unless (derived-mode-p 'emacs-lisp-compilation-mode) > >> + (emacs-lisp-compilation-mode)) > > > > bytecomp.el uses > > > > (unless (derived-mode-p 'compilation-mode) > > (emacs-lisp-compilation-mode)) > > > > Isn't that better? > > > > Also, do we really need to do this twice in comp-run-async-workers? > > > > Andrea, any comments? > > No, haven't tried it but it LGTM form here. Thanks, installed on the master branch, and closing the bug. From unknown Fri Aug 15 12:48:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 03 Aug 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator