Subject: bug#64452: [Wishlist/PATCH] Use special-mode for *Native-compile-log*, *Async-native-compile-log*

From: Andrea Corallo <[email-masked]>
Date: Wed, 05 Jul 2023 10:47:47 -0400

Eli Zaretskii <[email-masked]> writes:

>> From: No Wayman <[email-masked]>
>> Cc: Andrea Corallo <[email-masked]>, Stefan Monnier
>>  <[email-masked]>, [email-masked]
>> Date: Tue, 04 Jul 2023 18:21:00 -0400
>> 
>> Eli Zaretskii <[email-masked]> writes:
>> 
>> > Thanks, but why not elisp-compile-mode, like we do in 
>> > *Compile-log*
>> > buffers for byte compilation?
>> 
>> Works for me. Revision attached.
>> 
>> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
>> index 22fb08e4688..5f42d10407f 100644
>> --- a/lisp/emacs-lisp/comp.el
>> +++ b/lisp/emacs-lisp/comp.el
>> @@ -1133,7 +1133,8 @@ comp-log-to-buffer
>>           (log-buffer
>>               (or (get-buffer comp-log-buffer-name)
>>                   (with-current-buffer (get-buffer-create comp-log-buffer-name)
>> -                   (setf buffer-read-only t)
>> +                   (unless (derived-mode-p 'emacs-lisp-compilation-mode)
>> +                     (emacs-lisp-compilation-mode))
>
> bytecomp.el uses
>
>     (unless (derived-mode-p 'compilation-mode)
>       (emacs-lisp-compilation-mode))
>
> Isn't that better?
>
> Also, do we really need to do this twice in comp-run-async-workers?
>
> Andrea, any comments?

No, haven't tried it but it LGTM form here.

Bests

  Andrea