GNU bug report logs - #64442
29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Subject: bug#64442: closed (Re: bug#64442: 29.0.92; treesit-beginning-of-defun
 fails in DEFUN  functions in C)
Date: Sat, 19 Aug 2023 22:02:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 64442 <at> debbugs.gnu.org.

-- 
64442: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64442
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64442-done <at> debbugs.gnu.org
Subject: Re: bug#64442: 29.0.92; treesit-beginning-of-defun fails in DEFUN 
 functions in C
Date: Sat, 19 Aug 2023 15:00:52 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Tue, 15 Aug 2023 00:30:53 -0700
>> Cc: 64442 <at> debbugs.gnu.org
>> 
>> >>> That would allow "C-x 4 a" to work inside a DEFUN,
>> >>> something that still works less reliably with this patch: you
>> >>> must be
>> >>> in the "first defun" to get it to find the name of the function.
>> >> 
>> >> C-x 4 a should’ve been fixed already. And it shouldn’t rely on
>> >> this fix to work. Do you have a recipe for when it doesn’t work?
>> > 
>> > Just try it with your patch.  If point is inside the body, the
>> > function's name is not captured by "C-x 4 a”.
>> 
>> My bad, I must’ve been trying C-x 4 a in a different Emacs session,
>> which worked. Anyway, I updated the patch and C-x 4 a should now
>> work.
>
> Thanks, LGTM.  Please install on the emacs-29 branch, and close the
> bug when you do.

Pushed, thanks.

Yuan

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.92; treesit-beginning-of-defun fails in DEFUN functions in C
Date: Mon, 03 Jul 2023 20:13:47 +0300

To reproduce:

  emacs -Q
  C-x C-f src/dispnew.c RET
  M-x c-ts-mode RET
  C-u 220 M-g g
  C-M-a

Observe that instead of going to the beginning of
dump-redisplay-history, the function to which line 220 of dispnew.c
belongs, point goes to the beginning of the previous function, which
happens to be add_frame_display_history.

Can we please fix treesit-beginning-of-defun such that it recognizes C
functions defined via DEFUN?



In GNU Emacs 29.0.92 (build 20, i686-pc-mingw32) of 2023-07-02 built on
 HOME-C4E4A596F7
Repository revision: 15ff87617772c2a2c3d8a3a1e2ed7f96e527ad9e
Repository branch: emacs-29
Windowing system distributor 'Microsoft Corp.', version 5.1.2600
System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600)

Configured using:
 'configure -C --prefix=/d/usr --with-wide-int
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3''

Configured features:
ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY
W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB

Important settings:
  value of $LANG: ENU
  locale-coding-system: cp1255

Major mode: C/*

Minor modes in effect:
  bug-reference-prog-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
misearch multi-isearch c-ts-mode c-ts-common treesit cl-seq vc-git
diff-mode easy-mmode vc vc-dispatcher bug-reference byte-opt gv bytecomp
byte-compile cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles
cc-align cc-engine cc-vars cc-defs cl-loaddefs cl-lib rmc iso-transl
tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks
lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table
term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty
make-network-process emacs)

Memory information:
((conses 16 81182 12528)
 (symbols 48 9662 0)
 (strings 16 28732 3398)
 (string-bytes 1 924785)
 (vectors 16 15907)
 (vector-slots 8 209599 17044)
 (floats 8 29 78)
 (intervals 40 1068 136)
 (buffers 888 11))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.