GNU bug report logs - #64440
30.0.50; [PATCH] Highlight on non toolkit menu bar items

Previous Next

Full log

Message #20 received at 64440 <at> debbugs.gnu.org (full text, mbox):

From: Manuel Giraud <manuel <at> ledu-giraud.fr>
To: Po Lu <luangruo <at> yahoo.com>
Cc: Stefan Kangas <stefankangas <at> gmail.com>, 64440 <at> debbugs.gnu.org
Subject: Re: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar
 items
Date: Sat, 02 Sep 2023 15:05:19 +0200

Po Lu <luangruo <at> yahoo.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>>> Here is a new set of patches with two more on top of the previous ones
>>> (ie. Number 1 and 2 should be the same as before).
>>>
>>> Number 3 sets the default mouse cursor to be an arrow on the default
>>> menu bar area.  Number 4 fixes a flickering I had while moving the mouse
>>> pointer *into* a menu bar entry.
>>
>> Po Lu, do you have any comments on this patch series?
>>
>> Thanks in advance.
>
> Thanks.  I don't understand why adjustments to note_tab_bar_highlight or
> note_tool_bar_highlight are warranted, and I think this ought to be
> optional.

Ok, I'll look into those two adjustements.  BTW, I was more hesitant
about the global modification of 'window_from_coordinates' (even on
machines I don't have access to).

> ChangeLog entries are also absent from the commit messages.

Noted.
-- 
Manuel Giraud

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.