GNU bug report logs - #64440
30.0.50; [PATCH] Highlight on non toolkit menu bar items

Previous Next

Full log

Message #17 received at 64440 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: stefankangas <at> gmail.com, manuel <at> ledu-giraud.fr, 64440 <at> debbugs.gnu.org
Subject: Re: bug#64440: 30.0.50;
 [PATCH] Highlight on non toolkit menu bar items
Date: Sat, 02 Sep 2023 09:41:00 +0300

> Cc: 64440 <at> debbugs.gnu.org, Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Sat, 02 Sep 2023 08:44:16 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Stefan Kangas <stefankangas <at> gmail.com> writes:
> 
> >> Here is a new set of patches with two more on top of the previous ones
> >> (ie. Number 1 and 2 should be the same as before).
> >>
> >> Number 3 sets the default mouse cursor to be an arrow on the default
> >> menu bar area.  Number 4 fixes a flickering I had while moving the mouse
> >> pointer *into* a menu bar entry.
> >
> > Po Lu, do you have any comments on this patch series?
> >
> > Thanks in advance.
> 
> Thanks.  I don't understand why adjustments to note_tab_bar_highlight or
> note_tool_bar_highlight are warranted, and I think this ought to be
> optional.
> 
> ChangeLog entries are also absent from the commit messages.

I'd appreciate a walkthrough of the patches with explanations for the
significant hunks.  It's a non-trivial change, so I think the
rationale and the main ideas of the implementation should be described
and discussed.

I also have difficulty understanding comments like this one:

   /* Clear mouse face but the mouse cursor.  */

What does it try to say?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.