GNU bug report logs - #64440
30.0.50; [PATCH] Highlight on non toolkit menu bar items

Previous Next

Full log

Message #145 received at 64440 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Manuel Giraud <manuel <at> ledu-giraud.fr>
Cc: Eli Zaretskii <eliz <at> gnu.org>, stefankangas <at> gmail.com, 64440 <at> debbugs.gnu.org
Subject: Re: bug#64440: 30.0.50; [PATCH] Highlight on non toolkit menu bar
 items
Date: Sat, 21 Oct 2023 21:24:15 +0800

Manuel Giraud <manuel <at> ledu-giraud.fr> writes:

> Po Lu <luangruo <at> yahoo.com> writes:
>
>> Better, thanks.  Although the commit message must be filled to 64
>> columns, and I'd rather callers passing true be enumerated there.
>
> What about this one?
>
> From d2ed7c704854082e5f84a717d18f29c92785a638 Mon Sep 17 00:00:00 2001
> From: Manuel Giraud <manuel <at> ledu-giraud.fr>
> Date: Sat, 21 Oct 2023 14:36:24 +0200
> Subject: [PATCH] Support for menu bar in window_from_coordinates
>
> * src/window.h:
> * src/window.c (window_from_coordinates): In the no toolkit
> build, add support for the menu bar window.  Add a new
> 'menu_bar_p' argument so the function's signature has changed.
> All callers changed.
>
> * src/androidterm.c (handle_one_android_event):
> * src/haikuterm.c (haiku_read_socket):
> * src/keyboard.c (make_lispy_position):
> * src/nsterm.m ([EmacsView mouseDown:]):
> * src/pgtkterm.c (button_event):
> * src/w32term.c (w32_read_socket):
> * src/xdisp.c (note_mouse_highlight):
> * src/xterm.c (handle_one_xevent): All those callers have
> 'menu_bar_p' set to true.

I would write:

[...]
* src/xterm.c (handle_one_xevent): Set menu_bar_p to true.

With that aside, LGTM.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.