GNU bug report logs - #64428
[PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64428: closed ([PATCH] Fix flymake mode line scrolling with
 pixel-scroll-precision-mode)
Date: Thu, 13 Jul 2023 14:01:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 13 Jul 2023 17:00:43 +0300
with message-id <83sf9r52t0.fsf <at> gnu.org>
and subject line Re: bug#64428: [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
has caused the debbugs.gnu.org bug report #64428,
regarding [PATCH] Fix flymake mode line scrolling with pixel-scroll-precision-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64428: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64428
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: sbaugh <at> catern.com
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix flymake mode line scrolling with
 pixel-scroll-precision-mode
Date: Sun, 02 Jul 2023 21:51:01 +0000 (UTC)

[Message part 3 (text/plain, inline)]

Tags: patch


This patch is based on the patch in bug#64425 (since I noticed this
unrelated issue while working on that, and they touch the same code).



When pixel-scroll-precision-mode is enabled, scrolling the mouse wheel
will yield wheel-{up,down} events.  flymake now binds the new events
in addition to the old mouse-wheel-{up,down}-event.

* lisp/progmodes/flymake.el:(flymake--mode-line-counter-scroll-prev,
flymake--mode-line-counter-scroll-next,
flymake--mode-line-counter-map): Add.
(flymake--mode-line-counter): Use new keymap and include 'type as a
property in the mode-line.


In GNU Emacs 29.0.92 (build 8, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-07-02 built on earth
Repository revision: c361966508e2da159b5e65c37dff7f78e87b3445
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: NixOS 23.05 (Stoat)

Configured using:
 'configure --with-x-toolkit=lucid --with-tree-sitter --with-xinput2'

[0001-Fix-flymake-mode-line-scrolling-with-pixel-scroll-pr.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: sbaugh <at> catern.com, 64428-done <at> debbugs.gnu.org, sbaugh <at> janestreet.com
Subject: Re: bug#64428: [PATCH] Fix flymake mode line scrolling with
 pixel-scroll-precision-mode
Date: Thu, 13 Jul 2023 17:00:43 +0300

> From: João Távora <joaotavora <at> gmail.com>
> Date: Thu, 13 Jul 2023 09:12:33 +0100
> Cc: sbaugh <at> catern.com, Spencer Baugh <sbaugh <at> janestreet.com>, 64428 <at> debbugs.gnu.org
> 
>  Any reasons not to make them public and add doc strings?
> 
> If you can give a reasonable example of sonething the general public would want to do with them, ok. 
> Until then, I think public interfaces should be kept small.
> 
> Yes, it's good for pushing.

Thanks, installed on master, and closing the bug.

Spencer, please in the future try to follow closer our conventions of
formatting commit log messages.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.