Subject: bug#64424: closed (Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 03 Jul 2023 11:22:02 +0000

Your bug report

#64424: [PATCH] Include a help-echo for flymake's modeline counters

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
64424: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64424
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters
From: Eli Zaretskii <[email-masked]>
To: João Távora <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Mon, 03 Jul 2023 14:21:47 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

> From: João Távora <[email-masked]>
> Date: Sun, 2 Jul 2023 21:54:20 +0100
> Cc: [email-masked], [email-masked]
> 
> On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <[email-masked]> wrote:
> 
>  > From: [email-masked]
>  > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
>  > 
>  > This helps clarify what each of these numbers mean.  This is inspired
>  > by compilation-mode-line-errors which does the same.
>  > 
>  > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
>  > help-echo to mode line properties.
> 
>  Thanks.
> 
>  João, is this safe for the release branch?
> 
> I think so, yes. I'd like to give it a bit of testing with Eglot, which uses its own types, but it does seem
> safe regardless.

Thanks, installed on the emacs-29 branch, and closing the bug.

Subject: [PATCH] Include a help-echo for flymake's modeline counters
From: [email-masked]
To: [email-masked]
Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
List-Id: <debbugs-submit.debbugs.gnu.org>

Tags: patch

This helps clarify what each of these numbers mean.  This is inspired
by compilation-mode-line-errors which does the same.

* lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
help-echo to mode line properties.

In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth
Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 22.11 (Raccoon)

Configured using:
 'configure --with-x-toolkit=lucid --with-tree-sitter CC=gcc'
 
>From aa577647a91c295fedcff4c1357ebb1f6c0d1384 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <[email-masked]>
Date: Sun, 2 Jul 2023 12:11:09 -0400
Subject: [PATCH] Include a help-echo for flymake's modeline counters

This helps clarify what each of these numbers mean.  This is inspired
by compilation-mode-line-errors which does the same.

* lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
help-echo to mode line properties.
---
 lisp/progmodes/flymake.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 6f293acca5e..47dc32f9245 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1473,6 +1473,12 @@ flymake--mode-line-counter
          ,(format "%d" count)
          face ,face
          mouse-face mode-line-highlight
+         help-echo ,(format "Number of %s; scroll mouse to view."
+                            (cond
+                             ((eq type :error) "errors")
+                             ((eq type :warning) "warnings")
+                             ((eq type :note) "notes")
+                             (t (format "%s diagnostics" type))))
          keymap
          ,(let ((map (make-sparse-keymap)))
             (define-key map (vector 'mode-line
-- 
2.40.1