From unknown Mon Sep 22 23:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 64424@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168831433830740 (code B ref -1); Sun, 02 Jul 2023 16:13:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Jul 2023 16:12:18 +0000 Received: from localhost ([127.0.0.1]:60939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzgP-0007zj-JY for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:12:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:54132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzgM-0007zY-Dd for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFzgM-00016Z-0W for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:12:14 -0400 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFzgH-0002xw-Do for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:12:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:mime-version:to:content-type:cc:content-type:from: subject:to; s=s1; bh=XiqYjdDhNtLev5h2gSAUsULT2HvNn666ZrbbS424ccc=; b=fV1VWKdM6LCeUZqz0gIfMnpcMJfiqvCYX6VWizG4YNVZ3tgz3wJnd4+1xcpVBLwVZ6jM ROXB8Wa3U+sZmAHTTGsFGx33KBKlo8uHRwSbGsvKl6OnpD7vbahakeufDL1XTRJpARu73J Y3MiOKL8xXkYozSMRMsFSbsDt5tzmG+hxGL/3+bacKRREx4ysH7G1kMIukQ5IBf83jzts3 kB0IWLl0ekHJ9j6ueBZf5rUavKx62khNQ/LxN5pTy174nuNQO3xheh0fzqSPDSJxJiT/UB NPVgCGHRQoCCagiW0HYOGP0JN89+enPz6mzodZ0Ec7LZ2D6zjAw4mYYaLVsnTaUQ== Received: by filterdrecv-66949dbc98-4lpsw with SMTP id filterdrecv-66949dbc98-4lpsw-1-64A1A1D6-20 2023-07-02 16:12:06.680296971 +0000 UTC m=+4552339.957439589 Received: from earth.catern.com (unknown) by geopod-ismtpd-26 (SG) with ESMTP id Od1qFZaRQ1ughb3YHVwZMw for ; Sun, 02 Jul 2023 16:12:06.565 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 097F460087 for ; Sun, 2 Jul 2023 12:12:05 -0400 (EDT) From: sbaugh@catern.com Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC) Message-ID: <873526i97u.fsf@catern.com> MIME-Version: 1.0 X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbLeTrQ+l/WizRK9J2QWp3zl5jRh2SuqU+k6r7K/ON4yrkZ7fY/a/+O6pfffYas4nJ59IUfug9MwUOcD4qxiwDb+/ChDtLCtPvEsHQjWuBSyKTb4J+++ikI9qKkoybBodCeTy3fcwBhsIJUn1MXQLL9LbvQwChZk4CyKrhPLkO3S7g== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=149.72.123.24; envelope-from=bounces+21787432-3678-bug-gnu-emacs=gnu.org@em8926.catern.com; helo=s.wrqvtbkv.outbound-mail.sendgrid.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Tags: patch This helps clarify what each of these numbers mean. This is inspired by compilation-mode-line-errors which does the same. * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add help-echo to mode line properties. In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: NixOS 22.11 (Raccoon) Configured using: 'configure --with-x-toolkit=lucid --with-tree-sitter CC=gcc' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Include-a-help-echo-for-flymake-s-modeline-counters.patch >From aa577647a91c295fedcff4c1357ebb1f6c0d1384 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 2 Jul 2023 12:11:09 -0400 Subject: [PATCH] Include a help-echo for flymake's modeline counters This helps clarify what each of these numbers mean. This is inspired by compilation-mode-line-errors which does the same. * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add help-echo to mode line properties. --- lisp/progmodes/flymake.el | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 6f293acca5e..47dc32f9245 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1473,6 +1473,12 @@ flymake--mode-line-counter ,(format "%d" count) face ,face mouse-face mode-line-highlight + help-echo ,(format "Number of %s; scroll mouse to view." + (cond + ((eq type :error) "errors") + ((eq type :warning) "warnings") + ((eq type :note) "notes") + (t (format "%s diagnostics" type)))) keymap ,(let ((map (make-sparse-keymap))) (define-key map (vector 'mode-line -- 2.40.1 --=-=-=-- From unknown Mon Sep 22 23:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: sbaugh@catern.com, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: 64424@debbugs.gnu.org Received: via spool by 64424-submit@debbugs.gnu.org id=B64424.16883177213733 (code B ref 64424); Sun, 02 Jul 2023 17:09:01 +0000 Received: (at 64424) by debbugs.gnu.org; 2 Jul 2023 17:08:41 +0000 Received: from localhost ([127.0.0.1]:60975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0Yz-0000y9-HX for submit@debbugs.gnu.org; Sun, 02 Jul 2023 13:08:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG0Yw-0000xw-K2 for 64424@debbugs.gnu.org; Sun, 02 Jul 2023 13:08:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0Yq-0004cm-Bw; Sun, 02 Jul 2023 13:08:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=t0qyOTYYPr0PNFrmMW5l0HSuNL5y+H7EuQpIGl8uK9Y=; b=hQpTzeWt+kF6c0trlmc7 07HQOgv6AsCytKShl8yn7jsg45mMGXVVxS47nSt/S85hgCj42mgJaK+zY7qCvTjKZy1YGYgU4AVRL n3J2Yc6TOgLM5zzFHr9GD65mIQT2NHx0yhSV9OoJF91UszwcQ75e1KFaIaKulhMS+p+lQ37rrbWoE 4DT10ofp1Y5eNK7jskUYHCe+pgSKd/j4PCtJwYfHckDnOyPkE6yGwT/4MsS258HBH1EVejsakHMsu n6gInWfTILGQRmeYWgQ72LWmeMSOPFqAliib/UHb7Cw4XnxgwbBOKDU0OH/Z29LRV9usuTA3SBSif azfBQ+ZXx9x26A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qG0Yp-0004Af-Rr; Sun, 02 Jul 2023 13:08:32 -0400 Date: Sun, 02 Jul 2023 20:09:06 +0300 Message-Id: <838rbynsul.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <873526i97u.fsf@catern.com> (sbaugh@catern.com) References: <873526i97u.fsf@catern.com> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: sbaugh@catern.com > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC) > > This helps clarify what each of these numbers mean. This is inspired > by compilation-mode-line-errors which does the same. > > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add > help-echo to mode line properties. Thanks. Jo�o, is this safe for the release branch? From unknown Mon Sep 22 23:25:33 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jul 2023 20:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64424 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: sbaugh@catern.com, 64424@debbugs.gnu.org Received: via spool by 64424-submit@debbugs.gnu.org id=B64424.16883312893978 (code B ref 64424); Sun, 02 Jul 2023 20:55:01 +0000 Received: (at 64424) by debbugs.gnu.org; 2 Jul 2023 20:54:49 +0000 Received: from localhost ([127.0.0.1]:32828 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG45n-000124-5t for submit@debbugs.gnu.org; Sun, 02 Jul 2023 16:54:48 -0400 Received: from mail-oo1-f46.google.com ([209.85.161.46]:60417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qG45h-00011l-Bx for 64424@debbugs.gnu.org; Sun, 02 Jul 2023 16:54:42 -0400 Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5634db21a58so2683903eaf.0 for <64424@debbugs.gnu.org>; Sun, 02 Jul 2023 13:54:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688331275; x=1690923275; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=z3BOw9r86QTzwQB3g9wpMf3lgj2tKkMAWgQFQknnlY0=; b=F6Rl58tkD0gcf1Kv7JSrMltfWOUBW15dSkcJg0NOHG5oq31VSUnWknwDo/C1gUZ1we gcDzyn9tsBPH/BO32R8WXQQpfCR3VXNymgqhHuzKZ44jfD7wGObMVv7BIJ2Ys2TI0i1z fQ0FvZ91mpRFL6x+RIo7KNzKIWbstKEJPNWMUNO/Hnw4lLwsH/I8y/p5rIvPL5FM9bpm h8JtZ/vanHptejQzA13IOhA/BFDp1DrrjlsHFwlWbaXYcB3nPJG0r3MK4EIj5eqqreEO GvcTyhFI8aa3vbKd8q5o0T2FXAE464evfQJWC5+3Oo9u/fH9sQ4q4j0yp0n6+4itIMN8 pmZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688331275; x=1690923275; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z3BOw9r86QTzwQB3g9wpMf3lgj2tKkMAWgQFQknnlY0=; b=grZ4jm3mu5dMwZKqAjMA8nXs+zcTpqz04RQYbzrh+KNnJSF+YUnz65WbV9iFb+qnjr XBLnFRcBy7NnyJthuB5UZwWdTxrU6kXyH8RlsGykvZMO+4z6tya3ogANxoWxWdHixHDQ Gj670JIZRSfJXj4cL/BjBfe5ltN+soA6eQPL6Ohyml3MXu9CMDdUDqLNsTdDmGox28Vl z29Z2nlWU4Sk4XWVP8mLh0wVsZ5rwO1i/3V4D6hpS0RN4BLycskNlkeKCPPcxbEHHoLM /m1aR8aNxgKt+2wVbQssH1fHx7mG5/7osMqxG839eDcYwGZ+o+Ch9nO0Zc8+E/Ig/vsS okOw== X-Gm-Message-State: AC+VfDwxZHk2H1ki9wsj6MGXVdmRksXxmm0xYxyfdRAsRF+agtqSmf6W lKl+MlHJr8c/CqMMQxApncOZP5qokJVyD/GEbgjPnOAq X-Google-Smtp-Source: ACHHUZ7W7e9/3F8UFYNdiR0THoJBwBp2zi9Z2Kg54rFt/PuLSOJ3IZOTjp431EtuAZAi5g/8Ep2bJS9gXOUtTG/MCz0= X-Received: by 2002:a4a:5287:0:b0:55a:f44b:43cd with SMTP id d129-20020a4a5287000000b0055af44b43cdmr7015846oob.7.1688331275569; Sun, 02 Jul 2023 13:54:35 -0700 (PDT) MIME-Version: 1.0 References: <873526i97u.fsf@catern.com> <838rbynsul.fsf@gnu.org> In-Reply-To: <838rbynsul.fsf@gnu.org> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 2 Jul 2023 21:54:20 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000f18d6105ff87412e" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f18d6105ff87412e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Jul 2, 2023, 18:08 Eli Zaretskii wrote: > > From: sbaugh@catern.com > > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC) > > > > This helps clarify what each of these numbers mean. This is inspired > > by compilation-mode-line-errors which does the same. > > > > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add > > help-echo to mode line properties. > > Thanks. > > Jo=C3=A3o, is this safe for the release branch? > I think so, yes. I'd like to give it a bit of testing with Eglot, which uses its own types, but it does seem safe regardless. Jo=C3=A3o > --000000000000f18d6105ff87412e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Jul 2, 2023, 18:08 Eli Zaretskii <eliz@gnu.org> wrote:
> From: sbaugh@catern.com
> Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC)
>
> This helps clarify what each of these numbers mean.=C2=A0 This is insp= ired
> by compilation-mode-line-errors which does the same.
>
> * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add
> help-echo to mode line properties.

Thanks.

Jo=C3=A3o, is this safe for the release branch?

I think so, yes. I'd lik= e to give it a bit of testing with Eglot, which uses its own types, but it = does seem safe regardless.

Jo=C3=A3o
--000000000000f18d6105ff87412e-- From unknown Mon Sep 22 23:25:33 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: sbaugh@catern.com Subject: bug#64424: closed (Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters) Message-ID: References: <831qhpnstw.fsf@gnu.org> <873526i97u.fsf@catern.com> X-Gnu-PR-Message: they-closed 64424 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 64424@debbugs.gnu.org Date: Mon, 03 Jul 2023 11:22:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1688383322-14334-1" This is a multi-part message in MIME format... ------------=_1688383322-14334-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64424: [PATCH] Include a help-echo for flymake's modeline counters which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64424@debbugs.gnu.org. --=20 64424: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64424 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1688383322-14334-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64424-done) by debbugs.gnu.org; 3 Jul 2023 11:21:20 +0000 Received: from localhost ([127.0.0.1]:33257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGHcN-0003iB-Kp for submit@debbugs.gnu.org; Mon, 03 Jul 2023 07:21:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGHcL-0003hy-0C for 64424-done@debbugs.gnu.org; Mon, 03 Jul 2023 07:21:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGHcF-0000iq-ON; Mon, 03 Jul 2023 07:21:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HqGScfkhiRCqj4qlaTfFZaOK9i6HEbKMSltIANsvycQ=; b=B9ad0Pvo+WISC/sphSxa 0BhFrjftUaXkEHrlHSs827tPpDbkLcCI9dPVVGK1fNNGXXqkpdcvD5x/ghCOYqgnTneYH0pbtGgy5 KkDmZjRTGasr2GmvJ4wvDsohg9Q0AJrJiYDCSiBQ6ynDEzBT+uFwMQJ9MFrp8eWRkZWGGZTwtiYwL GNbtHn8NKjakbhCVYcBmddoavrHCqdilokT16G8AvLw5NO0wuHRokYvXMT4I61/JVSnUDMiMnJ51d IF2e/K3dsY1HghM78CQQvJrmF7whoV7BQzLzXlh+1bNGszkbo5Hzb9I2ehXEdctdqw8UY9C5puNVE WRq8l7oQyZ3pjg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGHcF-0001tg-6O; Mon, 03 Jul 2023 07:21:11 -0400 Date: Mon, 03 Jul 2023 14:21:47 +0300 Message-Id: <831qhpnstw.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= In-Reply-To: (message from =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= on Sun, 2 Jul 2023 21:54:20 +0100) Subject: Re: bug#64424: [PATCH] Include a help-echo for flymake's modeline counters References: <873526i97u.fsf@catern.com> <838rbynsul.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64424-done Cc: sbaugh@catern.com, 64424-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: João Távora > Date: Sun, 2 Jul 2023 21:54:20 +0100 > Cc: sbaugh@catern.com, 64424@debbugs.gnu.org > > On Sun, Jul 2, 2023, 18:08 Eli Zaretskii wrote: > > > From: sbaugh@catern.com > > Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC) > > > > This helps clarify what each of these numbers mean. This is inspired > > by compilation-mode-line-errors which does the same. > > > > * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add > > help-echo to mode line properties. > > Thanks. > > João, is this safe for the release branch? > > I think so, yes. I'd like to give it a bit of testing with Eglot, which uses its own types, but it does seem > safe regardless. Thanks, installed on the emacs-29 branch, and closing the bug. ------------=_1688383322-14334-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Jul 2023 16:12:18 +0000 Received: from localhost ([127.0.0.1]:60939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzgP-0007zj-JY for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:12:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:54132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qFzgM-0007zY-Dd for submit@debbugs.gnu.org; Sun, 02 Jul 2023 12:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qFzgM-00016Z-0W for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:12:14 -0400 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qFzgH-0002xw-Do for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2023 12:12:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:mime-version:to:content-type:cc:content-type:from: subject:to; s=s1; bh=XiqYjdDhNtLev5h2gSAUsULT2HvNn666ZrbbS424ccc=; b=fV1VWKdM6LCeUZqz0gIfMnpcMJfiqvCYX6VWizG4YNVZ3tgz3wJnd4+1xcpVBLwVZ6jM ROXB8Wa3U+sZmAHTTGsFGx33KBKlo8uHRwSbGsvKl6OnpD7vbahakeufDL1XTRJpARu73J Y3MiOKL8xXkYozSMRMsFSbsDt5tzmG+hxGL/3+bacKRREx4ysH7G1kMIukQ5IBf83jzts3 kB0IWLl0ekHJ9j6ueBZf5rUavKx62khNQ/LxN5pTy174nuNQO3xheh0fzqSPDSJxJiT/UB NPVgCGHRQoCCagiW0HYOGP0JN89+enPz6mzodZ0Ec7LZ2D6zjAw4mYYaLVsnTaUQ== Received: by filterdrecv-66949dbc98-4lpsw with SMTP id filterdrecv-66949dbc98-4lpsw-1-64A1A1D6-20 2023-07-02 16:12:06.680296971 +0000 UTC m=+4552339.957439589 Received: from earth.catern.com (unknown) by geopod-ismtpd-26 (SG) with ESMTP id Od1qFZaRQ1ughb3YHVwZMw for ; Sun, 02 Jul 2023 16:12:06.565 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver= Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 097F460087 for ; Sun, 2 Jul 2023 12:12:05 -0400 (EDT) From: sbaugh@catern.com Subject: [PATCH] Include a help-echo for flymake's modeline counters Date: Sun, 02 Jul 2023 16:12:06 +0000 (UTC) Message-ID: <873526i97u.fsf@catern.com> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?ZgbRq7gjGrt0q=2FPjvxk7wM0yQFRdOkTJAtEbkjCkHbLeTrQ+l=2FWizRK9J2QWp3?= =?us-ascii?Q?zl5jRh2SuqU+k6r7K=2FON4yrkZ7fY=2Fa=2F+O6pfffY?= =?us-ascii?Q?as4nJ59IUfug9MwUOcD4qxiwDb+=2FChDtLCtPvEs?= =?us-ascii?Q?HQjWuBSyKTb4J+++ikI9qKkoybBodCeTy3fcwBh?= =?us-ascii?Q?sIJUn1MXQLL9LbvQwChZk4CyKrhPLkO3S7g=3D=3D?= To: bug-gnu-emacs@gnu.org X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=149.72.123.24; envelope-from=bounces+21787432-3678-bug-gnu-emacs=gnu.org@em8926.catern.com; helo=s.wrqvtbkv.outbound-mail.sendgrid.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Tags: patch This helps clarify what each of these numbers mean. This is inspired by compilation-mode-line-errors which does the same. * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add help-echo to mode line properties. In GNU Emacs 29.0.92 (build 2, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-07-01 built on earth Repository revision: b179926388ee76f7b3304535a7189f89bd7c7f8c Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12014000 System Description: NixOS 22.11 (Raccoon) Configured using: 'configure --with-x-toolkit=lucid --with-tree-sitter CC=gcc' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Include-a-help-echo-for-flymake-s-modeline-counters.patch >From aa577647a91c295fedcff4c1357ebb1f6c0d1384 Mon Sep 17 00:00:00 2001 From: Spencer Baugh Date: Sun, 2 Jul 2023 12:11:09 -0400 Subject: [PATCH] Include a help-echo for flymake's modeline counters This helps clarify what each of these numbers mean. This is inspired by compilation-mode-line-errors which does the same. * lisp/progmodes/flymake.el (flymake--mode-line-counter): Add help-echo to mode line properties. --- lisp/progmodes/flymake.el | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el index 6f293acca5e..47dc32f9245 100644 --- a/lisp/progmodes/flymake.el +++ b/lisp/progmodes/flymake.el @@ -1473,6 +1473,12 @@ flymake--mode-line-counter ,(format "%d" count) face ,face mouse-face mode-line-highlight + help-echo ,(format "Number of %s; scroll mouse to view." + (cond + ((eq type :error) "errors") + ((eq type :warning) "warnings") + ((eq type :note) "notes") + (t (format "%s diagnostics" type)))) keymap ,(let ((map (make-sparse-keymap))) (define-key map (vector 'mode-line -- 2.40.1 --=-=-=-- ------------=_1688383322-14334-1--