GNU bug report logs - #64418
[PATCH 0/1] Common Lisp local-time Postgres extension

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64418 in the body.
You can then email your comments to 64418 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH 0/1] Common Lisp local-time Postgres extension
Date: Sun,  2 Jul 2023 13:58:33 +0200

Hello Guix,

I was trying to use postmodern with the local-time library. This did not work,
because it looks like the extensions is not compiled with the local-rime time
package. When I tried loading the extension, a compilation was triggered but
ultimatly failed because it was trying to write the compiled fasl file into
the Guix store.

Since the local-time package can be used without postgresql, I created a new
package for just the extension and removed the broken system from the
local-time package in order to not add cl-postgres and postmodern to it.

Could you please review this patch?

Thanks, Roman.

Roman Scherer (1):
  gnu: Add sbcl-postgres+local-time.

 gnu/packages/lisp-xyz.scm | 54 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 53 insertions(+), 1 deletion(-)

--
2.40.1

Message #8 received at 64418 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: 64418 <at> debbugs.gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH 1/1] gnu: Add sbcl-postgres+local-time.
Date: Sun,  2 Jul 2023 14:00:39 +0200

* gnu/packages/lisp-xyz.scm (sbcl-postgres+local-time): New variable.
---
 gnu/packages/lisp-xyz.scm | 54 ++++++++++++++++++++++++++++++++++++++-
 1 file changed, 53 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index d578c46b90..bd1efc2b83 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -6875,7 +6875,7 @@ (define-public ecl-cl-isaac
 
 (define-public sbcl-local-time
   (let ((commit "40169fe26d9639f3d9560ec0255789bf00b30036")
-        (revision "3"))
+        (revision "4"))
     (package
      (name "sbcl-local-time")
      (version (git-version "1.0.6" revision commit))
@@ -6889,6 +6889,14 @@ (define-public sbcl-local-time
        (sha256
         (base32 "1dbp33zmkqzzshmf5k76pxqgli285wvy0p0dhcz816fdikpwn2jg"))))
      (build-system asdf-build-system/sbcl)
+     (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           ;; Delete the extension provided by sbcl-cl-postgres+local-time
+           (add-after 'unpack 'delete-local-time
+             (lambda _
+               (delete-file "cl-postgres+local-time.asd")
+               (delete-file "src/integration/cl-postgres.lisp"))))))
      (native-inputs
       (list sbcl-hu.dwim.stefil))
      (home-page "https://common-lisp.net/project/local-time/")
@@ -6905,6 +6913,50 @@ (define-public cl-local-time
 (define-public ecl-local-time
   (sbcl-package->ecl-package sbcl-local-time))
 
+(define-public sbcl-postgres+local-time
+  (let ((commit "40169fe26d9639f3d9560ec0255789bf00b30036")
+        (revision "3"))
+    (package
+      (name "sbcl-postgres+local-time")
+      (version (git-version "1.0.6" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/dlowe-net/local-time")
+               (commit commit)))
+         (file-name (git-file-name "cl-postgres+local-time" version))
+         (sha256
+          (base32 "1dbp33zmkqzzshmf5k76pxqgli285wvy0p0dhcz816fdikpwn2jg"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs (list sbcl-local-time sbcl-postmodern))
+      (native-inputs
+       (list sbcl-hu.dwim.stefil))
+      (arguments
+       `(#:asd-systems '("cl-postgres+local-time")
+         #:phases
+         (modify-phases %standard-phases
+           (add-after 'unpack 'delete-local-time
+             (lambda _
+               (delete-file "local-time.asd")
+               (delete-file "src/package.lisp")
+               (delete-file "src/local-time.lisp")
+               (delete-file-recursively "doc")
+               (delete-file-recursively "test")
+               (delete-file-recursively "zoneinfo"))))))
+      (home-page "https://common-lisp.net/project/local-time/")
+      (synopsis "Integration between cl-postgres and local-time")
+      (description
+       "This package provides the LOCAL-TIME extensions for the cl-postgres
+ASDF system of postmodern.")
+      (license license:expat))))
+
+(define-public cl-postgres+local-time
+  (sbcl-package->cl-source-package sbcl-postgres+local-time))
+
+(define-public ecl-postgres+local-time
+  (sbcl-package->ecl-package sbcl-postgres+local-time))
+
 (define-public sbcl-chronicity
   (package
     (name "sbcl-chronicity")
-- 
2.40.1

Message #13 received at 64418-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 64418-done <at> debbugs.gnu.org
Subject: Re: [bug#64418] [PATCH 0/1] Common Lisp local-time Postgres extension
Date: Tue, 04 Jul 2023 09:15:14 +0000

[Message part 1 (text/plain, inline)]

I modified your patch to make the package definition for
sbcl-cl-postgres+local-time more concise by inheriting from
sbcl-local-time, given that they have the same source repository.

Patch applied as ec2b5784abc18870c3a1031928f86131d78684ae.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.