GNU bug report logs - #64395
[PATCH] * src/xdisp.c (display_string): Don't truncate mode line in terminal

Previous Next

Package: emacs;

Reported by: Gong Qijian <gongqijian <at> gmail.com>

Date: Sat, 1 Jul 2023 06:31:01 UTC

Severity: normal

Tags: patch

Merged with 64396

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 64395 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: gongqijian <at> gmail.com
Cc: 64395 <at> debbugs.gnu.org
Subject: Re: bug#64395: [PATCH] * src/xdisp.c (display_string): Don't truncate
 mode line in terminal
Date: Sun, 02 Jul 2023 11:15:20 +0300
> Cc: 64395 <at> debbugs.gnu.org
> Date: Sat, 01 Jul 2023 15:47:39 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> Your proposed change fixes the problem, but it fixes it incorrectly:
> after applying the patch, I see a truncation glyph "$" at the end of
> the mode line.  This should never happen on the mode line: we don't
> show truncation glyphs there.  Compare the display after applying your
> patch with the mode-line displayed after evaluating the below:
> 
>  (setq mode-line-format
>        (concat (format-mode-line
>                 "- Ln %l, Col %c ")
>                (make-string 100 ?-)))
> 
> As you see, the expected display of the mode line that is truncated is
> simply not to see the truncated part, without any "$" truncation
> glyph at the end of the mode line.
> 
> So a slightly different change is needed to properly fix this case.
> I'm working on such a proper fix.

Should be fixed now on the master branch, please test.




This bug report was last modified 2 years and 25 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.