GNU bug report logs - #64361
[PATCH] gnu: python-wand: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64361 in the body.
You can then email your comments to 64361 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>, Thorsten Wilms <t_w_ <at> freenet.de>
Subject: [PATCH] gnu: python-wand: Fix build.
Date: Fri, 30 Jun 2023 15:56:45 +0800

Fixes <https://issues.guix.gnu.org/64350>.

* gnu/packages/python-xyz.scm (python-wand)[arguments]<#:phases>: Pass tests?
to 'check.

Reported-by: Thorsten Wilms <t_w_ <at> freenet.de>
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index c4105c4685..bf0ccfe07b 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2445,7 +2445,7 @@ (define-public python-wand
              (setenv "MAGICK_HOME" (assoc-ref inputs "imagemagick"))
              (setenv "WAND_MAGICK_LIBRARY_SUFFIX" ".Q16")))
          (replace 'check
-           (lambda _
+           (lambda* (#:key tests? #:allow-other-keys)
              (when tests?
                (invoke "pytest" "-vv")))))))
     (native-inputs

base-commit: 94ac93042f09b4ba68b7b64ed1feeebd3dab1ea4
-- 
2.40.1

Message #8 received at 64361 <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 64361 <at> debbugs.gnu.org
Cc: Hilton Chain <hako <at> ultrarare.space>
Subject: [PATCH v2] gnu: python-wand: Honor #:tests? argument.
Date: Mon, 17 Jul 2023 20:43:55 +0800

Fixes <https://issues.guix.gnu.org/64350>.

* gnu/packages/python-xyz.scm (python-wand)[arguments]<#:phases>: Pass keyword
argument #:tests? to 'check.

Reported-by: Thorsten Wilms <t_w_ <at> freenet.de>
---
 gnu/packages/python-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 973216c5ed..f07ae0b1f9 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -2446,7 +2446,7 @@ (define-public python-wand
              (setenv "MAGICK_HOME" (assoc-ref inputs "imagemagick"))
              (setenv "WAND_MAGICK_LIBRARY_SUFFIX" ".Q16")))
          (replace 'check
-           (lambda _
+           (lambda* (#:key tests? #:allow-other-keys)
              (when tests?
                (invoke "pytest" "-vv")))))))
     (native-inputs

base-commit: ad08f9331fee7a8e71e94b02f86f54ab3e1001a8
-- 
2.41.0

Message #13 received at 64361-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: Hilton Chain <hako <at> ultrarare.space>
Cc: Tobias Geerinckx-Rice <me <at> tobias.gr>, 64361-done <at> debbugs.gnu.org,
 64350-done <at> debbugs.gnu.org
Subject: Re: [bug#64361] [PATCH v2] gnu: python-wand: Honor #:tests? argument.
Date: Wed, 19 Jul 2023 05:45:32 +0100

Fixed with 13cb9b302868b5a966a6ae177412c474084f4bf1.

-- 
Furthermore, I consider that nonfree software must be eradicated.

Cheers,
Bruno.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.