From unknown Fri Aug 08 22:53:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64358 <64358@debbugs.gnu.org> To: bug#64358 <64358@debbugs.gnu.org> Subject: Status: =?UTF-8?Q?=E2=80=9Cguix_?= =?UTF-8?Q?refresh=E2=80=9D?= chokes on cran.scm Reply-To: bug#64358 <64358@debbugs.gnu.org> Date: Sat, 09 Aug 2025 05:53:45 +0000 retitle 64358 =E2=80=9Cguix refresh=E2=80=9D chokes on cran.scm reassign 64358 guix submitter 64358 Ricardo Wurmus severity 64358 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 29 17:31:14 2023 Received: (at submit) by debbugs.gnu.org; 29 Jun 2023 21:31:14 +0000 Received: from localhost ([127.0.0.1]:54169 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEzEQ-0007SA-4I for submit@debbugs.gnu.org; Thu, 29 Jun 2023 17:31:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:35778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEzEK-0007Ry-H5 for submit@debbugs.gnu.org; Thu, 29 Jun 2023 17:31:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEzEE-0000vi-3v for bug-guix@gnu.org; Thu, 29 Jun 2023 17:31:03 -0400 Received: from sender3-of-o59.zoho.com ([136.143.184.59]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEzEC-0001mC-18; Thu, 29 Jun 2023 17:31:01 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1688074252; cv=none; d=zohomail.com; s=zohoarc; b=CK9p2cdj/NWDf/ysSofezqcXVxFO7+uCKgQuGkDQwvnsN3UZnTt6/yztmzVSEh34yUXPGKkIyOGm/hTmiZ15iAYJOYEws80RUDugF2MNgeYMYKsePa1mbLXCWZIg7tjzARglQeRCi9LOb93lRuWGCX0AGvkTGwOXHC1rBIJ2YzE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688074252; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=0JTFCe/HGSYeSYEH5dKvgzHWXsI8njNpoKS7LtCIHs8=; b=gNih+vfQux7e10ZvUsq6r2efZhxNt56meEN1RSxrC97w/t9WporQP2vEyu9EvY0UHpq638vZB/aNGKKsA3RGZb+C44exhzwID/E8VMga8CVIOEysaFtQNJxA04FiLflzQuKD6LaTKAuHFFD+ilK5E+VnI97VfVQuywJreyI+uHE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688074252; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=0JTFCe/HGSYeSYEH5dKvgzHWXsI8njNpoKS7LtCIHs8=; b=J4LERXjLfoDExYZ+hveuHINapDBCFavqzr4PL8Iv09aGD7cWMo2oaRvf5JhUkP/Z s8fxtnXaFvLXHt9Ud5X7d9Rkabbmo0AHZWCIVttH22qXihE2Dj+D5NpCLvPLRwkD7qY r8JMQXqlSdAhhHuLfzChPMQ7XOydo7i/w0xfblck= Received: from localhost (45-110-142-46.pool.kielnet.net [46.142.110.45]) by mx.zohomail.com with SMTPS id 1688074247819256.7903934227902; Thu, 29 Jun 2023 14:30:47 -0700 (PDT) User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: bug-guix@gnu.org Subject: =?utf-8?Q?=E2=80=9Cguix_refresh=E2=80=9D?= chokes on cran.scm Date: Thu, 29 Jun 2023 23:26:48 +0200 Message-ID: <87bkgyklbv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass client-ip=136.143.184.59; envelope-from=rekado@elephly.net; helo=sender3-of-o59.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The new refresh behavior to update inputs automatically seems to sometimes cause the updater to lose track of the position in the file, leading to errors like this: --8<---------------cut here---------------start------------->8--- Backtrace: In ice-9/boot-9.scm: 1752:10 18 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In unknown file: 17 (apply-smob/0 #) In ice-9/boot-9.scm: 724:2 16 (call-with-prompt _ _ #) In ice-9/eval.scm: 619:8 15 (_ #(#(#))) In guix/ui.scm: 2309:7 14 (run-guix . _) 2272:10 13 (run-guix-command _ . _) In ice-9/boot-9.scm: 1752:10 12 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) 1752:10 11 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In guix/store.scm: 659:37 10 (thunk) 2168:25 9 (run-with-store # _ #:gu= ile-for-build _ #:system _ #:target _) In guix/scripts/refresh.scm: 592:16 8 (_ _) In srfi/srfi-1.scm: 634:9 7 (for-each # _) In guix/scripts/refresh.scm: 363:21 6 (update-package _ # _ =E2=80=A6) In ice-9/boot-9.scm: 1747:15 5 (with-exception-handler # _ #:unwind? _ #:unwind-for-type _) In ice-9/ports.scm: 433:17 4 (call-with-input-file _ _ #:binary _ #:encoding _ #:guess-enco= ding _) In guix/packages.scm: 762:17 3 (_ #) In guix/utils.scm: 423:23 2 (go-to-location # 30341 2) In ice-9/boot-9.scm: 1685:16 1 (raise-exception _ #:continuable? _) 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: unexpected end of line # --8<---------------cut here---------------end--------------->8--- Prior to that we see warnings like this: --8<---------------cut here---------------start------------->8--- /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: r-readte= xt: updating from version 0.82 to version 0.90... /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: warning:= r-readtext: no `version' field in source; skipping --8<---------------cut here---------------end--------------->8--- It=E2=80=99s as if the position in the file has been lost and it tries to u= pdate the definition of r-readtext that is no longer where the current port position is. I use =E2=80=9C./pre-inst-env guix refresh -t cran -u=E2=80=9D, which updat= es dozens of packages. Perhaps the changes result in untracked position shifts in the file? --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 03 15:43:10 2023 Received: (at 64358) by debbugs.gnu.org; 3 Jul 2023 19:43:10 +0000 Received: from localhost ([127.0.0.1]:34534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGPS1-0003JG-Vh for submit@debbugs.gnu.org; Mon, 03 Jul 2023 15:43:10 -0400 Received: from sender3-of-o58.zoho.com ([136.143.184.58]:21824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qGPS0-0003J6-3H for 64358@debbugs.gnu.org; Mon, 03 Jul 2023 15:43:09 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1688413373; cv=none; d=zohomail.com; s=zohoarc; b=nvZJKOwe9LgKnapTAqnQjlJI35PjWFIE990CVlkLWDoFQ1t2MwjnPphIDo/4yvyCru5/hQeRQGsmLaI0CamohSjozgm5eM1GGVX61ZajDZqN4t2KPBJbdumAIoZQ8ZZRXkquIOWqATJzGDxRkuan7CdHmxvQeYKVs/4QLI+HCQk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688413373; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=PY0L1jGYRR5XUvB/Ub+i/u567cq3YMXLjAdMfPPeNNc=; b=EEoR6P8NfYLCghmaeh148+ok+rwEOhlP7+PNImjRqULtZqqHQbRKgMd0pe+0RCo+8e7TdknfBrUbhV5cw6l6JLtCok9pirPFioEMLG5Bws3VtOiL+Vd8xV9KQ4IRFpETQ3jpEzA6EWUgrwT9Q3dNamWjrXU5bzjjPkyHguv7vXE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688413373; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=PY0L1jGYRR5XUvB/Ub+i/u567cq3YMXLjAdMfPPeNNc=; b=PnhaPOn0WodraylC9K3UBqiGAIycgq1YnN3fT+7kcRZQjxuglWv7y1kcL9cPkyjL 8p5QnZHRsow3leP9NQuiGMFHuWMZGZ4wJnQlo19rd4DCjbBScpAQBIZJqGlZSSja6ut 3hVtFS4/cfFLedjSatklF4cFSBRUatLEkXcSLWZs= Received: from localhost (45-110-142-46.pool.kielnet.net [46.142.110.45]) by mx.zohomail.com with SMTPS id 1688413371672103.3891389990589; Mon, 3 Jul 2023 12:42:51 -0700 (PDT) References: <87bkgyklbv.fsf@elephly.net> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: 64358@debbugs.gnu.org Subject: =?utf-8?Q?=E2=80=9Cguix_refresh=E2=80=9D?= chokes on cran.scm Date: Mon, 03 Jul 2023 21:29:09 +0200 In-reply-to: Message-ID: <87r0pou6h3.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64358 Cc: ludo@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Prior to that we see warnings like this: > > /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: r-read= text: updating from version 0.82 to version 0.90... > /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: warnin= g: r-readtext: no `version' field in source; skipping > > It=E2=80=99s as if the position in the file has been lost and it tries to= update > the definition of r-readtext that is no longer where the current port > position is. It seems that this is indeed the problem. The value for a =E2=80= =99s =E2=80=9Clocation=E2=80=9D field is known at compile/eval time and this val= ue will not be correct after the first substantial edit has taken place. I see these options: 1 - pass a value to =E2=80=9Cupdate-package=E2=80=9D that corresponds to li= ne changes so far and let it return an updated value, making =E2=80=9Cupdate-package=E2= =80=9D aware of file changes. This would be rather ugly. 2 - compute the location of the target package anew if the file it is located in has since been edited. 3 - never rely on the line number of the package location value; just open the specified file and always search it for a package definition. Optionally take the line number into account as a starting point for a search in both directions. 4 - integrate changes with git, so that all edits are commits that are applied to the very same base commit. The third option seems the most reasonable and lightweight to me. --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 09:43:13 2023 Received: (at 64358) by debbugs.gnu.org; 7 Jul 2023 13:43:13 +0000 Received: from localhost ([127.0.0.1]:42788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHljs-0004tJ-SS for submit@debbugs.gnu.org; Fri, 07 Jul 2023 09:43:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHljn-0004sz-Vq for 64358@debbugs.gnu.org; Fri, 07 Jul 2023 09:43:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHlji-0005hG-AY; Fri, 07 Jul 2023 09:43:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=J8aLXb60C0lYiw/4DvtfblKaWvjMjcBwPUwJVZOv3Dw=; b=VnwKvYn4GjiFp4V8uEXc FumHfqnL/qyfg75JO+rTeSKx3RGgllvP/KwCxsWB4LM2tqntzVO9fb+e2JUFrknbJzPkMPm+oLde+ ZEUlE3HzqhfTiPcmmiJCqiqQaN7xXUuQNpGSFZrDN5ms1xTdAEsLyCoxWOEkIdMn8o3TEQX3OOz1f RKLaa/nZHaiIrhu2a8o1DLmPPLMRMQYy/vGSpGKXYuHLj8ON4MGRbnIOALDcjZZpCtBnw1wJJAIKg zzGSXgxtkAy9pWCTZ8j9eWVz2L2QW5gdmiJtKXnGaIG4GT0TCw+kC463ZEg3mW1eNtda86g7T6A+O UgFG1JUvttiBpQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHljh-00008a-UJ; Fri, 07 Jul 2023 09:43:02 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: bug#64358: =?utf-8?Q?=E2=80=9Cguix_refresh=E2=80=9D?= chokes on cran.scm References: <87bkgyklbv.fsf@elephly.net> <87r0pou6h3.fsf@elephly.net> Date: Fri, 07 Jul 2023 15:42:59 +0200 In-Reply-To: <87r0pou6h3.fsf@elephly.net> (Ricardo Wurmus's message of "Mon, 03 Jul 2023 21:29:09 +0200") Message-ID: <87v8evkfbw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64358 Cc: 64358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ricardo Wurmus skribis: >> Prior to that we see warnings like this: >> >> /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: r-rea= dtext: updating from version 0.82 to version 0.90... >> /home/rekado/dev/gx/branches/master/gnu/packages/cran.scm:36350:2: warni= ng: r-readtext: no `version' field in source; skipping >> >> It=E2=80=99s as if the position in the file has been lost and it tries t= o update >> the definition of r-readtext that is no longer where the current port >> position is. > > It seems that this is indeed the problem. The value for a =E2= =80=99s > =E2=80=9Clocation=E2=80=9D field is known at compile/eval time and this v= alue will not > be correct after the first substantial edit has taken place. The way =E2=80=98guix style -S inputs=E2=80=99 handles it is by starting ed= iting packages from the bottom of the file and upwards (see the bottom of (guix scripts style)). That way, source location is valid as it edits things. Perhaps we can do that here? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 07 16:14:46 2023 Received: (at 64358) by debbugs.gnu.org; 7 Jul 2023 20:14:46 +0000 Received: from localhost ([127.0.0.1]:43853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHrqn-00033C-Ts for submit@debbugs.gnu.org; Fri, 07 Jul 2023 16:14:46 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHrqk-000333-TF for 64358@debbugs.gnu.org; Fri, 07 Jul 2023 16:14:45 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1688760874; cv=none; d=zohomail.com; s=zohoarc; b=miwmNLsA77Z+5YgwSQ3eaV4lBzkSh67fsDawPPrevYquoxu70pMJOa5OyuOLeUXEsk+kauqKHg90w4y9SOUY0ZyDS8XXSJRVlirBZOjBKezVilvTFB6fj+k/HheI0QWWsq5BGFJFpC/rjgnQ8I4MuSOKNddH5poYhI9VExBw2lU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1688760874; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=k+4X/asTqmJmcU3MwcqhPYO1XvlzqmTQMwht0+mJPTA=; b=GyAW3e4OXX0Xnau2UC4TcMeVTurOwugcZ200cETv6PSgudXiMPoG86iHfcva3FHKtSLoneNuyOyMI+DfOI274T37g1PWtCGz+0Vbx4z5meWs89bgiZngQGVJ5lOMxebCwRZLig1lwR01wHiBXfiA32i6GW6cZmKpX/yDziFLj0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1688760874; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=k+4X/asTqmJmcU3MwcqhPYO1XvlzqmTQMwht0+mJPTA=; b=PcPA0/nn9qiYL7AgZzcJHrj1E/0SCl56TmfUBbbwR7b2i0VYllzBsGYBgqciYGu+ EtWkkyeQcJxk/8KoRkUiOCx8PdQ9gtCCbzVumgtgktUyKd79No+OXUzNCPT6yNPTEig nFWtknfnFB7y0cmY1t/yjQwNi+vGSJRo3YqLdfHI= Received: from localhost (92-108-142-46.pool.kielnet.net [46.142.108.92]) by mx.zohomail.com with SMTPS id 1688760872834722.7562405446394; Fri, 7 Jul 2023 13:14:32 -0700 (PDT) References: <87bkgyklbv.fsf@elephly.net> <87r0pou6h3.fsf@elephly.net> <87v8evkfbw.fsf@gnu.org> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#64358: =?utf-8?Q?=E2=80=9Cguix_refresh=E2=80=9D?= chokes on cran.scm Date: Fri, 07 Jul 2023 22:13:52 +0200 In-reply-to: <87v8evkfbw.fsf@gnu.org> Message-ID: <87y1jrscm2.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64358 Cc: 64358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > The way =E2=80=98guix style -S inputs=E2=80=99 handles it is by starting = editing > packages from the bottom of the file and upwards (see the bottom of > (guix scripts style)). That way, source location is valid as it edits > things. > > Perhaps we can do that here? Oh, that=E2=80=99s a very good idea. Worth a try! --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 10 14:41:55 2023 Received: (at 64358) by debbugs.gnu.org; 10 Jul 2023 18:41:55 +0000 Received: from localhost ([127.0.0.1]:49125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIvpa-0002uo-LQ for submit@debbugs.gnu.org; Mon, 10 Jul 2023 14:41:55 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIvpX-0002uc-S3 for 64358@debbugs.gnu.org; Mon, 10 Jul 2023 14:41:53 -0400 Delivered-To: rekado@elephly.net ARC-Seal: i=1; a=rsa-sha256; t=1689014508; cv=none; d=zohomail.com; s=zohoarc; b=MW4GMEtXDg0TO+fKavmgVl2ViEOc5aK9iu0ZWTjy4qGsaXqT+xFrdCBqvpG2/fff+7CQoPPDL8GxmOlChwl1NBksRCHkK0NzeAJQkdyDD/5KmfVCR7lUocS5cEfiU9AF4tUSm9VraZUDLUpJbT2rewbAMeUHnsEWNZi49oTjOmo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689014508; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Xw6QI5nNd2t3n92f+wyp4nfcK+OxxwUPx3sKsnswREw=; b=Exw+seFIus3V8ziALXtxgWMHP9vi6oS6V2xRmDqOa/445+IvF/BQildOQ3AQ4amYgiOi+O8DzDEvAilzYY1Xo+bEF5qc8MZKy2v0UMNr1NnaRA1Uzq+wKBTVhT/HUytnYsHWI06mBzE64F1rY2C+9pv8fOpR58DwOT2aSSBw2o0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689014508; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=Xw6QI5nNd2t3n92f+wyp4nfcK+OxxwUPx3sKsnswREw=; b=OQMMPJ2FbKMS+e+/iIutfnhTUUPZfXdRqFuSTnkmEkksC+uiMIjzU5zYZluXcVdm MZbaBLocU6bZiAGEw4T363umAhpFEoxxqbYOLsLFGbYaH5tvSvVFa8aKdG+/4whhqQb sW50I5iJpPV1DMmCHgBB5NScDP9Nz6hDsB2IaXjM= Received: from localhost (92-108-142-46.pool.kielnet.net [46.142.108.92]) by mx.zohomail.com with SMTPS id 1689014507079272.883472741977; Mon, 10 Jul 2023 11:41:47 -0700 (PDT) From: Ricardo Wurmus To: 64358@debbugs.gnu.org Subject: [PATCH] refresh: Sort update specs by package location. Date: Mon, 10 Jul 2023 20:41:41 +0200 Message-Id: <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64358 Cc: Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . * guix/scripts/refresh.scm (guix-refresh): Sort update specs by location from bottom to top before updating packages. --- guix/scripts/refresh.scm | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm index 9676271542..7a0c312f9d 100644 --- a/guix/scripts/refresh.scm +++ b/guix/scripts/refresh.scm @@ -6,7 +6,7 @@ ;;; Copyright © 2016 Ben Woodcroft ;;; Copyright © 2017 Mathieu Othacehe ;;; Copyright © 2018 Efraim Flashner -;;; Copyright © 2019 Ricardo Wurmus +;;; Copyright © 2019, 2023 Ricardo Wurmus ;;; Copyright © 2020 Simon Tournier ;;; Copyright © 2021 Sarah Morgensen ;;; Copyright © 2022 Hartmut Goebel @@ -589,16 +589,27 @@ (define-command (guix-refresh . args) (or (assoc-ref opts 'keyring) (string-append (config-directory) "/upstream/trustedkeys.kbx")))) - (for-each - (lambda (update) - (update-package store - (update-spec-package update) - (update-spec-version update) - updaters - #:key-server (%openpgp-key-server) - #:key-download key-download - #:warn? warn?)) - update-specs) + (let* ((get-line + (compose location-line + package-location + update-spec-package)) + ;; Sort the specs so that we update packages from the + ;; bottom of the file to the top. This way we can be + ;; sure that the package locations are always correct + ;; and never shifted due to previous edits. + (sorted-update-specs + (sort update-specs + (lambda (a b) (> (get-line a) (get-line b)))))) + (for-each + (lambda (update) + (update-package store + (update-spec-package update) + (update-spec-version update) + updaters + #:key-server (%openpgp-key-server) + #:key-download key-download + #:warn? warn?)) + sorted-update-specs)) (return #t))) (else (for-each (cut check-for-package-update <> updaters base-commit: d0296970fb8ed97ac17bd4c580351af961a8c0fb -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 10 17:50:08 2023 Received: (at 64358) by debbugs.gnu.org; 10 Jul 2023 21:50:08 +0000 Received: from localhost ([127.0.0.1]:49316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIylj-0007jB-NK for submit@debbugs.gnu.org; Mon, 10 Jul 2023 17:50:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIyle-0007iW-H9 for 64358@debbugs.gnu.org; Mon, 10 Jul 2023 17:50:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIylZ-0007jz-8w; Mon, 10 Jul 2023 17:49:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1gKv57wEYJ9bE+T+KljYpz+1NNBRrdZyK/RtB/KUQvM=; b=bNKVGECVdjafEoFixORw LdtzQWssrVvZJsl/PK1+NhFEpfZ87uAbdDsxf4RO/kw81sNIUCv4Z35SGejUYY6PK4GXjcPCvW9Ih aKl/1WbH7ayPeStonv5wY9OTuSjSbhZxZZgvrpJZlphtU4gMkqTGvWBKW84/eyvOsGyYq8u2lmsqb q7QyDJcIY+ZV4VDzLLeH0TQx7NXz7P77NgCj/Gsjrp0wtSq2eM2onCN3gp/gQj0djIDA+cU+cFFpi 1jW+W6wTi9QhzllcNaXh/9niVVn9gepK/tVQbBUkL85GT8mOndOcYaw3D8PSq7uXLxQOuxW0OMKJS zCOzjYU0o6HTLA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qIylY-0003IN-Rm; Mon, 10 Jul 2023 17:49:57 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: bug#64358: [PATCH] refresh: Sort update specs by package location. References: <87bkgyklbv.fsf@elephly.net> <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 22 Messidor an 231 de la =?utf-8?Q?R=C3=A9volu?= =?utf-8?Q?tion=2C?= jour du Cumin X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 10 Jul 2023 23:49:55 +0200 In-Reply-To: <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> (Ricardo Wurmus's message of "Mon, 10 Jul 2023 20:41:41 +0200") Message-ID: <87v8er5tdo.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64358 Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 64358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Ricardo Wurmus skribis: > Fixes . > > * guix/scripts/refresh.scm (guix-refresh): Sort update specs by location = from > bottom to top before updating packages. [=E2=80=A6] > + (let* ((get-line > + (compose location-line > + package-location > + update-spec-package)) Maybe s/get-line/spec-line/ ? Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 10 18:20:24 2023 Received: (at 64358) by debbugs.gnu.org; 10 Jul 2023 22:20:24 +0000 Received: from localhost ([127.0.0.1]:49330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIzF2-000055-DH for submit@debbugs.gnu.org; Mon, 10 Jul 2023 18:20:24 -0400 Received: from sender3-of-o57.zoho.com ([136.143.184.57]:21775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIzEz-00004s-M4 for 64358@debbugs.gnu.org; Mon, 10 Jul 2023 18:20:22 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689027612; cv=none; d=zohomail.com; s=zohoarc; b=Z0UomCvSXRvhNgm0M1qKK1i8p8v/lTL1wm2sbUzpQ8briMnPpUSy2DxEo8gqXwsipa5w0gRjRK0iYrY2XkcblYgn98bo2dJOh8GgOPitKxKXVDR1MpnAs9gXmDEU80RbwqE4bArpI1Hn8VSMmRPa0aGNMmvrjWePtmjFk1NR3FU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689027612; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=VS/LWW+ZgzDGRW99vm2p+VdC9vXja/bJor+XOB3DY0Y=; b=ay7Vr6vw0bvDAsoLYO/2MsAYR2piw/WNGjITOSW7gXuyXiWW+n0xXUhSmOdXMt30ztafif/03XxSX6iAaTVvgZqrK626pHh3fydaGzAkZZgrT/okajoQMVygA3SRiD+tlUJTb4LTFdrybvAtyvtI4zmQRJq+8PZep9CKyGAiI70= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689027612; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=VS/LWW+ZgzDGRW99vm2p+VdC9vXja/bJor+XOB3DY0Y=; b=DagLdGw3ajVAyWc+sOH12YMUJsoPLWrqoI56YNQ72xZw+DlrsNk5FB6tJd+uUyeV o3uXgtm3j3EL8Oq45aXIjHJIxmLUBzmWWyu3jZuDdneMKnBNIPRmDhX62zt2RRXEq7g +9p8sPCRweaoONC3NP/csPCbmbvSjxS6zyVOJ7Cg= Received: from localhost (92-108-142-46.pool.kielnet.net [46.142.108.92]) by mx.zohomail.com with SMTPS id 1689027610504535.7495296636165; Mon, 10 Jul 2023 15:20:10 -0700 (PDT) References: <87bkgyklbv.fsf@elephly.net> <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> <87v8er5tdo.fsf@gnu.org> User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#64358: [PATCH] refresh: Sort update specs by package location. Date: Tue, 11 Jul 2023 00:17:43 +0200 In-reply-to: <87v8er5tdo.fsf@gnu.org> Message-ID: <87ilarjtnt.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64358 Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 64358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ludovic Court=C3=A8s writes: > Ricardo Wurmus skribis: > >> Fixes . >> >> * guix/scripts/refresh.scm (guix-refresh): Sort update specs by location= from >> bottom to top before updating packages. > > [=E2=80=A6] > >> + (let* ((get-line >> + (compose location-line >> + package-location >> + update-spec-package)) > > Maybe s/get-line/spec-line/ ? Okay, will change it. I found that it=E2=80=99s probably not a good idea to sort by location-line without also taking into account the file name. My latest version uses =E2=80=9Clocation->string=E2=80=9D and =E2=80=9Cstring>=E2=80=9D instead of= =E2=80=9Clocation-line=E2=80=9D and =E2=80=9C>=E2=80=9D, ensuring that changes to the same file remain grouped. I=E2=80=99ll push this together with the bulk update of CRAN packages that = I=E2=80=99m working on. Thanks for the review! --=20 Ricardo From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 08:35:41 2023 Received: (at 64358-done) by debbugs.gnu.org; 12 Jul 2023 12:35:41 +0000 Received: from localhost ([127.0.0.1]:51874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZ4G-00060Y-Ub for submit@debbugs.gnu.org; Wed, 12 Jul 2023 08:35:41 -0400 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21017) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJZ4E-00060O-T5 for 64358-done@debbugs.gnu.org; Wed, 12 Jul 2023 08:35:40 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1689165335; cv=none; d=zohomail.com; s=zohoarc; b=h2b/TFKw8nxjvdeSdNl/nvwH3Cw/xQcSJ3pup9ZHq743KtRIFkN36ZlceKtihsc9VLu2AcL8y2v+gYQC5nSBZC05mmy0K7qjM/FxS2NTmlCpWHUZxto1lI1P5eHgdWf905LcBkMuKbWSmV7bwiXi7tYCHBAtWSrzaNVxlO1G0v8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1689165335; h=Content-Type:Date:From:MIME-Version:Message-ID:Subject:To; bh=ap1u+osgh82NwexKfqxmlL/8X/8GzmE4ITDn3kowwDg=; b=YwFkOvz5L5yQse5byBZk95v1QEEhZB5E5MY0IxdityHnu0fxbTT+Tg2PZRTUoUKW7ZJz1Qn4trRIX2KHBXrvuXqBukWAxlvh+o7hglEmha6MrtAItazcofUfd7rrpXguTllcvncOqmg36OZFPnJin8ThC6GvRLW5ef21NJLZsDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1689165335; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:From:To:To:Subject:Subject:Date:Date:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To:Cc; bh=ap1u+osgh82NwexKfqxmlL/8X/8GzmE4ITDn3kowwDg=; b=VJQ+6v3fDIleHXKK0lKdoYjeJocNLYxwHOK6HL6gPN9mCXDo5ZSI2p/f6lTjxFyS JYPxsDHHoovI2GHg2jt9ARAZZ4iRAcegWv4mxoiYZWOl5WJYHsFssKZXSTK6qyYwZ66 b9fdE6km67izbfwoJyFWeg7DLqCRlXZRrVLZeP9k= Received: from localhost (46-110-142-46.pool.kielnet.net [46.142.110.46]) by mx.zohomail.com with SMTPS id 1689165334010862.9547934655595; Wed, 12 Jul 2023 05:35:34 -0700 (PDT) User-agent: mu4e 1.10.3; emacs 28.2 From: Ricardo Wurmus To: 64358-done@debbugs.gnu.org Subject: =?utf-8?Q?=E2=80=9Cguix_refresh=E2=80=9D?= chokes on cran.scm Date: Wed, 12 Jul 2023 14:35:13 +0200 Message-ID: <87jzv5i9yl.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain X-ZohoMailClient: External X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64358-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixed in commit b43841c124d15eaecc41b3928f08a26dbd5c653a -- Ricardo From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 14 09:19:51 2023 Received: (at 64358) by debbugs.gnu.org; 14 Jul 2023 13:19:51 +0000 Received: from localhost ([127.0.0.1]:41688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKIi7-0000KV-Dv for submit@debbugs.gnu.org; Fri, 14 Jul 2023 09:19:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKIi4-0000KB-SV for 64358@debbugs.gnu.org; Fri, 14 Jul 2023 09:19:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKIhy-0002oQ-PO; Fri, 14 Jul 2023 09:19:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=nXhxX22mJ9DnN66Prg4PERXFwY7g2urnF5vPQDnhqlw=; b=alYEtdPneaKgkD3BiuCi JctMif08w0bj5Fp3T4UQn5PZFxQl7TsC6Gcwy/Y9AMr+Y6wVn9p24QrPi6laNkB28e7IUgSNxEhlx +nkWPGW/BWPA/5GzEpT/G45+r3sVjpJ6POYQ/8Dc863meK/+keaaoDQqvBf6JNLrmJopaoSKkqk+J zqMd8E+pPIHpmXD02+B7GiewdzUn8plSmc1zSj36BTPnzd8aif7iiqy0+AuLr21zmcMuNWRje/F67 DtAdrP7cpXJ3EaIpA3oo/UsTdmTfIlGPrk5TCRIWD7aDpu5Zcm1IR43JGD4FnM3CcAv+pSky/MlS8 imKca2V27vRNTQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKIhm-0000UT-Mi; Fri, 14 Jul 2023 09:19:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Ricardo Wurmus Subject: Re: bug#64358: [PATCH] refresh: Sort update specs by package location. References: <87bkgyklbv.fsf@elephly.net> <74997f913e60491d74afcea38a13e5edb0c71b09.1689014499.git.rekado@elephly.net> <87v8er5tdo.fsf@gnu.org> <87ilarjtnt.fsf@elephly.net> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Sextidi 26 Messidor an 231 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour de la Sauge X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 14 Jul 2023 15:19:28 +0200 In-Reply-To: <87ilarjtnt.fsf@elephly.net> (Ricardo Wurmus's message of "Tue, 11 Jul 2023 00:17:43 +0200") Message-ID: <87zg3ywrz3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64358 Cc: Josselin Poiret , Christopher Baines , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 64358@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hallo, Ricardo Wurmus skribis: > I found that it=E2=80=99s probably not a good idea to sort by location-li= ne > without also taking into account the file name. My latest version uses > =E2=80=9Clocation->string=E2=80=9D and =E2=80=9Cstring>=E2=80=9D instead = of =E2=80=9Clocation-line=E2=80=9D and =E2=80=9C>=E2=80=9D, > ensuring that changes to the same file remain grouped. Oops, good point. > I=E2=80=99ll push this together with the bulk update of CRAN packages tha= t I=E2=80=99m > working on. Awesome, thanks! Ludo=E2=80=99. From unknown Fri Aug 08 22:53:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 12 Aug 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator