Subject: [bug#64356] [PATCH 0/4] Fix GDM and VNC tests

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 19 Jul 2023 10:47:39 -0400

Hi,

Bruno Victal <[email-masked]> writes:

> * gnu/tests/vnc.scm (run-xvnc-test): Group up GDM test. Use GNU Ocrad.
> ---
>  gnu/tests/vnc.scm | 59 +++++++++++++++++++++++++----------------------
>  1 file changed, 31 insertions(+), 28 deletions(-)
>
> diff --git a/gnu/tests/vnc.scm b/gnu/tests/vnc.scm
> index e59972eee4..40f8348db9 100644
> --- a/gnu/tests/vnc.scm
> +++ b/gnu/tests/vnc.scm
> @@ -1,5 +1,6 @@

[...]

>  
>                  ;; Run vncviewer and expect the GDM login screen (accessed via
>                  ;; XDMCP).  This can take a while to appear on slower machines.
> -                (ratpoison-exec "vncviewer localhost:5905")
> -                ;; XXX: tesseract narrowly recognizes "Guix" as "uix" from the
> -                ;; background image; ocrad fares worst.  Sadly, 'Username' is
> -                ;; not recognized at all.

I've kept most of the comment; otherwise it'd be hard to understand for
a newcomer that Guix is matched from the background (e.g. when the
background changes and breaks this assumption...).

> +              (ratpoison-exec "vncviewer localhost:5905")
> +
> +              (test-assert "GDM login screen ready"
>                  (wait-for-screen-text marionette
> -                                      (cut string-contains <> "uix")
> -                                      #:ocr #$(file-append tesseract-ocr
> -                                                           "/bin/tesseract")
> -                                      #:timeout 120)))
> +                                      (cut string-contains <> "Guix")
> +                                      #:ocr #$ocr
> +                                      #:ocr-arguments '("--invert"))))

I've preserved the timeout, which is important for slow systems (I added
a comment).

-- 
Thanks,
Maxim