Subject: Re: bug#64356: [PATCH 0/4] Fix GDM and VNC tests

From: Maxim Cournoyer <[email-masked]>
Date: Wed, 19 Jul 2023 10:44:04 -0400

Hi,

Bruno Victal <[email-masked]> writes:

> * gnu/tests/vnc.scm (run-xvnc-test): Use system* instead of invoke.
> ---
>  gnu/tests/vnc.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/tests/vnc.scm b/gnu/tests/vnc.scm
> index 5c4bd43fa3..e59972eee4 100644
> --- a/gnu/tests/vnc.scm
> +++ b/gnu/tests/vnc.scm
> @@ -142,11 +142,11 @@ (define (run-xvnc-test)
>                (marionette-eval
>                 '(begin
>                    ;; Check that DCONF_PROFILE is set...
> -                  (invoke "/bin/sh" "-lc" "\
> +                  (system* "/bin/sh" "-lc" "\
>  pgrep gdm | head -n1 | xargs -I{} grep -Fq DCONF_PROFILE /proc/{}/environ")
>  
>                    ;; ... and that
> -                  (invoke "/bin/sh" "-lc" "\
> +                  (system* "/bin/sh" "-lc" "\
>  sudo -E -u gdm env DCONF_PROFILE=/etc/dconf/profile/gdm dbus-run-session \
>  gsettings get org.gnome.settings-daemon.plugins.power sleep-inactive-ac-type \
>  | grep -Fq nothing"))

Using system* instead of invoke would silence the errors as it doesn't
raise on errors.

The real cause of the problem was a09c7da ("tests: Fork and exec a new
Guile for the marionette REPL."), which I've fixed in 1edbadc6 ("tests:
xvnc: Fix 'gdm auto-suspend is disabled' test.").

Thanks for the report!

-- 
Thanks,
Maxim