GNU bug report logs - #64352
[PATCH] gnu: fluxbox: Fix build.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64352 in the body.
You can then email your comments to 64352 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: fluxbox: Fix build.
Date: Thu, 29 Jun 2023 20:59:06 +0200

* gnu/packages/patches/fluxbox-1.3.7-gcc.patch: New file.
* gnu/local.mk (dist_patch_DATA): Add it.
* gnu/packages/wm.scm (fluxbox)[source](patches): Add it.
---
 gnu/local.mk                                 |  1 +
 gnu/packages/patches/fluxbox-1.3.7-gcc.patch | 16 ++++++++++++++++
 gnu/packages/wm.scm                          |  3 ++-
 3 files changed, 19 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/fluxbox-1.3.7-gcc.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index 2b3df5d75a..478a7cb954 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1144,6 +1144,7 @@ dist_patch_DATA =						\
   %D%/packages/patches/flatpak-fix-path.patch			\
   %D%/packages/patches/flatpak-unset-gdk-pixbuf-for-sandbox.patch	\
   %D%/packages/patches/fluxbox-1.3.7-no-dynamic-cursor.patch	\
+  %D%/packages/patches/fluxbox-1.3.7-gcc.patch			\
   %D%/packages/patches/fontconfig-cache-ignore-mtime.patch	\
   %D%/packages/patches/foobillard++-pkg-config.patch		\
   %D%/packages/patches/foomatic-filters-CVE-2015-8327.patch	\
diff --git a/gnu/packages/patches/fluxbox-1.3.7-gcc.patch b/gnu/packages/patches/fluxbox-1.3.7-gcc.patch
new file mode 100644
index 0000000000..0c805251ac
--- /dev/null
+++ b/gnu/packages/patches/fluxbox-1.3.7-gcc.patch
@@ -0,0 +1,16 @@
+Author: Danny Milosavljevic <dannym <at> scratchpost.org>
+Date: 2023-06-12
+License: expat
+
+diff -ur orig/fluxbox-1.3.7/util/fluxbox-remote.cc fluxbox-1.3.7/util/fluxbox-remote.cc
+--- orig/fluxbox-1.3.7/util/fluxbox-remote.cc	1970-01-01 01:00:01.000000000 +0100
++++ fluxbox-1.3.7/util/fluxbox-remote.cc	2023-05-01 01:11:52.225547895 +0200
+@@ -73,7 +73,7 @@
+     if (strcmp(cmd, "result") == 0) {
+         XTextProperty text_prop;
+         if (XGetTextProperty(disp, root, &text_prop, atom_result) != 0
+-            && text_prop.value > 0
++            && text_prop.value != NULL
+             && text_prop.nitems > 0) {
+ 
+             printf("%s", text_prop.value);
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index c380abc0e8..f5bbf40fcd 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1033,7 +1033,8 @@ (define-public fluxbox
                (base32
                 "1h1f70y40qd225dqx937vzb4k2cz219agm1zvnjxakn5jkz7b37w"))
               (patches
-               (search-patches "fluxbox-1.3.7-no-dynamic-cursor.patch"))))
+               (search-patches "fluxbox-1.3.7-no-dynamic-cursor.patch"
+                               "fluxbox-1.3.7-gcc.patch"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("CPPFLAGS=-U__TIME__") ;ugly, but for reproducibility
-- 
2.39.2

Message #8 received at 64352 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 64352 <at> debbugs.gnu.org
Subject: Re: bug#64352: [PATCH] gnu: fluxbox: Fix build.
Date: Tue, 18 Jul 2023 00:36:49 +0200

Hey Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/packages/patches/fluxbox-1.3.7-gcc.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/wm.scm (fluxbox)[source](patches): Add it.

Go for it!

Ludo’.

Message #13 received at 64352-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 64352-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: fluxbox: Fix build.
Date: Sat, 19 Aug 2023 13:28:37 +0200

[Message part 1 (text/plain, inline)]

This fluxbox build fix was pushed to guix master as commit 18b6e309cec3a0c9c7401b131e18612914f1fcf9.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.