GNU bug report logs - #64344
[PATCH] Make calculator work with customized mode-line

Previous Next

Full log

View this message in rfc822 format

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64344 <at> debbugs.gnu.org
Subject: bug#64344: [PATCH] Make calculator work with customized mode-line
Date: Thu, 29 Jun 2023 10:12:06 -0500

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> +               (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0))))
>                                                ^^^^^
> Shouldn't that be 'consp' instead?  'listp' returns non-nil for nil
> argument.

I’m not expert enough to say more than that either way works to fix the
issue. Originally I did the ‘(cdr lh)’ unconditionally and got an error
mentioning ‘listp’ so I just used that when I added the condition; if it
had said ‘conps’ I would have used that.

Here is the patch with ‘consp’ instead.

[0001-lisp-calculator-el--calculator-need-3-lines---Ch.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.