GNU bug report logs - #64344
[PATCH] Make calculator work with customized mode-line

Previous Next

Full log

Message #26 received at 64344 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andreas Schwab <schwab <at> suse.de>
Cc: jm <at> pub.pink, 64344 <at> debbugs.gnu.org
Subject: Re: bug#64344: [PATCH] Make calculator work with customized mode-line
Date: Thu, 29 Jun 2023 12:38:36 +0300

> From: Andreas Schwab <schwab <at> suse.de>
> Cc: jm <at> pub.pink,  64344 <at> debbugs.gnu.org
> Date: Thu, 29 Jun 2023 11:31:06 +0200
> 
> On Jun 29 2023, Eli Zaretskii wrote:
> 
> >> From: Andreas Schwab <schwab <at> suse.de>
> >> Cc: john muhl <jm <at> pub.pink>,  64344 <at> debbugs.gnu.org
> >> Date: Thu, 29 Jun 2023 10:22:02 +0200
> >> 
> >> On Jun 29 2023, Eli Zaretskii wrote:
> >> 
> >> >> -               (and bx (or (not lh) (> lh 0))))
> >> >> +               (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0))))
> >> >                                                ^^^^^
> >> > Shouldn't that be 'consp' instead?  'listp' returns non-nil for nil
> >> > argument.
> >> 
> >> lh cannot be nil here, but it wouldn't make a difference anyway, since
> >> (cdr nil) returns nil.
> >
> > I prefer not to have, nor force others, to analyze code in order to
> > ensure it's correct.
> 
> Then you need to add a comment, not change correct code.

There's no reason whatsoever to comment correct code.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.