Subject: Re: bug#64344: [PATCH] Make calculator work with customized mode-line

From: Andreas Schwab <[email-masked]>
Date: Thu, 29 Jun 2023 11:31:06 +0200

On Jun 29 2023, Eli Zaretskii wrote:

>> From: Andreas Schwab <[email-masked]>
>> Cc: john muhl <[email-masked]>,  [email-masked]
>> Date: Thu, 29 Jun 2023 10:22:02 +0200
>> 
>> On Jun 29 2023, Eli Zaretskii wrote:
>> 
>> >> -               (and bx (or (not lh) (> lh 0))))
>> >> +               (and bx (or (not lh) (> (if (listp lh) (cdr lh) lh) 0))))
>> >                                                ^^^^^
>> > Shouldn't that be 'consp' instead?  'listp' returns non-nil for nil
>> > argument.
>> 
>> lh cannot be nil here, but it wouldn't make a difference anyway, since
>> (cdr nil) returns nil.
>
> I prefer not to have, nor force others, to analyze code in order to
> ensure it's correct.

Then you need to add a comment, not change correct code.

-- 
Andreas Schwab, SUSE Labs, [email-masked]
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."