From unknown Sun Jun 22 17:12:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64338 <64338@debbugs.gnu.org> To: bug#64338 <64338@debbugs.gnu.org> Subject: Status: [PATCH RFC] gnu: ungoogled-chromium: Build with h264. Reply-To: bug#64338 <64338@debbugs.gnu.org> Date: Mon, 23 Jun 2025 00:12:02 +0000 retitle 64338 [PATCH RFC] gnu: ungoogled-chromium: Build with h264. reassign 64338 guix-patches submitter 64338 Liliana Marie Prikler severity 64338 normal tag 64338 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 15:08:46 2023 Received: (at submit) by debbugs.gnu.org; 28 Jun 2023 19:08:46 +0000 Received: from localhost ([127.0.0.1]:51720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEaX0-0004zn-DT for submit@debbugs.gnu.org; Wed, 28 Jun 2023 15:08:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:51936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEaWv-0004zb-3o for submit@debbugs.gnu.org; Wed, 28 Jun 2023 15:08:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qEaWu-0003Jy-FC for guix-patches@gnu.org; Wed, 28 Jun 2023 15:08:40 -0400 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qEaWs-00068L-6E for guix-patches@gnu.org; Wed, 28 Jun 2023 15:08:40 -0400 Received: by mail-lj1-x242.google.com with SMTP id 38308e7fff4ca-2b6a152a933so2628591fa.1 for ; Wed, 28 Jun 2023 12:08:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687979315; x=1690571315; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:from:to:cc:subject:date:message-id:reply-to; bh=OZiCSHr1rDFPNdRnL9fjcE5Y+iuatH2RMS0N9aVLg2U=; b=Z4dFeShQzBWq5009zRIzttXApeo9nvNBxe1+6XlGdBFAfNcgnzwmj1C9/V8Mjyj03/ 2a6g/Zd0I4aUvHBMgJeqLozgO/KecRtbTXGGMP/tVzCzC1Iusj4LF5cMxUZ02JQbIgnT Y6F8LhlL2XM6SJ98oV8ZNUAK8mxzEdewAQmtaogccl4GObibE+Xo4ONa5Auhw+wabAEL 17RKjcgMqiqnO4AelkjWevGqEokcxKRZgD76A/MgCFOoCY5BlOQp+O2dSp/JvAP6Bw+k 8J6zP4OlFbjb/nP3cDvg6w8weslRLNqnw75Z1rAzepay7jTKoF7VUvwM9+vSNwjlpofv fpUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687979315; x=1690571315; h=to:content-transfer-encoding:mime-version:subject:date:from :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OZiCSHr1rDFPNdRnL9fjcE5Y+iuatH2RMS0N9aVLg2U=; b=Qv2/ayxVMKrChLGMkmq1snedj0BKWXCK5Fc8Dmk7MeCiTL4NIVWL/V/PdV9lGrWunp rubiBJHE1m3VMGIOIfjY2BrLxxs1fxEmlajfkQNe/UOqu8kJLWfgO8lYZxSb8fDnzJ/I 1L+0X7seVyqVrxRJYpkyONRLhbByskLX6CkCwB8bJzBNnPg09K46siAKdlPFe6/Vjfiv iXfQL5oeYzxLZacWc5aWAnjX8H5c2cHyyiQ76Og3CJCKNifO5BR6Jr7sUO9b8YzasgHO 4uHxYdeW1ZxcD+a3z2vJe8pzoPNg5V2N30M/rdiYIv8AUz829/ouZYAWCOCk0HkG+6+2 XsEQ== X-Gm-Message-State: AC+VfDwSed2P5JI2kbujG1UaQktOcGtXfxWqUmIZx7QW8mgTeMq6mjXR EhYuxtVdD8/8HhP1VHmmWKjOS09TmuBCzg== X-Google-Smtp-Source: ACHHUZ4u8acLvcjV2TCdxuyk4ch6jMcialSwkntWqW+fd8dzipeslJVwWSDzjGSXtFP+UemKkUDXlg== X-Received: by 2002:a2e:9cc4:0:b0:2b4:7c31:ab8a with SMTP id g4-20020a2e9cc4000000b002b47c31ab8amr19505075ljj.23.1687979315065; Wed, 28 Jun 2023 12:08:35 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j17-20020a170906279100b0099248468c4esm1597518ejc.21.2023.06.28.12.08.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 12:08:34 -0700 (PDT) Message-Id: <587c8308f3fa585f5f93426e9d0b646170dfe4f0.1687978766.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Wed, 28 Jun 2023 20:57:37 +0200 Subject: [PATCH RFC] gnu: ungoogled-chromium: Build with h264. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Debbugs-Cc: ( , Christopher Baines , Ludovic Courtès , Mathieu Othacehe , Raghav Gururajan , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice , jgart to: guix-patches@gnu.org Received-SPF: pass client-ip=2a00:1450:4864:20::242; envelope-from=liliana.prikler@gmail.com; helo=mail-lj1-x242.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/chromium.scm (ungoogled-chromium)[configure-flags]: Change “rtc_use_h264=false” to “rtc_use_h264=true”. --- Hi Guix, we haven't had a browser with a working WebRTC implementation for quite some time now (basically, both icecat and ungoogled-chromium choke on h264, which is very important for actually seeing video in video conferences). Looking at chromium in particular, the comment next to the flag disabling this feature appears wrong/possibly outdated. As far as I can tell, our ungoogling script already unbundles openh264, so there is nothing to be afraid of. WDYT? BTW, it would of course be nice to have the same for icecat, and possibly have a GStreamer-based WebRTC once GNOME browsers actually come around to support this use case. I simply looked at chromium first because I recalled it to work perfectly fine before this flag was added. Cheers @ mentors: Sorry to CC you all, but I really want at least 2 LGTMs before pushig. gnu/packages/chromium.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/packages/chromium.scm b/gnu/packages/chromium.scm index cef21a4fd1..6a9f113831 100644 --- a/gnu/packages/chromium.scm +++ b/gnu/packages/chromium.scm @@ -584,7 +584,7 @@ (define-public ungoogled-chromium "ffmpeg_branding=\"Chrome\"" ;; WebRTC stuff. - "rtc_use_h264=false" ;XXX needs bundled openh264 + "rtc_use_h264=true" "rtc_use_pipewire=true" "rtc_link_pipewire=true" ;; Don't use bundled sources. base-commit: b24a05830d11e3011eee4bc5f60a41e26188cde1 -- 2.40.1 From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 09 05:33:26 2023 Received: (at 64338-done) by debbugs.gnu.org; 9 Sep 2023 09:33:26 +0000 Received: from localhost ([127.0.0.1]:46122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeuLG-0001XR-17 for submit@debbugs.gnu.org; Sat, 09 Sep 2023 05:33:26 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:51650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeuLD-0001XC-0I for 64338-done@debbugs.gnu.org; Sat, 09 Sep 2023 05:33:24 -0400 Received: by mail-ed1-x544.google.com with SMTP id 4fb4d7f45d1cf-52a39a1c4d5so3722697a12.3 for <64338-done@debbugs.gnu.org>; Sat, 09 Sep 2023 02:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694251994; x=1694856794; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=3ChOYKzcah9YTAS8dYMaeK8R1OPwbBZCUzBzPkX50Fg=; b=jz/sydnkSvQnlNFVTwPshpO1KBVdYZwLcqAYsDIq4skUBkN5k1nUlHXZJRkH6rLEFx pIaF098r9y26m8WLbteV2ovL45XxU5vO8DcFoPbDv4Bjn0Xivv4Z7F+FDC7OJd6oeq3L bv+C7kid7etZ2G9vMx9MTtnJ4ZVu1gfZmPMPiYybV0J970xleU8L1FKy1PUbONEds6KP p1cWYF771Iy6JhV4gLeh/jVioTe4kiftdHO0h+Me/dG0ysIH9af4Mt2KZUmjoMqzIoyN xalKeqwLQx6v2nWJRnCwynyVtU92RMmvR9G56SD6veeoF0+mdTO+sFGlFNPNaXleGwuJ wtnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694251994; x=1694856794; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3ChOYKzcah9YTAS8dYMaeK8R1OPwbBZCUzBzPkX50Fg=; b=SFdbT3DJw/UW7jJt7/O/q8Z8xIJEOjpf1vBT0a0ekS+KKE3Ejas+iwVxP6GJxRp43t THuHDuc7sBnW1btXPPYQEYMnsj/VnL/FBKbGerZYDKVkse0wCmNMRgdr/aKPJNjZUxXg WQ72LvePdumbyiobwC5EvTXJzb/vhKkx5954IPLNr1MrcFHLU9BbJGBiVFEmaa3Eq1HE ZnBKJSXCfyWrLw5aCrIyf4toW9sf7uuQvBdYGjULDcWj6TUXDuErMmmYVs/8r8JohJIq /kmDxMA1FA3tiYJx5Y99RMV/97cUJGRfTYT2mP1dHqGvVHzYdTZmJRRYO1PzUeodGCIJ bERw== X-Gm-Message-State: AOJu0YynNgmZp/4QpFsQY25thU9a01pHT8COx8/RlhxyqklSdp66+qrC YhV7btyu0iH/4wRW3Dv2yWnOpUl0SgZHQ0PR X-Google-Smtp-Source: AGHT+IFHJNJe73He3MBP7hcnFoSlUzCjGXa4hqKg0c3IGx/+kvmnnIbgaVvvA7M28vDdvitH8EdXxg== X-Received: by 2002:a05:6402:1287:b0:51d:95f2:ee76 with SMTP id w7-20020a056402128700b0051d95f2ee76mr3736410edv.27.1694251994208; Sat, 09 Sep 2023 02:33:14 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b7-20020aa7c6c7000000b0052328d4268asm1964502eds.81.2023.09.09.02.33.13 for <64338-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Sep 2023 02:33:13 -0700 (PDT) Message-ID: <6faaacae0917548c37c52edd39a2b7293a6e3cfd.camel@gmail.com> Subject: Re: [PATCH RFC] gnu: ungoogled-chromium: Build with h264. From: Liliana Marie Prikler To: 64338-done@debbugs.gnu.org Date: Sat, 09 Sep 2023 11:33:11 +0200 In-Reply-To: <587c8308f3fa585f5f93426e9d0b646170dfe4f0.1687978766.git.liliana.prikler@gmail.com> References: <587c8308f3fa585f5f93426e9d0b646170dfe4f0.1687978766.git.liliana.prikler@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 64338-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 28.06.2023 um 20:57 +0200 schrieb Liliana Marie Prikler: > * gnu/packages/chromium.scm (ungoogled-chromium)[configure-flags]: > Change > =E2=80=9Crtc_use_h264=3Dfalse=E2=80=9D to =E2=80=9Crtc_use_h264=3Dtrue=E2= =80=9D. > --- Pushed a while ago, forgot to mark as done. From unknown Sun Jun 22 17:12:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Oct 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator