From unknown Mon Jun 23 18:32:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 27 Jun 2023 14:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 64317 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 64317@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16878749744788 (code B ref -1); Tue, 27 Jun 2023 14:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2023 14:09:34 +0000 Received: from localhost ([127.0.0.1]:49330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE9Nt-0001F9-QP for submit@debbugs.gnu.org; Tue, 27 Jun 2023 10:09:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE9Nm-0001Ei-MK for submit@debbugs.gnu.org; Tue, 27 Jun 2023 10:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE9Nj-0005t8-Pq for bug-guix@gnu.org; Tue, 27 Jun 2023 10:09:24 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE9Ng-0006Pp-Lo for bug-guix@gnu.org; Tue, 27 Jun 2023 10:09:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=0Jn97HEX0XF9NjxOEC0eMiwdSSDjcJlume+0DQDZYsk=; b=hMCtG8krEhnVL96In23h7HMzQHueeU6RlcVM6SF19FwYpOMK8Dc2wp5L eDkxd4evj1JbIsogVv6Ui3/VhMOMYrHqGasM+xt8KULupqOcMQUGaJI3i wUERdO1SDu/0ofdmBlLc3+iZrXOgqqgG4xqUQon2o7E1B6y+w8F5t7nAc E=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.01,162,1684792800"; d="scan'208";a="114927147" Received: from unknown (HELO ribbon) ([193.50.110.213]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 16:09:15 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 Messidor an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour de l'Absinthe X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Jun 2023 16:09:16 +0200 Message-ID: <87bkh1uhdf.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.83; envelope-from=ludovic.courtes@inria.fr; helo=mail2-relais-roc.national.inria.fr X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The /download endpoint refers directly to store items. However, they can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails gracelessly (HTTP 500 or so) as shown here: --8<---------------cut here---------------start------------->8--- 2023-06-27 16:02:24 GET /download/718 2023-06-27 16:02:24 Uncaught exception in task: 2023-06-27 16:02:24 In fibers.scm: 2023-06-27 16:02:24 172:8 1 (_) 2023-06-27 16:02:24 In ice-9/boot-9.scm: 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception: 2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/gn= u/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" --8<---------------cut here---------------end--------------->8--- The solution IMO is to (1) register GC roots for these, (2) periodically remove old GC roots, and (3) return 404 when the file has vanished. Ludo=E2=80=99. From unknown Mon Jun 23 18:32:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#64317: closed (Re: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500) Message-ID: References: <875y54xy6t.fsf@gnu.org> <87bkh1uhdf.fsf@inria.fr> X-Gnu-PR-Message: they-closed 64317 X-Gnu-PR-Package: guix Reply-To: 64317@debbugs.gnu.org Date: Thu, 24 Aug 2023 15:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1692890582-3518-1" This is a multi-part message in MIME format... ------------=_1692890582-3518-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #64317: [Cuirass] Download products can disappear, leading to HTTP 500 which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 64317@debbugs.gnu.org. --=20 64317: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D64317 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1692890582-3518-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 64317-done) by debbugs.gnu.org; 24 Aug 2023 15:22:35 +0000 Received: from localhost ([127.0.0.1]:38421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZCAM-0000u5-O4 for submit@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZCAK-0000tt-Sn for 64317-done@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZCAB-0001sD-BS for 64317-done@debbugs.gnu.org; Thu, 24 Aug 2023 11:22:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=v4jvtVkwshoteARlEeJneqoBE0ha7+eigyM9eksu63A=; b=pii6j+XqSYbaRJVC+IuP ChnKtEl1uaVm9E5J343QW97PO9102MM0QaZy6r1l8P6W2nYKXTiWS66ZZRYSrX7hsP+qFN9Lh9wZh c0R4+jwh9l3QyQZrAKCtgdwG7yDxZiQiHTQ0EI/64IyBwrP/xqv8gg/GyNtk2ujK/Z/qkNB18E6hF 8Vtzm8EDA/WXsU49j2MimhA36+F/QMLed4jIRDQUNtSbUHsdLMLAaVdyXKedPtgK1v5/lvC/2eUa9 E4hgEwQYSW7bkVefhPAAkQESbex4BzZZ2wQfAktvC6SsizyyLqh0XYnvo+xraWy2bHi9HmYYOc0Yq J8QCGjH2j8KQWg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 64317-done@debbugs.gnu.org Subject: Re: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 References: <87bkh1uhdf.fsf@inria.fr> Date: Thu, 24 Aug 2023 17:22:18 +0200 In-Reply-To: <87bkh1uhdf.fsf@inria.fr> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?= =?utf-8?Q?'s?= message of "Tue, 27 Jun 2023 16:09:16 +0200") Message-ID: <875y54xy6t.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 64317-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > The /download endpoint refers directly to store items. However, they > can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails > gracelessly (HTTP 500 or so) as shown here: > > 2023-06-27 16:02:24 GET /download/718 > 2023-06-27 16:02:24 Uncaught exception in task: > 2023-06-27 16:02:24 In fibers.scm: > 2023-06-27 16:02:24 172:8 1 (_) > 2023-06-27 16:02:24 In ice-9/boot-9.scm: > 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) > 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exceptio= n: > 2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/= gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" > > The solution IMO is to (1) register GC roots for these, (2) periodically > remove old GC roots, and (3) return 404 when the file has vanished. Fixed with these Cuirass commits: 9e897d8 'create-build-outputs' registers a GC root on build products. 103a6ec http: Gracefully handle missing files in "/download". 5e3e49c http: "/download" returns 404 rather than 500 for "not found". Ludo=E2=80=99. ------------=_1692890582-3518-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jun 2023 14:09:34 +0000 Received: from localhost ([127.0.0.1]:49330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE9Nt-0001F9-QP for submit@debbugs.gnu.org; Tue, 27 Jun 2023 10:09:34 -0400 Received: from lists.gnu.org ([209.51.188.17]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE9Nm-0001Ei-MK for submit@debbugs.gnu.org; Tue, 27 Jun 2023 10:09:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE9Nj-0005t8-Pq for bug-guix@gnu.org; Tue, 27 Jun 2023 10:09:24 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE9Ng-0006Pp-Lo for bug-guix@gnu.org; Tue, 27 Jun 2023 10:09:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=0Jn97HEX0XF9NjxOEC0eMiwdSSDjcJlume+0DQDZYsk=; b=hMCtG8krEhnVL96In23h7HMzQHueeU6RlcVM6SF19FwYpOMK8Dc2wp5L eDkxd4evj1JbIsogVv6Ui3/VhMOMYrHqGasM+xt8KULupqOcMQUGaJI3i wUERdO1SDu/0ofdmBlLc3+iZrXOgqqgG4xqUQon2o7E1B6y+w8F5t7nAc E=; Authentication-Results: mail2-relais-roc.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="6.01,162,1684792800"; d="scan'208";a="114927147" Received: from unknown (HELO ribbon) ([193.50.110.213]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2023 16:09:15 +0200 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: [Cuirass] Download products can disappear, leading to HTTP 500 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Nonidi 9 Messidor an 231 de la =?utf-8?Q?R=C3=A9volu?= =?utf-8?Q?tion=2C?= jour de l'Absinthe X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 27 Jun 2023 16:09:16 +0200 Message-ID: <87bkh1uhdf.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.83; envelope-from=ludovic.courtes@inria.fr; helo=mail2-relais-roc.national.inria.fr X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The /download endpoint refers directly to store items. However, they can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails gracelessly (HTTP 500 or so) as shown here: --8<---------------cut here---------------start------------->8--- 2023-06-27 16:02:24 GET /download/718 2023-06-27 16:02:24 Uncaught exception in task: 2023-06-27 16:02:24 In fibers.scm: 2023-06-27 16:02:24 172:8 1 (_) 2023-06-27 16:02:24 In ice-9/boot-9.scm: 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception: 2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/gn= u/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" --8<---------------cut here---------------end--------------->8--- The solution IMO is to (1) register GC roots for these, (2) periodically remove old GC roots, and (3) return 404 when the file has vanished. Ludo=E2=80=99. ------------=_1692890582-3518-1-- From unknown Mon Jun 23 18:32:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 26 Aug 2023 20:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64317 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 64317-done@debbugs.gnu.org Cc: ludo@gnu.org, ludovic.courtes@inria.fr Received: via spool by 64317-done@debbugs.gnu.org id=D64317.16930809624949 (code D ref 64317); Sat, 26 Aug 2023 20:17:02 +0000 Received: (at 64317-done) by debbugs.gnu.org; 26 Aug 2023 20:16:02 +0000 Received: from localhost ([127.0.0.1]:43498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZzhR-0001He-Hx for submit@debbugs.gnu.org; Sat, 26 Aug 2023 16:16:01 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:49403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZzhO-0001HN-BC for 64317-done@debbugs.gnu.org; Sat, 26 Aug 2023 16:16:00 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-412137ae07aso8026511cf.2 for <64317-done@debbugs.gnu.org>; Sat, 26 Aug 2023 13:15:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693080947; x=1693685747; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=DMsa9oPWJ9tdmz1lysNmJsOD+CI7GdQN+lz/LIKZSZw=; b=i4FfPu9qM7pn2o6pNBF2PjI13JqfDdmoZOSTIm5+eXbGNcv8hBDJLEAZi1zs49JsmJ iF+Da4NOWWe4czODqL7W/KJ0AWwb08G/EiQc5uaOt/mbUXER5hSO6q5OGbmFcGWWyC1k gMGUndkCQdHPcYunQbFe7sA1of3X3JC7IMV5vtkiT80+lREQuLhe1npx9XH79rH5mgZn QeacxljTiSZ+r42Nn1fSumOp73viF868YJ/b5L7Bdoffsur9g+w60ZiXxxlq1K5d/vUb 1LqyE3X+3kmHttAGwYgXZgXrg7fkx74/rV5a1VsnDNCoDSL84ABbdbti1YXM/+cRV95z uiIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693080947; x=1693685747; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=DMsa9oPWJ9tdmz1lysNmJsOD+CI7GdQN+lz/LIKZSZw=; b=IaSAlvUKtRFyF7QL2mN5WRp5UZsj6+dIlVtAGzhx2OMGEYSjJrFw08AZQAt9b/pVsk NNW5DjP8t7xUpKEbPSE7rfHpcT+vyTxagdLRgMiBAwA+mN5/4FpQOpVaUfmxt0e4WVhx hvKYUA/tLV6pynGsvLa2+h0WPMUNmFyxvge9OgjWvIpIL/XtTg0vsR8peGpFpcUz5T5b /unfOmPwJ/lPwx6Swe0DWmgy+4Lovfo7PBO1Mt16KNAmQzzYI8rH1iAsCZ44jtk/VtQ/ SNIlXDx5xaBoK0krnhSkbsnLafsENeFUQugcDA5umczM3+cT/89aiBt6vE89cBmGS1Mo nfHQ== X-Gm-Message-State: AOJu0Yzb0IbP1GeecED74npXgvwganHDIjPcom0QkJYbbW890I1x0H8w PLJ/B8yxNWPQooMsWKfDGg4mDU03n7Y= X-Google-Smtp-Source: AGHT+IHlwmoRV01kT9FAjjlvh1EOo8ZSH9JCtXx0Pq1DOwXLZ17gHyvacEdV+TWz9XSyDooYGht27Q== X-Received: by 2002:ac8:5fc2:0:b0:410:90c7:518d with SMTP id k2-20020ac85fc2000000b0041090c7518dmr22881057qta.11.1693080947176; Sat, 26 Aug 2023 13:15:47 -0700 (PDT) Received: from hurd (dsl-155-106.b2b2c.ca. [66.158.155.106]) by smtp.gmail.com with ESMTPSA id ic7-20020a05622a68c700b00401f7f23ab6sm1291321qtb.85.2023.08.26.13.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Aug 2023 13:15:46 -0700 (PDT) From: Maxim Cournoyer References: <87bkh1uhdf.fsf@inria.fr> <875y54xy6t.fsf@gnu.org> Date: Sat, 26 Aug 2023 16:15:45 -0400 In-Reply-To: <875y54xy6t.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Thu, 24 Aug 2023 17:22:18 +0200") Message-ID: <87v8d1mufi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> The /download endpoint refers directly to store items. However, they >> can be GC=E2=80=99d in the meantime, in which case the HTTP handler fails >> gracelessly (HTTP 500 or so) as shown here: >> >> 2023-06-27 16:02:24 GET /download/718 >> 2023-06-27 16:02:24 Uncaught exception in task: >> 2023-06-27 16:02:24 In fibers.scm: >> 2023-06-27 16:02:24 172:8 1 (_) >> 2023-06-27 16:02:24 In ice-9/boot-9.scm: >> 2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _) >> 2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-excepti= on: >> 2023-06-27 16:02:24 In procedure open-file: No such file or >> directory: >> "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz" >> >> The solution IMO is to (1) register GC roots for these, (2) periodically >> remove old GC roots, and (3) return 404 when the file has vanished. > > Fixed with these Cuirass commits: > > 9e897d8 'create-build-outputs' registers a GC root on build products. > 103a6ec http: Gracefully handle missing files in "/download". > 5e3e49c http: "/download" returns 404 rather than 500 for "not found". Yay! Thanks for fixing this long standing issue! --=20 Thanks, Maxim