From unknown Mon Jun 23 13:12:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#64316 <64316@debbugs.gnu.org> To: bug#64316 <64316@debbugs.gnu.org> Subject: Status: ASAN failures in dir.c Reply-To: bug#64316 <64316@debbugs.gnu.org> Date: Mon, 23 Jun 2025 20:12:05 +0000 retitle 64316 ASAN failures in dir.c reassign 64316 diffutils submitter 64316 Gisle Vanem severity 64316 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 09:05:07 2023 Received: (at submit) by debbugs.gnu.org; 27 Jun 2023 13:05:07 +0000 Received: from localhost ([127.0.0.1]:47885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE8NW-00058t-Jm for submit@debbugs.gnu.org; Tue, 27 Jun 2023 09:05:06 -0400 Received: from lists.gnu.org ([209.51.188.17]:53544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qE8NT-00058i-0x for submit@debbugs.gnu.org; Tue, 27 Jun 2023 09:05:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qE8NS-00045X-41 for bug-diffutils@gnu.org; Tue, 27 Jun 2023 09:05:02 -0400 Received: from sonic305-20.consmr.mail.ir2.yahoo.com ([77.238.177.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qE8NN-0007Uv-IZ for bug-diffutils@gnu.org; Tue, 27 Jun 2023 09:05:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.no; s=s2048; t=1687871091; bh=hwDGzA4F253uGPZQL+fOiJLiGIhVGz+LFP2CbKlnH+Y=; h=From:Subject:To:Date:References:From:Subject:Reply-To; b=ZrR0Cw5KMGJoCeEGK+OrhmnulvNoMmmg1gtXIRItJZA0Q5bIovT3Yjf3rOs2qD6e76z0eD/Tohhf0uanpxvfsvdqmwlSA9aqiMVNyGjqBdAMw7nqYpT1w+sEWHvijjBd1qJ8RdkoH10U/U8rTGguyhvwkzEulJRuF4XV8Jvxa5I0wgLGRwJBQe255DOOcJ9kpFhp1SNXwi1khU0klHASMqZeAApGI+OLGzgHUt8nz6yqEiY6VDqGNZXWQ5r+fOI6MN/NdSWr+Fr1rmGJUc4yzyclKM8F3WfqLnQPcCMRoUg3J+hT2OHO52DGbENoHGWPUHCHpFHeRaJBgfHCpCv/pA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1687871091; bh=ReOck0Ab2b8D5/lFPP6Gb7cW/T0/9uXetPg4Njxt2tD=; h=X-Sonic-MF:From:Subject:To:Date:From:Subject; b=Q8ljMnOkhHtKMU0QK39EGazpgIjCOTSmva+HCn38HR5cvKuxEUSXVioSX+X5M8rFzRVTPYJ948/8t4epbMbW98h2VO38sgNpLOazPCCQ7O3EeMWvliaVjDmysQ3lznsAPOKvqQxz2lr0RpI2zcDJ991ik+syUFGi8sD7U6/cvI6eCEajX1E4XcGzRAgaRw9BkLGl0YYnne/AOJaisem7iBH7gQ2D5tUvUI7z83wSdPRdGMGE1gA0RENRd4aNRLk1maDBdu9LjokhKTZYWR1C/il399Lsp8IQhBkuU9V57oZlMDg1nd8Rfuu6g4tygpIrOVZL5SxRKB8T7TK7rTYTeQ== X-YMail-OSG: plufS08VM1m2rOv2rnozQHScwmN8RftdrZpTxhDm4oK4Ws4cPAEL3EEbh1uHTB_ IUynR7oZYbQc8Uhwwj89ui0C6peFtFEczZtiLosC7FOJN30.aMeNsN4gCvqP0yXX0zH_nlSDfBeT lwP.pO3HeGdEDKTCKPS15Z_itkXiUcoNaC5IQyDjo63pnnfzIcJyQSlhklNJg7txme8QebsjYk2D 0e0ZwOE1yttPMPs67CHvTd7lwvSWHK0MRPTXaojSUQlIR_TQKd8c0uGJyPBI5O8lZNaXqFGw8kDa e86WCGeAs3.P.WQRHtotf4V6aC.Rq5zaUdu3y2T7edGrk0pWcn1WdRjVvWlZa8mmyvZio_o.r4qA buBqxYtSJpnwFNDcLQHNmACv3vaGv4OVFwOvKGIYXKTt8kat6bXh3PifrCw3A_MAMq7cUA.FDeut xpreaaLfUFnhlaDzgTZdikjM413b7gQzx5iNtPrs7SXd25R6aEIgPBCCGZ0rUg07n4gq3adIDewV LimOh8j1XPdmX2H4S3agdI1xZtLusEbdr3TLZHmyM5fee9cdciLoRfGfiGZ2bHW0vcRwc0WR2O1J xXD990HaSpfqy5kKUnG0mhVerhzfBp46TQy3A18SvMXoMqj2TFm.0yCRIPKShUqo_0q1hbtZCWt8 3iqzgNA8UjkjXLCW3taBCSTNmADT0qeevdCg4IJ6lamLaE1fPDzIlffL.neoUTxmgVNB1pnRQW.R 93ka1b04XVmahhOOrSBjvUQTYyLDoW.d1SV3jnJ43mbvvaTMkokHymXN6Lza6C7ykRnN5MsWmRL1 aEPmkTjMAY182cYdG0he1bsev09RMIqyYFrWt8uhtxzCXvZU_Sk6pBQTtSv70ezGv5muKqpVhu_3 lllq.UsxVELdDNfBv0W.Urd7FkTQV2DAd6S3LJJDFnNH7MN3bip60TyHQVkL9KMLo3RjD85sYGe6 RPdwQYc8Za0fPuwhaCfXYwXFXTrXQD5T4xZg.fKU6xo07kbbEUi58Ah_DH40Oc_Yg4RAHM2aQp0B fc20BQvY5isO0gF5jyK.hXCA_qBJTr1h3hGbWenCkRJagPVsiz3RfnwHAdOfMTk05jP8B2IT2ZDm 6StEh7bfrlxVEpnrQB9cMylk5LpbT4PrPmUuNK7w6NOWkVgoESHZp_hS9a4MYRXEixqkPLO2n_8R YJGaUfxZVEMCUVt0lyP7TlmEEhGlMBAufKvq3ivIxgiCh6EEClksQmNvTo.dFzxWSzdORiUtaYNl ckjGaCJwclVZNpSAMQXJpAEGbf7aRirfCgAWezn3x4V9X31U6FQKnaKXBev2FoIskJdw2tWMnK7i y3jrKk0vvfwbTf58oZbxUmJbgw_UZZPQRgLp.JMpyhIs6JIPvhA43ZGUdwaN7t3vVLval5s7nuLw yEGAl9UUz9n04VKGUObDvPS6KHldD4zgu6ETlU.OqKxtXAKo_MBJBxRXFW3zhTHxeXjgcMLE2Yz0 Rrx3nOf1ekYAf6N98PwnRFxtEua6Yxh4JRhsZoX6WzBb3ANfowBM6C4jfj6m1cgpzowqSP6bO2rc Y1QTdOCuI7HXOSp.3_jB3kOuFvx7MJAHJ0gwlMNHIn6QpBWMgA3wWu6Z.HEqiNKmIX1IG0RzIM4n c5z3ypAEKrlvz4RVqW6Lxv2KMQBdM_H.YMx4OYuENzQBMh8iukogBWnypGgg2W86cWfWEGXYsaMb tJrz3eORlY.EH0xrz3KwxHNLIT0XeL0FiwI_j10RSTWuwzxM.SQNFBQGetgmeIOjLYuG.4g7Q3Ma naVwJSWzxJC.AUTd5SEA04HhPKO6Mf.1SqEFGP.IL6QyVHq3WlniHFrAVFsgjr3hJQeggLxvcums 1I3Fgysj2C.D9ovm.w9W2ENnEEk2MNv5A05UeEvgnGYURZsbc.3X2Z9cPTBVrk6NwWMTSJ91uqkK HohCW11rzwBhl.ww_RDZp7N15Kl82hJ19b7lWqe1ViC5JLnzejGsCTz5mxiI7VAwA8KlKjOvTrZw vjLAHMr0GmNqwaORNSRxJKg2yfjeX1yJTl2FA223sBd_Ty4ZlOVnm675dFFncGwwQ9CWNwQYraH4 TU0KfU.0iNDkOolyOdl39T5w20ChuEnlyA7YGNP842JcC7.iUjlpJ0eQ3nGYvSj0HXuXuLZvsNNK qpnO6bLk7PvmBzP2CadRikgRWLLBLsa60H4_BSNEJNO2V03WGNEkkAC1HlPDkh.LIC1SGYKcQXtO 52knS_OU- X-Sonic-MF: X-Sonic-ID: 5b59de04-cce0-46f7-b464-5a0716ebe1ec Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.ir2.yahoo.com with HTTP; Tue, 27 Jun 2023 13:04:51 +0000 Received: by hermes--production-ir2-7867f454fc-dskkf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 824088317abe3df421d378b24664be24; Tue, 27 Jun 2023 13:04:49 +0000 (UTC) From: Gisle Vanem Subject: ASAN failures in dir.c To: bug-diffutils@gnu.org Message-ID: <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> Date: Tue, 27 Jun 2023 15:04:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> X-Mailer: WebService/1.1.21557 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1929 Received-SPF: pass client-ip=77.238.177.82; envelope-from=gvanem@yahoo.no; helo=sonic305-20.consmr.mail.ir2.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello list. Since some time ago, building diff.exe with ASAN (on Windows-10), causes it to trigger on illegal use of memcpy(). For example: ==3752==ERROR: AddressSanitizer: heap-use-after-free on address 0x121647e20772 at pc 0x7ffc6e93727e bp 0x00d589efdba0 sp 0x00d589efd330 WRITE of size 17 at 0x121647e20772 thread T0 #0 0x7ffc6e93727d in __asan_memcpy D:\a\_work\1\s\src\vctools\asan\llvm\compiler-rt\li\asan\asan_interceptors_memintrinsics.cpp:22 #1 0x7ff604834af1 in dir_read F:\MinGW32\src\gnu\GNU-diff\src\dir.c:101 #2 0x7ff604832ec7 in diff_dirs F:\MinGW32\src\gnu\GNU-diff\src\dir.c:214 #3 0x7ff60482dc37 in compare_files F:\MinGW32\src\gnu\GNU-diff\src\diff.c:1369 #4 0x7ff604833b1b in diff_dirs F:\MinGW32\src\gnu\GNU-diff\src\dir.c:289 #5 0x7ff60482dc37 in compare_files F:\MinGW32\src\gnu\GNU-diff\src\diff.c:1369 #6 0x7ff60483270e in main F:\MinGW32\src\gnu\GNU-diff\src\diff.c:862 ... ----------------------- This causes Heap Corruption all over the place. I'm not sure this is an issue with Gnulib or diff. But reverting this patch: diff --git a/src/dir.c b/src/dir.c index ba9403b..773afeb 100644 --- a/src/dir.c +++ b/src/dir.c @@ -95,13 +95,9 @@ dir_read (struct file_data const *dir, struct dirdata *dirdata) if (excluded_file_name (excluded, d_name)) continue; - while (data_alloc - data_used < d_size) - { - if (IDX_MAX / 2 <= data_alloc) - xalloc_die (); - dirdata->data = data = xirealloc (data, data_alloc *= 2); - } - + if (data_alloc - data_used < d_size) + dirdata->data = xpalloc (dirdata->data, &data_alloc, + d_size - (data_alloc - data_used), -1, 1); memcpy (data + data_used, d_name, d_size); data_used += d_size; nnames++; -------- it work with ASAN too (although much slower). -- --gv From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 12:40:21 2023 Received: (at 64316-done) by debbugs.gnu.org; 27 Jun 2023 16:40:21 +0000 Received: from localhost ([127.0.0.1]:49434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEBjo-0005LF-0c for submit@debbugs.gnu.org; Tue, 27 Jun 2023 12:40:21 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:35938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEBjh-0005Kx-Nl for 64316-done@debbugs.gnu.org; Tue, 27 Jun 2023 12:40:18 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 434093C09FA06; Tue, 27 Jun 2023 09:40:07 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id SeOobcaFM3x6; Tue, 27 Jun 2023 09:40:07 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id E9EC43C09FB43; Tue, 27 Jun 2023 09:40:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu E9EC43C09FB43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1687884007; bh=SkML1kZf+N6Af0ieZR7+61EA7nDBrSSbDQ4ypAfB9hk=; h=Message-ID:Date:MIME-Version:To:From; b=Q1RLtA0b20CFzejO8VGirD05ZDvDZWZz8NR0zswAQLuOvGzcMcA5hNpqGPeSwnCyZ vM1WM8vPvwmabzNSEiwUA3AMckrNradAcvo2aXVL5kHuQAYkgxxhTSWguS4+xROErp O9se2495bBEQNhGIjWGd4YH587wC54mibKGZg9lbTDQ0wl2lKasEllcnmcAfsKh0cN Kq1s7AiVQRIyWx8qHiwaGUS4g24eraXH5Upmxd6bRKYr+lR0hVCGIfi9mjzUFiTc83 UxU+8957LKcXC8IM3QUewHNG6SoOYZU5kKDBVs7OphUM4icX5CqofgneRhh2uzcId+ XkqUNErJqfLlg== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id SeArjGGJ0BRW; Tue, 27 Jun 2023 09:40:06 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id C28B23C09FA06; Tue, 27 Jun 2023 09:40:06 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------eLmuLdst2ekSgXsge3QA1SMs" Message-ID: Date: Tue, 27 Jun 2023 09:40:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [bug-diffutils] bug#64316: ASAN failures in dir.c To: Gisle Vanem References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64316-done Cc: 64316-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------eLmuLdst2ekSgXsge3QA1SMs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that bug, which I recently introduced. I installed the attached to fix it. --------------eLmuLdst2ekSgXsge3QA1SMs Content-Type: text/x-patch; charset=UTF-8; name="0001-diff-fix-xpalloc-typo.patch" Content-Disposition: attachment; filename="0001-diff-fix-xpalloc-typo.patch" Content-Transfer-Encoding: base64 RnJvbSBkNGE2M2IxMWZjNmI2MmY1MzhkYWNmZDdkYjQ3MjcwZGM1NzdhYzgxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBUdWUsIDI3IEp1biAyMDIzIDA5OjM2OjI3IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZGlmZjogZml4IHhwYWxsb2MgdHlwbwoKUHJvYmxlbSByZXBvcnRlZCBieSBHaXNsZSBW YW5lbSAoQnVnIzY0MzE2KS4KKiBzcmMvZGlyLmMgKGRpcl9yZWFkKTogQWxzbyBzZXQgbG9j YWwgdmFyIGNhY2hlLgotLS0KIHNyYy9kaXIuYyB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2Vk LCAzIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2Rp ci5jIGIvc3JjL2Rpci5jCmluZGV4IDY5MzA2MjYuLjRiY2ZjZWIgMTAwNjQ0Ci0tLSBhL3Ny Yy9kaXIuYworKysgYi9zcmMvZGlyLmMKQEAgLTk2LDggKzk2LDkgQEAgZGlyX3JlYWQgKHN0 cnVjdCBmaWxlX2RhdGEgY29uc3QgKmRpciwgc3RydWN0IGRpcmRhdGEgKmRpcmRhdGEpCiAg ICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgIGlmIChkYXRhX2FsbG9jIC0gZGF0 YV91c2VkIDwgZF9zaXplKQotCSAgICBkaXJkYXRhLT5kYXRhID0geHBhbGxvYyAoZGlyZGF0 YS0+ZGF0YSwgJmRhdGFfYWxsb2MsCi0JCQkJICAgICBkX3NpemUgLSAoZGF0YV9hbGxvYyAt IGRhdGFfdXNlZCksIC0xLCAxKTsKKwkgICAgZGlyZGF0YS0+ZGF0YSA9IGRhdGEKKwkgICAg ICA9IHhwYWxsb2MgKGRhdGEsICZkYXRhX2FsbG9jLAorCQkJIGRfc2l6ZSAtIChkYXRhX2Fs bG9jIC0gZGF0YV91c2VkKSwgLTEsIDEpOwogICAgICAgICAgIG1lbWNweSAoZGF0YSArIGRh dGFfdXNlZCwgZF9uYW1lLCBkX3NpemUpOwogICAgICAgICAgIGRhdGFfdXNlZCArPSBkX3Np emU7CiAgICAgICAgICAgbm5hbWVzKys7Ci0tIAoyLjM5LjIKCg== --------------eLmuLdst2ekSgXsge3QA1SMs-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 15:53:15 2023 Received: (at 64316-done) by debbugs.gnu.org; 27 Jun 2023 19:53:15 +0000 Received: from localhost ([127.0.0.1]:49574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEEkU-0001sB-Oo for submit@debbugs.gnu.org; Tue, 27 Jun 2023 15:53:14 -0400 Received: from sonic309-25.consmr.mail.ir2.yahoo.com ([77.238.179.83]:35706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEEkQ-0001rs-Gt for 64316-done@debbugs.gnu.org; Tue, 27 Jun 2023 15:53:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.no; s=s2048; t=1687895583; bh=S7fkj/RQwWP+MJXQYfh/AhfwWzGDt3Dhlp4ZUgvPzJg=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From:Subject:Reply-To; b=Xp1fzgeWLSaNdRObBO5/5hTUt7nI7PEis7+Hlk1n0/vChjlpP/AxqcHK50aAlZpxTZZ63jeZ0IYixBg7ZZQnuBsC5XyHKqPNsqI8mVfo0I1pghgjgtFhVjLeqdcseOxqJMwQwAmkBZt9SisxsehJfcED5JfOZnnQE1UVejb8l1qwSFOIfYuQ8NLUU9iqb1XS3JEiCO22cxSmPdd+poZJ0B54EnuDImKf0KgA4O2GhtnZXuUEMYtPzfGG0qtef3GRh0fiNp7w/zxzY0MNIsIgW6oBWVq7kN7jlS/lyM8+MBB9SRT4L8t3ZLUlLGl4GZmusqybLe01o1PoR2exsdjijA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1687895583; bh=8EbyKj7fRPqAJy31Vo+OJpT1GFXEkEuyAwOZwnpcXz4=; h=X-Sonic-MF:From:Subject:To:Date:From:Subject; b=f2Vil2QXR2Y7XicW1ERVFyFVfacNKqy1Cuf55GsuqZXSj+7UhENRQVDQtyvJwmI25dh5/9hGX+u80CWOt6hen15gcoL4a8uqhnM2rya0cwjYbK5t1vdU0KchXvVPHv2NZrr43dAuVk4bMl6e7tm5sjhsg2bVMw1yGE8zeUjOYdo7e8+/aJ6ZIJqO94AWhyXUJMYAzEhAgupqpybpluY76AZHDxOcQE+DDi1r5yrgiqROQF2wSpZbK66yvBwuh44vu1TnWOXatyoqiCPsdLdBEsaqbefIsuI83YxtU4EeH/ONydMMUFnUKSpIYB/81ooRExVGZ5u05jNht8QtxS3pTw== X-YMail-OSG: bq6jIz4VM1lI7e1xGqkXN3Xa1LGKXS1K1CuqV8cWcLbfVtD5ZlQ6Jo8rcZd_SW7 K4HZPOKR8kV8LEiqQ24HdwQQcGF4thu70QOZ_3Sxa9M_SCrgvk_Bs69olMjOYoXpOjHc28qmhmZ3 d4uKq0RiMpDpqaNi1S8b6X92PhZ0M.4T8F2OftN7W2cR_OARHULbxyvx5.LivbPRS08cDdnLfwcw KtWNI40wyhecBqSabXYmD3FBS2wrYCVC9HPXU1PDx2tIZQ1V49C1TzZvL_sRwekCuKpaxxU_YalY OsjlJfVrscER5V8NnVuuKvOQ6iNHY9xU.wXeZWBpZ0XQtiyudhAoGjLL6zFEQSYo6rsfTS4FHVpO FbLL62HRTiUrMmNm_EbqiUzwiL4e.KuIbvd71PVvnpnwQR0rpAJ6I1Zqk78JgHNm3er4Q.W38dzQ BGWjjwS3ddcUxvxBEdi7TAHDavoLz1ucN.YBO_d8CQ1s852xopWEkNrhdz_0SA8mphDL4tMRLtqt j2miKRU91x4A2Px8JS.IJUtMOFf5HQQhOCpPIKTiCQE4fkXSlbU9pUipEPRjB8MekSMMk19ZW8qO eh0hfFcMU7YshUpddN2A4janmUq35kUfz96ZFLKDmtS9um_4o6kIYqubua8am8mV0O_q.RYDejit yGVvC4y3UOKfJGSQhzajJwQcQ1NEkLeejBzgBfkeN4foWGIxNcVl.bYOUwml5CD42b663.rvrNoa 8YZqgR46iDL9onTDtczSglmIioQpwP9Kx6UAhP7O1TpV8JePx5HL56cB5_TTyV_cgTF5_zG_PPOw EG7N7DQSQwJwSPDp_Wd04h7PK8vMM5EI..MqGldlieMPR1_aTeMPm7tHcmthygk62EDTZ6R8TDAP AL78eg7QG8jMRYUoUbX4kfzUYZmCYrnCxe8M7uHSUwaBr8uoylwT.Rpqg8g6ORXOyrZLvsmm8lUw hVO6wrYOPknjE0TIGfj.DKkGzCUZdGcTZtnjsToDsVQqYuW8IOneu0TUIKj8n2eOIWJ6ib9HBXBQ a9votsGwYFfM8cChrnnB9n6IdAcdF7bTkjH6f0QWS6zzlNq2UFw93BdIiAADk_GN3HbNIql7wb_l 4GeHQsKxCJMHnE.hijBUps4W7N8Fo05b6dYg_NW1RFcux0JEdQzaF7IXIGlY.8YsDhwYiFAytg5U hSukC6YLLEHCtaLriTGO8RH45jRZZH7gNzYvONdtFPb7LGJODUvLKW9.PfuuBZAGVpEaGY7BLiJY vV9St3PRVbQhE0nTBBcHwn_WIyFK46mGbpfTXbYTAtaJDfRRW0qduuq3uhUiHZGfddQ48_HeDIVT jILXrg85yn0A9FVqtny1QyJO5W6nR8Gg_dA62cDHSAh3A_Z5dtEXuyNLgjYoh0lgt9VPMaf.fnLA WMim7U03AxaqPlXJFvSB1LPjrwww.NK77gyrzfieTyCoElQOzEZepYeYgWcRaWynHFkZ2E1MfRvJ pmIHB.Ks5BsduRUkgmqHAt0yL_CUUCDszgb_dZ6rmMCUf0Fwb.YNcTb4UmjGhm4eBpGWsuVAYzSs oVnkwNlJFR6.54BqPEGxdtOOQw9FflYhxQiI78BLFWoHPx6bxucBU70_yVkQwqWRqvC87X9zQLRY X47NDV7iyLphjXtnyFzpfjlN9Qt8L5ynweGmXPV18ELr3DJ7_qT8V5nJ0hXsnC3zGxg1wmqrmS7v RtipKv95HVvxbzbQ0ejedioL3H52eVDTVoEvva.RD8lJnfO3k7ivUvt7JkccRixuOdZxtEiFNHuP IEWG3AzBEL9.PFw.ad9LUCm8b.PxDbYHdW1ryoLnrVb_poaTIaQuiMXFZMcEatkmY5nlK_c1t7.r 1peVQOUxvINcL.KKcykLDmRsn0AAsWnl6YB7xLuK2.tuvZySK.7QS496VYELaTZ2oeUp.ga9mu6Y kR_JmI8Q3qsMhmM6T2tXiiLsLO2grQRbO724peCU8ITX_878Av1Vmd68Npe9MvdW0d6Lj4KZS88h Z7UnYnheJUa8Gmq3SPT8FEJKA4OnG7K3KbVWWPP4uvCK5d26qV_AdEGrkg5ibNabRe5wfkfgJOO6 WIu3GYvGe7tGJPYiTGMuecFJXSJF_CGBdqA354iwcatCJp36Ot3QtSOANZVAw4Tq8DmLvi6vKOGP BznUQmUTveS9_.EOTK61_TJKJKM7T5tL1UsCmJhQAWSHUBcFFkF.tMffvpvCkisRicV2D6KniYf_ kFP1VsUB3M3oSlzxO1jOK4A2OELmkW.8- X-Sonic-MF: X-Sonic-ID: f0ec392b-fb81-448e-a1e8-aed35e7c717d Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ir2.yahoo.com with HTTP; Tue, 27 Jun 2023 19:53:03 +0000 Received: by hermes--production-ir2-7fdc5d6df5-cn8gk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d267db51c1bdc11d65566d77e8b242fc; Tue, 27 Jun 2023 19:52:59 +0000 (UTC) From: Gisle Vanem Subject: Re: [bug-diffutils] bug#64316: ASAN failures in dir.c To: Paul Eggert References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> Message-ID: Date: Tue, 27 Jun 2023 21:52:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.21557 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 507 X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64316-done Cc: 64316-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) > Thanks for reporting that bug, which I recently introduced. I installed the attached to fix it. Applied it, ran the new version. Works fine (I think) when compiling using 'clang-cl.exe', But with MSVC's 'cl.exe', I often get: diff.exe: memory exhausted (on directory branches with approx. > 7000 files) From where the allocation fails, I've no idea since Gnulib is so unfriendly telling where this occurs. Is there really no xmalloc_die() with some more useful messages than this? Yikes! -- --gv From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 27 21:04:41 2023 Received: (at 64316) by debbugs.gnu.org; 28 Jun 2023 01:04:41 +0000 Received: from localhost ([127.0.0.1]:49733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEJbs-0001PE-I7 for submit@debbugs.gnu.org; Tue, 27 Jun 2023 21:04:41 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:33286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEJbo-0001Oy-J1 for 64316@debbugs.gnu.org; Tue, 27 Jun 2023 21:04:39 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 403D73C020F7C; Tue, 27 Jun 2023 18:04:30 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id T7QV_Cg-6Phr; Tue, 27 Jun 2023 18:04:30 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id EB3F73C21FA45; Tue, 27 Jun 2023 18:04:29 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu EB3F73C21FA45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1687914270; bh=TwKJ/rvEO7UObtxd8rFvpzLkPD+eRlvaIKHK4WIex+M=; h=Message-ID:Date:MIME-Version:To:From; b=Yd0K+mvhj4y0mdgzx7YfyZu43783+FO+noo01FAYyLo8EoUdLbiusORwyLWIVCvaA rd4SIPbkMdW7ZWqD7I+rUk+DZquZZhfOUuo3zCtssHaN0DNXAddAOBq0mabracIw8M V1Dk+TF/XpVJwQhQtpPNQhla9bvMSklkcAh906EtKzXYik+7pmA3p8pFMU3e9cpDIM 45BWQfBYMxdfn8bKR8gMJoePCmdRNFY3/RnWXxyELuP01Sb1gQqdhgsgIViQ9bHx/Y ANeXNPSnr3ynzrr2oLpChQ10OOZira10qPNNCkDxWGC4EuNZOv8USTWTy221u11PMi Jxwj7ve1gpk4w== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WOnfRmb1KtUD; Tue, 27 Jun 2023 18:04:29 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id CC98E3C020F7C; Tue, 27 Jun 2023 18:04:29 -0700 (PDT) Message-ID: <4dba433a-7cad-e88d-3aef-bdaade46ef6f@cs.ucla.edu> Date: Tue, 27 Jun 2023 18:04:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Gisle Vanem References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [bug-diffutils] bug#64316: ASAN failures in dir.c In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64316 Cc: 64316@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2023-06-27 12:52, Gisle Vanem wrote: > with MSVC's 'cl.exe', I often get: > =C2=A0 diff.exe: memory exhausted >=20 > (on directory branches with approx. > 7000 files) I can't reproduce that on Ubuntu x86 or x86-64. I built a test case this=20 way: for dir in d e; do (mkdir $dir && cd $dir && for i in $(seq 8000); do echo $dir$i>$i done) done and "diff d e >f" worked just fine. Do you have a reproducible test case? > From where the allocation fails, I've no idea since Gnulib is so > unfriendly telling where this occurs. Is there really no > xmalloc_die() with some more useful messages than this? Yikes! When you run out of memory, bad things happen pretty much everywhere.=20 Too bad Microsoft gives you a bad backtrace. You might try running the leak detector though to be honest I've not had=20 much luck with that. Another possibility is to try to find the commit that introduced the=20 problem, if it's reproducible. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 28 18:32:06 2023 Received: (at 64316) by debbugs.gnu.org; 28 Jun 2023 22:32:06 +0000 Received: from localhost ([127.0.0.1]:51840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEdhm-00076f-0W for submit@debbugs.gnu.org; Wed, 28 Jun 2023 18:32:06 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:59328) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEdhj-000767-7i for 64316@debbugs.gnu.org; Wed, 28 Jun 2023 18:32:04 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id F04423C020F7C; Wed, 28 Jun 2023 15:31:56 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7ErkzSGMLEsR; Wed, 28 Jun 2023 15:31:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id D22083C09FA2C; Wed, 28 Jun 2023 15:31:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu D22083C09FA2C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1687991515; bh=ofnVT3usz6zEgtouvydM7ahp7PW74v4PuyO/Oicn6xs=; h=Message-ID:Date:MIME-Version:To:From; b=WAX/KQJTuUtJochKJO7q2uPLyvCifth8MivRP+W1VZvM+ivv8y3tMnyQX21+8h32W bN/3DWS2YWKrpxcm8vttZJeIWTKAtRx7Ta/ClmNZ92EvnUIhITAtqSm648c5n+7O7s 1vE4G54lboBovK0T600mDuTFwHRZlizOzkyTXieWOAd/T6Wex/hUEXxmk7ZWNOtA0S HOEAj6eiibqwGrwsaegWjMoHWmBQmfNrQWbMaCwVt82/wncgZschrYdAk9qZK8QkfS bHGtJZGWQZDSBz71A1LbzWtJxZUpTUHULgveNsYcrfxGNdW4XYjVEA1W7nrn4EC7SK rkmgggo/CHQUQ== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rSw2QmhEgpp0; Wed, 28 Jun 2023 15:31:55 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id A96AC3C020F7C; Wed, 28 Jun 2023 15:31:55 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------1bIIMqN1E2vdzlKtgJpzTEfM" Message-ID: <524311dc-7915-228c-b1a2-95e7ea6fd1ca@cs.ucla.edu> Date: Wed, 28 Jun 2023 15:31:55 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Content-Language: en-US To: Gisle Vanem References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> <4dba433a-7cad-e88d-3aef-bdaade46ef6f@cs.ucla.edu> <0f23fe14-4eed-479e-50e2-9e0113d10dc0@yahoo.no> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: [bug-diffutils] bug#64316: ASAN failures in dir.c In-Reply-To: <0f23fe14-4eed-479e-50e2-9e0113d10dc0@yahoo.no> X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64316 Cc: 64316@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------1bIIMqN1E2vdzlKtgJpzTEfM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-06-28 03:32, Gisle Vanem wrote: > 'PTRDIFF_T_MAX - - 3' folds to '-9223372036854775806'. > > But how can 'linbuf_base' become negative? Ordinarily it's zero, but it can be negative. It's never positive. Thanks for the report. I reproduced the signed integer overflow issue with -fsanitize=undefined and installed the attached patch to fix it and add a regression test (and also a comment about linbuf_base). Although I don't see how this would fix a "memory exhausted" error, please give the latest Git commit a try and see whether it fixes things for you. --------------1bIIMqN1E2vdzlKtgJpzTEfM Content-Type: text/x-patch; charset=UTF-8; name="0001-diff-fix-xpalloc-related-signed-integer-overflow.patch" Content-Disposition: attachment; filename*0="0001-diff-fix-xpalloc-related-signed-integer-overflow.patch" Content-Transfer-Encoding: base64 RnJvbSAzNTliOGMzZWYyOGM2NDM5ZmY5NDM4ZThlOWZlOGI0NWI1MGUxNDA4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBXZWQsIDI4IEp1biAyMDIzIDE0OjA4OjE0IC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gZGlmZjogZml4IHhwYWxsb2MtcmVsYXRlZCBzaWduZWQgaW50ZWdlciBvdmVyZmxvdwoK UHJvYmxlbSByZXBvcnRlZCBieSBHaXNsZSBWYW5lbSA8aHR0cHM6Ly9idWdzLmdudS5vcmcv NjQzMTY+LgoqIHNyYy9pby5jIChmaW5kX2FuZF9oYXNoX2VhY2hfbGluZSk6ClJlbHkgb24g eHBhbGxvYyB0byBjaGVjayBmb3IgaW50ZWdlciBvdmVyZmxvdyBpbnN0ZWFkCm9mIHRyeWlu ZyB0byBkbyBpdCBvdXJzZWx2ZXMgaW5jb3JyZWN0bHksIHdpdGggb2xkIGNvZGUKdGhhdCBw cmVkYXRlZCB0aGUgdXNlIG9mIHhwYWxsb2MuCiogc3JjL3N5c3RlbS5oOiBWZXJpZnkgdGhh dCBMSU5fTUFYID09IElEWF9NQVgsCnNpbmNlIHRoZSBjb2RlIG5vdyByZWxpZXMgb24gdGhp cy4KKiB0ZXN0cy9NYWtlZmlsZS5hbSAoVEVTVFMpOiBBZGQgYnVnLTY0MzE2LgoqIHRlc3Rz L2J1Zy02NDMxNjogTmV3IGZpbGUKLS0tCiBzcmMvZGlmZi5oICAgICAgICB8ICA4ICsrKyst LS0tCiBzcmMvaW8uYyAgICAgICAgICB8IDEyICsrKy0tLS0tLS0tLQogc3JjL3N5c3RlbS5o ICAgICAgfCAgMiArLQogdGVzdHMvTWFrZWZpbGUuYW0gfCAgMSArCiB0ZXN0cy9idWctNjQz MTYgICB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDUgZmlsZXMgY2hh bmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9kZSAx MDA3NTUgdGVzdHMvYnVnLTY0MzE2CgpkaWZmIC0tZ2l0IGEvc3JjL2RpZmYuaCBiL3NyYy9k aWZmLmgKaW5kZXggZWMzOWI3My4uYjUyYzFmNSAxMDA2NDQKLS0tIGEvc3JjL2RpZmYuaAor KysgYi9zcmMvZGlmZi5oCkBAIC0yODgsMTAgKzI4OCwxMCBAQCBzdHJ1Y3QgZmlsZV9kYXRh IHsKICAgICAvKiBBcnJheSBvZiBwb2ludGVycyB0byBsaW5lcyBpbiB0aGUgZmlsZS4gICov CiAgICAgY2hhciBjb25zdCAqKmxpbmJ1ZjsKIAotICAgIC8qIGxpbmJ1Zl9iYXNlIDw9IGJ1 ZmZlcmVkX2xpbmVzIDw9IHZhbGlkX2xpbmVzIDw9IGFsbG9jX2xpbmVzLgotICAgICAgIGxp bmVidWZbbGluYnVmX2Jhc2UgLi4uIGJ1ZmZlcmVkX2xpbmVzIC0gMV0gYXJlIHBvc3NpYmx5 IGRpZmZlcmluZy4KLSAgICAgICBsaW5lYnVmW2xpbmJ1Zl9iYXNlIC4uLiB2YWxpZF9saW5l cyAtIDFdIGNvbnRhaW4gdmFsaWQgZGF0YS4KLSAgICAgICBsaW5lYnVmW2xpbmJ1Zl9iYXNl IC4uLiBhbGxvY19saW5lcyAtIDFdIGFyZSBhbGxvY2F0ZWQuICAqLworICAgIC8qIGxpbmJ1 Zl9iYXNlIDw9IDAgPD0gYnVmZmVyZWRfbGluZXMgPD0gdmFsaWRfbGluZXMgPD0gYWxsb2Nf bGluZXMuCisgICAgICAgbGluYnVmWzAgLi4uIGJ1ZmZlcmVkX2xpbmVzIC0gMV0gYXJlIHBv c3NpYmx5IGRpZmZlcmluZy4KKyAgICAgICBsaW5idWZbbGluYnVmX2Jhc2UgLi4uIHZhbGlk X2xpbmVzIC0gMV0gY29udGFpbiB2YWxpZCBkYXRhLgorICAgICAgIGxpbmJ1ZltsaW5idWZf YmFzZSAuLi4gYWxsb2NfbGluZXMgLSAxXSBhcmUgYWxsb2NhdGVkLiAgKi8KICAgICBsaW4g bGluYnVmX2Jhc2UsIGJ1ZmZlcmVkX2xpbmVzLCB2YWxpZF9saW5lcywgYWxsb2NfbGluZXM7 CiAKICAgICAvKiBQb2ludGVyIHRvIGVuZCBvZiBwcmVmaXggb2YgdGhpcyBmaWxlIHRvIGln bm9yZSB3aGVuIGhhc2hpbmcuICAqLwpkaWZmIC0tZ2l0IGEvc3JjL2lvLmMgYi9zcmMvaW8u YwppbmRleCAxODUxYzlhLi43ZmIzMGY0IDEwMDY0NAotLS0gYS9zcmMvaW8uYworKysgYi9z cmMvaW8uYwpAQCAtMzgxLDkgKzM4MSw3IEBAIGZpbmRfYW5kX2hhc2hfZWFjaF9saW5lIChz dHJ1Y3QgZmlsZV9kYXRhICpjdXJyZW50KQogICAgICAgICAgICAgLyogQ3JlYXRlIGEgbmV3 IGVxdWl2YWxlbmNlIGNsYXNzIGluIHRoaXMgYnVja2V0LiAgKi8KICAgICAgICAgICAgIGkg PSBlcXNfaW5kZXgrKzsKICAgICAgICAgICAgIGlmIChpID09IGVxc19hbGxvYykKLQkgICAg ICBlcXMgPSB4cGFsbG9jIChlcXMsICZlcXNfYWxsb2MsIDEsCi0JCQkgICAgIExJTl9NQVgg PCBQVFJESUZGX01BWCA/IExJTl9NQVggOiAtMSwKLQkJCSAgICAgc2l6ZW9mICplcXMpOwor CSAgICAgIGVxcyA9IHhwYWxsb2MgKGVxcywgJmVxc19hbGxvYywgMSwgLTEsIHNpemVvZiAq ZXFzKTsKICAgICAgICAgICAgIGVxc1tpXS5uZXh0ID0gKmJ1Y2tldDsKICAgICAgICAgICAg IGVxc1tpXS5oYXNoID0gaDsKICAgICAgICAgICAgIGVxc1tpXS5saW5lID0gaXA7CkBAIC00 MTcsMTMgKzQxNSwxMCBAQCBmaW5kX2FuZF9oYXNoX2VhY2hfbGluZSAoc3RydWN0IGZpbGVf ZGF0YSAqY3VycmVudCkKICAgICAgIC8qIE1heWJlIGluY3JlYXNlIHRoZSBzaXplIG9mIHRo ZSBsaW5lIHRhYmxlLiAgKi8KICAgICAgIGlmIChsaW5lID09IGFsbG9jX2xpbmVzKQogICAg ICAgICB7Ci0JICBpZHhfdCBlcXNfbWF4ID0gTUlOIChMSU5fTUFYLCBJRFhfTUFYIC8gc2l6 ZW9mICpjdXJlcXMpOwotCiAJICAvKiBHcm93IChhbGxvY19saW5lcyAtIGxpbmJ1Zl9iYXNl KSBieSBhZGRpbmcgdG8gYWxsb2NfbGluZXMuICAqLwogCSAgaWR4X3QgbiA9IGFsbG9jX2xp bmVzIC0gbGluYnVmX2Jhc2U7CiAgICAgICAgICAgbGluYnVmICs9IGxpbmJ1Zl9iYXNlOwot CSAgbGluYnVmID0geHBhbGxvYyAobGluYnVmLCAmbiwgMSwgZXFzX21heCAtIGxpbmJ1Zl9i YXNlLAotCQkJICAgIHNpemVvZiAqbGluYnVmKTsKKwkgIGxpbmJ1ZiA9IHhwYWxsb2MgKGxp bmJ1ZiwgJm4sIDEsIC0xLCBzaXplb2YgKmxpbmJ1Zik7CiAgICAgICAgICAgbGluYnVmIC09 IGxpbmJ1Zl9iYXNlOwogCSAgYWxsb2NfbGluZXMgPSBsaW5idWZfYmFzZSArIG47CiAgICAg ICAgICAgY3VyZXFzID0geGlyZWFsbG9jIChjdXJlcXMsIGFsbG9jX2xpbmVzICogc2l6ZW9m ICpjdXJlcXMpOwpAQCAtNDQ1LDggKzQ0MCw3IEBAIGZpbmRfYW5kX2hhc2hfZWFjaF9saW5l IChzdHJ1Y3QgZmlsZV9kYXRhICpjdXJyZW50KQogCSAgLyogR3JvdyAoYWxsb2NfbGluZXMg LSBsaW5idWZfYmFzZSkgYnkgYWRkaW5nIHRvIGFsbG9jX2xpbmVzLiAgKi8KIAkgIGlkeF90 IG4gPSBhbGxvY19saW5lcyAtIGxpbmJ1Zl9iYXNlOwogCSAgbGluYnVmICs9IGxpbmJ1Zl9i YXNlOwotCSAgbGluYnVmID0geHBhbGxvYyAobGluYnVmLCAmbiwgMSwgTUFYICgwLCBJRFhf TUFYIC0gbGluYnVmX2Jhc2UpLAotCQkJICAgIHNpemVvZiAqbGluYnVmKTsKKwkgIGxpbmJ1 ZiA9IHhwYWxsb2MgKGxpbmJ1ZiwgJm4sIDEsIC0xLCBzaXplb2YgKmxpbmJ1Zik7CiAJICBs aW5idWYgLT0gbGluYnVmX2Jhc2U7CiAJICBhbGxvY19saW5lcyA9IG4gLSBsaW5idWZfYmFz ZTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvc3JjL3N5c3RlbS5oIGIvc3JjL3N5c3RlbS5o CmluZGV4IGM2MzNhMjUuLjMyZDY4MGQgMTAwNjQ0Ci0tLSBhL3NyYy9zeXN0ZW0uaAorKysg Yi9zcmMvc3lzdGVtLmgKQEAgLTEyOSw3ICsxMjksNyBAQCB0eXBlZGVmIHN0cnVjdCBpbmNv bXBsZXRlICp3b3JkOwogdHlwZWRlZiBwdHJkaWZmX3QgbGluOwogI2RlZmluZSBMSU5fTUFY IFBUUkRJRkZfTUFYCiAjZGVmaW5lIHBJICJ0IgotdmVyaWZ5IChMSU5fTUFYIDw9IElEWF9N QVgpOwordmVyaWZ5IChMSU5fTUFYID09IElEWF9NQVgpOwogDAogLyogVGhpcyBzZWN0aW9u IGNvbnRhaW5zIFBPU0lYLWNvbXBsaWFudCBkZWZhdWx0cyBmb3IgbWFjcm9zCiAgICB0aGF0 IGFyZSBtZWFudCB0byBiZSBvdmVycmlkZGVuIGJ5IGhhbmQgaW4gY29uZmlnLmggYXMgbmVl ZGVkLiAgKi8KZGlmZiAtLWdpdCBhL3Rlc3RzL01ha2VmaWxlLmFtIGIvdGVzdHMvTWFrZWZp bGUuYW0KaW5kZXggNzliYWNmYi4uZGI3NTdiZCAxMDA2NDQKLS0tIGEvdGVzdHMvTWFrZWZp bGUuYW0KKysrIGIvdGVzdHMvTWFrZWZpbGUuYW0KQEAgLTUsNiArNSw3IEBAIFRFU1RTID0g XAogICBiaWdudW0gXAogICBiaW5hcnkgXAogICBicmllZi12cy1zdGF0LXplcm8ta2VybmVs LWxpZXMgXAorICBidWctNjQzMTYgXAogICBjbXAgXAogICBjb2xsaWRpbmctZmlsZS1uYW1l cyBcCiAgIGRpZmYzIFwKZGlmZiAtLWdpdCBhL3Rlc3RzL2J1Zy02NDMxNiBiL3Rlc3RzL2J1 Zy02NDMxNgpuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi4yYzEzMzFjCi0t LSAvZGV2L251bGwKKysrIGIvdGVzdHMvYnVnLTY0MzE2CkBAIC0wLDAgKzEsMzEgQEAKKyMh L2Jpbi9zaAorIyBUZXN0IGZvciBzaWduZWQgaW50ZWdlciBvdmVyZmxvdyBidWcgd2l0aGlu IGRpZmYuCisjIEJ1ZyByZXBvcnRlZCBieSBHaXNlbGUgVmFuZW0gPGh0dHA6Ly9idWdzLmdu dS5vcmcvNjQzMTY+LgorIyBDb21waWxlIHdpdGggZ2NjIC1mc2FuaXRpemU9dW5kZWZpbmVk IHRvIHRlc3QgZm9yIHRoaXMgYnVnLgorCisuICIke3NyY2Rpcj0ufS9pbml0LnNoIjsgcGF0 aF9wcmVwZW5kXyAuLi9zcmMKKworZmFpbD0wCisKK2ZvciBmIGluIGEgYjsgZG8KKyAgcHJp bnRmICdjXG5kXG5lXG5mXG5nXG4lc1xuaFxuaVxualxua1xubFxuJyAkZiA+JGYgfHwgZnJh bWV3b3JrX2ZhaWx1cmVfCitkb25lCisKK2NhdCA+ZXhwIDw8J0VPRicgfHwgZnJhbWV3b3Jr X2ZhaWx1cmVfCitAQCAtMyw3ICszLDcgQEAKKyBlCisgZgorIGcKKy1hCisrYgorIGgKKyBp CisgagorRU9GCisKK3JldHVybnNfIDEgZGlmZiAtdSBhIGIgPm91dCAyPmVyciB8fCBmYWls PTEKK3NlZCAnMSwyZCcgb3V0ID5vdXQxIHx8IGZyYW1ld29ya19mYWlsdXJlXworY29tcGFy ZSBleHAgb3V0MSB8fCBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIGVyciB8fCBmYWlsPTEK KworRXhpdCAkZmFpbAotLSAKMi4zOS4yCgo= --------------1bIIMqN1E2vdzlKtgJpzTEfM-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 29 12:59:51 2023 Received: (at 64316) by debbugs.gnu.org; 29 Jun 2023 16:59:52 +0000 Received: from localhost ([127.0.0.1]:53957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEuzn-0000Kv-Ny for submit@debbugs.gnu.org; Thu, 29 Jun 2023 12:59:51 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:39892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qEuzk-0000Kf-I2 for 64316@debbugs.gnu.org; Thu, 29 Jun 2023 12:59:50 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 22D043C09FA06; Thu, 29 Jun 2023 09:59:42 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id DK0UM14-jzBJ; Thu, 29 Jun 2023 09:59:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id CAADF3C09FB44; Thu, 29 Jun 2023 09:59:41 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu CAADF3C09FB44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1688057981; bh=8PMSQEJyeQLNMR4f7fs3sMXxAFm32WYB/BMRELP0k1o=; h=Message-ID:Date:MIME-Version:To:From; b=hsMMaUgMZP2kjo3xKGcfvhAa6wNH958Y7I2optjlJOGYcr2E9Yrktc2COWUw125yA ugPHUsBkTwXLVnNdk+uzpQc0iiWNZgW/mkx0N7aW8qjOaIC+hBUPNECxEb1dzEy48a 8L9Ql40Q59O5IkwEX3b2hecVDt3njVE8yqaL6zcDh1UB24zPOGW7JaiC7y+kyXCGwE WssCTSLd2P1fCE2qyNAn6apQE/urk5jlfWIPrHcpzjWrvEF0HlmQOt+ZN1ay5nhxO9 28+ynvBg7OFmGmKyDOEyi9CMhAZcQwzzkOKXtmkjlwZKZHusEaVCq9g+dxS2GkCX8a nE9s9iwHyxJnA== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1Ats3s5Mcykx; Thu, 29 Jun 2023 09:59:41 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id A33C33C09FA06; Thu, 29 Jun 2023 09:59:41 -0700 (PDT) Message-ID: <85915438-dd4b-6e15-fe82-6860aba64883@cs.ucla.edu> Date: Thu, 29 Jun 2023 09:59:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [bug-diffutils] bug#64316: ASAN failures in dir.c Content-Language: en-US To: Gisle Vanem References: <740b3932-20dc-3fd1-d931-4ff7b41da3de.ref@yahoo.no> <740b3932-20dc-3fd1-d931-4ff7b41da3de@yahoo.no> <4dba433a-7cad-e88d-3aef-bdaade46ef6f@cs.ucla.edu> <0f23fe14-4eed-479e-50e2-9e0113d10dc0@yahoo.no> <524311dc-7915-228c-b1a2-95e7ea6fd1ca@cs.ucla.edu> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 64316 Cc: 64316@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) On 2023-06-29 05:09, Gisle Vanem wrote: > Seems to work fine now. For both MSVC and clang-cl. Thanks for checking; I'm noting this in the bug report. From unknown Mon Jun 23 13:12:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Jul 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator