GNU bug report logs - #64311
[PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#64311: closed ([PATCH] Fix shell-dirtrack-mode showing up as
 enabled in unrelated buffers)
Date: Sat, 08 Jul 2023 08:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 08 Jul 2023 11:30:25 +0300
with message-id <83r0pidcv2.fsf <at> gnu.org>
and subject line Re: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
has caused the debbugs.gnu.org bug report #64311,
regarding [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
64311: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=64311
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vladimir Sedach <vas <at> oneofus.la>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated
 buffers
Date: Mon, 26 Jun 2023 22:39:50 -0600

[Message part 3 (text/plain, inline)]

Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

shell-dirtrack-mode always shows up in unrelated buffers.

Steps to reproduce:
1. emacs -q
2. M-x shell
3. describe-mode (C-h m) in *scratch* or *GNU Emacs*

This is because shell-dirtrack-mode is aliased to shell-dirtrackp,
which has default value t.

Changes in this patch:
mark shell-dirtrackp obsolete
replace existing occurrences of shell-dirtrackp with shell-dirtrack-mode
add :interactive (shell-mode) suggestion to shell-dirtrack-mode

shell-dirtrack-mode is still turned on by default. There is an
explicit call to (shell-dirtrack-mode 1) in the definition of
shell-mode.

Definition of shell-dirtrack-mode is moved to quiet warning about
reference to free variable ‘shell-dirtrack-mode’.

Note: I am not sure what to put for WHEN on the obsolete variable.
Does that get filled in when merging?

--
Vladimir Sedach

[0001-test-lisp-shell-tests.el-added-tests-for-shell-dirtr.patch (text/x-diff, attachment)]

[0002-Fix-shell-dirtrack-mode-showing-up-as-enabled-in-unr.patch (text/x-diff, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vladimir Sedach <vas <at> oneofus.la>
Cc: 64311-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as
 enabled in unrelated buffers
Date: Sat, 08 Jul 2023 11:30:25 +0300

> From: Vladimir Sedach <vas <at> oneofus.la>
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 64311 <at> debbugs.gnu.org
> Date: Thu, 06 Jul 2023 14:30:16 -0600
> 
> Attached is a patch that keeps defvaralias, and does not obsolete
> anything.

Thanks, I installed this, with slight changes, on the master branch,
and I'm therefore closing this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.