GNU bug report logs - #64311
[PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vladimir Sedach <vas <at> oneofus.la>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated
 buffers
Date: Mon, 26 Jun 2023 22:39:50 -0600

[Message part 1 (text/plain, inline)]

Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

shell-dirtrack-mode always shows up in unrelated buffers.

Steps to reproduce:
1. emacs -q
2. M-x shell
3. describe-mode (C-h m) in *scratch* or *GNU Emacs*

This is because shell-dirtrack-mode is aliased to shell-dirtrackp,
which has default value t.

Changes in this patch:
mark shell-dirtrackp obsolete
replace existing occurrences of shell-dirtrackp with shell-dirtrack-mode
add :interactive (shell-mode) suggestion to shell-dirtrack-mode

shell-dirtrack-mode is still turned on by default. There is an
explicit call to (shell-dirtrack-mode 1) in the definition of
shell-mode.

Definition of shell-dirtrack-mode is moved to quiet warning about
reference to free variable ‘shell-dirtrack-mode’.

Note: I am not sure what to put for WHEN on the obsolete variable.
Does that get filled in when merging?

--
Vladimir Sedach

[0001-test-lisp-shell-tests.el-added-tests-for-shell-dirtr.patch (text/x-diff, attachment)]

[0002-Fix-shell-dirtrack-mode-showing-up-as-enabled-in-unr.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.