GNU bug report logs - #64311
[PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers

Previous Next

Full log

View this message in rfc822 format

From: Vladimir Sedach <vas <at> oneofus.la>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64311 <at> debbugs.gnu.org
Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers
Date: Thu, 29 Jun 2023 13:24:58 -0600

Eli Zaretskii <eliz <at> gnu.org> writes:

> Am I?  Asking about the root cause of the problem is not wrong,
> because it indicates how best to fix it.

The root cause of the problem is the redundant variable
shell-dirtrackp, not its value. It is the variable aliasing in the
2018 commit 9c3eeba4db26ddaeead100beea7a96f9fa640918 that introduced
the bug.

This is why my patch addresses the root cause of the problem, instead
of setting the value of the variable (which commit
9c3eeba4db26ddaeead100beea7a96f9fa640918 did not touch).

> Why would we bother about that?  With the exception of the default
> value, what harm does that variable cause by existing?

It is misleading for someone trying to customize shell-mode, or work
on shell.el. I found it confusing on both counts. If it were not
confusing for you too, we obviously would not be having such a long
back-and-forth conversation about this bug.

--
Vladimir Sedach

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.