GNU bug report logs - #6431
24.0.50; read-file-name-predicate is never reset

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6431 in the body.
You can then email your comments to 6431 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.50; read-file-name-predicate is never reset
Date: Tue, 15 Jun 2010 11:06:20 -0700

read-file-name-predicate is declared obsolete in 23.2.  But it is still
available and still used.
 
However, it is no longer bound in `read-file-name', as it was.  So if
3rd-party code ever sets it then it stays set instead of being
reinitialized by `read-file-name'.
 
The binding is missing here, in `read-file-name':
 
(let ((completion-ignore-case read-file-name-completion-ignore-case)
      (minibuffer-completing-file-name t)
      (read-file-name-predicate (or predicate 'file-exists-p)) ; MISSING
      (add-to-history nil))
 

In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
 of 2010-06-14 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
 

Message #8 received at 6431 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6431 <at> debbugs.gnu.org
Subject: Re: bug#6431: 24.0.50; read-file-name-predicate is never reset
Date: Sun, 09 Feb 2014 23:36:28 -0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> read-file-name-predicate is declared obsolete in 23.2.  But it is still
> available and still used.
>
> However, it is no longer bound in `read-file-name', as it was.  So if
> 3rd-party code ever sets it then it stays set instead of being
> reinitialized by `read-file-name'.

It no longer seems to be used.  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #13 received at 6431 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 6431 <at> debbugs.gnu.org
Subject: RE: bug#6431: 24.0.50; read-file-name-predicate is never reset
Date: Mon, 10 Feb 2014 10:54:12 -0800 (PST)

> > read-file-name-predicate is declared obsolete in 23.2.  But it is
> > still available and still used.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > However, it is no longer bound in `read-file-name', as it was.  So
> > if 3rd-party code ever sets it then it stays set instead of being
> > reinitialized by `read-file-name'.
> 
> It no longer seems to be used.  Closing.

It is used - by 3rd-party code.  Please restore the binding
cited in the bug report.

Message #18 received at 6431 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> altern.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 6431 <at> debbugs.gnu.org
Subject: Re: bug#6431: 24.0.50; read-file-name-predicate is never reset
Date: Tue, 11 Feb 2014 00:31:23 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

>> > read-file-name-predicate is declared obsolete in 23.2.  But it is
>> > still available and still used.
>     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > However, it is no longer bound in `read-file-name', as it was.  So
>> > if 3rd-party code ever sets it then it stays set instead of being
>> > reinitialized by `read-file-name'.
>> 
>> It no longer seems to be used.  Closing.
>
> It is used - by 3rd-party code.  Please restore the binding
> cited in the bug report.

Changes that are incompatible with third-part code should be
documented in NEWS, not restored.

Can you suggest something for NEWS?

-- 
 Bastien

Message #21 received at 6431 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Bastien <bzg <at> altern.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 6431 <at> debbugs.gnu.org
Subject: RE: bug#6431: 24.0.50; read-file-name-predicate is never reset
Date: Mon, 10 Feb 2014 15:35:44 -0800 (PST)

> > It is used - by 3rd-party code.  Please restore the binding
> > cited in the bug report.
> 
> Changes that are incompatible with third-part code should be
> documented in NEWS, not restored.
> 
> Can you suggest something for NEWS?

My suggestion is to restore the binding.  That will fix this
bug.

If you want to file a bug report about something being missing
from NEWS, please go for it.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.