GNU bug report logs - #64295
[PATCH] treesit-install-language-grammar ignores out-dir

Previous Next

Package: emacs;

Reported by: john muhl <jm <at> pub.pink>

Date: Mon, 26 Jun 2023 07:16:02 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64295 in the body.
You can then email your comments to 64295 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#64295; Package emacs. (Mon, 26 Jun 2023 07:16:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to john muhl <jm <at> pub.pink>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 26 Jun 2023 07:16:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] treesit-install-language-grammar ignores out-dir
Date: Sun, 25 Jun 2023 19:43:18 -0500
[Message part 1 (text/plain, inline)]
Running interactively from emacs -Q:

  M-x t-i-l-g RET bash RET y RET RET RET RET RET ~/tmp/tree-sitter RET

installs to user-emacs-directory/tree-sitter instead of the supplied
directory.

Here’s the tiny change to make it work.

[0001-Fix-treesit-install-language-grammar-for-custom-ou.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#64295; Package emacs. (Thu, 29 Jun 2023 05:40:02 GMT) Full text and rfc822 format available.

Message #8 received at 64295 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>, Yuan Fu <casouri <at> gmail.com>
Cc: 64295 <at> debbugs.gnu.org
Subject: Re: bug#64295: [PATCH] treesit-install-language-grammar ignores
 out-dir
Date: Thu, 29 Jun 2023 08:39:50 +0300
> Date: Sun, 25 Jun 2023 19:43:18 -0500
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Running interactively from emacs -Q:
> 
>   M-x t-i-l-g RET bash RET y RET RET RET RET RET ~/tmp/tree-sitter RET
> 
> installs to user-emacs-directory/tree-sitter instead of the supplied
> directory.
> 
> Here’s the tiny change to make it work.

Yuan, are you looking into this?  AFAIU, this is for the master
branch.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#64295; Package emacs. (Thu, 29 Jun 2023 16:45:02 GMT) Full text and rfc822 format available.

Message #11 received at 64295 <at> debbugs.gnu.org (full text, mbox):

From: john muhl <jm <at> pub.pink>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 64295 <at> debbugs.gnu.org, Yuan Fu <casouri <at> gmail.com>
Subject: Re: bug#64295: [PATCH] treesit-install-language-grammar ignores
 out-dir
Date: Thu, 29 Jun 2023 10:30:30 -0500
Eli Zaretskii <eliz <at> gnu.org> writes:

> AFAIU, this is for the master branch.

Sorry for omitting that but master is correct.




Reply sent to Yuan Fu <casouri <at> gmail.com>:
You have taken responsibility. (Thu, 29 Jun 2023 19:05:02 GMT) Full text and rfc822 format available.

Notification sent to john muhl <jm <at> pub.pink>:
bug acknowledged by developer. (Thu, 29 Jun 2023 19:05:02 GMT) Full text and rfc822 format available.

Message #16 received at 64295-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: john muhl <jm <at> pub.pink>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 64295-done <at> debbugs.gnu.org
Subject: Re: bug#64295: [PATCH] treesit-install-language-grammar ignores
 out-dir
Date: Thu, 29 Jun 2023 12:03:59 -0700

> On Jun 29, 2023, at 8:30 AM, john muhl <jm <at> pub.pink> wrote:
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>> AFAIU, this is for the master branch.
> 
> Sorry for omitting that but master is correct.

Thanks, the fix is right, and the problem is on master. I’ve pushed the fix.

Yuan



bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 28 Jul 2023 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 329 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.