GNU bug report logs - #64288
[PATCH] gnu: python-msgspec: Regenerate autogenerated file.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 64288 in the body.
You can then email your comments to 64288 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Vinicius Monego <monego <at> posteo.net>
Subject: [PATCH] gnu: python-msgspec: Regenerate autogenerated file.
Date: Sun, 25 Jun 2023 22:21:53 +0000

* gnu/packages/serialization.scm (python-msgspec)[source]: Add a snippet to
delete autogenerated "msgspec/atof_consts.h".
[arguments]: Add new phase to regenerate that file.
---
 gnu/packages/serialization.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index 1f8c128eba..2d763e815e 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -628,6 +628,11 @@ (define-public python-msgspec
                     (url "https://github.com/jcrist/msgspec")
                     (commit version)))
               (file-name (git-file-name name version))
+              (modules '((guix build utils)))
+              (snippet
+               ;; Delete autogenerated file, regenerate in a phase.
+               '(begin
+                  (delete-file "msgspec/atof_consts.h")))
               (sha256
                (base32
                 "09q567klcv7ly60w9lqip2ffyhrij100ky9igh3p3vqwbml33zb3"))))
@@ -645,7 +650,12 @@ (define-public python-msgspec
                        (invoke "versioneer" "install")
                        (substitute* "setup.py"
                          (("version=versioneer.get_version\\(),")
-                          (format #f "version=~s," #$version))))))))
+                          (format #f "version=~s," #$version)))))
+                   (add-after 'versioneer 'atof-consts
+                     (lambda _
+                       (with-directory-excursion "scripts"
+                         ;; Regenerate the autogenerated file.
+                         (invoke "python" "generate_atof_consts.py")))))))
     (native-inputs (list python-attrs
                          python-gcovr
                          python-msgpack
-- 
2.34.1

Message #8 received at 64288 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Vinicius Monego <monego <at> posteo.net>
Cc: 64288 <at> debbugs.gnu.org
Subject: Re: bug#64288: [PATCH] gnu: python-msgspec: Regenerate
 autogenerated file.
Date: Tue, 18 Jul 2023 13:40:28 +0200

Hello,

Vinicius Monego <monego <at> posteo.net> skribis:

> * gnu/packages/serialization.scm (python-msgspec)[source]: Add a snippet to
> delete autogenerated "msgspec/atof_consts.h".
> [arguments]: Add new phase to regenerate that file.

Good catch, LGTM!

Ludo’.

Message #13 received at 64288-done <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 64288-done <at> debbugs.gnu.org
Subject: Re: bug#64288: [PATCH] gnu: python-msgspec: Regenerate
 autogenerated file.
Date: Sat, 29 Jul 2023 18:43:28 +0000

Em ter, 2023-07-18 às 13:40 +0200, Ludovic Courtès escreveu:
> Hello,
> 
> Vinicius Monego <monego <at> posteo.net> skribis:
> 
> > * gnu/packages/serialization.scm (python-msgspec)[source]: Add a
> > snippet to
> > delete autogenerated "msgspec/atof_consts.h".
> > [arguments]: Add new phase to regenerate that file.
> 
> Good catch, LGTM!
> 
> Ludo’.

Applied, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.